Page MenuHomePhabricator

boga95 (Borsik Gábor)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 27 2018, 12:48 AM (93 w, 1 d)

Recent Activity

Sun, Dec 1

boga95 created D70878: [analyzer] Add support for namespaces to GenericTaintChecker.
Sun, Dec 1, 11:13 AM · Restricted Project

Sat, Nov 23

boga95 committed rG79e2325f145d: [analyzer][docs] NFC: Extend documentation for MallocOverflow checker (authored by boga95).
[analyzer][docs] NFC: Extend documentation for MallocOverflow checker
Sat, Nov 23, 12:00 PM
boga95 closed D70596: [analyzer][docs] NFC: Extend documentation for MallocOverflow checker.
Sat, Nov 23, 12:00 PM · Restricted Project
boga95 committed rG89bc4c662c6c: [analyzer] Add custom filter functions for GenericTaintChecker (authored by boga95).
[analyzer] Add custom filter functions for GenericTaintChecker
Sat, Nov 23, 11:33 AM
boga95 closed D59516: [analyzer] Add custom filter functions for GenericTaintChecker.
Sat, Nov 23, 11:33 AM · Restricted Project

Sat, Nov 16

boga95 added a comment to D59516: [analyzer] Add custom filter functions for GenericTaintChecker.

I did the required changes and tried to commit it, but I couldn't. I heard the codebase was migrated to GitHub. Maybe it affected my commit access.

Sat, Nov 16, 6:31 AM · Restricted Project

Oct 9 2019

boga95 added a comment to D59516: [analyzer] Add custom filter functions for GenericTaintChecker.

Ping

Oct 9 2019, 2:41 PM · Restricted Project

Oct 3 2019

boga95 added a comment to D59516: [analyzer] Add custom filter functions for GenericTaintChecker.

Ping

Oct 3 2019, 1:49 PM · Restricted Project

Sep 18 2019

boga95 added a comment to D52281: [clang-tidy] Add modernize check to use std::invoke in generic code.

Resolving the problems properly seemed quite difficult. I just finished university and started to work, therefore I don't have enough free time to finish the checker. Sorry about that.

Sep 18 2019, 1:32 PM · Restricted Project

Sep 17 2019

boga95 abandoned D52281: [clang-tidy] Add modernize check to use std::invoke in generic code.
Sep 17 2019, 2:06 PM · Restricted Project

Sep 16 2019

boga95 updated the diff for D59516: [analyzer] Add custom filter functions for GenericTaintChecker.
Sep 16 2019, 1:51 PM · Restricted Project

Sep 12 2019

boga95 updated the diff for D59516: [analyzer] Add custom filter functions for GenericTaintChecker.
Sep 12 2019, 1:01 PM · Restricted Project

Sep 8 2019

boga95 closed D59637: [analyzer] Use the custom propagation rules and sinks in GenericTaintChecker.

Closed by 080ecafdd8b3e990e5ad19202d089c91c9c9b164.

Sep 8 2019, 1:04 PM · Restricted Project
boga95 committed rG080ecafdd8b3: Move prop-sink branch to monorepo. (authored by boga95).
Move prop-sink branch to monorepo.
Sep 8 2019, 12:24 PM
boga95 committed rL371342: Move prop-sink branch to monorepo..
Move prop-sink branch to monorepo.
Sep 8 2019, 12:23 PM

Sep 6 2019

boga95 updated the diff for D59637: [analyzer] Use the custom propagation rules and sinks in GenericTaintChecker.
Sep 6 2019, 2:02 PM · Restricted Project

Sep 2 2019

boga95 updated the diff for D59637: [analyzer] Use the custom propagation rules and sinks in GenericTaintChecker.
Sep 2 2019, 3:13 PM · Restricted Project

Aug 30 2019

boga95 added a comment to D59637: [analyzer] Use the custom propagation rules and sinks in GenericTaintChecker.

Should I do anything or it is ready?

Aug 30 2019, 2:51 PM · Restricted Project

Aug 14 2019

boga95 updated the diff for D59637: [analyzer] Use the custom propagation rules and sinks in GenericTaintChecker.
Aug 14 2019, 3:25 PM · Restricted Project

Jul 31 2019

boga95 added a comment to D59637: [analyzer] Use the custom propagation rules and sinks in GenericTaintChecker.

I think it shouldn't give compile error in case of incorrect configuration now (maybe warning) because:

Jul 31 2019, 2:23 AM · Restricted Project

Jul 28 2019

boga95 updated the diff for D59637: [analyzer] Use the custom propagation rules and sinks in GenericTaintChecker.
Jul 28 2019, 2:36 PM · Restricted Project
boga95 committed rG2c8098374b6b: Buildbot fix for r367190 (authored by boga95).
Buildbot fix for r367190
Jul 28 2019, 10:08 AM
boga95 committed rG2c8098374b6b: Buildbot fix for r367190 (authored by boga95).
Buildbot fix for r367190
Jul 28 2019, 9:26 AM
boga95 committed rG2c8098374b6b: Buildbot fix for r367190 (authored by boga95).
Buildbot fix for r367190
Jul 28 2019, 8:43 AM
boga95 committed rG2c8098374b6b: Buildbot fix for r367190 (authored by boga95).
Buildbot fix for r367190
Jul 28 2019, 8:01 AM
boga95 committed rL367193: Buildbot fix for r367190.
Buildbot fix for r367190
Jul 28 2019, 7:57 AM
boga95 committed rG4bde15fe1e4a: [analyzer] Add yaml parser to GenericTaintChecker (authored by boga95).
[analyzer] Add yaml parser to GenericTaintChecker
Jul 28 2019, 6:38 AM
boga95 committed rL367190: [analyzer] Add yaml parser to GenericTaintChecker.
[analyzer] Add yaml parser to GenericTaintChecker
Jul 28 2019, 6:37 AM
boga95 closed D59555: [analyzer] Add yaml parser to GenericTaintChecker.
Jul 28 2019, 6:37 AM · Restricted Project, Restricted Project

Jul 27 2019

boga95 updated the diff for D59555: [analyzer] Add yaml parser to GenericTaintChecker.
Jul 27 2019, 11:28 AM · Restricted Project, Restricted Project

Jul 18 2019

boga95 updated the diff for D59555: [analyzer] Add yaml parser to GenericTaintChecker.
Jul 18 2019, 6:00 AM · Restricted Project, Restricted Project

Jul 17 2019

boga95 updated the diff for D59555: [analyzer] Add yaml parser to GenericTaintChecker.
Jul 17 2019, 12:42 AM · Restricted Project, Restricted Project
boga95 updated the diff for D59555: [analyzer] Add yaml parser to GenericTaintChecker.
Jul 17 2019, 12:37 AM · Restricted Project, Restricted Project

Jul 16 2019

boga95 updated the diff for D59555: [analyzer] Add yaml parser to GenericTaintChecker.

Report diagnostic error in case of an invalid filename or an ill-formed yaml file.

Jul 16 2019, 5:45 AM · Restricted Project, Restricted Project

Jun 6 2019

boga95 updated the diff for D59555: [analyzer] Add yaml parser to GenericTaintChecker.
Jun 6 2019, 6:11 AM · Restricted Project, Restricted Project

May 23 2019

boga95 added a comment to D59555: [analyzer] Add yaml parser to GenericTaintChecker.

I already thought about it. It would make the code much cleaner, but it would have a little performance impact (Does it matter?).
It's straightforward to read the supported functions from another yaml file. Besides that, it can support multiple config files too.

May 23 2019, 1:45 PM · Restricted Project, Restricted Project

May 17 2019

boga95 updated the diff for D59555: [analyzer] Add yaml parser to GenericTaintChecker.

I changed the parsing, therefore the return value index is represented by -1.
I added a test configuration file and parse it when testing to prove the configuration doesn't break the code.

May 17 2019, 2:07 AM · Restricted Project, Restricted Project

May 16 2019

boga95 added a comment to D59555: [analyzer] Add yaml parser to GenericTaintChecker.

Sorry for the late answer, I was working on my thesis which is about taint analysis. During that, I implemented several cool features (namespaces, std::cin, std::string, etc.) for the checker. I will share them soon.

May 16 2019, 6:42 AM · Restricted Project, Restricted Project

Apr 4 2019

boga95 updated the diff for D59516: [analyzer] Add custom filter functions for GenericTaintChecker.

Rebase after https://reviews.llvm.org/D59861.
Fix custom filter test case: functions without definition always remove taintedness.

Apr 4 2019, 7:15 AM · Restricted Project
boga95 updated the diff for D59637: [analyzer] Use the custom propagation rules and sinks in GenericTaintChecker.

Rebase after https://reviews.llvm.org/D59861.

Apr 4 2019, 2:20 AM · Restricted Project

Apr 1 2019

boga95 updated the diff for D59555: [analyzer] Add yaml parser to GenericTaintChecker.

Rebase after https://reviews.llvm.org/D59861.

Apr 1 2019, 2:02 PM · Restricted Project, Restricted Project

Mar 29 2019

boga95 added a child revision for D59861: [analyzer] NFC: Replace Taint API with a usual inter-checker communication API?: D59555: [analyzer] Add yaml parser to GenericTaintChecker.
Mar 29 2019, 5:48 AM · Restricted Project
boga95 added a parent revision for D59555: [analyzer] Add yaml parser to GenericTaintChecker: D59861: [analyzer] NFC: Replace Taint API with a usual inter-checker communication API?.
Mar 29 2019, 5:48 AM · Restricted Project, Restricted Project

Mar 27 2019

boga95 added a comment to D59861: [analyzer] NFC: Replace Taint API with a usual inter-checker communication API?.

Thanks, it will make my changes more cleaner.

Mar 27 2019, 2:43 AM · Restricted Project

Mar 26 2019

boga95 added a comment to D59516: [analyzer] Add custom filter functions for GenericTaintChecker.

I add a new taint type, which represents a lack of taintedness. That's why I changed the name of addTaint() to setTaint(). Of course, it's not an important change, I can move it to another patch.

Mar 26 2019, 4:12 PM · Restricted Project

Mar 25 2019

boga95 added a comment to D59555: [analyzer] Add yaml parser to GenericTaintChecker.

Why is it better not to use static functions/variables? Has it any performance impact?

Mar 25 2019, 2:35 PM · Restricted Project, Restricted Project

Mar 21 2019

boga95 updated the diff for D59516: [analyzer] Add custom filter functions for GenericTaintChecker.
Mar 21 2019, 5:56 AM · Restricted Project
boga95 removed a parent revision for D59516: [analyzer] Add custom filter functions for GenericTaintChecker: D59555: [analyzer] Add yaml parser to GenericTaintChecker.
Mar 21 2019, 5:52 AM · Restricted Project
boga95 removed a child revision for D59555: [analyzer] Add yaml parser to GenericTaintChecker: D59516: [analyzer] Add custom filter functions for GenericTaintChecker.
Mar 21 2019, 5:52 AM · Restricted Project, Restricted Project
boga95 added a child revision for D59637: [analyzer] Use the custom propagation rules and sinks in GenericTaintChecker: D59516: [analyzer] Add custom filter functions for GenericTaintChecker.
Mar 21 2019, 5:51 AM · Restricted Project
boga95 added a parent revision for D59516: [analyzer] Add custom filter functions for GenericTaintChecker: D59637: [analyzer] Use the custom propagation rules and sinks in GenericTaintChecker.
Mar 21 2019, 5:51 AM · Restricted Project
boga95 added a child revision for D59555: [analyzer] Add yaml parser to GenericTaintChecker: D59637: [analyzer] Use the custom propagation rules and sinks in GenericTaintChecker.
Mar 21 2019, 5:50 AM · Restricted Project, Restricted Project
boga95 added a parent revision for D59637: [analyzer] Use the custom propagation rules and sinks in GenericTaintChecker: D59555: [analyzer] Add yaml parser to GenericTaintChecker.
Mar 21 2019, 5:50 AM · Restricted Project
boga95 created D59637: [analyzer] Use the custom propagation rules and sinks in GenericTaintChecker.
Mar 21 2019, 5:50 AM · Restricted Project

Mar 19 2019

boga95 added a parent revision for D59516: [analyzer] Add custom filter functions for GenericTaintChecker: D59555: [analyzer] Add yaml parser to GenericTaintChecker.
Mar 19 2019, 12:30 PM · Restricted Project
boga95 added a child revision for D59555: [analyzer] Add yaml parser to GenericTaintChecker: D59516: [analyzer] Add custom filter functions for GenericTaintChecker.
Mar 19 2019, 12:30 PM · Restricted Project, Restricted Project
boga95 created D59555: [analyzer] Add yaml parser to GenericTaintChecker.
Mar 19 2019, 12:29 PM · Restricted Project, Restricted Project

Mar 18 2019

boga95 created D59516: [analyzer] Add custom filter functions for GenericTaintChecker.
Mar 18 2019, 3:25 PM · Restricted Project

Mar 8 2019

boga95 added a comment to D59055: [analyzer] Prepare generic taint checker for new sources.

Yes, they do. Thanks for the review.

Mar 8 2019, 1:05 AM · Restricted Project

Mar 6 2019

boga95 created D59055: [analyzer] Prepare generic taint checker for new sources.
Mar 6 2019, 2:47 PM · Restricted Project

Mar 1 2019

boga95 created D58828: [analyzer] Fix taint propagation in GenericTaintChecker.
Mar 1 2019, 7:01 AM · Restricted Project

Jan 28 2019

boga95 added a comment to D55734: [analyzer] Revise GenericTaintChecker's internal representation.

Yes, thank you.

Jan 28 2019, 11:38 PM

Jan 27 2019

boga95 added a comment to D55734: [analyzer] Revise GenericTaintChecker's internal representation.

Is it ready to land?

Jan 27 2019, 11:01 AM

Dec 23 2018

boga95 updated the diff for D55734: [analyzer] Revise GenericTaintChecker's internal representation.
Dec 23 2018, 3:07 AM

Dec 17 2018

boga95 updated the diff for D55734: [analyzer] Revise GenericTaintChecker's internal representation.
Dec 17 2018, 2:49 PM
boga95 added a comment to D54918: [analyzer] Apply clang-format to GenericTaintChecker.cpp.

I don't have commit access. Can you please do it on my behalf?

Dec 17 2018, 9:00 AM · Restricted Project

Dec 15 2018

boga95 retitled D55734: [analyzer] Revise GenericTaintChecker's internal representation from [analyzer] Refactoring GenericTaintChecker.cpp to [analyzer] Revise GenericTaintChecker's internal representation.
Dec 15 2018, 11:45 AM
boga95 updated the diff for D55734: [analyzer] Revise GenericTaintChecker's internal representation.

Rebase patch on the earlier version. Remove unnecessary inline specifiers. Fix typo.

Dec 15 2018, 11:38 AM
boga95 updated the diff for D55734: [analyzer] Revise GenericTaintChecker's internal representation.
Dec 15 2018, 7:58 AM
boga95 added a child revision for D54918: [analyzer] Apply clang-format to GenericTaintChecker.cpp: D55734: [analyzer] Revise GenericTaintChecker's internal representation.
Dec 15 2018, 4:17 AM · Restricted Project
boga95 added a parent revision for D55734: [analyzer] Revise GenericTaintChecker's internal representation: D54918: [analyzer] Apply clang-format to GenericTaintChecker.cpp.
Dec 15 2018, 4:17 AM
boga95 added a comment to D55734: [analyzer] Revise GenericTaintChecker's internal representation.

I use std::move which is in the <utility>.

Dec 15 2018, 2:59 AM
boga95 updated the diff for D55734: [analyzer] Revise GenericTaintChecker's internal representation.

Upload diff with full context.

Dec 15 2018, 2:51 AM
boga95 created D55734: [analyzer] Revise GenericTaintChecker's internal representation.
Dec 15 2018, 1:53 AM

Nov 29 2018

boga95 added a comment to D54918: [analyzer] Apply clang-format to GenericTaintChecker.cpp.

If you find it ok, can you please commit it? @xazax.hun

Nov 29 2018, 6:06 AM · Restricted Project

Nov 26 2018

boga95 created D54918: [analyzer] Apply clang-format to GenericTaintChecker.cpp.
Nov 26 2018, 2:30 PM · Restricted Project

Oct 2 2018

boga95 updated the diff for D52281: [clang-tidy] Add modernize check to use std::invoke in generic code.
Oct 2 2018, 11:40 AM · Restricted Project

Sep 25 2018

boga95 updated the diff for D52281: [clang-tidy] Add modernize check to use std::invoke in generic code.
Sep 25 2018, 2:40 PM · Restricted Project

Sep 22 2018

boga95 updated the diff for D52281: [clang-tidy] Add modernize check to use std::invoke in generic code.
Sep 22 2018, 9:36 AM · Restricted Project

Sep 19 2018

boga95 created D52281: [clang-tidy] Add modernize check to use std::invoke in generic code.
Sep 19 2018, 2:40 PM · Restricted Project

Jul 4 2018

boga95 added a comment to D44143: [clang-tidy] Create properly seeded random generator check.

How can I commit it?

Jul 4 2018, 12:24 PM · Restricted Project

Jul 1 2018

boga95 updated the diff for D44143: [clang-tidy] Create properly seeded random generator check.
Jul 1 2018, 1:52 PM · Restricted Project

Jun 27 2018

boga95 updated the diff for D44143: [clang-tidy] Create properly seeded random generator check.
Jun 27 2018, 1:55 PM · Restricted Project
boga95 updated the diff for D44143: [clang-tidy] Create properly seeded random generator check.
Jun 27 2018, 1:45 PM · Restricted Project

Jun 25 2018

boga95 updated the diff for D44143: [clang-tidy] Create properly seeded random generator check.

Add std::srand check to C++ tests. Format patch.

Jun 25 2018, 2:48 PM · Restricted Project

Jun 24 2018

boga95 added a comment to D44143: [clang-tidy] Create properly seeded random generator check.

I think I resolved all of the comments. Do I forget anything?

Jun 24 2018, 11:47 AM · Restricted Project

Apr 27 2018

boga95 updated the diff for D44143: [clang-tidy] Create properly seeded random generator check.
Apr 27 2018, 6:54 AM · Restricted Project

Mar 12 2018

boga95 updated subscribers of D44143: [clang-tidy] Create properly seeded random generator check.
Mar 12 2018, 12:45 PM · Restricted Project

Mar 10 2018

boga95 updated the diff for D44143: [clang-tidy] Create properly seeded random generator check.

Add capability to provide a user-configurable list of disallowed types which will trigger warning. Now it also detects C srand function. Rename check to cert-msc51-cpp. Add cert-msc32-c check. Change warning messages. Other minor fixes.

Mar 10 2018, 10:26 AM · Restricted Project

Mar 7 2018

boga95 updated subscribers of D44143: [clang-tidy] Create properly seeded random generator check.
Mar 7 2018, 12:16 PM · Restricted Project

Mar 6 2018

boga95 created D44143: [clang-tidy] Create properly seeded random generator check.
Mar 6 2018, 3:58 AM · Restricted Project