Page MenuHomePhabricator

bobsayshilol (Ben)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 25 2018, 3:32 PM (72 w, 1 d)

Recent Activity

Wed, Nov 13

bobsayshilol added inline comments to D69490: [LoopIdiomRecognize] Avoid trying to create a pattern from the address of a thread local..
Wed, Nov 13, 4:04 PM · Restricted Project

Nov 3 2019

bobsayshilol added a reviewer for D69490: [LoopIdiomRecognize] Avoid trying to create a pattern from the address of a thread local.: hans.
Nov 3 2019, 9:49 AM · Restricted Project

Oct 28 2019

bobsayshilol added inline comments to D69490: [LoopIdiomRecognize] Avoid trying to create a pattern from the address of a thread local..
Oct 28 2019, 4:27 PM · Restricted Project

Oct 27 2019

bobsayshilol created D69490: [LoopIdiomRecognize] Avoid trying to create a pattern from the address of a thread local..
Oct 27 2019, 4:22 PM · Restricted Project

Nov 11 2018

bobsayshilol added a comment to D54381: [llvm-exegesis] InstructionBenchmarkClustering::dbScan(): use llvm::SetVector<> instead of ILLEGAL std::unordered_set<>.

I think the usage of Set is correct.
We will, at most, fail to deduplicate one element (the one we just removed) out of N returned by rangeQuery(Q).
But if we don't do any deduplication at all, then we will add all the N elements. And that sounds exponential.

Nov 11 2018, 8:03 AM
bobsayshilol added a comment to D54381: [llvm-exegesis] InstructionBenchmarkClustering::dbScan(): use llvm::SetVector<> instead of ILLEGAL std::unordered_set<>.

I could be missing something, but I don't understand why ToProcess needs to be a set-like container since we're erasing elements as we go (ie the erased elements won't be duplicate checked on next insertion). We skip any that have been previously processed in the inner loop too, which seems like it's doing the same work the set would be doing.

Nov 11 2018, 5:54 AM
bobsayshilol added a comment to D53263: Fix places where the return type of a FunctionDecl was being used in place of the function type.

Huge apologies, it seems I can't get this to patch cleanly against my fork and therefore can't test it before committing, which is something I generally always do. I'll leave it to someone else. Again, huge apologies, hopefully you won't have to wait too long.

Nov 11 2018, 3:54 AM

Nov 10 2018

bobsayshilol added a comment to D53263: Fix places where the return type of a FunctionDecl was being used in place of the function type.

I can do it if you'd like, will be a moment though.

Thanks and much appreciated!

Nov 10 2018, 3:14 PM
bobsayshilol added a comment to D53263: Fix places where the return type of a FunctionDecl was being used in place of the function type.

Thanks!
I don't have commit access to land this myself.

Nov 10 2018, 12:49 PM

Nov 8 2018

bobsayshilol added a reviewer for D53263: Fix places where the return type of a FunctionDecl was being used in place of the function type: rjmccall.

Ping.

Nov 8 2018, 3:07 PM

Oct 27 2018

bobsayshilol added a comment to D53263: Fix places where the return type of a FunctionDecl was being used in place of the function type.

Ping.

Oct 27 2018, 1:49 PM

Oct 19 2018

bobsayshilol updated the diff for D53263: Fix places where the return type of a FunctionDecl was being used in place of the function type.

Add missing part of previous change to patch. Now all unit tests pass.

Oct 19 2018, 4:57 PM

Oct 18 2018

bobsayshilol updated the summary of D53263: Fix places where the return type of a FunctionDecl was being used in place of the function type.
Oct 18 2018, 5:46 PM
bobsayshilol updated the diff for D53263: Fix places where the return type of a FunctionDecl was being used in place of the function type.

Fixed the added assert to do the right thing. Clang can now build with a debug Clang built from this patch, and all unittests I could find pass in that built version too.

Oct 18 2018, 5:43 PM

Oct 14 2018

bobsayshilol created D53263: Fix places where the return type of a FunctionDecl was being used in place of the function type.
Oct 14 2018, 3:20 PM

Aug 25 2018

bobsayshilol added a comment to D50101: [asan] Update a vector's storage annotation during destruction..

Pinging this as it's been "Ready to Land" for a while and I want to check that that's not because I've forgotten to do something?

Aug 25 2018, 12:18 PM

Aug 1 2018

bobsayshilol added a comment to D50101: [asan] Update a vector's storage annotation during destruction..

Thanks! I don't have write access to svn so I can't commit the patch myself, but assuming that I've read the docs correctly if anyone is able to take it I'd be grateful.

Aug 1 2018, 12:38 PM

Jul 31 2018

bobsayshilol created D50101: [asan] Update a vector's storage annotation during destruction..
Jul 31 2018, 1:32 PM