Page MenuHomePhabricator

bobmoretti (Bobby Moretti)
User

Projects

User does not belong to any projects.

User Details

User Since
May 5 2014, 5:49 PM (432 w, 6 h)

Recent Activity

May 7 2014

bobmoretti updated the diff for D3634: clang-format recognizes alternative binary operator keywords.

I updated the proto test to not include any c++ reserved keywords, and I changed the LangOpts returned by getFormattingLangOpts to set CXXOperatorNames to 1 unconditionally, as per review feedback

May 7 2014, 4:06 PM

May 6 2014

bobmoretti added a comment to D3634: clang-format recognizes alternative binary operator keywords.

Oh, I missed your edit. I will wait for more feedback before changing.

May 6 2014, 10:38 PM
bobmoretti added a comment to D3634: clang-format recognizes alternative binary operator keywords.

All right, so probably the proto test should not try to use a C++ reserved keyword for a type name. I will change that, and get rid of the LanguageKind parameter.

May 6 2014, 10:36 PM
bobmoretti added a comment to D3634: clang-format recognizes alternative binary operator keywords.

Yes, I think that would be a problem. However, this particular failing test case doesn't involve the field name; rather it involves the field's type. So I think a closer parallel would be

May 6 2014, 10:06 PM
bobmoretti added a comment to D3634: clang-format recognizes alternative binary operator keywords.

I didn't add the LanguageKind parameter initially. However, without checking the LanguageKind parameter, a protocol buffers test fails.

May 6 2014, 9:28 PM
bobmoretti added a comment to D3634: clang-format recognizes alternative binary operator keywords.

NB: Phabricator choked on a diff with UTF8, so I replaced all non-ascii characters in the uploaded diff with spaces (which you will see if you expand the context enough).

May 6 2014, 8:47 PM
bobmoretti retitled D3634: clang-format recognizes alternative binary operator keywords from to clang-format recognizes alternative binary operator keywords.
May 6 2014, 8:44 PM