Page MenuHomePhabricator

bkelley (Brian T. Kelley)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 23 2017, 4:06 PM (142 w, 2 d)

Recent Activity

Jun 20 2017

bkelley accepted D34377: Support MS builtins using 'long' on LP64.

Looks good to me. Thank you!

Jun 20 2017, 9:37 AM

Mar 29 2017

bkelley committed rL299015: [Objective-C] Miscellaneous -fobjc-weak Fixes.
[Objective-C] Miscellaneous -fobjc-weak Fixes
Mar 29 2017, 11:29 AM
bkelley closed D31007: [Objective-C] Miscellaneous -fobjc-weak Fixes.
Mar 29 2017, 11:28 AM
bkelley committed rL299014: [Objective-C] Fix "weak-unavailable" warning with -fobjc-weak.
[Objective-C] Fix "weak-unavailable" warning with -fobjc-weak
Mar 29 2017, 11:21 AM
bkelley closed D31006: [Objective-C] Fix "weak-unavailable" warning with -fobjc-weak.
Mar 29 2017, 11:21 AM
bkelley committed rL299011: [Objective-C] Fix "repeated use of weak" warning with -fobjc-weak.
[Objective-C] Fix "repeated use of weak" warning with -fobjc-weak
Mar 29 2017, 11:07 AM
bkelley closed D31005: [Objective-C] Fix "repeated use of weak" warning with -fobjc-weak.
Mar 29 2017, 11:07 AM
bkelley committed rL299010: [Objective-C] Fix __weak type traits with -fobjc-weak.
[Objective-C] Fix __weak type traits with -fobjc-weak
Mar 29 2017, 10:53 AM
bkelley closed D31004: [Objective-C] Fix __weak type traits with -fobjc-weak.
Mar 29 2017, 10:52 AM
bkelley committed rL299008: [Objective-C] C++ Classes with __weak Members non-POD Types when using -fobjc….
[Objective-C] C++ Classes with __weak Members non-POD Types when using -fobjc…
Mar 29 2017, 10:44 AM
bkelley closed D31003: [Objective-C] C++ Classes with __weak Members non-POD Types when using -fobjc-weak.
Mar 29 2017, 10:44 AM
bkelley committed rL299007: Test Commit.
Test Commit
Mar 29 2017, 10:30 AM

Mar 27 2017

bkelley added a comment to D31007: [Objective-C] Miscellaneous -fobjc-weak Fixes.

Thank you @rjmccall for the approval. I don't have commit access; would someone be willing to commit this path for me please? Thanks!

Mar 27 2017, 9:15 AM
bkelley added a comment to D31006: [Objective-C] Fix "weak-unavailable" warning with -fobjc-weak.

Thank you @rjmccall for the approval. I don't have commit access; would someone be willing to commit this path for me please? Thanks!

Mar 27 2017, 9:14 AM
bkelley added a comment to D31005: [Objective-C] Fix "repeated use of weak" warning with -fobjc-weak.

Thank you @rjmccall for the approval. I don't have commit access; would someone be willing to commit this path for me please? Thanks!

Mar 27 2017, 9:14 AM
bkelley added a comment to D31004: [Objective-C] Fix __weak type traits with -fobjc-weak.

Thank you @rjmccall for the approval. I don't have commit access; would someone be willing to commit this path for me please? Thanks!

Mar 27 2017, 9:14 AM
bkelley added a comment to D31003: [Objective-C] C++ Classes with __weak Members non-POD Types when using -fobjc-weak.

Thank you @rjmccall for the approval. I don't have commit access; would someone be willing to commit this path for me please? Thanks!

Mar 27 2017, 9:14 AM

Mar 24 2017

bkelley added a comment to D31005: [Objective-C] Fix "repeated use of weak" warning with -fobjc-weak.

Sorry for missing the unnecessary LangOpts checks here. Thanks again for the feedback!

Mar 24 2017, 5:26 PM
bkelley updated the diff for D31005: [Objective-C] Fix "repeated use of weak" warning with -fobjc-weak.

Updated with feedback from @rjmccall

Mar 24 2017, 5:26 PM
bkelley added a comment to D31005: [Objective-C] Fix "repeated use of weak" warning with -fobjc-weak.

Thanks again for the feedback. Is there anything further I should update in this diff or is it looking good?

Mar 24 2017, 1:25 PM
bkelley added inline comments to D31007: [Objective-C] Miscellaneous -fobjc-weak Fixes.
Mar 24 2017, 9:38 AM
bkelley updated the diff for D31007: [Objective-C] Miscellaneous -fobjc-weak Fixes.

Updated with latest feedback from @rjmccall

Mar 24 2017, 9:38 AM

Mar 23 2017

bkelley added inline comments to D31007: [Objective-C] Miscellaneous -fobjc-weak Fixes.
Mar 23 2017, 6:02 PM
bkelley updated the diff for D31007: [Objective-C] Miscellaneous -fobjc-weak Fixes.
Mar 23 2017, 6:01 PM
bkelley added a comment to D31004: [Objective-C] Fix __weak type traits with -fobjc-weak.

Thanks for the feedback! Apologies for the slow turn around; I was out sick :(

Mar 23 2017, 5:55 PM
bkelley updated the diff for D31004: [Objective-C] Fix __weak type traits with -fobjc-weak.

Removed redundant conditions, per feedback from @rjmccall

Mar 23 2017, 5:55 PM

Mar 17 2017

bkelley updated the diff for D31007: [Objective-C] Miscellaneous -fobjc-weak Fixes.

Integrated feedback from @rjmccall

Mar 17 2017, 4:14 PM
bkelley added a comment to D31007: [Objective-C] Miscellaneous -fobjc-weak Fixes.

Thanks for all the feedback! I think things are looking a lot better now.

Mar 17 2017, 4:05 PM
bkelley added inline comments to D31006: [Objective-C] Fix "weak-unavailable" warning with -fobjc-weak.
Mar 17 2017, 4:05 PM
bkelley updated the diff for D31006: [Objective-C] Fix "weak-unavailable" warning with -fobjc-weak.

Updated with feedback from @rjmccall

Mar 17 2017, 4:05 PM
bkelley updated the diff for D31005: [Objective-C] Fix "repeated use of weak" warning with -fobjc-weak.

Updated with feedback from @jordan_rose and @arphaman

Mar 17 2017, 4:05 PM
bkelley added inline comments to D31005: [Objective-C] Fix "repeated use of weak" warning with -fobjc-weak.
Mar 17 2017, 4:05 PM
bkelley updated the diff for D31004: [Objective-C] Fix __weak type traits with -fobjc-weak.

Updated with feedback from @rjmccall

Mar 17 2017, 4:05 PM
bkelley added a comment to D31004: [Objective-C] Fix __weak type traits with -fobjc-weak.

Looks like we can simplify everything by using hasNonTrivialObjCLifetime(), like in D31003.

Mar 17 2017, 4:05 PM
bkelley added inline comments to D31003: [Objective-C] C++ Classes with __weak Members non-POD Types when using -fobjc-weak.
Mar 17 2017, 4:05 PM
bkelley updated the diff for D31003: [Objective-C] C++ Classes with __weak Members non-POD Types when using -fobjc-weak.

Integrated feedback from @rjmccall

Mar 17 2017, 4:05 PM

Mar 15 2017

bkelley added inline comments to D31005: [Objective-C] Fix "repeated use of weak" warning with -fobjc-weak.
Mar 15 2017, 4:10 PM
bkelley added a child revision for D31006: [Objective-C] Fix "weak-unavailable" warning with -fobjc-weak: D31007: [Objective-C] Miscellaneous -fobjc-weak Fixes.
Mar 15 2017, 3:44 PM
bkelley added a parent revision for D31007: [Objective-C] Miscellaneous -fobjc-weak Fixes: D31006: [Objective-C] Fix "weak-unavailable" warning with -fobjc-weak.
Mar 15 2017, 3:44 PM
bkelley created D31007: [Objective-C] Miscellaneous -fobjc-weak Fixes.
Mar 15 2017, 3:44 PM
bkelley added a parent revision for D31006: [Objective-C] Fix "weak-unavailable" warning with -fobjc-weak: D31005: [Objective-C] Fix "repeated use of weak" warning with -fobjc-weak.
Mar 15 2017, 3:40 PM
bkelley added a child revision for D31005: [Objective-C] Fix "repeated use of weak" warning with -fobjc-weak: D31006: [Objective-C] Fix "weak-unavailable" warning with -fobjc-weak.
Mar 15 2017, 3:40 PM
bkelley created D31006: [Objective-C] Fix "weak-unavailable" warning with -fobjc-weak.
Mar 15 2017, 3:39 PM
bkelley added a parent revision for D31005: [Objective-C] Fix "repeated use of weak" warning with -fobjc-weak: D31004: [Objective-C] Fix __weak type traits with -fobjc-weak.
Mar 15 2017, 3:35 PM
bkelley added a child revision for D31004: [Objective-C] Fix __weak type traits with -fobjc-weak: D31005: [Objective-C] Fix "repeated use of weak" warning with -fobjc-weak.
Mar 15 2017, 3:35 PM
bkelley created D31005: [Objective-C] Fix "repeated use of weak" warning with -fobjc-weak.
Mar 15 2017, 3:35 PM
bkelley added a child revision for D31003: [Objective-C] C++ Classes with __weak Members non-POD Types when using -fobjc-weak: D31004: [Objective-C] Fix __weak type traits with -fobjc-weak.
Mar 15 2017, 3:30 PM
bkelley added a parent revision for D31004: [Objective-C] Fix __weak type traits with -fobjc-weak: D31003: [Objective-C] C++ Classes with __weak Members non-POD Types when using -fobjc-weak.
Mar 15 2017, 3:30 PM
bkelley created D31004: [Objective-C] Fix __weak type traits with -fobjc-weak.
Mar 15 2017, 3:30 PM
bkelley created D31003: [Objective-C] C++ Classes with __weak Members non-POD Types when using -fobjc-weak.
Mar 15 2017, 3:25 PM