Page MenuHomePhabricator

bin.cheng (Bin Cheng)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 5 2021, 10:58 PM (55 w, 23 h)

Recent Activity

Jun 10 2022

bin.cheng committed rG8b360c69e9e3: [FuncSpec]Fix assertion failure when value is not added to solver (authored by bin.cheng).
[FuncSpec]Fix assertion failure when value is not added to solver
Jun 10 2022, 3:46 AM · Restricted Project, Restricted Project
bin.cheng closed D126355: [FuncSpec]Fix assertion failure when lattice value is not found..
Jun 10 2022, 3:46 AM · Restricted Project, Restricted Project

May 25 2022

bin.cheng added a comment to D126355: [FuncSpec]Fix assertion failure when lattice value is not found..

We should generate a patch with option -U9999 to offer more context to review.

Thanks for the info and feedback. I have updated the diff file.

Thanks for working on this. Have you measured any performance/code size change?

I only ran on Spec 2017, and luckily no crash during compiling. I will check the performance/code size different later.

Also, I feel we could do better since we've already mark it as overrefined in https://github.com/llvm/llvm-project/blob/cd2292ef824591cc34cc299910a3098545c840c7/llvm/lib/Transforms/Utils/SCCPSolver.cpp#L1254
So it looks possible to get the lattice successfully.

Ok, I will think about it, thanks again!

Given it might be non-trivial to support ByVal arguments in SCCPSolver, and ByVal is generally used for pointers to structure/array, we can first try to get this version of patch reviewed and merged, then work on ByVal/SCCPSolver as a following task (probably with a lower priority).

May 25 2022, 8:53 PM · Restricted Project, Restricted Project

Feb 15 2022

bin.cheng committed rGdfec0b3053b9: [FuncSpec] Save compilation time by caching uses for propagation (authored by bin.cheng).
[FuncSpec] Save compilation time by caching uses for propagation
Feb 15 2022, 6:47 PM
bin.cheng closed D119815: [FuncSpec]Save compilation time by caching uses of replaced value.
Feb 15 2022, 6:47 PM · Restricted Project
bin.cheng requested review of D119815: [FuncSpec]Save compilation time by caching uses of replaced value.
Feb 15 2022, 1:08 AM · Restricted Project

Nov 10 2021

bin.cheng committed rGbf76e6485431: [BPI] Push exit block rather than exiting ones in getSccExitBlocks (authored by bin.cheng).
[BPI] Push exit block rather than exiting ones in getSccExitBlocks
Nov 10 2021, 10:23 PM
bin.cheng closed D113344: [BPI] Push exit block rather than exiting ones in getSccExitBlocks.
Nov 10 2021, 10:22 PM · Restricted Project

Nov 8 2021

bin.cheng added inline comments to D113345: [WIP][BPI] `calcEstimatedHeuristics()`: symmetrically with loop exiting edge, scale loop enter edge weight by trip count.
Nov 8 2021, 1:03 AM · Restricted Project

Nov 7 2021

bin.cheng requested review of D113377: [Sink] Use reverse post order in iterative sinking algorithm.
Nov 7 2021, 7:03 PM · Restricted Project

Nov 6 2021

bin.cheng added a comment to D113342: [LoopRotate] Add branch_weights metadata for rotated branch.

Indeed, https://godbolt.org/z/cM8P49qxo, but it sounds like a BPI problem?

Nov 6 2021, 8:54 PM · Restricted Project, Restricted Project
bin.cheng added inline comments to D113345: [WIP][BPI] `calcEstimatedHeuristics()`: symmetrically with loop exiting edge, scale loop enter edge weight by trip count.
Nov 6 2021, 8:15 PM · Restricted Project
bin.cheng requested review of D113344: [BPI] Push exit block rather than exiting ones in getSccExitBlocks.
Nov 6 2021, 5:05 AM · Restricted Project
bin.cheng requested review of D113342: [LoopRotate] Add branch_weights metadata for rotated branch.
Nov 6 2021, 4:50 AM · Restricted Project, Restricted Project

Nov 5 2021

bin.cheng committed rG54d891a7d5f2: [RISCV]: Fix typo by abstracting VWholeLoad* classes (authored by bin.cheng).
[RISCV]: Fix typo by abstracting VWholeLoad* classes
Nov 5 2021, 7:48 PM
bin.cheng committed rGd488f1fff202: [RISCV][NFC]: Refactor classes for load/store instructions of RVV (authored by bin.cheng).
[RISCV][NFC]: Refactor classes for load/store instructions of RVV
Nov 5 2021, 7:48 PM
bin.cheng closed D109319: [RISCV] Fix typo by abstracting VWholeLoad* classes.
Nov 5 2021, 7:48 PM · Restricted Project, Restricted Project
bin.cheng closed D109318: [RISCV][NFC] Refactor classes for load/store instructions of V extension.
Nov 5 2021, 7:48 PM · Restricted Project, Restricted Project

Sep 28 2021

bin.cheng added inline comments to D109318: [RISCV][NFC] Refactor classes for load/store instructions of V extension.
Sep 28 2021, 9:11 AM · Restricted Project, Restricted Project
bin.cheng updated the diff for D109318: [RISCV][NFC] Refactor classes for load/store instructions of V extension.

Update comments in patch. Thanks

Sep 28 2021, 9:07 AM · Restricted Project, Restricted Project
bin.cheng added inline comments to D109318: [RISCV][NFC] Refactor classes for load/store instructions of V extension.
Sep 28 2021, 8:56 AM · Restricted Project, Restricted Project

Sep 26 2021

bin.cheng added a comment to D109319: [RISCV] Fix typo by abstracting VWholeLoad* classes.

Gentle ping. Could any one review this? So that I can drop it if it's not wanted.

Sep 26 2021, 2:07 AM · Restricted Project, Restricted Project
bin.cheng added a comment to D109318: [RISCV][NFC] Refactor classes for load/store instructions of V extension.

Gentle ping. Could any one review this? So that I can drop it if it's not wanted.

Sep 26 2021, 2:07 AM · Restricted Project, Restricted Project

Sep 6 2021

bin.cheng requested review of D109319: [RISCV] Fix typo by abstracting VWholeLoad* classes.
Sep 6 2021, 5:25 AM · Restricted Project, Restricted Project
bin.cheng requested review of D109318: [RISCV][NFC] Refactor classes for load/store instructions of V extension.
Sep 6 2021, 5:19 AM · Restricted Project, Restricted Project