Page MenuHomePhabricator

betulb (Betul Buyukkurt)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 24 2015, 2:59 PM (238 w, 4 d)

Recent Activity

Apr 26 2016

betulb added inline comments to D19515: [PGO] Prohibit the recording the function address if it's internal and COMDAT..
Apr 26 2016, 12:19 PM
betulb added a comment to D19515: [PGO] Prohibit the recording the function address if it's internal and COMDAT..

Thanks for the test.

Apr 26 2016, 11:11 AM

Apr 14 2016

betulb committed rL266335: [PGO] Do not attach VP metadata if value count at site is 0 [NFC] .
[PGO] Do not attach VP metadata if value count at site is 0 [NFC]
Apr 14 2016, 9:31 AM

Apr 13 2016

betulb committed rL266240: [PGO] Fix the buildbots for r266229. .
[PGO] Fix the buildbots for r266229.
Apr 13 2016, 1:07 PM
betulb committed rL266229: [PGO] Remove redundant VP instrumentation.
[PGO] Remove redundant VP instrumentation
Apr 13 2016, 11:58 AM

Apr 11 2016

betulb updated subscribers of D18126: Port InstrProfiling pass to new pass manager .
Apr 11 2016, 12:10 AM

Apr 4 2016

betulb committed rL265330: [PGO] Avoid instrumenting direct callee's at value sites..
[PGO] Avoid instrumenting direct callee's at value sites.
Apr 4 2016, 12:02 PM

Mar 31 2016

betulb committed rL265037: [PGO] Avoid instrumenting constants at value sites.
[PGO] Avoid instrumenting constants at value sites
Mar 31 2016, 11:47 AM

Mar 29 2016

betulb committed rL264795: [PGO] Test case fix for r264783 .
[PGO] Test case fix for r264783
Mar 29 2016, 3:23 PM
betulb committed rL264783: [PGO] Move the instrumentation point closer to the value site..
[PGO] Move the instrumentation point closer to the value site.
Mar 29 2016, 1:49 PM

Feb 9 2016

betulb added a comment to D16935: [PGO] Indirect-call profile annotation in IR level.

Looks fine to me except a naming nit.

Feb 9 2016, 2:34 PM

Jan 23 2016

betulb committed rL258652: [PGO] Windows buildbot failure fix. [NFC].
[PGO] Windows buildbot failure fix. [NFC]
Jan 23 2016, 5:00 PM
betulb committed rL258650: Clang changes for value profiling.
Clang changes for value profiling
Jan 23 2016, 2:54 PM

Jan 15 2016

betulb added inline comments to D16016: [PGO] IR level instrumentation of indirect call value profiling.
Jan 15 2016, 2:23 PM

Jan 12 2016

betulb added inline comments to D16015: [PGO] Create the profile data variable before the lowering.
Jan 12 2016, 11:38 AM

Dec 23 2015

betulb added a comment to D15258: [PGO] Remove data races on Data->Values field.

LGTM overall.

Dec 23 2015, 5:28 PM

Dec 17 2015

betulb added inline comments to D15258: [PGO] Remove data races on Data->Values field.
Dec 17 2015, 4:35 PM
betulb added inline comments to D15258: [PGO] Remove data races on Data->Values field.
Dec 17 2015, 3:40 PM

Dec 10 2015

betulb added inline comments to D15258: [PGO] Remove data races on Data->Values field.
Dec 10 2015, 2:25 PM

Dec 3 2015

betulb added a comment to D15057: [PGO] Enable common VP format in profile runtime .

My LGTM was for Diff 41674.

Dec 3 2015, 12:44 PM
betulb added a comment to D15057: [PGO] Enable common VP format in profile runtime .

LGTM.

Dec 3 2015, 12:28 PM

Dec 2 2015

betulb added inline comments to D15057: [PGO] Enable common VP format in profile runtime .
Dec 2 2015, 10:57 AM
betulb added a comment to D15057: [PGO] Enable common VP format in profile runtime .

betulb added a comment.

One side comment on the commit message: Using TotalValueDataSize would
only
cause a drop of the last N function(s)' value data if/when file writing is
to be triggered through means other than atexit() and calls to
__llvm_profile_instrument_target are allowed to execute concurrently w/
file
write. Neither is happening at this time.

================
Comment at: lib/profile/InstrProfiling.c:70
@@ +69,3 @@
+ uint32_t ValueKind, uint16_t
NumValueSites) {
+ *((uint16_t *)&Data->NumValueSites[ValueKind]) = NumValueSites;
+}


Is the casting really needed? What's passed in is a __llvm_profile_data
pointer, so
shouldn't Data->NumValueSites[ValueKind] be OK?

Dec 2 2015, 7:08 AM
betulb added a comment to D15057: [PGO] Enable common VP format in profile runtime .

One side comment on the commit message: Using TotalValueDataSize would only cause a drop of the last N function(s)' value data if/when file writing is to be triggered through means other than atexit() and calls to __llvm_profile_instrument_target are allowed to execute concurrently w/ file write. Neither is happening at this time.

Dec 2 2015, 12:21 AM

Dec 1 2015

betulb added a comment to D15056: [PGO] Unify VP data format between raw and indexed profile (part-1).

+1

Dec 1 2015, 8:10 PM

Nov 20 2015

betulb added a comment to D14841: [PGO] profile runtime naming cleanups.

LGTM

Nov 20 2015, 10:47 AM
betulb added inline comments to D14841: [PGO] profile runtime naming cleanups.
Nov 20 2015, 5:41 AM

Nov 18 2015

betulb committed rL253492: [PGO] Fix the build failures due to 253483 and 253489..
[PGO] Fix the build failures due to 253483 and 253489.
Nov 18 2015, 11:42 AM
betulb committed rL253489: [PGO] Removed an extra ')' in the LLVM_ALIGNAS(x) macro..
[PGO] Removed an extra ')' in the LLVM_ALIGNAS(x) macro.
Nov 18 2015, 11:14 AM
betulb committed rL253485: [PGO] Test update for revision 253484..
[PGO] Test update for revision 253484.
Nov 18 2015, 10:18 AM
betulb committed rL253484: [PGO] Value profiling support.
[PGO] Value profiling support
Nov 18 2015, 10:17 AM
betulb committed rL253483: [PGO] Runtime support for value profiling..
[PGO] Runtime support for value profiling.
Nov 18 2015, 10:15 AM

Nov 17 2015

betulb committed rL253404: [PGO] Removed unused code. [NFC].
[PGO] Removed unused code. [NFC]
Nov 17 2015, 4:16 PM

Nov 6 2015

betulb added a comment to D14401: [PGO] Make indexed value profile data more compact and add structural definitions for the data format.

+1

Nov 6 2015, 9:48 AM
betulb added a comment to D14401: [PGO] Make indexed value profile data more compact and add structural definitions for the data format.

It looks fine to me overall. I'll need to do the testing when I'm rebasing my pending CL's.

Nov 6 2015, 8:59 AM