Page MenuHomePhabricator

bdf (Bruno De Fraine)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 30 2020, 2:36 AM (28 w, 2 d)

Recent Activity

Oct 8 2020

bdf added a comment to D88363: [CodeGen] Improve likelihood attribute branch weights.

Can you explain the kind of issues you're having?

At the shallowest level, our -O1 produces different IR and fails the test, which is more or less our problem; however my understanding is that tests in the LLVM project / subprojects should aim to test as little amount of code as possible. Relying on all of -O1 makes it a brittle test -- changes to any optimisation pass enabled in -O1 could cause this test to fail spuriously.

Instead, I believe the test should be in two parts:

  • One checking clang produces the correct /unoptimised/ IR output
  • One or more checking that the consuming IR passes do-the-right-thing
Oct 8 2020, 6:26 AM · Restricted Project

Sep 30 2020

bdf accepted D88363: [CodeGen] Improve likelihood attribute branch weights.

Looks good. Good idea to add tests to verify that we match __builtin_except().

Sep 30 2020, 2:40 AM · Restricted Project