User Details
- User Since
- Dec 8 2022, 7:55 AM (26 w, 1 d)
Wed, May 31
May 9 2023
Apr 17 2023
Thank you, this looks good to me.
I understand now that the intent behind the issue is that one may need to link libm in order to use frem, which was not obvious to me from the initial change.
I suggested an edit that conveys this more directly. Let me know what you think.
Apr 13 2023
Sorry for the delay in replying to this. I don't think that such implementation details belong in the documentation of the operation.
Is there a particular problem that would have been avoided by adding in this information?
Mar 1 2023
Feb 28 2023
Jan 17 2023
Glad you like it! I'd love to eventually get this added to existing workflows, either as a pre- or a post-merge check, but no plan has been concretised so far.
I am hoping to get some feedback from users of it before I put together a RFC---so please let me know if it turns out to be useful to you!
Jan 12 2023
Thinking about this more, I think that you are right and the added complexity of not hardcoding the comment prefixes may not be worth it.
I decided to go with "decide we do care, and hardcode (any comment marker|start-of-line), dropping the optional-ness and language detection".
Remove comment prefix derivation and hardcode prefixes instead.
Thanks for the thorough review, Sam, I think this is much better!
Address review comments.
Jan 11 2023
Jan 5 2023
Jan 4 2023
Abandoned in favour of https://reviews.llvm.org/D140846.
Address comments requested by reviewers.
Jan 2 2023
The proposed fix is at https://reviews.llvm.org/D140846. Thanks again for pointing me there!
Fix vertical alignment.
Dec 29 2022
Thanks for pointing this out, I agree that this would be a better fix.
I will work on a fix there.
Dec 28 2022
The fix above corrects an edge case in which the result of the remainder operation is NaN when the second argument is inf.
This was detected in TensorFlow (https://github.com/tensorflow/tensorflow/issues/58369). (Sorry for the delay, I had to fix a problem with my bug repro :-))
Dec 27 2022
Fix clang format errors.