Page MenuHomePhabricator

bchetioui (Benjamin Chetioui)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 8 2022, 7:55 AM (26 w, 1 d)

Recent Activity

Wed, May 31

bchetioui committed rG981766a3d6cf: [mlir][bazel] Disable Transform/test-repro-dump.mlir test in bazel build. (authored by bchetioui).
[mlir][bazel] Disable Transform/test-repro-dump.mlir test in bazel build.
Wed, May 31, 4:51 AM · Restricted Project
bchetioui committed rG96816a124994: [mlir][bazel] Follow-up fix for ce954e1cda5c9b55325903d51285cd742152a0c3. (authored by bchetioui).
[mlir][bazel] Follow-up fix for ce954e1cda5c9b55325903d51285cd742152a0c3.
Wed, May 31, 1:20 AM · Restricted Project

May 9 2023

bchetioui committed rG7e9f0f1fa8ef: [bazel] Port BUILD rules for 92cc30aca78703174e89880aca85e5a5ff41cc98. (authored by bchetioui).
[bazel] Port BUILD rules for 92cc30aca78703174e89880aca85e5a5ff41cc98.
May 9 2023, 3:22 AM · Restricted Project

Apr 17 2023

bchetioui accepted D146900: [docs][LangRef] Added minor update inside the `frem`. Fix : #61653.

Thank you, this looks good to me.

Apr 17 2023, 8:00 AM · Restricted Project, Restricted Project
bchetioui added inline comments to D146900: [docs][LangRef] Added minor update inside the `frem`. Fix : #61653.
Apr 17 2023, 2:14 AM · Restricted Project, Restricted Project
bchetioui requested changes to D146900: [docs][LangRef] Added minor update inside the `frem`. Fix : #61653.

I understand now that the intent behind the issue is that one may need to link libm in order to use frem, which was not obvious to me from the initial change.
I suggested an edit that conveys this more directly. Let me know what you think.

Apr 17 2023, 2:13 AM · Restricted Project, Restricted Project

Apr 13 2023

bchetioui added a comment to D146900: [docs][LangRef] Added minor update inside the `frem`. Fix : #61653.

Sorry for the delay in replying to this. I don't think that such implementation details belong in the documentation of the operation.
Is there a particular problem that would have been avoided by adding in this information?

Apr 13 2023, 1:10 AM · Restricted Project, Restricted Project

Mar 1 2023

bchetioui committed rG55fd1a05b977: [mlir][NFC] Address filecheck_lint findings in Vector/CPU/test-broadcast.mlir. (authored by bchetioui).
[mlir][NFC] Address filecheck_lint findings in Vector/CPU/test-broadcast.mlir.
Mar 1 2023, 12:19 AM · Restricted Project, Restricted Project
bchetioui closed D144972: [mlir][NFC] Address filecheck_lint findings in Vector/CPU/test-broadcast.mlir..
Mar 1 2023, 12:18 AM · Restricted Project, Restricted Project

Feb 28 2023

bchetioui requested review of D144972: [mlir][NFC] Address filecheck_lint findings in Vector/CPU/test-broadcast.mlir..
Feb 28 2023, 8:09 AM · Restricted Project, Restricted Project
bchetioui requested review of D144971: [mlir][NFC] Address filecheck_lint findings in tosa-to-linalg-named.mlir..
Feb 28 2023, 7:59 AM · Restricted Project, Restricted Project

Jan 17 2023

bchetioui added a comment to rGf702c75995db: [utils][filecheck-lint] Add filecheck-lint, a linter for FileCheck directives..

Glad you like it! I'd love to eventually get this added to existing workflows, either as a pre- or a post-merge check, but no plan has been concretised so far.
I am hoping to get some feedback from users of it before I put together a RFC---so please let me know if it turns out to be useful to you!

Jan 17 2023, 6:36 AM · Restricted Project, Restricted Project

Jan 12 2023

bchetioui committed rGf702c75995db: [utils][filecheck-lint] Add filecheck-lint, a linter for FileCheck directives. (authored by bchetioui).
[utils][filecheck-lint] Add filecheck-lint, a linter for FileCheck directives.
Jan 12 2023, 5:20 AM · Restricted Project, Restricted Project
bchetioui closed D141508: [utils][filecheck-lint] Add filecheck-lint, a linter for FileCheck directives..
Jan 12 2023, 5:20 AM · Restricted Project, Restricted Project
bchetioui added inline comments to D141508: [utils][filecheck-lint] Add filecheck-lint, a linter for FileCheck directives..
Jan 12 2023, 5:17 AM · Restricted Project, Restricted Project
bchetioui added a comment to D141508: [utils][filecheck-lint] Add filecheck-lint, a linter for FileCheck directives..

Thinking about this more, I think that you are right and the added complexity of not hardcoding the comment prefixes may not be worth it.
I decided to go with "decide we do care, and hardcode (any comment marker|start-of-line), dropping the optional-ness and language detection".

Jan 12 2023, 5:04 AM · Restricted Project, Restricted Project
bchetioui updated the diff for D141508: [utils][filecheck-lint] Add filecheck-lint, a linter for FileCheck directives..

Remove comment prefix derivation and hardcode prefixes instead.

Jan 12 2023, 5:04 AM · Restricted Project, Restricted Project
bchetioui added a comment to D141508: [utils][filecheck-lint] Add filecheck-lint, a linter for FileCheck directives..

Thanks for the thorough review, Sam, I think this is much better!

Jan 12 2023, 2:47 AM · Restricted Project, Restricted Project
bchetioui updated the diff for D141508: [utils][filecheck-lint] Add filecheck-lint, a linter for FileCheck directives..

Address review comments.

Jan 12 2023, 2:46 AM · Restricted Project, Restricted Project

Jan 11 2023

bchetioui requested review of D141508: [utils][filecheck-lint] Add filecheck-lint, a linter for FileCheck directives..
Jan 11 2023, 8:08 AM · Restricted Project, Restricted Project

Jan 5 2023

bchetioui committed rG2679fc3f42a5: [NFC] Test commit. (authored by bchetioui).
[NFC] Test commit.
Jan 5 2023, 11:26 PM

Jan 4 2023

bchetioui abandoned D140684: [mlir][gpu] Lower arith::RemFOp to __nv_remainder on NVIDIA GPU..

Abandoned in favour of https://reviews.llvm.org/D140846.

Jan 4 2023, 1:14 AM · Restricted Project, Restricted Project
bchetioui added a comment to D140846: [NVPTX] Fix NVPTX lowering of frem when denominator is infinite..

Thanks for the review, @tra and @herhut!

Jan 4 2023, 1:00 AM · Restricted Project, Restricted Project
bchetioui updated the diff for D140846: [NVPTX] Fix NVPTX lowering of frem when denominator is infinite..

Address comments requested by reviewers.

Jan 4 2023, 12:57 AM · Restricted Project, Restricted Project

Jan 2 2023

bchetioui added a comment to D140684: [mlir][gpu] Lower arith::RemFOp to __nv_remainder on NVIDIA GPU..

The proposed fix is at https://reviews.llvm.org/D140846. Thanks again for pointing me there!

Jan 2 2023, 8:42 AM · Restricted Project, Restricted Project
bchetioui updated the diff for D140846: [NVPTX] Fix NVPTX lowering of frem when denominator is infinite..

Fix vertical alignment.

Jan 2 2023, 8:21 AM · Restricted Project, Restricted Project
bchetioui added a reviewer for D140846: [NVPTX] Fix NVPTX lowering of frem when denominator is infinite.: csigg.
Jan 2 2023, 8:17 AM · Restricted Project, Restricted Project
bchetioui added reviewers for D140846: [NVPTX] Fix NVPTX lowering of frem when denominator is infinite.: herhut, ThomasRaoux.
Jan 2 2023, 8:11 AM · Restricted Project, Restricted Project
bchetioui requested review of D140846: [NVPTX] Fix NVPTX lowering of frem when denominator is infinite..
Jan 2 2023, 8:09 AM · Restricted Project, Restricted Project

Dec 29 2022

bchetioui added a comment to D140684: [mlir][gpu] Lower arith::RemFOp to __nv_remainder on NVIDIA GPU..

Thanks for pointing this out, I agree that this would be a better fix.
I will work on a fix there.

Dec 29 2022, 5:57 AM · Restricted Project, Restricted Project

Dec 28 2022

bchetioui requested review of D140684: [mlir][gpu] Lower arith::RemFOp to __nv_remainder on NVIDIA GPU..

The fix above corrects an edge case in which the result of the remainder operation is NaN when the second argument is inf.
This was detected in TensorFlow (https://github.com/tensorflow/tensorflow/issues/58369). (Sorry for the delay, I had to fix a problem with my bug repro :-))

Dec 28 2022, 11:51 PM · Restricted Project, Restricted Project

Dec 27 2022

bchetioui updated the diff for D140684: [mlir][gpu] Lower arith::RemFOp to __nv_remainder on NVIDIA GPU..

Fix clang format errors.

Dec 27 2022, 12:55 AM · Restricted Project, Restricted Project
bchetioui requested review of D140684: [mlir][gpu] Lower arith::RemFOp to __nv_remainder on NVIDIA GPU..
Dec 27 2022, 12:03 AM · Restricted Project, Restricted Project

Dec 9 2022

bchetioui requested review of D139698: [mlir] Clean up typos in FileCheck directives in various tests..
Dec 9 2022, 1:48 AM · Restricted Project, Restricted Project