Page MenuHomePhabricator

bbli (Benson Li)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 11 2020, 3:22 PM (8 w, 2 d)

Recent Activity

Mon, Jul 20

bbli added a comment to D83425: [lldb] add printing of stdout compile errors to lldbsuite.

I presume you don't have commit access and need someone to commit this for you?

Mon, Jul 20, 9:16 PM · Restricted Project

Sun, Jul 19

bbli added a comment to D83425: [lldb] add printing of stdout compile errors to lldbsuite.

Setting this no longer makes sense, as it will always be empty. Please remove that. Maybe also rename stdout_content to indicate it also contains stderr. Just plain "output" might suffice?

Ok, deleted it and changed "stdout_content" to "combined_content".

Sun, Jul 19, 10:09 PM · Restricted Project
bbli updated the diff for D83425: [lldb] add printing of stdout compile errors to lldbsuite.

Changed getCompilerVersion and a function in TestDataFormatterSkipSummary to account for stderr being merged with stdout now

Sun, Jul 19, 10:09 PM · Restricted Project

Wed, Jul 15

bbli added a comment to D83425: [lldb] add printing of stdout compile errors to lldbsuite.

Ok, I have revised the patch with the code from the first pic. I also moved the decode back to the format_build_error since it was there to begin with(not sure how much of a difference it makes). Also while we finalize this patch, is there another fix I can get started on?

Wed, Jul 15, 4:46 PM · Restricted Project
bbli updated the diff for D83425: [lldb] add printing of stdout compile errors to lldbsuite.

Modified stderr output instead of concatenating the stderr and stdout output strings.

Wed, Jul 15, 1:20 PM · Restricted Project

Tue, Jul 14

bbli added a comment to D83425: [lldb] add printing of stdout compile errors to lldbsuite.

Yeah so in this pic,

, you can see in the code that both stdout and stderr point to PIPE, and what gets printed out is the concatenation of the two. However, in
, where stderr now points to stdout, and I just print the stdout output, the "clang-11: error" messages from stderr gets mixed up with the results from stdout,

Tue, Jul 14, 10:56 AM · Restricted Project

Mon, Jul 13

bbli added a comment to D83425: [lldb] add printing of stdout compile errors to lldbsuite.

Hi Pavel,

Mon, Jul 13, 5:02 PM · Restricted Project

Jul 8 2020

bbli added a comment to D81697: Add support for batch-testing to the LLDB testsuite..

Hi Pavel, so I submitted the new patch(which I added you as a reviewer of) but it looks like the remote build failed. I ran ninja check-lldb locally and it works fine. How would I go about debugging this? I tried clicking on the links to the failed build, but couldn't really interpret it.

Jul 8 2020, 6:21 PM · Restricted Project
bbli updated the diff for D83425: [lldb] add printing of stdout compile errors to lldbsuite.

Changed back to original function signature, as this method gets called once outside the class.

Jul 8 2020, 4:04 PM · Restricted Project
bbli planned changes to D83425: [lldb] add printing of stdout compile errors to lldbsuite.
Jul 8 2020, 4:01 PM · Restricted Project
Herald added a project to D83425: [lldb] add printing of stdout compile errors to lldbsuite: Restricted Project.
Jul 8 2020, 1:53 PM · Restricted Project

Jul 7 2020

bbli added a comment to D81697: Add support for batch-testing to the LLDB testsuite..

Hi, so I think I got the fix working. Attached is a screenshot of the new output, with title "Build Command Stdout Ouput". Should I submit a new pull request for this?

Jul 7 2020, 6:23 PM · Restricted Project

Jul 3 2020

bbli added a comment to D81697: Add support for batch-testing to the LLDB testsuite..

Ideally this error should include the actual command line

Jul 3 2020, 1:04 PM · Restricted Project

Jul 2 2020

bbli added a comment to D81697: Add support for batch-testing to the LLDB testsuite..

For example, the thing that's annoying me now is that whenever a test fails in the "make" phase (e.g. a compile error), we only get an error message with the return status, and the original make invocation.

Jul 2 2020, 3:41 PM · Restricted Project

Jul 1 2020

bbli added a comment to D81697: Add support for batch-testing to the LLDB testsuite..

Hi, bumping my post from two weeks ago. The main question I had was: would it be ok if I just brought over the Outcome object for the time being?

Jul 1 2020, 6:23 PM · Restricted Project

Jun 12 2020

bbli added a comment to D81697: Add support for batch-testing to the LLDB testsuite..
  • Ohh ok, guess I should have gotten the point about catching all exceptions recursively clarified before I began.
Jun 12 2020, 6:48 PM · Restricted Project

Jun 11 2020

bbli created D81697: Add support for batch-testing to the LLDB testsuite..
Jun 11 2020, 4:33 PM · Restricted Project