- User Since
- Jun 11 2020, 3:22 PM (8 w, 2 d)
Mon, Jul 20
I presume you don't have commit access and need someone to commit this for you?
Sun, Jul 19
Setting this no longer makes sense, as it will always be empty. Please remove that. Maybe also rename stdout_content to indicate it also contains stderr. Just plain "output" might suffice?
Ok, deleted it and changed "stdout_content" to "combined_content".
Changed getCompilerVersion and a function in TestDataFormatterSkipSummary to account for stderr being merged with stdout now
Wed, Jul 15
Ok, I have revised the patch with the code from the first pic. I also moved the decode back to the format_build_error since it was there to begin with(not sure how much of a difference it makes). Also while we finalize this patch, is there another fix I can get started on?
Modified stderr output instead of concatenating the stderr and stdout output strings.
Tue, Jul 14
Yeah so in this pic,, you can see in the code that both stdout and stderr point to PIPE, and what gets printed out is the concatenation of the two. However, in , where stderr now points to stdout, and I just print the stdout output, the "clang-11: error" messages from stderr gets mixed up with the results from stdout,
Mon, Jul 13
Jul 8 2020
Hi Pavel, so I submitted the new patch(which I added you as a reviewer of) but it looks like the remote build failed. I ran ninja check-lldb locally and it works fine. How would I go about debugging this? I tried clicking on the links to the failed build, but couldn't really interpret it.
Changed back to original function signature, as this method gets called once outside the class.
Jul 7 2020
Hi, so I think I got the fix working. Attached is a screenshot of the new output, with title "Build Command Stdout Ouput". Should I submit a new pull request for this?
Jul 3 2020
Ideally this error should include the actual command line
Jul 2 2020
For example, the thing that's annoying me now is that whenever a test fails in the "make" phase (e.g. a compile error), we only get an error message with the return status, and the original make invocation.
Jul 1 2020
Hi, bumping my post from two weeks ago. The main question I had was: would it be ok if I just brought over the Outcome object for the time being?
Jun 12 2020
- Ohh ok, guess I should have gotten the point about catching all exceptions recursively clarified before I began.