Page MenuHomePhabricator

bbassi (Bhopesh Bassi)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 26 2020, 1:40 PM (8 w, 6 d)

Recent Activity

Sat, May 9

bbassi added a comment to D33029: [clang-format] add option for dangling parenthesis.

@MyDeveloperDay Thanks. This would be my first revision and I have few questions before I start coding. Would you be able to answer those over email? They are mainly about the design of clang-format and some existing options.

Sat, May 9, 11:09 AM · Restricted Project, Restricted Project

Apr 12 2020

bbassi added a comment to D33029: [clang-format] add option for dangling parenthesis.

@MyDeveloperDay hey, I am currently working on this, and adding a new option called BreakBeforeClosingBracket. I have some questions to understand the existing code, they might not be directly linked to this change so I am not sure if this the best place to ask those questions. What do you think? e.g. I don't understand what FakeLParens is and have some questions about that.

Apr 12 2020, 2:57 PM · Restricted Project, Restricted Project

Mar 30 2020

bbassi added a comment to D33029: [clang-format] add option for dangling parenthesis.

@MyDeveloperDay Can you please share your thoughts on my comment above?

Mar 30 2020, 5:29 PM · Restricted Project, Restricted Project

Mar 27 2020

bbassi added a comment to D33029: [clang-format] add option for dangling parenthesis.

I don't think that's quite right. Then you will also have to have a AlignWithDanglingParenthesis for cases when people still want closing parenthesis on new line but want parameters as well as closing parenthesis to be aligned with opening parenthesis. I think we need a separate option, something like BreakBeforeClosingBracket.

Mar 27 2020, 1:10 PM · Restricted Project, Restricted Project
bbassi added a comment to D33029: [clang-format] add option for dangling parenthesis.

@stringham @MyDeveloperDay I have some questions.

Mar 27 2020, 10:55 AM · Restricted Project, Restricted Project

Mar 26 2020

bbassi added a comment to D33029: [clang-format] add option for dangling parenthesis.

@MyDeveloperDay Is someone working on fixing the breaking tests and merging it? I need this feature so if someone isn't working on it already, I can take it.

Mar 26 2020, 2:08 PM · Restricted Project, Restricted Project