Page MenuHomePhabricator

barcisz (Bartłomiej Cieślar)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 5 2022, 10:28 AM (12 w, 2 d)

Recent Activity

Sep 23 2022

barcisz added inline comments to D133801: Extraction of a matcher for an unused value from an expression from the bugprone-unused-return-value check.
Sep 23 2022, 8:33 PM · Restricted Project, Restricted Project

Sep 21 2022

barcisz updated the diff for D133942: Clang tidy utility to generate a fix hint for a subsequent expression to the existing one.

Tests for the utility

Sep 21 2022, 11:04 AM · Restricted Project, Restricted Project

Sep 20 2022

barcisz updated the diff for D133801: Extraction of a matcher for an unused value from an expression from the bugprone-unused-return-value check.

Tests for the check

Sep 20 2022, 2:50 PM · Restricted Project, Restricted Project
barcisz added a comment to D133801: Extraction of a matcher for an unused value from an expression from the bugprone-unused-return-value check.
Sep 20 2022, 1:20 PM · Restricted Project, Restricted Project
barcisz updated the diff for D133801: Extraction of a matcher for an unused value from an expression from the bugprone-unused-return-value check.

Removed unused matcher definitions from bugprone-unused-return-value

Sep 20 2022, 7:11 AM · Restricted Project, Restricted Project
barcisz updated the diff for D133436: Ground work for cuda-related checks in clang-tidy.

Inlined definition of size_t

Sep 20 2022, 7:09 AM · Restricted Project, Restricted Project

Sep 17 2022

barcisz added inline comments to D133436: Ground work for cuda-related checks in clang-tidy.
Sep 17 2022, 10:14 AM · Restricted Project, Restricted Project
barcisz added a comment to D133942: Clang tidy utility to generate a fix hint for a subsequent expression to the existing one.

How does this handle pathological cases like the statement being the iteration-expression of a for loop, or a init-statement in an if/switch/range-for loop. The documentation looks like it tries to explain that, but it doesn't do a great job IMHO.

Sep 17 2022, 10:13 AM · Restricted Project, Restricted Project
barcisz updated the summary of D133942: Clang tidy utility to generate a fix hint for a subsequent expression to the existing one.
Sep 17 2022, 10:11 AM · Restricted Project, Restricted Project
barcisz added a comment to D133942: Clang tidy utility to generate a fix hint for a subsequent expression to the existing one.

It would also be nice to add in some unittests to demonstrate that braces are currently inserted etc.

Sep 17 2022, 10:09 AM · Restricted Project, Restricted Project

Sep 16 2022

barcisz updated the diff for D133956: Cuda Check for ignored errors after calling a CUDA kernel.

documentation for the check

Sep 16 2022, 7:07 AM · Restricted Project, Restricted Project
barcisz added reviewers for D133436: Ground work for cuda-related checks in clang-tidy: alex, aaron.ballman.
Sep 16 2022, 6:48 AM · Restricted Project, Restricted Project
barcisz added reviewers for D133801: Extraction of a matcher for an unused value from an expression from the bugprone-unused-return-value check: alex, aaron.ballman, LegalizeAdulthood.
Sep 16 2022, 6:47 AM · Restricted Project, Restricted Project
barcisz added reviewers for D133804: Cuda Check for ignored return errors from api calls to cuda: alex, aaron.ballman, LegalizeAdulthood.
Sep 16 2022, 6:47 AM · Restricted Project, Restricted Project
barcisz added reviewers for D133942: Clang tidy utility to generate a fix hint for a subsequent expression to the existing one: alex, aaron.ballman, LegalizeAdulthood.
Sep 16 2022, 6:47 AM · Restricted Project, Restricted Project
barcisz added reviewers for D133956: Cuda Check for ignored errors after calling a CUDA kernel: alex, aaron.ballman, LegalizeAdulthood.
Sep 16 2022, 6:46 AM · Restricted Project, Restricted Project

Sep 15 2022

barcisz added inline comments to D133956: Cuda Check for ignored errors after calling a CUDA kernel.
Sep 15 2022, 4:51 PM · Restricted Project, Restricted Project
barcisz updated the diff for D133942: Clang tidy utility to generate a fix hint for a subsequent expression to the existing one.

Misplaced diff

Sep 15 2022, 4:35 PM · Restricted Project, Restricted Project
barcisz updated the diff for D133956: Cuda Check for ignored errors after calling a CUDA kernel.

Rebase

Sep 15 2022, 4:35 PM · Restricted Project, Restricted Project
barcisz added a comment to D133942: Clang tidy utility to generate a fix hint for a subsequent expression to the existing one.

Would I be correct in assuming you have uploaded the wrong diff here?

Sep 15 2022, 4:34 PM · Restricted Project, Restricted Project
barcisz updated the diff for D133942: Clang tidy utility to generate a fix hint for a subsequent expression to the existing one.

rebase

Sep 15 2022, 3:48 PM · Restricted Project, Restricted Project
barcisz updated the diff for D133436: Ground work for cuda-related checks in clang-tidy.

moved size_t definition to an stddef.h stub

Sep 15 2022, 3:43 PM · Restricted Project, Restricted Project
barcisz updated the diff for D133436: Ground work for cuda-related checks in clang-tidy.

Dummy definition for size_t

Sep 15 2022, 3:39 PM · Restricted Project, Restricted Project
barcisz added reviewers for D133956: Cuda Check for ignored errors after calling a CUDA kernel: tra, alexfh, alexfh_, pcc, yaxunl, rnk, ivanmurashko, r-barnes, 0x1eaf, kuganv, njames93.
Sep 15 2022, 3:13 PM · Restricted Project, Restricted Project
barcisz updated the summary of D133956: Cuda Check for ignored errors after calling a CUDA kernel.
Sep 15 2022, 3:04 PM · Restricted Project, Restricted Project
barcisz updated the summary of D133942: Clang tidy utility to generate a fix hint for a subsequent expression to the existing one.
Sep 15 2022, 3:03 PM · Restricted Project, Restricted Project
barcisz updated the summary of D133436: Ground work for cuda-related checks in clang-tidy.
Sep 15 2022, 3:02 PM · Restricted Project, Restricted Project
barcisz updated the summary of D133801: Extraction of a matcher for an unused value from an expression from the bugprone-unused-return-value check.
Sep 15 2022, 3:02 PM · Restricted Project, Restricted Project
barcisz added a comment to D133725: Searching for tokens including comments.

Can you help me understand the expected use for these change?

Sep 15 2022, 3:01 PM · Restricted Project, Restricted Project
barcisz retitled D133956: Cuda Check for ignored errors after calling a CUDA kernel from git push Cuda Check for ignored errors after calling a CUDA kernel to Cuda Check for ignored errors after calling a CUDA kernel.
Sep 15 2022, 3:01 PM · Restricted Project, Restricted Project
barcisz updated the summary of D133725: Searching for tokens including comments.
Sep 15 2022, 3:00 PM · Restricted Project, Restricted Project
barcisz added a comment to D133956: Cuda Check for ignored errors after calling a CUDA kernel.

I think ultimately the checker should be generalized to flag all unchecked CUDA runtime calls. The problem is that that is going to be exceedingly noisy in practice as a lot of real code does not bother to check for the errors consistently. Limiting the checks to kernel launches may be a reasonable starting point as it would give us the ability to zero in on the culprit kernel by running the app with "CUDA_LAUNCH_BLOCKING".

Sep 15 2022, 2:59 PM · Restricted Project, Restricted Project
barcisz updated the summary of D133725: Searching for tokens including comments.
Sep 15 2022, 1:15 PM · Restricted Project, Restricted Project
barcisz updated the summary of D133942: Clang tidy utility to generate a fix hint for a subsequent expression to the existing one.
Sep 15 2022, 1:14 PM · Restricted Project, Restricted Project
barcisz requested review of D133956: Cuda Check for ignored errors after calling a CUDA kernel.
Sep 15 2022, 10:44 AM · Restricted Project, Restricted Project
barcisz updated the diff for D133804: Cuda Check for ignored return errors from api calls to cuda.

Use header guards instead of pragma

Sep 15 2022, 7:50 AM · Restricted Project, Restricted Project
barcisz updated the diff for D133942: Clang tidy utility to generate a fix hint for a subsequent expression to the existing one.

Use the new Lexer option to include comments while finding next token

Sep 15 2022, 7:38 AM · Restricted Project, Restricted Project
barcisz requested review of D133942: Clang tidy utility to generate a fix hint for a subsequent expression to the existing one.
Sep 15 2022, 7:35 AM · Restricted Project, Restricted Project
barcisz updated the diff for D133804: Cuda Check for ignored return errors from api calls to cuda.

Rebase

Sep 15 2022, 5:30 AM · Restricted Project, Restricted Project
barcisz updated the diff for D133436: Ground work for cuda-related checks in clang-tidy.

Changes suggested by njames93

Sep 15 2022, 5:16 AM · Restricted Project, Restricted Project

Sep 14 2022

barcisz updated the diff for D133804: Cuda Check for ignored return errors from api calls to cuda.

Removed unneeded headers from the check

Sep 14 2022, 4:03 PM · Restricted Project, Restricted Project
barcisz updated the diff for D133804: Cuda Check for ignored return errors from api calls to cuda.

Removed unneeded headers from the check

Sep 14 2022, 4:00 PM · Restricted Project, Restricted Project
barcisz updated the diff for D133804: Cuda Check for ignored return errors from api calls to cuda.

Brought back different message prefix for when AcceptedHandlers is set

Sep 14 2022, 3:50 PM · Restricted Project, Restricted Project
barcisz updated the diff for D133804: Cuda Check for ignored return errors from api calls to cuda.

Documentation and small check-message-related bugfixes

Sep 14 2022, 12:35 PM · Restricted Project, Restricted Project
barcisz updated the diff for D133436: Ground work for cuda-related checks in clang-tidy.

Common documentation for cuda checks

Sep 14 2022, 6:59 AM · Restricted Project, Restricted Project
barcisz added a reviewer for D133436: Ground work for cuda-related checks in clang-tidy: njames93.
Sep 14 2022, 6:31 AM · Restricted Project, Restricted Project
barcisz added a reviewer for D133725: Searching for tokens including comments: aaron.ballman.
Sep 14 2022, 6:30 AM · Restricted Project, Restricted Project
barcisz added a reviewer for D133801: Extraction of a matcher for an unused value from an expression from the bugprone-unused-return-value check: njames93.
Sep 14 2022, 6:17 AM · Restricted Project, Restricted Project
barcisz added a reviewer for D133804: Cuda Check for ignored return errors from api calls to cuda: njames93.
Sep 14 2022, 6:17 AM · Restricted Project, Restricted Project
barcisz updated the diff for D133804: Cuda Check for ignored return errors from api calls to cuda.

Update base to D133801

Sep 14 2022, 5:54 AM · Restricted Project, Restricted Project
barcisz added inline comments to D133804: Cuda Check for ignored return errors from api calls to cuda.
Sep 14 2022, 5:50 AM · Restricted Project, Restricted Project
barcisz updated the diff for D133804: Cuda Check for ignored return errors from api calls to cuda.

Removed unnecessary cuda-related compilation flags from tests

Sep 14 2022, 4:15 AM · Restricted Project, Restricted Project
barcisz updated the diff for D133436: Ground work for cuda-related checks in clang-tidy.

Better explanation of cuda-related flags in tests

Sep 14 2022, 3:52 AM · Restricted Project, Restricted Project
barcisz updated the summary of D133804: Cuda Check for ignored return errors from api calls to cuda.
Sep 14 2022, 3:49 AM · Restricted Project, Restricted Project
barcisz updated the summary of D133804: Cuda Check for ignored return errors from api calls to cuda.
Sep 14 2022, 3:49 AM · Restricted Project, Restricted Project
barcisz updated the diff for D133804: Cuda Check for ignored return errors from api calls to cuda.

Rebase and better comments for cuda-related decisions in the check

Sep 14 2022, 3:38 AM · Restricted Project, Restricted Project
barcisz updated the diff for D133804: Cuda Check for ignored return errors from api calls to cuda.

More explanation comments for the check's code

Sep 14 2022, 3:17 AM · Restricted Project, Restricted Project

Sep 13 2022

barcisz added a comment to D133436: Ground work for cuda-related checks in clang-tidy.

@tschuett does it look alright now?

Sep 13 2022, 2:17 PM · Restricted Project, Restricted Project
barcisz updated the summary of D133436: Ground work for cuda-related checks in clang-tidy.
Sep 13 2022, 2:16 PM · Restricted Project, Restricted Project
barcisz updated the diff for D133804: Cuda Check for ignored return errors from api calls to cuda.

Added some explanation comments

Sep 13 2022, 2:08 PM · Restricted Project, Restricted Project
barcisz added reviewers for D133804: Cuda Check for ignored return errors from api calls to cuda: tra, alexfh, alexfh_, pcc, yaxunl, rnk, ivanmurashko, r-barnes, 0x1eaf, kuganv.
Sep 13 2022, 1:09 PM · Restricted Project, Restricted Project
barcisz updated the summary of D133804: Cuda Check for ignored return errors from api calls to cuda.
Sep 13 2022, 1:04 PM · Restricted Project, Restricted Project
barcisz requested review of D133804: Cuda Check for ignored return errors from api calls to cuda.
Sep 13 2022, 1:02 PM · Restricted Project, Restricted Project
barcisz added reviewers for D133801: Extraction of a matcher for an unused value from an expression from the bugprone-unused-return-value check: alexfh, alexfh_, ivanmurashko, 0x1eaf, kuganv, jbcoe, jranieri-grammatech, flx, AntonBikineev, etienneb, etienne.bergeron.
Sep 13 2022, 12:40 PM · Restricted Project, Restricted Project
barcisz requested review of D133801: Extraction of a matcher for an unused value from an expression from the bugprone-unused-return-value check.
Sep 13 2022, 12:36 PM · Restricted Project, Restricted Project

Sep 12 2022

barcisz added reviewers for D133725: Searching for tokens including comments: usaxena95, arphaman, zaks.anna, efriedma, ivanmurashko, DmitryPolukhin.
Sep 12 2022, 1:49 PM · Restricted Project, Restricted Project
barcisz requested review of D133725: Searching for tokens including comments.
Sep 12 2022, 1:45 PM · Restricted Project, Restricted Project

Sep 7 2022

barcisz added inline comments to D133436: Ground work for cuda-related checks in clang-tidy.
Sep 7 2022, 10:33 AM · Restricted Project, Restricted Project
barcisz updated the diff for D133436: Ground work for cuda-related checks in clang-tidy.

removed duplication of '.cu' in the lit config for clang-tidy tests

Sep 7 2022, 10:31 AM · Restricted Project, Restricted Project
barcisz updated the diff for D133436: Ground work for cuda-related checks in clang-tidy.

Fixed a copy-paste error with Google->Cuda in CudaTidyModule.cpp

Sep 7 2022, 10:29 AM · Restricted Project, Restricted Project
barcisz updated the summary of D133436: Ground work for cuda-related checks in clang-tidy.
Sep 7 2022, 10:22 AM · Restricted Project, Restricted Project
barcisz requested review of D133436: Ground work for cuda-related checks in clang-tidy.
Sep 7 2022, 10:14 AM · Restricted Project, Restricted Project