Page MenuHomePhabricator

aybassiouny (Ahmed Mahdy)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 19 2021, 4:25 PM (7 w, 6 d)

Recent Activity

Mon, Apr 19

aybassiouny updated the summary of D99031: [clang-format] Fix CompactNamespaces corner case when AllowShortLambdasOnASingleLine/BraceWrapping.BeforeLambdaBody are set.
Mon, Apr 19, 10:05 AM · Restricted Project, Restricted Project

Sun, Apr 18

aybassiouny updated the diff for D99031: [clang-format] Fix CompactNamespaces corner case when AllowShortLambdasOnASingleLine/BraceWrapping.BeforeLambdaBody are set.

After rechecking, turns out AllowShortLambdasOnASingleLine and BeforeLambdaBody both need to be turned on in order for the regression to be expressed, this affects the UT.

Sun, Apr 18, 5:46 PM · Restricted Project, Restricted Project

Mar 21 2021

aybassiouny added a comment to D99031: [clang-format] Fix CompactNamespaces corner case when AllowShortLambdasOnASingleLine/BraceWrapping.BeforeLambdaBody are set.

How about verifyFormat? Would that fail without your patch?

Mar 21 2021, 5:26 PM · Restricted Project, Restricted Project

Mar 20 2021

aybassiouny requested review of D99031: [clang-format] Fix CompactNamespaces corner case when AllowShortLambdasOnASingleLine/BraceWrapping.BeforeLambdaBody are set.
Mar 20 2021, 9:52 PM · Restricted Project, Restricted Project