Page MenuHomePhabricator

axzhang (Andy Zhang)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 28 2018, 5:25 PM (54 w, 2 d)

Recent Activity

Apr 30 2019

axzhang added a comment to D55044: [clang-tidy] check for Abseil make_unique.

Pinging for visibility.

Apr 30 2019, 4:11 PM · Restricted Project

Apr 18 2019

axzhang updated the diff for D55044: [clang-tidy] check for Abseil make_unique.

Simplify tests and fix issues with Options.

Apr 18 2019, 11:26 AM · Restricted Project
axzhang added inline comments to D55044: [clang-tidy] check for Abseil make_unique.
Apr 18 2019, 11:25 AM · Restricted Project

Apr 17 2019

axzhang added inline comments to D55044: [clang-tidy] check for Abseil make_unique.
Apr 17 2019, 8:32 PM · Restricted Project
axzhang added a comment to D55044: [clang-tidy] check for Abseil make_unique.

I'm having some issues with the AbseilTidyModule options. I am storing IgnoreListInit as true for the abseil-make-unique check, but when I run the check it shows IgnoreListInit as being false. Any ideas why this is happening?

Apr 17 2019, 8:05 PM · Restricted Project

Apr 11 2019

axzhang added a reviewer for D55044: [clang-tidy] check for Abseil make_unique: Eugene.Zelenko.
Apr 11 2019, 11:23 AM · Restricted Project

Apr 10 2019

axzhang added a comment to D55044: [clang-tidy] check for Abseil make_unique.

If no more changes need to be made, is this okay to be merged in?

Apr 10 2019, 4:22 PM · Restricted Project

Apr 9 2019

axzhang updated the diff for D55044: [clang-tidy] check for Abseil make_unique.
Apr 9 2019, 6:51 PM · Restricted Project

Apr 1 2019

axzhang added inline comments to D55044: [clang-tidy] check for Abseil make_unique.
Apr 1 2019, 7:45 PM · Restricted Project
axzhang added inline comments to D55044: [clang-tidy] check for Abseil make_unique.
Apr 1 2019, 7:37 PM · Restricted Project

Mar 26 2019

axzhang updated the diff for D55044: [clang-tidy] check for Abseil make_unique.

Add documentation about the added option for modernize-make-unique.

Mar 26 2019, 6:05 PM · Restricted Project

Mar 14 2019

axzhang updated the diff for D55044: [clang-tidy] check for Abseil make_unique.

Make fixes to the UseLegacyFunction option, renaming to IgnoreListInit.

Mar 14 2019, 8:09 PM · Restricted Project
axzhang updated the diff for D55044: [clang-tidy] check for Abseil make_unique.

Updated diff with full context.

Mar 14 2019, 11:03 AM · Restricted Project

Mar 13 2019

axzhang updated the diff for D55044: [clang-tidy] check for Abseil make_unique.

Apologies for the extended hiatus. I have changed the implementation to an alias to modernize-make-unique, and have added an extra option to modernize-make-unique that ignores C++11 features such as list initializations, to allow absl::make_unique to function correctly. Also, after looking more into absl::WrapUnique, it seems like this also is not really the function to use for brace initializations, so no extra functionality needs to be added to the existing modernize-make-unique check.

Mar 13 2019, 7:57 PM · Restricted Project

Dec 13 2018

axzhang added a comment to D55044: [clang-tidy] check for Abseil make_unique.

In fact, the existing modernize-make-unique can be configured to support absl::make_unique, you'd just need to configure the check option MakeSmartPtrFunction to absl::make_unique (this is what we do inside google).

The biggest missing part of the modernize-make-unique is absl::WrapUnique, I think we should extend MakeSmartPtrCheck class (maybe add hooks) to support it.

Dec 13 2018, 11:16 AM · Restricted Project

Dec 12 2018

axzhang updated the diff for D55044: [clang-tidy] check for Abseil make_unique.

Per the suggestions of reviewers, change the check so that it uses modernize-make-smart-pointer instead.

Dec 12 2018, 4:28 PM · Restricted Project

Nov 28 2018

axzhang created D55044: [clang-tidy] check for Abseil make_unique.
Nov 28 2018, 8:15 PM · Restricted Project