Pinging for visibility.

Simplify tests and fix issues with Options.

I'm having some issues with the AbseilTidyModule options. I am storing IgnoreListInit as true for the abseil-make-unique check, but when I run the check it shows IgnoreListInit as being false. Any ideas why this is happening?

If no more changes need to be made, is this okay to be merged in?

Add documentation about the added option for modernize-make-unique.

Make fixes to the UseLegacyFunction option, renaming to IgnoreListInit.

Updated diff with full context.

Apologies for the extended hiatus. I have changed the implementation to an alias to modernize-make-unique, and have added an extra option to modernize-make-unique that ignores C++11 features such as list initializations, to allow absl::make_unique to function correctly. Also, after looking more into absl::WrapUnique, it seems like this also is not really the function to use for brace initializations, so no extra functionality needs to be added to the existing modernize-make-unique check.

In D55044#1329604, @hokein wrote:

In fact, the existing modernize-make-unique can be configured to support absl::make_unique, you'd just need to configure the check option MakeSmartPtrFunction to absl::make_unique (this is what we do inside google).

The biggest missing part of the modernize-make-unique is absl::WrapUnique, I think we should extend MakeSmartPtrCheck class (maybe add hooks) to support it.

Per the suggestions of reviewers, change the check so that it uses modernize-make-smart-pointer instead.