Page MenuHomePhabricator

awpandey (Awanish Pandey)
User

Projects

User does not belong to any projects.

User Details

User Since
Mon, Nov 11, 10:34 PM (3 w, 2 d)

Recent Activity

Today

awpandey added a comment to D70524: Support DebugInfo generation for auto return type for C++ functions..

It looks to me like there are a few tests for unspecified_type already:

$ grep -r unspecified_type llvm/test
llvm/test/Assembler/debug-info.ll:; CHECK-NEXT: !7 = !DIBasicType(tag: DW_TAG_unspecified_type, name: "decltype(nullptr)")
llvm/test/Assembler/debug-info.ll:!8 = !DIBasicType(tag: DW_TAG_unspecified_type, name: "decltype(nullptr)")

...
@dblaikie, are you suggesting me to modify some of these existing test cases to include auto return functionality as well.

Thu, Dec 5, 2:57 AM · debug-info, Restricted Project, Restricted Project
awpandey updated the diff for D70524: Support DebugInfo generation for auto return type for C++ functions..
Thu, Dec 5, 2:11 AM · debug-info, Restricted Project, Restricted Project

Wed, Nov 27

awpandey updated the diff for D70524: Support DebugInfo generation for auto return type for C++ functions..

Hi @aprantl and @dblaikie. Currently, there is no test case for the unspecified type, so I have added that in the regression test suite. Also, I have incorporated all of your suggestions.

Wed, Nov 27, 3:34 AM · debug-info, Restricted Project, Restricted Project

Mon, Nov 25

awpandey updated the diff for D70111: [DWARF5]Addition of alignment field in the typedef for dwarf5.

Thanks @dblaikie. I have updated go and C bindings. I have also added the release note for why these APIs are changing.

Mon, Nov 25, 10:52 PM · Restricted Project, Restricted Project, debug-info

Fri, Nov 22

awpandey added a comment to D70524: Support DebugInfo generation for auto return type for C++ functions..

Thanks @aprantl for your suggestions. I have revised by patch based on that.

Fri, Nov 22, 12:59 AM · debug-info, Restricted Project, Restricted Project
awpandey updated the diff for D70524: Support DebugInfo generation for auto return type for C++ functions..

This revision includes

Fri, Nov 22, 12:52 AM · debug-info, Restricted Project, Restricted Project

Thu, Nov 21

awpandey added a comment to D70111: [DWARF5]Addition of alignment field in the typedef for dwarf5.

I am considering this

  • Will commit this without C bindings
  • will give separate patch for C bindings and release notes (if necessary).
  • will give another patch for Go bindings and release notes (if necessary).
Thu, Nov 21, 2:00 AM · Restricted Project, Restricted Project, debug-info

Wed, Nov 20

awpandey created D70524: Support DebugInfo generation for auto return type for C++ functions..
Wed, Nov 20, 9:35 PM · debug-info, Restricted Project, Restricted Project

Tue, Nov 19

awpandey added a comment to D70111: [DWARF5]Addition of alignment field in the typedef for dwarf5.

Hi @aprantl. Can we drop C binding for this feature ? What will be the impact of this.
As noted by @sammccall this does not conform / break LLVM-C ABI?

Tue, Nov 19, 4:04 AM · Restricted Project, Restricted Project, debug-info

Sat, Nov 16

awpandey added a comment to D70111: [DWARF5]Addition of alignment field in the typedef for dwarf5.

Hi @aprantl. I had made the changes and my team member will commit this.

Sat, Nov 16, 6:05 AM · Restricted Project, Restricted Project, debug-info

Fri, Nov 15

awpandey updated the diff for D70111: [DWARF5]Addition of alignment field in the typedef for dwarf5.

Thanks for your suggestion @aprantl. I have revised the data type based on your suggestion. Please inform me if any other changes are required.

Fri, Nov 15, 7:33 AM · Restricted Project, Restricted Project, debug-info

Tue, Nov 12

awpandey added inline comments to D70111: [DWARF5]Addition of alignment field in the typedef for dwarf5.
Tue, Nov 12, 11:11 PM · Restricted Project, Restricted Project, debug-info
awpandey updated the diff for D70111: [DWARF5]Addition of alignment field in the typedef for dwarf5.

@aprantl Thanks for the suggestion. Based on your suggestion I have done the following changes

Tue, Nov 12, 11:11 PM · Restricted Project, Restricted Project, debug-info
awpandey added a comment to D70111: [DWARF5]Addition of alignment field in the typedef for dwarf5.

Thank you @djtodoro for reviewing this.

Tue, Nov 12, 4:04 AM · Restricted Project, Restricted Project, debug-info
awpandey updated the diff for D70111: [DWARF5]Addition of alignment field in the typedef for dwarf5.

Revised and address comments of @djtodoro

Tue, Nov 12, 4:04 AM · Restricted Project, Restricted Project, debug-info

Mon, Nov 11

awpandey created D70111: [DWARF5]Addition of alignment field in the typedef for dwarf5.
Mon, Nov 11, 11:24 PM · Restricted Project, Restricted Project, debug-info