Page MenuHomePhabricator

awpandey (Awanish Pandey)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 11 2019, 10:34 PM (55 w, 2 d)

Recent Activity

Mar 1 2020

awpandey updated the diff for D73462: [dwarf-5] Support DebugInfo for Defaulted parameters for C++ templates.
Mar 1 2020, 8:50 PM · Restricted Project, Restricted Project

Feb 21 2020

awpandey updated the diff for D73462: [dwarf-5] Support DebugInfo for Defaulted parameters for C++ templates.
Feb 21 2020, 8:32 AM · Restricted Project, Restricted Project

Feb 18 2020

awpandey added a comment to D73462: [dwarf-5] Support DebugInfo for Defaulted parameters for C++ templates.

Hi @aprantl, I have included all of your suggestions. Can I merge this?

Feb 18 2020, 2:14 AM · Restricted Project, Restricted Project

Feb 13 2020

awpandey updated the diff for D73462: [dwarf-5] Support DebugInfo for Defaulted parameters for C++ templates.

Hi @aprantl, I have added a test that two DITemplateTypeParameter only differ in the isDefault parameter are not equal.

Feb 13 2020, 10:34 PM · Restricted Project, Restricted Project
awpandey added a comment to D73462: [dwarf-5] Support DebugInfo for Defaulted parameters for C++ templates.

Hi @aprantl , can you please inform me what extra changes should I make in this patch.

Feb 13 2020, 3:16 AM · Restricted Project, Restricted Project

Feb 10 2020

awpandey updated the diff for D73261: [dwarf5] Support DebugInfo for constexpr for C++ variables and functions.

@probinson I have reimplemented the feature by using DIFlags.

Feb 10 2020, 4:20 AM · Restricted Project, Restricted Project, debug-info

Feb 6 2020

awpandey added a comment to D73462: [dwarf-5] Support DebugInfo for Defaulted parameters for C++ templates.

Thanks @dblaikie for all of your suggestions. I will commit this in 3 patches after getting the green signal from @aprantl.

Feb 6 2020, 8:55 PM · Restricted Project, Restricted Project

Feb 4 2020

awpandey updated the diff for D73462: [dwarf-5] Support DebugInfo for Defaulted parameters for C++ templates.

@dblaikie, I have updated the test cases.

Feb 4 2020, 9:50 PM · Restricted Project, Restricted Project

Feb 3 2020

awpandey updated the diff for D73462: [dwarf-5] Support DebugInfo for Defaulted parameters for C++ templates.

Hi @dblaikie, I removed the condition and put false as the third argument of PrintBool. I have also removed the updated bitcode file.

Feb 3 2020, 8:30 PM · Restricted Project, Restricted Project
awpandey updated the diff for D73462: [dwarf-5] Support DebugInfo for Defaulted parameters for C++ templates.

Thanks, @aprantl, and @dblaikie. I have added two new test cases as per your suggestions. I have to update dityperefs-3.8.ll and dityperefs-3.8.ll.bc because they are no longer compatible with this patch.

Feb 3 2020, 1:23 AM · Restricted Project, Restricted Project

Jan 30 2020

awpandey added a comment to D73462: [dwarf-5] Support DebugInfo for Defaulted parameters for C++ templates.

@aprantl Thanks for your valuable feedback.

Jan 30 2020, 10:43 PM · Restricted Project, Restricted Project
awpandey added inline comments to D73462: [dwarf-5] Support DebugInfo for Defaulted parameters for C++ templates.
Jan 30 2020, 3:24 AM · Restricted Project, Restricted Project
awpandey updated the diff for D73462: [dwarf-5] Support DebugInfo for Defaulted parameters for C++ templates.

Hi @dblaikie, I have incorporated your suggestions (renaming variables, test case modification).

Jan 30 2020, 3:24 AM · Restricted Project, Restricted Project

Jan 29 2020

awpandey updated the diff for D73462: [dwarf-5] Support DebugInfo for Defaulted parameters for C++ templates.

Thanks @dblaikie for figuring out the missing feature. I have added support for the non-type template parameter too. Please let me know if further modifications are required. I will happily address them.

Jan 29 2020, 6:44 AM · Restricted Project, Restricted Project

Jan 27 2020

awpandey created D73462: [dwarf-5] Support DebugInfo for Defaulted parameters for C++ templates.
Jan 27 2020, 5:02 AM · Restricted Project, Restricted Project

Jan 24 2020

awpandey updated the diff for D73261: [dwarf5] Support DebugInfo for constexpr for C++ variables and functions.

Hi @probinson, I have changed the patch according to your comments.

Jan 24 2020, 1:59 AM · Restricted Project, Restricted Project, debug-info

Jan 23 2020

awpandey created D73261: [dwarf5] Support DebugInfo for constexpr for C++ variables and functions.
Jan 23 2020, 2:53 AM · Restricted Project, Restricted Project, debug-info

Jan 10 2020

awpandey updated the diff for D70524: Support DebugInfo generation for auto return type for C++ functions..

@dblaikie I have added an LLVM test case and I will commit it like a different patch.
I have also updated the clang test case.

Jan 10 2020, 1:24 AM · debug-info, Restricted Project, Restricted Project

Jan 3 2020

awpandey updated the diff for D70524: Support DebugInfo generation for auto return type for C++ functions..

@dblaikie Thanks a lot for the suggestions. I have made the changes such that this will become consistent with your suggestions.

Jan 3 2020, 12:44 AM · debug-info, Restricted Project, Restricted Project

Dec 11 2019

awpandey updated the diff for D70524: Support DebugInfo generation for auto return type for C++ functions..

@dblaikie . I have removed the redundant test case. What else should I do in this patch?

Dec 11 2019, 2:39 AM · debug-info, Restricted Project, Restricted Project

Dec 5 2019

awpandey added a comment to D70524: Support DebugInfo generation for auto return type for C++ functions..

It looks to me like there are a few tests for unspecified_type already:

$ grep -r unspecified_type llvm/test
llvm/test/Assembler/debug-info.ll:; CHECK-NEXT: !7 = !DIBasicType(tag: DW_TAG_unspecified_type, name: "decltype(nullptr)")
llvm/test/Assembler/debug-info.ll:!8 = !DIBasicType(tag: DW_TAG_unspecified_type, name: "decltype(nullptr)")

...
@dblaikie, are you suggesting me to modify some of these existing test cases to include auto return functionality as well.

Dec 5 2019, 2:57 AM · debug-info, Restricted Project, Restricted Project
awpandey updated the diff for D70524: Support DebugInfo generation for auto return type for C++ functions..
Dec 5 2019, 2:11 AM · debug-info, Restricted Project, Restricted Project

Nov 27 2019

awpandey updated the diff for D70524: Support DebugInfo generation for auto return type for C++ functions..

Hi @aprantl and @dblaikie. Currently, there is no test case for the unspecified type, so I have added that in the regression test suite. Also, I have incorporated all of your suggestions.

Nov 27 2019, 3:34 AM · debug-info, Restricted Project, Restricted Project

Nov 25 2019

awpandey updated the diff for D70111: [DWARF5]Addition of alignment field in the typedef for dwarf5.

Thanks @dblaikie. I have updated go and C bindings. I have also added the release note for why these APIs are changing.

Nov 25 2019, 10:52 PM · Restricted Project, Restricted Project, debug-info

Nov 22 2019

awpandey added a comment to D70524: Support DebugInfo generation for auto return type for C++ functions..

Thanks @aprantl for your suggestions. I have revised by patch based on that.

Nov 22 2019, 12:59 AM · debug-info, Restricted Project, Restricted Project
awpandey updated the diff for D70524: Support DebugInfo generation for auto return type for C++ functions..

This revision includes

Nov 22 2019, 12:52 AM · debug-info, Restricted Project, Restricted Project

Nov 21 2019

awpandey added a comment to D70111: [DWARF5]Addition of alignment field in the typedef for dwarf5.

I am considering this

  • Will commit this without C bindings
  • will give separate patch for C bindings and release notes (if necessary).
  • will give another patch for Go bindings and release notes (if necessary).
Nov 21 2019, 2:00 AM · Restricted Project, Restricted Project, debug-info

Nov 20 2019

awpandey created D70524: Support DebugInfo generation for auto return type for C++ functions..
Nov 20 2019, 9:35 PM · debug-info, Restricted Project, Restricted Project

Nov 19 2019

awpandey added a comment to D70111: [DWARF5]Addition of alignment field in the typedef for dwarf5.

Hi @aprantl. Can we drop C binding for this feature ? What will be the impact of this.
As noted by @sammccall this does not conform / break LLVM-C ABI?

Nov 19 2019, 4:04 AM · Restricted Project, Restricted Project, debug-info

Nov 16 2019

awpandey added a comment to D70111: [DWARF5]Addition of alignment field in the typedef for dwarf5.

Hi @aprantl. I had made the changes and my team member will commit this.

Nov 16 2019, 6:05 AM · Restricted Project, Restricted Project, debug-info

Nov 15 2019

awpandey updated the diff for D70111: [DWARF5]Addition of alignment field in the typedef for dwarf5.

Thanks for your suggestion @aprantl. I have revised the data type based on your suggestion. Please inform me if any other changes are required.

Nov 15 2019, 7:33 AM · Restricted Project, Restricted Project, debug-info

Nov 12 2019

awpandey added inline comments to D70111: [DWARF5]Addition of alignment field in the typedef for dwarf5.
Nov 12 2019, 11:11 PM · Restricted Project, Restricted Project, debug-info
awpandey updated the diff for D70111: [DWARF5]Addition of alignment field in the typedef for dwarf5.

@aprantl Thanks for the suggestion. Based on your suggestion I have done the following changes

Nov 12 2019, 11:11 PM · Restricted Project, Restricted Project, debug-info
awpandey added a comment to D70111: [DWARF5]Addition of alignment field in the typedef for dwarf5.

Thank you @djtodoro for reviewing this.

Nov 12 2019, 4:04 AM · Restricted Project, Restricted Project, debug-info
awpandey updated the diff for D70111: [DWARF5]Addition of alignment field in the typedef for dwarf5.

Revised and address comments of @djtodoro

Nov 12 2019, 4:04 AM · Restricted Project, Restricted Project, debug-info

Nov 11 2019

awpandey created D70111: [DWARF5]Addition of alignment field in the typedef for dwarf5.
Nov 11 2019, 11:24 PM · Restricted Project, Restricted Project, debug-info