- User Since
- Nov 11 2019, 10:34 PM (21 w, 2 d)
Mar 1 2020
Feb 21 2020
Feb 18 2020
Hi @aprantl, I have included all of your suggestions. Can I merge this?
Feb 13 2020
Hi @aprantl, I have added a test that two DITemplateTypeParameter only differ in the isDefault parameter are not equal.
Hi @aprantl , can you please inform me what extra changes should I make in this patch.
Feb 10 2020
@probinson I have reimplemented the feature by using DIFlags.
Feb 6 2020
Feb 4 2020
@dblaikie, I have updated the test cases.
Feb 3 2020
Hi @dblaikie, I removed the condition and put false as the third argument of PrintBool. I have also removed the updated bitcode file.
Thanks, @aprantl, and @dblaikie. I have added two new test cases as per your suggestions. I have to update dityperefs-3.8.ll and dityperefs-3.8.ll.bc because they are no longer compatible with this patch.
Jan 30 2020
@aprantl Thanks for your valuable feedback.
Hi @dblaikie, I have incorporated your suggestions (renaming variables, test case modification).
Jan 29 2020
Thanks @dblaikie for figuring out the missing feature. I have added support for the non-type template parameter too. Please let me know if further modifications are required. I will happily address them.
Jan 27 2020
Jan 24 2020
Hi @probinson, I have changed the patch according to your comments.
Jan 23 2020
Jan 10 2020
@dblaikie I have added an LLVM test case and I will commit it like a different patch.
I have also updated the clang test case.
Jan 3 2020
@dblaikie Thanks a lot for the suggestions. I have made the changes such that this will become consistent with your suggestions.
Dec 11 2019
@dblaikie . I have removed the redundant test case. What else should I do in this patch?
Dec 5 2019
It looks to me like there are a few tests for unspecified_type already:
$ grep -r unspecified_type llvm/test
llvm/test/Assembler/debug-info.ll:; CHECK-NEXT: !7 = !DIBasicType(tag: DW_TAG_unspecified_type, name: "decltype(nullptr)")
llvm/test/Assembler/debug-info.ll:!8 = !DIBasicType(tag: DW_TAG_unspecified_type, name: "decltype(nullptr)")
@dblaikie, are you suggesting me to modify some of these existing test cases to include auto return functionality as well.
Nov 27 2019
Nov 25 2019
Thanks @dblaikie. I have updated go and C bindings. I have also added the release note for why these APIs are changing.
Nov 22 2019
Thanks @aprantl for your suggestions. I have revised by patch based on that.
This revision includes
Nov 21 2019
I am considering this
- Will commit this without C bindings
- will give separate patch for C bindings and release notes (if necessary).
- will give another patch for Go bindings and release notes (if necessary).
Nov 20 2019
Nov 19 2019
Nov 16 2019
Hi @aprantl. I had made the changes and my team member will commit this.
Nov 15 2019
Thanks for your suggestion @aprantl. I have revised the data type based on your suggestion. Please inform me if any other changes are required.
Nov 12 2019
@aprantl Thanks for the suggestion. Based on your suggestion I have done the following changes
Thank you @djtodoro for reviewing this.
Revised and address comments of @djtodoro