Page MenuHomePhabricator

avarmapml (Abhishek Varma)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 23 2020, 2:48 AM (17 w, 4 d)

Recent Activity

Oct 3 2020

avarmapml added a comment to D88719: [mlir] Normalize the results of normalizable operations.

Hi @imaihal, thank you for this patch.
The function normalizeFuncOpMemRefs has become quite long and I believe it'd be better to split the logic into modular sub-functions.
AllocOps, function arguments, result types, and external functions are being addressed within and maybe we can have separate functions for each of them.
Not sure if this change should go into this patch, maybe @bondhugula can say better.

Oct 3 2020, 5:24 AM · Restricted Project

Sep 17 2020

avarmapml updated the diff for D87437: [MLIR] Support for return values in Affine.For yield.

Minor code refactor

Sep 17 2020, 1:54 AM · Restricted Project
avarmapml updated the diff for D87437: [MLIR] Support for return values in Affine.For yield.

Updated test case to match loop body/yield

Sep 17 2020, 12:28 AM · Restricted Project

Sep 16 2020

avarmapml added inline comments to D87746: [mlir] Fix of updating function signature in normalizing memrefs.
Sep 16 2020, 11:14 PM · Restricted Project, Restricted Project
avarmapml added a comment to D87746: [mlir] Fix of updating function signature in normalizing memrefs.

Thank you for raising this.
Solution looks good to me. Please add the test case though.

Sep 16 2020, 11:00 PM · Restricted Project, Restricted Project

Sep 15 2020

avarmapml updated the summary of D87437: [MLIR] Support for return values in Affine.For yield.
Sep 15 2020, 3:16 AM · Restricted Project
avarmapml updated the diff for D87437: [MLIR] Support for return values in Affine.For yield.

Handled review comments and updated test case

Sep 15 2020, 2:48 AM · Restricted Project

Sep 14 2020

avarmapml updated the diff for D87437: [MLIR] Support for return values in Affine.For yield.

Updated getter/setter functions for lower and upper bound

Sep 14 2020, 3:59 PM · Restricted Project
avarmapml updated the diff for D87437: [MLIR] Support for return values in Affine.For yield.

Added test case for build method and bug fix

Sep 14 2020, 10:23 AM · Restricted Project

Sep 10 2020

avarmapml updated the diff for D87437: [MLIR] Support for return values in Affine.For yield.

Bug fix for build function.

Sep 10 2020, 11:36 PM · Restricted Project
avarmapml updated the diff for D87437: [MLIR] Support for return values in Affine.For yield.

Tackled initial review comments.

Sep 10 2020, 11:34 PM · Restricted Project
avarmapml updated the summary of D87437: [MLIR] Support for return values in Affine.For yield.
Sep 10 2020, 12:28 AM · Restricted Project
avarmapml added a reviewer for D87437: [MLIR] Support for return values in Affine.For yield: bondhugula.
Sep 10 2020, 12:24 AM · Restricted Project
avarmapml requested review of D87437: [MLIR] Support for return values in Affine.For yield.
Sep 10 2020, 12:22 AM · Restricted Project

Aug 24 2020

avarmapml accepted D86236: MemRef Normalization for Dialects.

Looks good to me.

Aug 24 2020, 12:30 AM · Restricted Project

Aug 12 2020

avarmapml updated the diff for D85226: [MLIR] Support for ReturnOps in memref map layout normalization.

Added TODO section for DimOp.

Aug 12 2020, 4:41 AM · Restricted Project

Aug 11 2020

avarmapml updated the diff for D85226: [MLIR] Support for ReturnOps in memref map layout normalization.

Addressed review changes.

Aug 11 2020, 9:59 PM · Restricted Project

Aug 4 2020

avarmapml updated the diff for D85226: [MLIR] Support for ReturnOps in memref map layout normalization.

Minor review changes

Aug 4 2020, 8:41 PM · Restricted Project
avarmapml updated the summary of D85226: [MLIR] Support for ReturnOps in memref map layout normalization.
Aug 4 2020, 11:29 AM · Restricted Project
avarmapml added reviewers for D85226: [MLIR] Support for ReturnOps in memref map layout normalization: bondhugula, rriddle.
Aug 4 2020, 10:31 AM · Restricted Project
avarmapml requested review of D85226: [MLIR] Support for ReturnOps in memref map layout normalization.
Aug 4 2020, 10:30 AM · Restricted Project

Jul 30 2020

avarmapml updated the diff for D84490: [MLIR] Introduce inter-procedural memref layout normalization.

Clang-format error fixed

Jul 30 2020, 5:15 AM · Restricted Project
avarmapml updated the diff for D84490: [MLIR] Introduce inter-procedural memref layout normalization.

Rebased to latest master branch

Jul 30 2020, 4:52 AM · Restricted Project
avarmapml updated the diff for D84490: [MLIR] Introduce inter-procedural memref layout normalization.

Resolved merge conflicts and involved another test case

Jul 30 2020, 2:20 AM · Restricted Project

Jul 29 2020

avarmapml updated the diff for D84490: [MLIR] Introduce inter-procedural memref layout normalization.

Handled minor comments

Jul 29 2020, 7:55 AM · Restricted Project

Jul 28 2020

avarmapml updated the diff for D84490: [MLIR] Introduce inter-procedural memref layout normalization.

Minor formatting of code comment

Jul 28 2020, 11:42 AM · Restricted Project
avarmapml updated the summary of D84490: [MLIR] Introduce inter-procedural memref layout normalization.
Jul 28 2020, 10:43 AM · Restricted Project
avarmapml added a comment to D84490: [MLIR] Introduce inter-procedural memref layout normalization.

@AlexEichenberger : Such operation handling can be a part of subsequent revision.
Thank you.

Jul 28 2020, 10:30 AM · Restricted Project
avarmapml added inline comments to D84490: [MLIR] Introduce inter-procedural memref layout normalization.
Jul 28 2020, 10:25 AM · Restricted Project
avarmapml updated the diff for D84490: [MLIR] Introduce inter-procedural memref layout normalization.

Review changes and code formatting

Jul 28 2020, 10:24 AM · Restricted Project

Jul 27 2020

avarmapml updated the diff for D84490: [MLIR] Introduce inter-procedural memref layout normalization.

Iterating over function arguments

Jul 27 2020, 11:37 PM · Restricted Project
avarmapml updated the diff for D84490: [MLIR] Introduce inter-procedural memref layout normalization.

Reformatted test cases

Jul 27 2020, 9:45 PM · Restricted Project
avarmapml added inline comments to D84490: [MLIR] Introduce inter-procedural memref layout normalization.
Jul 27 2020, 1:07 PM · Restricted Project
avarmapml updated the diff for D84490: [MLIR] Introduce inter-procedural memref layout normalization.

Memref map layout normalization for function argument and AllocOps

Jul 27 2020, 1:00 PM · Restricted Project

Jul 26 2020

avarmapml updated the diff for D84490: [MLIR] Introduce inter-procedural memref layout normalization.

Using setOperand to change memref operand of an operation.

Jul 26 2020, 9:09 PM · Restricted Project
avarmapml updated the diff for D84490: [MLIR] Introduce inter-procedural memref layout normalization.

Review changes :-

Jul 26 2020, 8:59 PM · Restricted Project

Jul 24 2020

avarmapml updated the diff for D84490: [MLIR] Introduce inter-procedural memref layout normalization.

Code refactoring:

Jul 24 2020, 10:08 AM · Restricted Project
avarmapml updated the diff for D84490: [MLIR] Introduce inter-procedural memref layout normalization.

Reformatted the code using clang-format

Jul 24 2020, 1:01 AM · Restricted Project
avarmapml retitled D84490: [MLIR] Introduce inter-procedural memref layout normalization from [MLIR] Interprocedural memref map layout normalization to [MLIR] Introduce inter-procedural memref layout normalization.
Jul 24 2020, 12:05 AM · Restricted Project

Jul 23 2020

avarmapml updated the summary of D84490: [MLIR] Introduce inter-procedural memref layout normalization.
Jul 23 2020, 11:59 PM · Restricted Project
avarmapml added a reviewer for D84490: [MLIR] Introduce inter-procedural memref layout normalization: bondhugula.
Jul 23 2020, 11:57 PM · Restricted Project
Herald added a project to D84490: [MLIR] Introduce inter-procedural memref layout normalization: Restricted Project.
Jul 23 2020, 11:55 PM · Restricted Project