- User Since
- Jul 23 2020, 2:48 AM (46 w, 5 d)
Mar 1 2021
A few minor comments.
Oct 3 2020
Hi @imaihal, thank you for this patch.
The function normalizeFuncOpMemRefs has become quite long and I believe it'd be better to split the logic into modular sub-functions.
AllocOps, function arguments, result types, and external functions are being addressed within and maybe we can have separate functions for each of them.
Not sure if this change should go into this patch, maybe @bondhugula can say better.
Sep 17 2020
Minor code refactor
Updated test case to match loop body/yield
Sep 16 2020
Thank you for raising this.
Solution looks good to me. Please add the test case though.
Sep 15 2020
Handled review comments and updated test case
Sep 14 2020
Updated getter/setter functions for lower and upper bound
Added test case for build method and bug fix
Sep 10 2020
Bug fix for build function.
Tackled initial review comments.
Aug 24 2020
Looks good to me.
Aug 12 2020
Added TODO section for DimOp.
Aug 11 2020
Addressed review changes.
Aug 4 2020
Minor review changes
Jul 30 2020
Clang-format error fixed
Rebased to latest master branch
Resolved merge conflicts and involved another test case
Jul 29 2020
Handled minor comments
Jul 28 2020
Minor formatting of code comment
@AlexEichenberger : Such operation handling can be a part of subsequent revision.
Review changes and code formatting
Jul 27 2020
Iterating over function arguments
Reformatted test cases
Memref map layout normalization for function argument and AllocOps
Jul 26 2020
Using setOperand to change memref operand of an operation.
Review changes :-
Jul 24 2020
Reformatted the code using clang-format