Page MenuHomePhabricator

aslepko (Alexander Slepko)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 21 2021, 1:51 PM (12 w, 4 d)

Recent Activity

Thu, Sep 9

aslepko committed rG89837a0e1b53: Adding min(f/s/u) and max(f/s/u) cases for vector reduction (authored by aslepko).
Adding min(f/s/u) and max(f/s/u) cases for vector reduction
Thu, Sep 9, 12:25 PM
aslepko closed D104881: Adding min(f/s/u) and max(f/s/u) cases for vector reduction.
Thu, Sep 9, 12:25 PM · Restricted Project

Tue, Sep 7

aslepko updated the diff for D104881: Adding min(f/s/u) and max(f/s/u) cases for vector reduction.

As discussed, this update removes the min/max recognition and testing part from the prior update (which will be added through a separate, new PR).

Tue, Sep 7, 10:55 AM · Restricted Project
aslepko added a comment to D104881: Adding min(f/s/u) and max(f/s/u) cases for vector reduction.

@aartbik, that sounds reasonable. Should I then basically go ahead and remove the tests+recognizer for a new/third patch and upload that patch. Then, make a new PR once this is merged for the recognition part? Thanks.

Tue, Sep 7, 10:25 AM · Restricted Project

Mon, Aug 30

aslepko updated the diff for D104881: Adding min(f/s/u) and max(f/s/u) cases for vector reduction.

This update adds code to recognize min/max reductions. This was necessary to test part some of the functionality we had added initially.
Also, this update contains all the tests missing in the original commit.

Mon, Aug 30, 6:32 PM · Restricted Project

Sat, Aug 28

aslepko added a comment to D104881: Adding min(f/s/u) and max(f/s/u) cases for vector reduction.

Hi @aartbik, my apologies this got dragged out. I was out for a while.
After internal discussion we decided to also add the code to recognize min/max reductions. With that we can add all test cases to cover the initial additions in this current commit.
Since it has been a while, should I do an entirely new commit, or just upload a second patch here?
Thanks.

Sat, Aug 28, 11:14 PM · Restricted Project

Jun 29 2021

aslepko added a comment to D104881: Adding min(f/s/u) and max(f/s/u) cases for vector reduction.

Hi @aartbik, thank you for your reply. And agree, it would be nice to add testing. I was not sure how to do that for min/max reductions without proper changes in the reduction recognizer (which we do in our local project). But I'd really appreciate any suggestions for what I can do here.
Thanks!

Jun 29 2021, 7:23 AM · Restricted Project

Jun 24 2021

aslepko requested review of D104881: Adding min(f/s/u) and max(f/s/u) cases for vector reduction.
Jun 24 2021, 3:50 PM · Restricted Project