- User Since
- Jun 21 2021, 1:51 PM (12 w, 4 d)
Thu, Sep 9
Tue, Sep 7
As discussed, this update removes the min/max recognition and testing part from the prior update (which will be added through a separate, new PR).
@aartbik, that sounds reasonable. Should I then basically go ahead and remove the tests+recognizer for a new/third patch and upload that patch. Then, make a new PR once this is merged for the recognition part? Thanks.
Mon, Aug 30
This update adds code to recognize min/max reductions. This was necessary to test part some of the functionality we had added initially.
Also, this update contains all the tests missing in the original commit.
Sat, Aug 28
Hi @aartbik, my apologies this got dragged out. I was out for a while.
After internal discussion we decided to also add the code to recognize min/max reductions. With that we can add all test cases to cover the initial additions in this current commit.
Since it has been a while, should I do an entirely new commit, or just upload a second patch here?
Jun 29 2021
Hi @aartbik, thank you for your reply. And agree, it would be nice to add testing. I was not sure how to do that for min/max reductions without proper changes in the reduction recognizer (which we do in our local project). But I'd really appreciate any suggestions for what I can do here.