- User Since
- Oct 26 2016, 1:12 AM (233 w, 6 d)
Mar 2 2020
Feb 17 2020
Hi @xbolva00, @fhahn! Gentle ping, can we land the change with the fix added?
For some reasons the revision is marked in Phabricator as accepted even after the modification, I would like to have explicit confirmation that I can commit it.
Feb 3 2020
Jan 24 2020
Could you please take a look on slightly updated changes? The previous version didn't preserve LoopInfo in case of new loops are created during a peeling, that causes a fail on EXPENSIVE_CHECKS builds. It's fixed now by recursively creating corresponding Loop objects by cloneLoop() utility function (moved from LoopUnswitch.cpp to LoopUtils.cpp to reuse).
Jan 16 2020
@RKSimon thanks, reverted. The added test is failed with LLVM_ENABLE_EXPENSIVE_CHECKS on. Will re-commit after the fix.
I'm trying to figure that out, the change is supposed to be off by default except the added test case and shouldn't affect anyone functionally.
What's LLVM policy in such cases - revert?
Jan 15 2020
Dec 19 2019
@fhahn Gentle reminder
Dec 9 2019
Hi @fhahn, do you have any more comments? Is it OK for trunk?
Nov 25 2019
@fhahn thanks for your comments, addressed!
Nov 15 2019
Feb 7 2018
Nov 22 2016
Nov 15 2016
Hi Eric! Could you please update a status of your mentioned fix?
Oct 26 2016
I will manage D18898 patch on behalf of Andrey.
Are you still working on the fix you mentioned above?