People ashlykov

ashlykov (Arkady Shlykov)
User

Projects

User does not belong to any projects.

User Details

User Since: Oct 26 2016, 1:12 AM (233 w, 6 d)

Recent Activity
View All

Mar 2 2020

ashlykov committed rG3dcaf296aeb0: [Loop Peeling] Add possibility to enable peeling on loop nests. (authored by ashlykov).

[Loop Peeling] Add possibility to enable peeling on loop nests.

Mar 2 2020, 8:42 AM

ashlykov closed D70304: [Loop Peeling] Add possibility to enable peeling on loop nests..

Mar 2 2020, 8:42 AM · Restricted Project

Feb 17 2020

ashlykov added a comment to D70304: [Loop Peeling] Add possibility to enable peeling on loop nests..

Hi @xbolva00, @fhahn! Gentle ping, can we land the change with the fix added?
For some reasons the revision is marked in Phabricator as accepted even after the modification, I would like to have explicit confirmation that I can commit it.

Feb 17 2020, 4:18 AM · Restricted Project

Feb 3 2020

ashlykov reopened D70304: [Loop Peeling] Add possibility to enable peeling on loop nests..

@fhahn, @xbolva00 Gentle reminder, the only change from the previously accepted revision is a fix of EXPENSIVE_CHECKS build failure (missing LoopInfo), change is off by default, can we land it?

Feb 3 2020, 4:24 AM · Restricted Project

Jan 24 2020

ashlykov updated the diff for D70304: [Loop Peeling] Add possibility to enable peeling on loop nests..

Could you please take a look on slightly updated changes? The previous version didn't preserve LoopInfo in case of new loops are created during a peeling, that causes a fail on EXPENSIVE_CHECKS builds. It's fixed now by recursively creating corresponding Loop objects by cloneLoop() utility function (moved from LoopUnswitch.cpp to LoopUtils.cpp to reuse).

Jan 24 2020, 7:37 AM · Restricted Project

Jan 16 2020

ashlykov added a comment to D70304: [Loop Peeling] Add possibility to enable peeling on loop nests..

@RKSimon thanks, reverted. The added test is failed with LLVM_ENABLE_EXPENSIVE_CHECKS on. Will re-commit after the fix.

Jan 16 2020, 10:51 AM · Restricted Project

ashlykov committed rGc87982b46701: Revert "[Loop Peeling] Add possibility to enable peeling on loop nests." (authored by ashlykov).

Revert "[Loop Peeling] Add possibility to enable peeling on loop nests."

Jan 16 2020, 10:42 AM

ashlykov added a reverting change for rG3f3017e162ec: [Loop Peeling] Add possibility to enable peeling on loop nests.: rGc87982b46701: Revert "[Loop Peeling] Add possibility to enable peeling on loop nests.".

Jan 16 2020, 10:42 AM

ashlykov added a comment to D70304: [Loop Peeling] Add possibility to enable peeling on loop nests..

I'm trying to figure that out, the change is supposed to be off by default except the added test case and shouldn't affect anyone functionally.
What's LLVM policy in such cases - revert?

Jan 16 2020, 8:28 AM · Restricted Project

Jan 15 2020

ashlykov committed rG3f3017e162ec: [Loop Peeling] Add possibility to enable peeling on loop nests. (authored by ashlykov).

[Loop Peeling] Add possibility to enable peeling on loop nests.

Jan 15 2020, 8:31 AM

ashlykov closed D70304: [Loop Peeling] Add possibility to enable peeling on loop nests..

Jan 15 2020, 8:31 AM · Restricted Project

ashlykov committed rG019c8d9d1511: [NFC] Adjust test cases numbering, test commit. (authored by ashlykov).

[NFC] Adjust test cases numbering, test commit.

Jan 15 2020, 3:52 AM

Dec 19 2019

ashlykov added a comment to D70304: [Loop Peeling] Add possibility to enable peeling on loop nests..

@fhahn Gentle reminder

Dec 19 2019, 3:16 AM · Restricted Project

Dec 9 2019

ashlykov added a comment to D70304: [Loop Peeling] Add possibility to enable peeling on loop nests..

Hi @fhahn, do you have any more comments? Is it OK for trunk?

Dec 9 2019, 3:34 AM · Restricted Project

Nov 25 2019

ashlykov added inline comments to D70304: [Loop Peeling] Add possibility to enable peeling on loop nests..

Nov 25 2019, 8:42 AM · Restricted Project

ashlykov updated the diff for D70304: [Loop Peeling] Add possibility to enable peeling on loop nests..

@fhahn thanks for your comments, addressed!

Nov 25 2019, 8:01 AM · Restricted Project

Nov 15 2019

ashlykov created D70304: [Loop Peeling] Add possibility to enable peeling on loop nests..

Nov 15 2019, 4:56 AM · Restricted Project

Feb 7 2018

ashlykov created D43007: Add missed PostDominatorTree analysis dependency to GVN hoist pass..

Feb 7 2018, 2:15 AM

Nov 22 2016

ashlykov added a comment to D18898: [Loop Rotation] Make default max rotation header size threshold dependent on target CPU.

@echristo Ping.

Nov 22 2016, 11:07 PM

Nov 15 2016

ashlykov added a comment to D18898: [Loop Rotation] Make default max rotation header size threshold dependent on target CPU.

Hi Eric! Could you please update a status of your mentioned fix?

Nov 15 2016, 2:23 AM

Oct 26 2016

ashlykov added a comment to D18898: [Loop Rotation] Make default max rotation header size threshold dependent on target CPU.

Hi Eric,
I will manage D18898 patch on behalf of Andrey.
Are you still working on the fix you mentioned above?

Oct 26 2016, 1:44 AM