Page MenuHomePhabricator

artemrad (Artem Radzikhovskyy)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 3 2021, 10:56 AM (14 w, 6 d)

Recent Activity

Mon, May 3

artemrad updated the diff for D101486: [Dependence Analysis] Enable delinearization of fixed sized arrays.

@fhahn You are right, removing FailingRangeCheck is much cleaner. I have updated the code as per your comment.

Mon, May 3, 7:24 AM · Restricted Project
artemrad added a comment to D101486: [Dependence Analysis] Enable delinearization of fixed sized arrays.

@bmahjour @fhahn Please let me know if there are further comments, otherwise please accept. I believe to have addressed all comments.

Mon, May 3, 6:56 AM · Restricted Project

Fri, Apr 30

artemrad added inline comments to D101486: [Dependence Analysis] Enable delinearization of fixed sized arrays.
Fri, Apr 30, 11:49 AM · Restricted Project
artemrad added a comment to D101486: [Dependence Analysis] Enable delinearization of fixed sized arrays.

@fhahn There already exists negative tests for delinearization in the LIT tests (see most tests in loop-interchange-optimization-remarks.ll). I still agree with you though, negative tests should still be present in the DependenceAnalysis folder directly, not somewhere else by fluke. In the most recent update to the diff I added explicit negative tests, see SimpleSIVNoValidityCheckFixedSize.ll and PreliminaryNoValidityCheckFixedSize.ll

Fri, Apr 30, 11:43 AM · Restricted Project
artemrad updated the diff for D101486: [Dependence Analysis] Enable delinearization of fixed sized arrays.
  • SimpleSIVNoValidityCheckFixedSize.ll - removed unnecessary "-da-disable-delinearization-checks" flag. Now can get the exact answer without it.
  • SimpleSIVNoValidityCheckFixedSize.ll and PreliminaryNoValidityCheckFixedSize.ll - made negative tests more explicit, in order to demonstrate the need for "-da-disable-delinearization-checks" flag
Fri, Apr 30, 11:38 AM · Restricted Project
artemrad added a comment to D101486: [Dependence Analysis] Enable delinearization of fixed sized arrays.

Addressed all comments

Fri, Apr 30, 8:53 AM · Restricted Project
artemrad updated the diff for D101486: [Dependence Analysis] Enable delinearization of fixed sized arrays.

Fixed style issues
Moved repeated code into a lamba
Fixed Invariant.ll comment

Fri, Apr 30, 8:49 AM · Restricted Project

Wed, Apr 28

artemrad requested review of D101486: [Dependence Analysis] Enable delinearization of fixed sized arrays.
Wed, Apr 28, 2:04 PM · Restricted Project

Mon, Apr 26

artemrad added a comment to D100331: [Dependence Analysis] Fix ExactSIV producing wrong analysis.

Sorry @Meinersbur, I responded to the comments but forgot to submit them. I am a new to Phabricator. Here they are now.

Mon, Apr 26, 6:31 AM · Restricted Project

Fri, Apr 23

artemrad updated the diff for D100331: [Dependence Analysis] Fix ExactSIV producing wrong analysis.

Fixed the style comments, and updated the academic reference for the algorithm to more closely match the implementation.

Fri, Apr 23, 11:21 AM · Restricted Project

Tue, Apr 20

artemrad added a comment to D100331: [Dependence Analysis] Fix ExactSIV producing wrong analysis.

This change reverses almost all directions in the test cases. Was the implementation that terribly wrong?

Not having studies the used algorithms myself, I assumed the DA result to be correct and when using it as analysis assumed that flow [<] and anti [>] are anti-dependences (WAR).

Tue, Apr 20, 6:42 AM · Restricted Project

Apr 13 2021

artemrad updated the diff for D100331: [Dependence Analysis] Fix ExactSIV producing wrong analysis.

Fixed clang-format issues

Apr 13 2021, 11:15 AM · Restricted Project

Apr 12 2021

artemrad requested review of D100331: [Dependence Analysis] Fix ExactSIV producing wrong analysis.
Apr 12 2021, 11:02 AM · Restricted Project