- User Since
- Feb 3 2021, 10:56 AM (14 w, 6 d)
Mon, May 3
@fhahn You are right, removing FailingRangeCheck is much cleaner. I have updated the code as per your comment.
Fri, Apr 30
@fhahn There already exists negative tests for delinearization in the LIT tests (see most tests in loop-interchange-optimization-remarks.ll). I still agree with you though, negative tests should still be present in the DependenceAnalysis folder directly, not somewhere else by fluke. In the most recent update to the diff I added explicit negative tests, see SimpleSIVNoValidityCheckFixedSize.ll and PreliminaryNoValidityCheckFixedSize.ll
- SimpleSIVNoValidityCheckFixedSize.ll - removed unnecessary "-da-disable-delinearization-checks" flag. Now can get the exact answer without it.
- SimpleSIVNoValidityCheckFixedSize.ll and PreliminaryNoValidityCheckFixedSize.ll - made negative tests more explicit, in order to demonstrate the need for "-da-disable-delinearization-checks" flag
Addressed all comments
Fixed style issues
Moved repeated code into a lamba
Fixed Invariant.ll comment
Wed, Apr 28
Mon, Apr 26
Sorry @Meinersbur, I responded to the comments but forgot to submit them. I am a new to Phabricator. Here they are now.
Fri, Apr 23
Fixed the style comments, and updated the academic reference for the algorithm to more closely match the implementation.
Tue, Apr 20
Apr 13 2021
Fixed clang-format issues