- User Since
- Feb 15 2018, 3:23 AM (61 w, 6 d)
This revision uses more appropriate gtest matchers.
Sun, Apr 21
FWIW I noticed that the author of the git-commit hook suggested using an emacs-lisp clang-format wrapper, and decided to try that first, until I grow unhappy.
Mon, Apr 15
Attended to the rest of Lebedev.ri's comments, plus clang-format
I didn't mean to suggest that I'd done all of them, I just ran out of working time on Friday. I attended to the rest now and will push a new revision as soon as the tests have run.
I pushed an update now. Will this comment submit the unsubmitted drafts?
Reworked based on good comments from maskray; thanks.
Fri, Apr 12
@dnsampaio Sorry about that. I looked at my shell history now, and I think I added you because I got a wildcard wrong and picked the most recent two committers for the wrong set of files.
more LLVM-y style, and better style too. Modern.
The old test did break, yes, that's why I changed it at all. The six branch instructions I moved down were all followed by phi nodes.
This patch's reviewer selection algorithm: Those who have changed two or more files in the same directory recently. I hope you don't mind.
I added lebedev.ri and the last two people to touch the file as reviewers, I hope that's not too much of an imposition.
updated following comments from lebedev.ri; thanks
I picked reviewers by taking the last two people who changed the file, hope you don't mind.
LebedevRI pointed out that the assert ought to have a message; thanks.
FWIW, I picked reviewers by taking the last two people who changed the file. I hope reviewing this isn't too much of an inconvenience ;)
Feb 15 2018
Looks like a clear improvement, but one minor point: "Callable" sounds like it's a template/base for Function and perhaps things that implement intrinsics, not like a base for instructions that call. CallerBase perhaps?