Page MenuHomePhabricator

arnt (Arnt Gulbrandsen)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 15 2018, 3:23 AM (83 w, 8 h)

Recent Activity

Jul 24 2019

arnt added a comment to D60616: Make parseBitcodeFile use a named StructType, if it exists and matches..

I have to type this in order to publish the comments above?

Jul 24 2019, 4:40 AM · Restricted Project
arnt updated the diff for D60613: Make setInitializer() assert that the entire initializer is usable..

More conservative testing, as half-suggested by efriedma.

Jul 24 2019, 12:50 AM · Restricted Project
arnt updated the diff for D60613: Make setInitializer() assert that the entire initializer is usable..

best take care of self-referential initialisers.

Jul 24 2019, 12:23 AM · Restricted Project

Jul 1 2019

arnt added a comment to D60613: Make setInitializer() assert that the entire initializer is usable..

I like colon-for.

Jul 1 2019, 3:29 AM · Restricted Project
arnt updated the diff for D60613: Make setInitializer() assert that the entire initializer is usable..

Add unit test, plus some nonfunctional changes.

Jul 1 2019, 3:25 AM · Restricted Project

Jun 27 2019

arnt updated the diff for D60616: Make parseBitcodeFile use a named StructType, if it exists and matches..

This should avoid clang-formatting the entire files. Should.

Jun 27 2019, 1:39 PM · Restricted Project
arnt added a comment to D60616: Make parseBitcodeFile use a named StructType, if it exists and matches..

Sorry about that; I'll revisit. But I won't have time to do this today. FWIW the patch looked right (ie. only my lines were touched by clang-format) immediately before I ran arc diff.

Jun 27 2019, 8:06 AM · Restricted Project
arnt updated the diff for D60616: Make parseBitcodeFile use a named StructType, if it exists and matches..

Rebased on top of today's LLVM.

Jun 27 2019, 7:34 AM · Restricted Project
arnt added a reviewer for D60613: Make setInitializer() assert that the entire initializer is usable.: pete.

pete: I took the liberty of adding you as reviewer since you made the most recent change to that function. 2015-06-02. Not exactly yesterday.

Jun 27 2019, 4:20 AM · Restricted Project
arnt updated the diff for D60613: Make setInitializer() assert that the entire initializer is usable..

Rebased to this morning's LLVM.

Jun 27 2019, 4:13 AM · Restricted Project
arnt added a comment to D60619: New pass to produce more easily-read IR..

I rebased onto this morning's LLVM now.

Jun 27 2019, 3:04 AM · Restricted Project
arnt updated the diff for D60619: New pass to produce more easily-read IR..

Attends to most comments, not all.

Jun 27 2019, 2:58 AM · Restricted Project

Jun 21 2019

arnt added a comment to D60619: New pass to produce more easily-read IR..

thanks for pinging.

Jun 21 2019, 12:38 PM · Restricted Project

Jun 7 2019

arnt updated the diff for D60619: New pass to produce more easily-read IR..

Respond to a few more comments, by lebedevri and jdoerfert.

Jun 7 2019, 1:12 PM · Restricted Project
arnt added a comment to D60619: New pass to produce more easily-read IR..

Now with the ones I missed.

Jun 7 2019, 12:59 PM · Restricted Project
arnt updated the diff for D60619: New pass to produce more easily-read IR..

Updates from review by jdoerfert etc

Jun 7 2019, 12:52 PM · Restricted Project
arnt added a comment to D60619: New pass to produce more easily-read IR..

Updated diff coming in a few minutes...

Jun 7 2019, 12:52 PM · Restricted Project

May 14 2019

arnt added a comment to D60613: Make setInitializer() assert that the entire initializer is usable..

Ping?

May 14 2019, 5:16 AM · Restricted Project
arnt updated the diff for D60619: New pass to produce more easily-read IR..

This revision updates the variable names as requested by hfinkel.

May 14 2019, 4:50 AM · Restricted Project

May 7 2019

arnt updated the diff for D60616: Make parseBitcodeFile use a named StructType, if it exists and matches..

Whitespace changes only.

May 7 2019, 8:03 AM · Restricted Project
arnt updated the diff for D60616: Make parseBitcodeFile use a named StructType, if it exists and matches..

This modifies the patch to handle forward type references, and adds
relevant unit testing.

May 7 2019, 7:55 AM · Restricted Project

May 2 2019

arnt added a comment to D60616: Make parseBitcodeFile use a named StructType, if it exists and matches..

This patch overlooks a case and should not be merged for now.

May 2 2019, 4:41 AM · Restricted Project

Apr 30 2019

arnt added a comment to D60619: New pass to produce more easily-read IR..

neither of you have commented in the past couple of weeks. Should I:

Apr 30 2019, 2:46 AM · Restricted Project

Apr 23 2019

arnt updated the diff for D60616: Make parseBitcodeFile use a named StructType, if it exists and matches..

This revision uses more appropriate gtest matchers.

Apr 23 2019, 3:55 AM · Restricted Project

Apr 21 2019

arnt added a comment to D60616: Make parseBitcodeFile use a named StructType, if it exists and matches..

FWIW I noticed that the author of the git-commit hook suggested using an emacs-lisp clang-format wrapper, and decided to try that first, until I grow unhappy.

Apr 21 2019, 12:47 PM · Restricted Project

Apr 15 2019

arnt updated the diff for D60619: New pass to produce more easily-read IR..

Ran clang-format.

Apr 15 2019, 7:51 AM · Restricted Project
arnt updated the diff for D60616: Make parseBitcodeFile use a named StructType, if it exists and matches..

Attended to the rest of Lebedev.ri's comments, plus clang-format

Apr 15 2019, 7:39 AM · Restricted Project
arnt added a comment to D60616: Make parseBitcodeFile use a named StructType, if it exists and matches..

I didn't mean to suggest that I'd done all of them, I just ran out of working time on Friday. I attended to the rest now and will push a new revision as soon as the tests have run.

Apr 15 2019, 7:16 AM · Restricted Project
arnt added a comment to D60619: New pass to produce more easily-read IR..

I pushed an update now. Will this comment submit the unsubmitted drafts?

Apr 15 2019, 6:46 AM · Restricted Project
arnt updated the diff for D60619: New pass to produce more easily-read IR..

Reworked based on good comments from maskray; thanks.

Apr 15 2019, 6:46 AM · Restricted Project

Apr 12 2019

arnt updated subscribers of D60616: Make parseBitcodeFile use a named StructType, if it exists and matches..

@dnsampaio Sorry about that. I looked at my shell history now, and I think I added you because I got a wildcard wrong and picked the most recent two committers for the wrong set of files.

Apr 12 2019, 9:43 AM · Restricted Project
arnt updated the diff for D60616: Make parseBitcodeFile use a named StructType, if it exists and matches..

more LLVM-y style, and better style too. Modern.

Apr 12 2019, 9:37 AM · Restricted Project
arnt added a comment to D60612: Cowardly refuse to insert instructions after a terminator..

The old test did break, yes, that's why I changed it at all. The six branch instructions I moved down were all followed by phi nodes.

Apr 12 2019, 9:21 AM · Restricted Project
arnt added a comment to D60619: New pass to produce more easily-read IR..

This patch's reviewer selection algorithm: Those who have changed two or more files in the same directory recently. I hope you don't mind.

Apr 12 2019, 8:32 AM · Restricted Project
arnt created D60619: New pass to produce more easily-read IR..
Apr 12 2019, 8:32 AM · Restricted Project
arnt added a comment to D60616: Make parseBitcodeFile use a named StructType, if it exists and matches..

I added lebedev.ri and the last two people to touch the file as reviewers, I hope that's not too much of an imposition.

Apr 12 2019, 7:26 AM · Restricted Project
arnt created D60616: Make parseBitcodeFile use a named StructType, if it exists and matches..
Apr 12 2019, 7:24 AM · Restricted Project
arnt updated the diff for D60613: Make setInitializer() assert that the entire initializer is usable..

updated following comments from lebedev.ri; thanks

Apr 12 2019, 7:20 AM · Restricted Project
arnt added a comment to D60613: Make setInitializer() assert that the entire initializer is usable..

I picked reviewers by taking the last two people who changed the file, hope you don't mind.

Apr 12 2019, 6:43 AM · Restricted Project
arnt created D60613: Make setInitializer() assert that the entire initializer is usable..
Apr 12 2019, 6:42 AM · Restricted Project
arnt updated the diff for D60612: Cowardly refuse to insert instructions after a terminator..

LebedevRI pointed out that the assert ought to have a message; thanks.

Apr 12 2019, 6:09 AM · Restricted Project
arnt added a comment to D60612: Cowardly refuse to insert instructions after a terminator..

FWIW, I picked reviewers by taking the last two people who changed the file. I hope reviewing this isn't too much of an inconvenience ;)

Apr 12 2019, 6:03 AM · Restricted Project
arnt created D60612: Cowardly refuse to insert instructions after a terminator..
Apr 12 2019, 5:56 AM · Restricted Project

Feb 15 2018

arnt added a comment to D40727: Syndicate duplicate code between CallInst and InvokeInst.

Looks like a clear improvement, but one minor point: "Callable" sounds like it's a template/base for Function and perhaps things that implement intrinsics, not like a base for instructions that call. CallerBase perhaps?

Feb 15 2018, 3:27 AM