- User Since
- Feb 15 2018, 3:23 AM (83 w, 8 h)
Jul 24 2019
I have to type this in order to publish the comments above?
More conservative testing, as half-suggested by efriedma.
best take care of self-referential initialisers.
Jul 1 2019
I like colon-for.
Add unit test, plus some nonfunctional changes.
Jun 27 2019
This should avoid clang-formatting the entire files. Should.
Sorry about that; I'll revisit. But I won't have time to do this today. FWIW the patch looked right (ie. only my lines were touched by clang-format) immediately before I ran arc diff.
Rebased on top of today's LLVM.
pete: I took the liberty of adding you as reviewer since you made the most recent change to that function. 2015-06-02. Not exactly yesterday.
Rebased to this morning's LLVM.
I rebased onto this morning's LLVM now.
Attends to most comments, not all.
Jun 21 2019
thanks for pinging.
Jun 7 2019
Respond to a few more comments, by lebedevri and jdoerfert.
Now with the ones I missed.
Updates from review by jdoerfert etc
Updated diff coming in a few minutes...
May 14 2019
This revision updates the variable names as requested by hfinkel.
May 7 2019
Whitespace changes only.
This modifies the patch to handle forward type references, and adds
relevant unit testing.
May 2 2019
This patch overlooks a case and should not be merged for now.
Apr 30 2019
neither of you have commented in the past couple of weeks. Should I:
Apr 23 2019
This revision uses more appropriate gtest matchers.
Apr 21 2019
FWIW I noticed that the author of the git-commit hook suggested using an emacs-lisp clang-format wrapper, and decided to try that first, until I grow unhappy.
Apr 15 2019
Attended to the rest of Lebedev.ri's comments, plus clang-format
I didn't mean to suggest that I'd done all of them, I just ran out of working time on Friday. I attended to the rest now and will push a new revision as soon as the tests have run.
I pushed an update now. Will this comment submit the unsubmitted drafts?
Reworked based on good comments from maskray; thanks.
Apr 12 2019
@dnsampaio Sorry about that. I looked at my shell history now, and I think I added you because I got a wildcard wrong and picked the most recent two committers for the wrong set of files.
more LLVM-y style, and better style too. Modern.
The old test did break, yes, that's why I changed it at all. The six branch instructions I moved down were all followed by phi nodes.
This patch's reviewer selection algorithm: Those who have changed two or more files in the same directory recently. I hope you don't mind.
I added lebedev.ri and the last two people to touch the file as reviewers, I hope that's not too much of an imposition.
updated following comments from lebedev.ri; thanks
I picked reviewers by taking the last two people who changed the file, hope you don't mind.
LebedevRI pointed out that the assert ought to have a message; thanks.
FWIW, I picked reviewers by taking the last two people who changed the file. I hope reviewing this isn't too much of an inconvenience ;)
Feb 15 2018
Looks like a clear improvement, but one minor point: "Callable" sounds like it's a template/base for Function and perhaps things that implement intrinsics, not like a base for instructions that call. CallerBase perhaps?