Page MenuHomePhabricator

arnt (Arnt Gulbrandsen)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 15 2018, 3:23 AM (61 w, 6 d)

Recent Activity

Yesterday

arnt updated the diff for D60616: Make parseBitcodeFile use a named StructType, if it exists and matches..

This revision uses more appropriate gtest matchers.

Tue, Apr 23, 3:55 AM · Restricted Project

Sun, Apr 21

arnt added a comment to D60616: Make parseBitcodeFile use a named StructType, if it exists and matches..

FWIW I noticed that the author of the git-commit hook suggested using an emacs-lisp clang-format wrapper, and decided to try that first, until I grow unhappy.

Sun, Apr 21, 12:47 PM · Restricted Project

Mon, Apr 15

arnt updated the diff for D60619: New pass to produce more easily-read IR..

Ran clang-format.

Mon, Apr 15, 7:51 AM · Restricted Project
arnt updated the diff for D60616: Make parseBitcodeFile use a named StructType, if it exists and matches..

Attended to the rest of Lebedev.ri's comments, plus clang-format

Mon, Apr 15, 7:39 AM · Restricted Project
arnt added a comment to D60616: Make parseBitcodeFile use a named StructType, if it exists and matches..

I didn't mean to suggest that I'd done all of them, I just ran out of working time on Friday. I attended to the rest now and will push a new revision as soon as the tests have run.

Mon, Apr 15, 7:16 AM · Restricted Project
arnt added a comment to D60619: New pass to produce more easily-read IR..

I pushed an update now. Will this comment submit the unsubmitted drafts?

Mon, Apr 15, 6:46 AM · Restricted Project
arnt updated the diff for D60619: New pass to produce more easily-read IR..

Reworked based on good comments from maskray; thanks.

Mon, Apr 15, 6:46 AM · Restricted Project

Fri, Apr 12

arnt updated subscribers of D60616: Make parseBitcodeFile use a named StructType, if it exists and matches..

@dnsampaio Sorry about that. I looked at my shell history now, and I think I added you because I got a wildcard wrong and picked the most recent two committers for the wrong set of files.

Fri, Apr 12, 9:43 AM · Restricted Project
arnt updated the diff for D60616: Make parseBitcodeFile use a named StructType, if it exists and matches..

more LLVM-y style, and better style too. Modern.

Fri, Apr 12, 9:37 AM · Restricted Project
arnt added a comment to D60612: Cowardly refuse to insert instructions after a terminator..

The old test did break, yes, that's why I changed it at all. The six branch instructions I moved down were all followed by phi nodes.

Fri, Apr 12, 9:21 AM · Restricted Project
arnt added a comment to D60619: New pass to produce more easily-read IR..

This patch's reviewer selection algorithm: Those who have changed two or more files in the same directory recently. I hope you don't mind.

Fri, Apr 12, 8:32 AM · Restricted Project
arnt created D60619: New pass to produce more easily-read IR..
Fri, Apr 12, 8:32 AM · Restricted Project
arnt added a comment to D60616: Make parseBitcodeFile use a named StructType, if it exists and matches..

I added lebedev.ri and the last two people to touch the file as reviewers, I hope that's not too much of an imposition.

Fri, Apr 12, 7:26 AM · Restricted Project
arnt created D60616: Make parseBitcodeFile use a named StructType, if it exists and matches..
Fri, Apr 12, 7:24 AM · Restricted Project
arnt updated the diff for D60613: Make setInitializer() assert that the entire initializer is usable..

updated following comments from lebedev.ri; thanks

Fri, Apr 12, 7:20 AM · Restricted Project
arnt added a comment to D60613: Make setInitializer() assert that the entire initializer is usable..

I picked reviewers by taking the last two people who changed the file, hope you don't mind.

Fri, Apr 12, 6:43 AM · Restricted Project
arnt created D60613: Make setInitializer() assert that the entire initializer is usable..
Fri, Apr 12, 6:42 AM · Restricted Project
arnt updated the diff for D60612: Cowardly refuse to insert instructions after a terminator..

LebedevRI pointed out that the assert ought to have a message; thanks.

Fri, Apr 12, 6:09 AM · Restricted Project
arnt added a comment to D60612: Cowardly refuse to insert instructions after a terminator..

FWIW, I picked reviewers by taking the last two people who changed the file. I hope reviewing this isn't too much of an inconvenience ;)

Fri, Apr 12, 6:03 AM · Restricted Project
arnt created D60612: Cowardly refuse to insert instructions after a terminator..
Fri, Apr 12, 5:56 AM · Restricted Project

Feb 15 2018

arnt added a comment to D40727: Syndicate duplicate code between CallInst and InvokeInst.

Looks like a clear improvement, but one minor point: "Callable" sounds like it's a template/base for Function and perhaps things that implement intrinsics, not like a base for instructions that call. CallerBase perhaps?

Feb 15 2018, 3:27 AM