Page MenuHomePhabricator

arielb1 (Ariel Ben-Yehuda)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 3 2016, 3:39 PM (312 w, 6 d)

Recent Activity

Nov 27 2017

arielb1 updated the diff for D37216: [SROA] propagate !range metadata when moving loads.

Rebased and ready to land

Nov 27 2017, 6:41 AM
arielb1 added a comment to D37821: [SimplifyCfg] Don't sink loads/stores to geps of allocas.

Ping Chandler - what is this waiting for?

Nov 27 2017, 3:36 AM

Oct 28 2017

arielb1 added a comment to D37216: [SROA] propagate !range metadata when moving loads.

Has this still not landed in this month? Did this become blocked on anything?

Oct 28 2017, 1:06 PM

Sep 20 2017

arielb1 added a comment to D37216: [SROA] propagate !range metadata when moving loads.

Ok. I was just going over my todo list for in-progress items.

Sep 20 2017, 6:04 AM
arielb1 added a comment to D37821: [SimplifyCfg] Don't sink loads/stores to geps of allocas.

We want this improvement. What is it waiting for?

Sep 20 2017, 3:42 AM
arielb1 added a comment to D37216: [SROA] propagate !range metadata when moving loads.

This *still* hasn't committed. What is this waiting for?

Sep 20 2017, 3:41 AM

Sep 13 2017

arielb1 added a comment to D37821: [SimplifyCfg] Don't sink loads/stores to geps of allocas.

Yes, I know the "right" thing to do might be to make SROA smarter, but de-messing selects in this context is pretty hard.

Sep 13 2017, 12:31 PM
arielb1 created D37821: [SimplifyCfg] Don't sink loads/stores to geps of allocas.
Sep 13 2017, 12:30 PM

Sep 5 2017

arielb1 updated the diff for D37216: [SROA] propagate !range metadata when moving loads.

address review comments

Sep 5 2017, 3:34 PM

Sep 4 2017

arielb1 updated the diff for D37216: [SROA] propagate !range metadata when moving loads.

address review comments

Sep 4 2017, 10:41 AM
arielb1 updated the diff for D37216: [SROA] propagate !range metadata when moving loads.

style

Sep 4 2017, 8:44 AM
arielb1 updated the diff for D37216: [SROA] propagate !range metadata when moving loads.

Don't use ValueTracking's isGuaranteedToBeExecuted to avoid potential O(n^2). This is much uglier but should be O(n log n) in all cases.

Sep 4 2017, 8:40 AM

Sep 3 2017

arielb1 updated the diff for D37216: [SROA] propagate !range metadata when moving loads.

address review comments

Sep 3 2017, 8:24 AM
arielb1 updated the diff for D37215: [ValueTracking] improve reverse assumption inference.

Added test

Sep 3 2017, 7:15 AM · Restricted Project

Aug 31 2017

arielb1 updated the diff for D37215: [ValueTracking] improve reverse assumption inference.

add annotations to isGuaranteedToTransferExecutionToSuccessor (they were present in isAssumeLikeIntrinsic, which was *another* orthogonal method that tried to obtain the same result)

Aug 31 2017, 2:15 PM · Restricted Project

Aug 28 2017

arielb1 created D37216: [SROA] propagate !range metadata when moving loads.
Aug 28 2017, 9:02 AM
arielb1 added a reviewer for D37215: [ValueTracking] improve reverse assumption inference: chandlerc.
Aug 28 2017, 9:01 AM · Restricted Project
arielb1 created D37215: [ValueTracking] improve reverse assumption inference.
Aug 28 2017, 8:59 AM · Restricted Project

Aug 10 2017

arielb1 updated the summary of D36588: [ValueTracking] don't delete assumes of side-effectful instructions.
Aug 10 2017, 12:54 PM
arielb1 created D36590: [ValueTracking] don't delete assumes of side-effectful instructions.
Aug 10 2017, 12:54 PM
arielb1 updated the summary of D36588: [ValueTracking] don't delete assumes of side-effectful instructions.
Aug 10 2017, 12:52 PM
arielb1 added a reviewer for D36588: [ValueTracking] don't delete assumes of side-effectful instructions: nagisa.
Aug 10 2017, 12:50 PM
arielb1 created D36588: [ValueTracking] don't delete assumes of side-effectful instructions.
Aug 10 2017, 12:49 PM

Jun 26 2017

arielb1 added inline comments to D34285: [SROA] Be smarter when copying metadata to retyped loads.
Jun 26 2017, 3:01 PM
arielb1 updated the diff for D34285: [SROA] Be smarter when copying metadata to retyped loads.

More conservative version on top of r306267.

Jun 26 2017, 3:40 AM
arielb1 added a comment to D34285: [SROA] Be smarter when copying metadata to retyped loads.

The assert failure is exactly the reason I wrote this patch. Without
this patch, the !nonnull metadata is copied from the %bar* load to
the i64 load, which triggers the assertion.

Jun 26 2017, 2:08 AM

Jun 25 2017

arielb1 added a comment to D34285: [SROA] Be smarter when copying metadata to retyped loads.

This is a hard blocker for Rust LLVM 5.0, and is also blocking us from backporting a perf patch.

Jun 25 2017, 6:32 AM

Jun 16 2017

arielb1 updated the diff for D34285: [SROA] Be smarter when copying metadata to retyped loads.

Fix test

Jun 16 2017, 11:23 AM
arielb1 created D34285: [SROA] Be smarter when copying metadata to retyped loads.
Jun 16 2017, 11:13 AM

Jun 8 2017

arielb1 updated the diff for D31583: StackColoring: smarter check for slot overlap.

Use "degenerate" in all comments.

Jun 8 2017, 4:23 AM
arielb1 updated the diff for D31583: StackColoring: smarter check for slot overlap.

Changed else/if nesting in that part.

Jun 8 2017, 4:11 AM

Jun 4 2017

arielb1 added a comment to D31583: StackColoring: smarter check for slot overlap.

Ping. I think the new comment is good enough to go.

Jun 4 2017, 3:54 AM

May 30 2017

arielb1 updated the diff for D31583: StackColoring: smarter check for slot overlap.

Works locally.

May 30 2017, 1:52 PM
arielb1 updated the diff for D31583: StackColoring: smarter check for slot overlap.

Updated comment.

May 30 2017, 1:15 PM

May 15 2017

arielb1 added a comment to D31583: StackColoring: smarter check for slot overlap.

Tests run locally.

May 15 2017, 4:11 PM
arielb1 added a reviewer for D31583: StackColoring: smarter check for slot overlap: rnk.

rnk can you review this? This is stuck in the queue for almost a month.

May 15 2017, 8:01 AM
arielb1 added a comment to D31583: StackColoring: smarter check for slot overlap.

Ready and just waiting for review.

May 15 2017, 6:39 AM

Apr 17 2017

arielb1 updated the diff for D31583: StackColoring: smarter check for slot overlap.

Clean up code to LLVM standards - thanks @doener. Also add support for multiple live ranges.

Apr 17 2017, 5:08 AM

Apr 6 2017

arielb1 added inline comments to D31583: StackColoring: smarter check for slot overlap.
Apr 6 2017, 1:53 AM

Apr 5 2017

arielb1 added a comment to D31583: StackColoring: smarter check for slot overlap.

To try to echo a bit what than is saying:, i think it would be helpful if you could write some paragraphs of what you think the high level design of this new part is.

IE something like:
we create a dataflow problem that tells us x
we do this by computing these attributes on a per-block basis, and then finding a maximal fixpoint.
We then use x to prune y.

or whatever.

I can think of a lot of different approaches than stack coloring currently takes (IE you could do real liveness analysis, as than mentions, you could build interference graphs and simplify them, etc), but they are more fundamental changes than i see here.

Apr 5 2017, 10:27 AM
arielb1 updated the diff for D31583: StackColoring: smarter check for slot overlap.

Change names and comment to not mention interference graph.

Apr 5 2017, 10:22 AM
arielb1 added a comment to D31583: StackColoring: smarter check for slot overlap.

Hi Ariel,

I am thinking that maybe there is something wrong with the patch on phab-- I downloaded it and it would not compile:

StackColoring.cpp:1050:5: error: use of undeclared identifier 'UI'
    UI->getNextValue(Indexes->getZeroIndex(), VNInfoAllocator);

I fixed that up in the obvious way.

Apr 5 2017, 8:59 AM
arielb1 updated the diff for D31583: StackColoring: smarter check for slot overlap.

Typofix UI -> SI

Apr 5 2017, 8:51 AM

Apr 2 2017

arielb1 created D31583: StackColoring: smarter check for slot overlap.
Apr 2 2017, 9:40 AM

Mar 22 2017

arielb1 added a comment to D31257: [ARM] PR32379 - fix CMOV operands in computeKnownBits.

Ninja'd

Mar 22 2017, 1:24 PM
arielb1 created D31257: [ARM] PR32379 - fix CMOV operands in computeKnownBits.
Mar 22 2017, 1:15 PM

Dec 19 2016

arielb1 added inline comments to D27114: Preserve nonnull metadata on Loads through SROA & mem2reg..
Dec 19 2016, 11:40 AM

Dec 1 2016

arielb1 added a comment to D27114: Preserve nonnull metadata on Loads through SROA & mem2reg..

Could you also preserve !range metadata? It behaves similarly to nonzero, and inttoptr/ptrtoint interchanges them.

Dec 1 2016, 1:47 PM

Oct 4 2016

arielb1 added inline comments to D25215: [InstCombine] Transform !range metadata to !nonnull when combining loads.
Oct 4 2016, 4:07 AM
arielb1 updated the diff for D25215: [InstCombine] Transform !range metadata to !nonnull when combining loads.

unsigned int -> unsigned.

Oct 4 2016, 4:06 AM
arielb1 updated the diff for D25215: [InstCombine] Transform !range metadata to !nonnull when combining loads.

address review comments.

Oct 4 2016, 4:05 AM

Oct 3 2016

arielb1 updated the diff for D25215: [InstCombine] Transform !range metadata to !nonnull when combining loads.

Fix submission errors.

Oct 3 2016, 5:27 PM
arielb1 updated the diff for D25215: [InstCombine] Transform !range metadata to !nonnull when combining loads.

Address nits and add test.

Oct 3 2016, 5:21 PM
arielb1 retitled D25215: [InstCombine] Transform !range metadata to !nonnull when combining loads from to [InstCombine] Transform !range metadata to !nonnull when combining loads.
Oct 3 2016, 4:38 PM
arielb1 updated subscribers of D25214: [InstCombine] Transform !range metadata to !nonnull when combining loads.
Oct 3 2016, 4:34 PM
arielb1 retitled D25214: [InstCombine] Transform !range metadata to !nonnull when combining loads from to [InstCombine] Transform !range metadata to !nonnull when combining loads.
Oct 3 2016, 4:29 PM