Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Avoid migrating existing patches. Phabricator shutdown timeline

arbipher (Shiwei Weng)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 25 2021, 12:01 PM (123 w, 4 d)

Recent Activity

Feb 16 2022

arbipher accepted D119884: [llvm] [bindings/OCaml] Remove unused dep on ounit2.

It looks good to me.

Feb 16 2022, 8:07 AM · Restricted Project
arbipher added a comment to D119079: [llvm] [cmake] Fix finding modern ounit2.

Thanks! I will learn from your script and test which flags help much in the opam building.

Feb 16 2022, 8:01 AM · Restricted Project

Feb 15 2022

arbipher added a comment to D119079: [llvm] [cmake] Fix finding modern ounit2.

Sure. It also sounds good to me.

Feb 15 2022, 12:35 PM · Restricted Project

Feb 13 2022

arbipher added a comment to D119079: [llvm] [cmake] Fix finding modern ounit2.

I saw that. My concern is the tests themselves don't use ounit.

Feb 13 2022, 1:43 PM · Restricted Project
arbipher updated arbipher.
Feb 13 2022, 11:38 AM
arbipher added a comment to D119079: [llvm] [cmake] Fix finding modern ounit2.

I see. Thanks for the explanation. I was opam-minded before and now the problem looks more clear to me.

Feb 13 2022, 11:36 AM · Restricted Project

Feb 12 2022

arbipher added a comment to D119079: [llvm] [cmake] Fix finding modern ounit2.

Hi all, I am happy to help with OCaml-related problems for this one and the future.
It seems I am a bit late to reply. I saw the email but didn't find a time to check this immediately at that moment until today.

Feb 12 2022, 6:00 PM · Restricted Project

Oct 6 2021

arbipher added a comment to D110983: Add .cmt and .cmti files for OCaml bindings.

@tnkhanh
I just made it including this patch, and this is the PR for opam-llvm-13.

Oct 6 2021, 10:24 AM · Restricted Project

Oct 3 2021

arbipher accepted D110983: Add .cmt and .cmti files for OCaml bindings.

This change looks good to me. Thank you all.

Oct 3 2021, 10:32 PM · Restricted Project