- User Since
- Jul 2 2019, 9:37 AM (194 w, 1 d)
Aug 23 2019
Made changes to review suggested in the patch for Vector Function ABI Name Demangling patch.
Minor Update. Cosmetic changes.
Had a minor bug in the previous patch. Updated it.
Aug 22 2019
Thank you all for valuable comments. I have made the changes as requested so far.
Aug 13 2019
Aug 12 2019
Aug 9 2019
All the parsing code is always extremely prone to subtle bugs.
At least it should not crash on them.
That would be easy to ensure via a fuzz target.
- Could you elaborate about the fuzzer target? The VFABI::getVectorName() extracts the custom redirection to a user-specified function that can be described using #pragma declare variant
- If I understood you correctly, yes, this name mangling format is as specified in the ABI. It is also supported by other implementations such as GCC. The following link is a demonstration of the same which uses GCC compiler. [https://godbolt.org/z/PrGLn0]
Aug 6 2019
As suggested earlier by Sander, I'll be splitting this patch into two patches for easier review.
Aug 1 2019
Jul 31 2019
Minor changes as suggested in the recent review.
Thank you for valuable inputs. Sorry for the delay in getting back to you.
Jul 15 2019
Jul 12 2019
Added code to expose the functionality as an Analysis Pass. Integrated changes as suggested in prior code review.