Page MenuHomePhabricator

apoos-maximus (APOORV SACHAN)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 21 2021, 5:10 AM (14 w, 1 d)

Recent Activity

Mon, Sep 6

apoos-maximus added a comment to D106226: [lldb] Improve error message when "lldb attach" fails.
Mon, Sep 6, 1:40 PM · Restricted Project
apoos-maximus added a comment to D106226: [lldb] Improve error message when "lldb attach" fails.

After our previous discussions, I have modified the patch.
Now :-

Mon, Sep 6, 1:37 PM · Restricted Project
apoos-maximus updated the diff for D106226: [lldb] Improve error message when "lldb attach" fails.

Changed the error message to be more informative, and added things,
based on the previous review.

Mon, Sep 6, 12:37 PM · Restricted Project
apoos-maximus updated the diff for D106226: [lldb] Improve error message when "lldb attach" fails.

added logic to report ptrace related error only if ptrace policy
was the actual reason for failure. i.e. by reading the value of
/proc/sys/kernel/yama/ptrace_scope file if it exists, and setting the
ptrace error only if the value is not 0.

Mon, Sep 6, 9:02 AM · Restricted Project

Sat, Sep 4

apoos-maximus updated the diff for D106226: [lldb] Improve error message when "lldb attach" fails.

moved the error message building logic to Target::Attach()
where the ptrace policy related mesasge gets appended only
if the debugee process is running on LinuxOS

Sat, Sep 4, 3:05 PM · Restricted Project

Jul 21 2021

apoos-maximus added a comment to D106226: [lldb] Improve error message when "lldb attach" fails.

Also I wonder how we could make sure we emit this diagnostic in cases where the ptrace_scope is actually the reason for the failed attach. The proper way to check this seems to be checking the errno after we call ptrace and then propagate the error all the way back to lldb from lldb-server. From the lldb side I don't think we have any way of knowing why the attach actually failed so we would emit this error speculatively which doesn't seem ideal.

Jul 21 2021, 4:11 PM · Restricted Project
apoos-maximus added a comment to D106226: [lldb] Improve error message when "lldb attach" fails.

Congrats on getting started on your first patch! I improving this error message really seems like a good idea.

Thanks : ) !

Jul 21 2021, 3:51 PM · Restricted Project
apoos-maximus added a comment to D106226: [lldb] Improve error message when "lldb attach" fails.

It changes whether the output goes to stdout or stderr and whether we set the return status to failed. So I would merge it into one call to AppendErrorWithFormat.

Thanks a lot for passing on this knowledge.

Jul 21 2021, 3:37 PM · Restricted Project

Jul 17 2021

apoos-maximus updated the diff for D106226: [lldb] Improve error message when "lldb attach" fails.

reformatted code to comply with pre-merge checks

Jul 17 2021, 3:36 PM · Restricted Project
apoos-maximus updated the diff for D106226: [lldb] Improve error message when "lldb attach" fails.

realigned patch against main branch

Jul 17 2021, 3:19 PM · Restricted Project
apoos-maximus updated the diff for D106226: [lldb] Improve error message when "lldb attach" fails.

changed the code-styling to comply with pre-merge checks.

Jul 17 2021, 3:14 PM · Restricted Project
apoos-maximus added reviewers for D106226: [lldb] Improve error message when "lldb attach" fails: jingham, rupprecht, davide.

This patch is supposed to fix this Bug : 39166
I compiled the code and used the binary with local/remote debugging scenarios. On attach failure this is the output it produces :-

Jul 17 2021, 3:01 PM · Restricted Project
apoos-maximus requested review of D106226: [lldb] Improve error message when "lldb attach" fails.
Jul 17 2021, 2:14 PM · Restricted Project

Jun 22 2021

apoos-maximus added a comment to D97804: [mlir][IR] Refactor the internal implementation of Value.
$ cmake -G Ninja -DCMAKE_CXX_COMPILER=$(command -v clang++) -DCMAKE_BUILD_TYPE=Release -DLLVM_ENABLE_PROJECTS="clang;debuginfo-tests;mlir" ../llvm
...

$ ninja projects/debuginfo-tests/CMakeFiles/check-gdb-mlir-support.dir/llvm-prettyprinters/gdb/mlir-support.cpp.o
...
/home/nathan/src/llvm-project/debuginfo-tests/llvm-prettyprinters/gdb/mlir-support.cpp:13:33: error: no member named 'Kind' in 'mlir::Value'
                   mlir::Value::Kind::TrailingOpResult});
                   ~~~~~~~~~~~~~^
1 error generated.

D98613 is needed to avoid other errors in this file.

Jun 22 2021, 1:25 AM · Restricted Project