Page MenuHomePhabricator

apinski-cavium (Andrew Pinski)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 23 2017, 4:35 PM (292 w, 3 d)

Recent Activity

Dec 9 2021

apinski-cavium added a comment to D115471: [clang] number labels in asm goto strings after tied inputs.

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98096
GCC even documents it this way.

Dec 9 2021, 5:50 PM · Restricted Project

Nov 29 2021

apinski-cavium added a comment to D113742: tsan: fix XMM register corruption in hacky call.

This breaks TSAN on processors which don't have AVX support because vmovdqu is not valid for them.
Reported as https://github.com/google/sanitizers/issues/1472

Nov 29 2021, 5:27 PM · Restricted Project

Jul 6 2017

apinski-cavium added a comment to D35075: [AArch64] Redundant copy elimination - remove more zero copies..

Why did it not produce:

str wzr, [x2]
Jul 6 2017, 11:47 AM

Jun 28 2017

apinski-cavium added a comment to D34579: Fold fneg and fabs like multiplications.

Note why don't you
fold "(select (fcmp X > 0.0), -1.0, 1.0)" into copysign(1.0, X)
fold "(select (fcmp X > 0.0), 1.0, -1.0)" into copysign(1.0, -X)
?

Jun 28 2017, 1:26 PM

Jun 23 2017

apinski-cavium added a comment to D34220: [AArch64] Prefer B.cond to CBZ/CBNZ/TBZ/TBNZ when NZCV flags can be set for "free".

Note this should be an improvement for ThunderX (though maybe it is not modeled correctly). Not ThunderX2T99 though (only because fusion happens even for add/cbz cases too).

Jun 23 2017, 9:24 PM
apinski-cavium added a comment to D34579: Fold fneg and fabs like multiplications.

(fmul X, (select (fcmp X > 0.0), -1.0, 1.0)) -> (fneg X)

Is not correct.

Jun 23 2017, 4:39 PM