Page MenuHomePhabricator

andrewluo (Andrew Luo)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 20 2019, 5:45 PM (21 w, 15 h)

Recent Activity

Jan 31 2019

andrewluo added a comment to D56997: Fix implementation of P0966 - string::reserve Should Not Shrink.

Just wanted to check to see if there are any other comments or if this looks good.

Jan 31 2019, 9:44 AM

Jan 24 2019

andrewluo updated the diff for D56997: Fix implementation of P0966 - string::reserve Should Not Shrink.

Split reserve again for all dialects

Jan 24 2019, 4:14 PM

Jan 23 2019

andrewluo added inline comments to D56997: Fix implementation of P0966 - string::reserve Should Not Shrink.
Jan 23 2019, 10:29 AM
andrewluo added a comment to D56997: Fix implementation of P0966 - string::reserve Should Not Shrink.

You are right, it is not guaranteed per the standard, although it has worked before (at least on MSVC).

But not with libc++, where there were already two overloads. Changing that to support broken code which was already unsupported seems unnecessary.

Jan 23 2019, 10:19 AM

Jan 22 2019

andrewluo added a comment to D56997: Fix implementation of P0966 - string::reserve Should Not Shrink.

You are right, it is not guaranteed per the standard, although it has worked before (at least on MSVC). Unfortunately, I've seen many instances of code that relies on this implementation-specific behavior (particularly older code that uses bind instead of lambdas).

Jan 22 2019, 10:05 PM
andrewluo added a comment to D56997: Fix implementation of P0966 - string::reserve Should Not Shrink.

Made some changes to keep behavior the same in older -std= dialects. We shouldn't overload the function to avoid code such as:

Jan 22 2019, 6:58 PM
andrewluo updated the diff for D56997: Fix implementation of P0966 - string::reserve Should Not Shrink.
Jan 22 2019, 6:57 PM

Jan 21 2019

andrewluo updated the diff for D56997: Fix implementation of P0966 - string::reserve Should Not Shrink.
Jan 21 2019, 7:36 PM
andrewluo added a comment to D56997: Fix implementation of P0966 - string::reserve Should Not Shrink.

Fixed with the new diff

Jan 21 2019, 9:51 AM
andrewluo updated the diff for D56997: Fix implementation of P0966 - string::reserve Should Not Shrink.
Jan 21 2019, 9:50 AM

Jan 20 2019

andrewluo added inline comments to D56997: Fix implementation of P0966 - string::reserve Should Not Shrink.
Jan 20 2019, 11:21 PM
andrewluo created D56997: Fix implementation of P0966 - string::reserve Should Not Shrink.
Jan 20 2019, 6:02 PM