Page MenuHomePhabricator

andrewjcg (Andrew Gallagher)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 11 2018, 4:24 PM (58 w, 8 h)

Recent Activity

Apr 10 2019

andrewjcg added a comment to D58920: [Modules][PR39287] Consolidate multiple std's.

Sorry for the delay. Just catching up on the code this covers, so apologies if the questions don't make sense.

Apr 10 2019, 9:54 AM · Restricted Project

Feb 21 2019

Herald added a project to D52956: Support `-fno-visibility-inlines-hidden`: Restricted Project.

Sorry for the delay here, but this should be ready to go.

Feb 21 2019, 4:44 PM · Restricted Project

Nov 29 2018

andrewjcg added a comment to D51568: [modules] Add `-fno-absolute-module-directory` flag for relocatable modules.

I don't think we need to change the serialization format for this: a serialized path beginning with / is already treated as absolute and any other path is already treated as relative, so we don't need a flag to carry that information.

Nov 29 2018, 8:14 PM

Oct 7 2018

andrewjcg added a reviewer for D52956: Support `-fno-visibility-inlines-hidden`: elsteveogrande.
Oct 7 2018, 11:20 AM · Restricted Project

Oct 5 2018

andrewjcg created D52956: Support `-fno-visibility-inlines-hidden`.
Oct 5 2018, 5:10 PM · Restricted Project

Sep 24 2018

andrewjcg updated the summary of D51568: [modules] Add `-fno-absolute-module-directory` flag for relocatable modules.
Sep 24 2018, 9:56 AM
andrewjcg retitled D51568: [modules] Add `-fno-absolute-module-directory` flag for relocatable modules from [modules] Add `-fdisable-module-directory` flag for relocatable modules to [modules] Add `-fno-absolute-module-directory` flag for relocatable modules.
Sep 24 2018, 9:56 AM
andrewjcg updated the diff for D51568: [modules] Add `-fno-absolute-module-directory` flag for relocatable modules.

Dropping the module directory entirely and fully resolving paths on serialization
broke some things during deserialization, specifically when the deserializer wanted
to update paths to use an alternate module directory.

Sep 24 2018, 9:56 AM

Sep 1 2018

andrewjcg updated the diff for D51568: [modules] Add `-fno-absolute-module-directory` flag for relocatable modules.

fix umbrella writing

Sep 1 2018, 1:16 AM
andrewjcg added a comment to D51568: [modules] Add `-fno-absolute-module-directory` flag for relocatable modules.

I'm not sure this is the best approach, but I wasn't sure of a better one (to support module files w/o absolute paths). Another approach I tried, was relativizing the other input files (from outside the module directory) using chains of ../ (e.g. ../../../../../other/modules/module.modulemap), but this causes issues when symlinks appear in the module directory path. Another potential option could be to add a bit to the serialized module format for each input, to allow some inputs to mark themselves as relative to the CWD, rather than the module directory.

Sep 1 2018, 12:56 AM
andrewjcg updated subscribers of D51568: [modules] Add `-fno-absolute-module-directory` flag for relocatable modules.
Sep 1 2018, 12:50 AM
andrewjcg added a reviewer for D51568: [modules] Add `-fno-absolute-module-directory` flag for relocatable modules: rsmith.
Sep 1 2018, 12:50 AM
andrewjcg created D51568: [modules] Add `-fno-absolute-module-directory` flag for relocatable modules.
Sep 1 2018, 12:50 AM