Page MenuHomePhabricator

anderslanglands (Anders Langlands)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 15 2022, 2:22 AM (20 w, 2 d)

Recent Activity

Nov 23 2022

anderslanglands updated the diff for D138377: add clang_Type_getFullyQualifiedName.

couple of little spaces I missed...

Nov 23 2022, 12:08 AM · Restricted Project, Restricted Project
anderslanglands updated the diff for D138377: add clang_Type_getFullyQualifiedName.

Remove whitespace changes on unaffected lines

Nov 23 2022, 12:04 AM · Restricted Project, Restricted Project

Nov 22 2022

anderslanglands added inline comments to D138377: add clang_Type_getFullyQualifiedName.
Nov 22 2022, 11:53 PM · Restricted Project, Restricted Project
anderslanglands added a comment to D138377: add clang_Type_getFullyQualifiedName.

Re the whitespace - yeah that's me running clang-format on the whole function rather than just the lines I changed. I'll see if I can split those out.

Nov 22 2022, 11:16 PM · Restricted Project, Restricted Project
anderslanglands updated the diff for D138377: add clang_Type_getFullyQualifiedName.

Now tested by adding a -print-qualified-type-names flag to c-index-test and creating a (small) dedicated test in print-qualified-type.cpp

Nov 22 2022, 12:21 AM · Restricted Project, Restricted Project

Nov 21 2022

anderslanglands updated the diff for D137818: Add support for querying SubstTemplateTypeParm types.

Move getReplacementType to LLVM_16 block

Nov 21 2022, 9:45 AM · Restricted Project, Restricted Project

Nov 19 2022

anderslanglands requested review of D138377: add clang_Type_getFullyQualifiedName.
Nov 19 2022, 10:33 PM · Restricted Project, Restricted Project
anderslanglands added a comment to D137818: Add support for querying SubstTemplateTypeParm types.

Arg just noticed an issue: clang_Type_getReplacementType should be in the LLVM_16 block in libclang.map not in the LLVM_13 block. I've blown away my local branch so don't know how to fix the patch. Shall I just make a new patch once this is merged?

Nov 19 2022, 10:54 AM · Restricted Project, Restricted Project
anderslanglands added a comment to D137818: Add support for querying SubstTemplateTypeParm types.

Great, thanks! I've got a couple more things to land once this is merged and I've cleaned them up. Do you wanna show me how to do the merge myself?

Nov 19 2022, 10:26 AM · Restricted Project, Restricted Project

Nov 17 2022

anderslanglands updated the diff for D137818: Add support for querying SubstTemplateTypeParm types.

Added release note, incorporated other review notes

Nov 17 2022, 3:57 PM · Restricted Project, Restricted Project

Nov 11 2022

anderslanglands requested review of D137818: Add support for querying SubstTemplateTypeParm types.
Nov 11 2022, 1:04 AM · Restricted Project, Restricted Project

Oct 19 2022

anderslanglands added inline comments to D135557: Add needsImplicitDefaultConstructor and friends.
Oct 19 2022, 6:07 PM · Restricted Project, Restricted Project

Oct 18 2022

anderslanglands added inline comments to D135557: Add needsImplicitDefaultConstructor and friends.
Oct 18 2022, 2:18 PM · Restricted Project, Restricted Project
anderslanglands added inline comments to D135557: Add needsImplicitDefaultConstructor and friends.
Oct 18 2022, 1:13 PM · Restricted Project, Restricted Project

Oct 14 2022

anderslanglands added inline comments to D135557: Add needsImplicitDefaultConstructor and friends.
Oct 14 2022, 12:24 PM · Restricted Project, Restricted Project

Oct 13 2022

anderslanglands added inline comments to D135557: Add needsImplicitDefaultConstructor and friends.
Oct 13 2022, 12:58 PM · Restricted Project, Restricted Project
anderslanglands added inline comments to D135557: Add needsImplicitDefaultConstructor and friends.
Oct 13 2022, 11:55 AM · Restricted Project, Restricted Project

Oct 10 2022

anderslanglands added reviewers for D135557: Add needsImplicitDefaultConstructor and friends: tbaeder, aaron.ballman.
Oct 10 2022, 5:34 PM · Restricted Project, Restricted Project
anderslanglands updated the diff for D135557: Add needsImplicitDefaultConstructor and friends.

Fixed clang-format error

Oct 10 2022, 5:33 PM · Restricted Project, Restricted Project

Oct 9 2022

anderslanglands requested review of D135557: Add needsImplicitDefaultConstructor and friends.
Oct 9 2022, 11:46 PM · Restricted Project, Restricted Project

Sep 22 2022

anderslanglands added a comment to D134416: Allow getting template args for ClassTemplateSpecializations.

I ended up modifying c-index-test to print out the template arguments in the same way it does for FunctionDecl, which ends up working all cases in the existing test suite. The only other thing I added was a specific case in index-templates.cpp to check whether it catches StructDecl too (it does).

Sep 22 2022, 10:51 PM · Restricted Project, Restricted Project
anderslanglands updated the diff for D134416: Allow getting template args for ClassTemplateSpecializations.

Add testing, address style notes

Sep 22 2022, 10:48 PM · Restricted Project, Restricted Project
anderslanglands updated the diff for D134416: Allow getting template args for ClassTemplateSpecializations.

Updating doc comments to reflect new functionality

Sep 22 2022, 1:11 AM · Restricted Project, Restricted Project
anderslanglands added reviewers for D134416: Allow getting template args for ClassTemplateSpecializations: tbaeder, aaron.ballman.

Hello again, this generalizes the template argument functionality to operate on cursor kinds other than functions.

Sep 22 2022, 1:04 AM · Restricted Project, Restricted Project
anderslanglands requested review of D134416: Allow getting template args for ClassTemplateSpecializations.
Sep 22 2022, 1:01 AM · Restricted Project, Restricted Project

Sep 16 2022

anderslanglands added a comment to D133924: add clang_CXXMethod_isDeleted function.

Yes it's probably safest if someone commits on my behalf, unless someone's got time to walk me through it. Just use Anders Langlands anderslangands@gmail.com for attribution please.

Sep 16 2022, 1:04 PM · Restricted Project, Restricted Project
anderslanglands updated the diff for D133924: add clang_CXXMethod_isDeleted function.

Adding missing backtick

Sep 16 2022, 1:03 PM · Restricted Project, Restricted Project
anderslanglands added a comment to D133924: add clang_CXXMethod_isDeleted function.

OK that should all be good now. Thanks for your patience, it's my first time doing all this.

Sep 16 2022, 1:55 AM · Restricted Project, Restricted Project
anderslanglands updated the diff for D133924: add clang_CXXMethod_isDeleted function.

Adding in the dyn_cast_is_present change I missed on the previous one

Sep 16 2022, 1:54 AM · Restricted Project, Restricted Project
anderslanglands updated the diff for D133924: add clang_CXXMethod_isDeleted function.

squashing all commits into one to hopefully fix the revision

Sep 16 2022, 12:45 AM · Restricted Project, Restricted Project
anderslanglands abandoned D133991: add new function to release notes.
Sep 16 2022, 12:42 AM · Restricted Project, Restricted Project

Sep 15 2022

anderslanglands added a comment to D133991: add new function to release notes.

Sorry, this was supposed to update https://reviews.llvm.org/D13392. How do I delete this?

Sep 15 2022, 4:34 PM · Restricted Project, Restricted Project
anderslanglands updated the diff for D133924: add clang_CXXMethod_isDeleted function.

Updating based on review

  • Add new function to release notes
  • Fix failing test and add a new test specifically for this function
Sep 15 2022, 4:33 PM · Restricted Project, Restricted Project
anderslanglands requested review of D133991: add new function to release notes.
Sep 15 2022, 4:31 PM · Restricted Project, Restricted Project
anderslanglands updated the summary of D133924: add clang_CXXMethod_isDeleted function.
Sep 15 2022, 2:38 AM · Restricted Project, Restricted Project
anderslanglands requested review of D133924: add clang_CXXMethod_isDeleted function.
Sep 15 2022, 2:31 AM · Restricted Project, Restricted Project