Page MenuHomePhabricator

anarazel (Andres Freund)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 8 2017, 5:43 PM (127 w, 2 d)

Recent Activity

Nov 28 2018

anarazel accepted D53773: [ExecutionEngine] Track objects using an abstract ObjectKey in JITEventListeners..

Gentle ping.

Nov 28 2018, 3:04 PM

Nov 1 2018

anarazel accepted D53999: Fix typo in LLVMCreateOprofileJITEventListener.

Darnit. Sorry for that. Good catch. Can you commit, or should I?

Nov 1 2018, 9:26 PM

Oct 30 2018

anarazel requested changes to D53773: [ExecutionEngine] Track objects using an abstract ObjectKey in JITEventListeners..

This looks like a sensible improvement. There's probably not many implementors of the interface, so the renaming shouldn't cause much pain.

Oct 30 2018, 1:13 PM

Jul 25 2018

anarazel committed rL337930: Move JIT listener C binding fallbackks to ExecutionEngineBindings.cpp..
Move JIT listener C binding fallbackks to ExecutionEngineBindings.cpp.
Jul 25 2018, 8:05 AM
anarazel closed D49654: Move JIT listener C binding definitions to ExecutionEngineBindings.cpp..
Jul 25 2018, 8:05 AM

Jul 24 2018

anarazel updated the diff for D49654: Move JIT listener C binding definitions to ExecutionEngineBindings.cpp..

Previous approach was a brick shy of a load, which I realized after
sleeping on it. We'd just end up with undefined symbol errors for the
listeners that *are* built in (because the part of the class
implementation ptentially is in a different lib). Hence just define
if necessary.

Jul 24 2018, 12:45 PM

Jul 23 2018

anarazel committed rL337789: Add PerfJITEventListener for perf profiling support..
Add PerfJITEventListener for perf profiling support.
Jul 23 2018, 5:54 PM
anarazel closed D44892: Add PerfJITEventListener for perf profiling support..
Jul 23 2018, 5:54 PM · Restricted Project
anarazel added a reviewer for D49654: Move JIT listener C binding definitions to ExecutionEngineBindings.cpp.: whitequark.
Jul 23 2018, 4:50 PM

Jul 22 2018

anarazel created D49654: Move JIT listener C binding definitions to ExecutionEngineBindings.cpp..
Jul 22 2018, 8:05 PM
anarazel added inline comments to rL333230: [C-API] Add functions to create GDB, Intel, Oprofile event listeners..
Jul 22 2018, 7:41 PM
anarazel added a comment to D44892: Add PerfJITEventListener for perf profiling support..

Given that the listener has no dependencies, it might be sensible to
enable it by default when running on linux.

Fwiw, I agree with this except I would add an option to lli so that generating the perf jitdump data was optional - otherwise you could end up filling a disk, .. unexpectedly.

Jul 22 2018, 7:35 PM · Restricted Project
anarazel added a comment to D44892: Add PerfJITEventListener for perf profiling support..

@vchuravy Yea, that was an unnecessary, and as you notice wrong, dependency. I confirmed that just removing it is sufficient. Does that resolve your blocker?

Jul 22 2018, 7:33 PM · Restricted Project
anarazel updated the diff for D44892: Add PerfJITEventListener for perf profiling support..

Fix build without perf enabled, fix rebasing issues.

Jul 22 2018, 7:28 PM · Restricted Project

May 24 2018

anarazel added inline comments to D44892: Add PerfJITEventListener for perf profiling support..
May 24 2018, 5:31 PM · Restricted Project
anarazel updated the diff for D44892: Add PerfJITEventListener for perf profiling support..

Address reames' comments and rebase onto newer code. As
https://reviews.llvm.org/D44890 has landed, add the corresponding
C-API function as well.

May 24 2018, 5:28 PM · Restricted Project
anarazel added a comment to D47343: [MCJIT] Call JIT notifiers only after code sections are ready..

This patch doesn't affect any of my use-cases, but it's possible that some clients are relying on the fact that memory will still be writable at this point.

May 24 2018, 3:02 PM
anarazel committed rL333230: [C-API] Add functions to create GDB, Intel, Oprofile event listeners..
[C-API] Add functions to create GDB, Intel, Oprofile event listeners.
May 24 2018, 2:37 PM
anarazel committed rL333229: [ORC][C-API] Expose LLVMOrc{Unr,R}egisterJITEventListener()..
[ORC][C-API] Expose LLVMOrc{Unr,R}egisterJITEventListener().
May 24 2018, 2:37 PM
anarazel committed rL333228: [ORC] Add ability [un]register JITEventListener on Orc C stack..
[ORC] Add ability [un]register JITEventListener on Orc C stack.
May 24 2018, 2:37 PM
anarazel committed rL333227: [ORC] Extend object layer callbacks so JITEventListener can be supported..
[ORC] Extend object layer callbacks so JITEventListener can be supported.
May 24 2018, 2:37 PM
anarazel closed D44890: Allow to integrate OrcJIT with JitEventListeners.
May 24 2018, 2:37 PM
anarazel added inline comments to D44892: Add PerfJITEventListener for perf profiling support..
May 24 2018, 12:09 PM · Restricted Project
anarazel created D47343: [MCJIT] Call JIT notifiers only after code sections are ready..
May 24 2018, 12:06 PM
anarazel committed rL333215: [ORC] Add findSymbolIn() wrapper to C bindings, take #2..
[ORC] Add findSymbolIn() wrapper to C bindings, take #2.
May 24 2018, 11:48 AM
anarazel committed rL333206: [ORC] Perform name mangling in findSymbolIn(), as done in findSymbol()..
[ORC] Perform name mangling in findSymbolIn(), as done in findSymbol().
May 24 2018, 10:07 AM
anarazel closed D47308: [ORC] Perform name mangling in findSymbolIn(), as done in findSymbol()..
May 24 2018, 10:07 AM
anarazel updated the diff for D47308: [ORC] Perform name mangling in findSymbolIn(), as done in findSymbol()..

Rebase after temporary revert of r333147.

May 24 2018, 9:42 AM

May 23 2018

anarazel committed rL333152: Revert r333147 "[ORC] Add findSymbolIn() wrapper to C bindings.".
Revert r333147 "[ORC] Add findSymbolIn() wrapper to C bindings."
May 23 2018, 10:14 PM
anarazel updated the summary of D47308: [ORC] Perform name mangling in findSymbolIn(), as done in findSymbol()..
May 23 2018, 9:58 PM
anarazel added a comment to D47308: [ORC] Perform name mangling in findSymbolIn(), as done in findSymbol()..

FWIW, I don't think this is really obvious / trivial enough to land w/o review by someone familiar w/ Orc and the users.

May 23 2018, 9:55 PM
anarazel created D47308: [ORC] Perform name mangling in findSymbolIn(), as done in findSymbol()..
May 23 2018, 9:16 PM
anarazel committed rL333147: [ORC] Add findSymbolIn() wrapper to C bindings..
[ORC] Add findSymbolIn() wrapper to C bindings.
May 23 2018, 6:06 PM
anarazel closed D44889: [ORC] Add findSymbolIn() wrapper to C bindings..
May 23 2018, 6:05 PM
anarazel added a comment to D44889: [ORC] Add findSymbolIn() wrapper to C bindings..

Looks good to me. Do you have commit access? If not I can commit on your behalf.

May 23 2018, 4:30 PM

Apr 23 2018

anarazel added a comment to D44890: Allow to integrate OrcJIT with JitEventListeners.

Ping? @lhames unfortunately you're probably the only one to review this?

Apr 23 2018, 10:09 AM
anarazel added a comment to D44892: Add PerfJITEventListener for perf profiling support..

Ping? Any suggestions for other reviewers?

Apr 23 2018, 9:58 AM · Restricted Project
anarazel added a comment to D44889: [ORC] Add findSymbolIn() wrapper to C bindings..

Ping? This is a simple enough addition that seems to have been envisioned when designing the Orc C stack (given that the underlying stack isn't used anywhere else, and has findSymbolIn()).

Apr 23 2018, 9:10 AM

Apr 22 2018

anarazel committed rL330551: Test commit access..
Test commit access.
Apr 22 2018, 10:57 AM

Apr 11 2018

anarazel added a comment to D44861: [C-API] Add LLVMGetHostCPU{Name,Features}..

Ideally we would have a test for this code but given that it involves host CPU and features this seems quite tricky and not worth the benefit.

Apr 11 2018, 3:39 PM
anarazel added a comment to D44890: Allow to integrate OrcJIT with JitEventListeners.

Ping? I'm using this functionality in postgres's new JIT support. It'd be cool if it were merged so we can make sure the released version of Postgres is going to use the right API, even if LLVM has to be patched for it to be available in older releases.

Apr 11 2018, 3:35 PM
anarazel added a comment to D44861: [C-API] Add LLVMGetHostCPU{Name,Features}..

Ping? This is a trivial change and makes it much easier to use Orc via the C API, as otherwise suboptimal code is generated. If anybody has suggestions for further reviewers I'd also be happy.

Apr 11 2018, 3:15 PM

Mar 26 2018

anarazel added reviewers for D44902: [ORC][C-API] Fix orc on platforms without indirection support.: lhames, dblaikie.
Mar 26 2018, 11:17 AM
anarazel created D44902: [ORC][C-API] Fix orc on platforms without indirection support..
Mar 26 2018, 11:17 AM

Mar 25 2018

anarazel retitled D44892: Add PerfJITEventListener for perf profiling support. from Call JIT notifiers only after code sections are ready. to Add PerfJITEventListener for perf profiling support..
Mar 25 2018, 11:22 PM · Restricted Project
anarazel created D44892: Add PerfJITEventListener for perf profiling support..
Mar 25 2018, 11:20 PM · Restricted Project
anarazel retitled D44890: Allow to integrate OrcJIT with JitEventListeners from Allow to integrate OrcJIT with JitEventListeners See #31521 Contained-Commits: [ORC] Extend object layer callbacks so JITEventListener can be supported. to Allow to integrate OrcJIT with JitEventListeners.
Mar 25 2018, 10:03 PM
anarazel created D44890: Allow to integrate OrcJIT with JitEventListeners.
Mar 25 2018, 10:03 PM
anarazel added a reviewer for D44889: [ORC] Add findSymbolIn() wrapper to C bindings.: lhames.
Mar 25 2018, 9:32 PM
anarazel created D44889: [ORC] Add findSymbolIn() wrapper to C bindings..
Mar 25 2018, 9:29 PM

Mar 23 2018

anarazel created D44861: [C-API] Add LLVMGetHostCPU{Name,Features}..
Mar 23 2018, 7:30 PM