User Details
- User Since
- Dec 5 2016, 5:23 PM (215 w, 2 d)
Jun 11 2020
I posted this on the GitHub PR, but was told the main discussion about this bug is here:
https://github.com/llvm/llvm-project/commit/1ce831912c797df1cb6d313d8e576a3f86175b6d#r39838454
Feb 6 2020
May 5 2017
Apr 5 2017
Mar 30 2017
Mar 11 2017
Feb 27 2017
Feb 26 2017
Made changes based on @hans 's feedback.
Feb 21 2017
Feb 17 2017
Hello again. Just wondering if anyone could take a look at this? I updated the patch a week ago :) Thanks!
Feb 10 2017
- Renamed VsixUtils to Vsix and TypeConverterUtils to TypeConversion
- Removed format on save mode
Feb 7 2017
Feb 6 2017
Hello! Just a small ping to see if anyone has taken a look at this change? I fully understand that everyone's really busy, but perhaps you can recommend another reviewer? Or if you're presently giving this change a whirl, just let me know! Cheers :)
Jan 27 2017
Jan 23 2017
Jan 21 2017
This change is no longer needed since clang-format now returns failure status (non-zero) whenever it writes to stderr (e.g. on parse error) since https://llvm.org/svn/llvm-project/cfe/trunk@292174 (D28081)
Jan 20 2017
Jan 19 2017
Jan 17 2017
Jan 16 2017
Rebased changes on latest. No functional changes in this diff since last.
Rebased changes on latest, no functional change in this diff.
Jan 15 2017
Jan 14 2017
Jan 11 2017
Fixed code in ClangApplyReplacementsMain.cpp so that we only handle the Expected<Style> when DoFormat is true. Note that I'm using the unidiomatic FormatStyleOrError variable name here, but that's because we only want to set the FormatStyle variable in the parent scope when DoFormat is true.
Fixed Format/style-on-command-line.cpp test to match new expected output.
Jan 10 2017
Last night, I realized that this problem extends to the clang/tests as well, not just those in clang-tools-extra. Is there someone who knows Windows, Git, and the testing pipeline that can weigh in more on this topic?
Jan 9 2017
Hello, sorry for the lack of details here. I will re-run the tests later and report here the tests that are failing along with output.
Jan 6 2017
@ioeric Okay, check-clang-tools passes with my changes.
Jan 5 2017
Jan 4 2017
@ioeric I think you removed cfe-commits as a reviewer, then added it back, but it didn't work. Should I re-add?
I made these changes, and they build, but I didn't really test them. Are there unit tests for these tools that I can run?
Jan 3 2017
Minor comment change, turned the ObjC test into a non-fixture test, and renamed FormatStyleOrError to FormatStyle in format function.
Jan 2 2017
More changes as suggested by @ioeric. I asked a question earlier about clang-tools-extras and understanding how not to break the build bots. If you can shed some light on that, I'd appreciate it, thanks :)
Reverted the FallbackStyle code and added a FIXME as @ioeric suggested. I'll fix the fallback style "none" bug in a separate change.
Jan 1 2017
Dec 31 2016
Hello everyone, so after a few more tests, I've uncovered a bug and perhaps a different meaning for fallback style. First, the bug: if you set fallback style to "none", clang-format will perform no replacements. This happens because getStyle will first initialize its local Style variable to LLVM style, and then because a fallback style is set, will then set it to the "none" style, will ends up setting Style.DisableFormatting to true. After that, when we parse YAML (either from Style arg or a config file), we use the Style variable as the "template" for fields that haven't been set. In this case, the "none" fallback style causes DisableFormatting to remain true, so no formatting will take place.
Dec 29 2016
Updated with the changes @ioeric suggested.
Dec 28 2016
Dec 27 2016
Thank you, @ioeric for your feedback!
Dec 24 2016
One more thing I forgot to mention is that this change comes from a discussion we had on this other change: https://reviews.llvm.org/D27440 where @djasper agreed that "fallback-style should only be used when there is no .clang-format file. If we find one, and it doesn't parse correctly, we should neither use the fallback style nor scan in higher-level directories (not sure whether we currently do that).".
Dec 23 2016
This change works, and passes all tests; however, I have a bunch of questions, which you'll find in the diffs. I look forward to your feedback. Thanks!
Dec 21 2016
Dec 20 2016
As agreed, modified getStyle to make use of vfs::FileSystem::makeAbsolute. I would modify the body of the commit as follows:
Dec 19 2016
Updated screenshot:
Added "na" format specifier to not show the pointer address to the string, just like the original visualizer did. Updated screenshot of what it looks like forthcoming...
Goes from:
to:
Dec 18 2016
Dec 16 2016
Dec 15 2016
Hi @djasper, just curious about your opinion on this change, and on the conversation following it, specifically regarding whether clang-format should really use the fallback style when failing to parse a .clang-format file. Thanks!
Hi @djasper, just curious about your opinion on this change, and on the conversation following it, specifically regarding whether clang-format should really use the fallback style when failing to parse a .clang-format file. Thanks!
Dec 12 2016
Dec 9 2016
(NOTE, I forgot to click Submit on the reply to @klimek yesterday)
Dec 7 2016
Dec 6 2016
My first patch accidentally included the changes from https://reviews.llvm.org/D27440
Yes, I think this is still a worthwhile change. Let's add the hour and minute and get it landed.
Added hour and minute.