Page MenuHomePhabricator

amadio (Guilherme Amadio)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 6 2017, 8:17 AM (89 w, 4 h)

Recent Activity

Nov 28 2018

amadio abandoned D39716: Explicitly set CMake policy CMP0068 to NEW to avoid warnings.

Abandoning, equivalent change added by commit below:

Nov 28 2018, 5:19 AM
amadio abandoned D41356: Don't look for OCaml if LLVM_ENABLE_OCAMLDOC=OFF.

This patch can be dropped as it no longer applies and there is now the option to disable OCaml bindings via LLVM_ENABLE_BINDINGS.

Nov 28 2018, 5:16 AM

Dec 19 2017

amadio added a comment to D41356: Don't look for OCaml if LLVM_ENABLE_OCAMLDOC=OFF.

I patched ROOT in Gentoo to avoid the error messages, but how could OCaml bindings be turned off in LLVM if OCaml is installed at configure time? (and avoiding the package lookup if it's not needed?)
Another comment is that include(FindOCaml) and find_package(OCaml) serve more or less the same purpose, so the error message appears twice. One of the lines could be removed.

Dec 19 2017, 2:57 AM
amadio added a comment to D41356: Don't look for OCaml if LLVM_ENABLE_OCAMLDOC=OFF.

Because the "Could NOT find ..." messages interfere with automated checks of issues: https://bugs.gentoo.org/641536.
Maybe LLVM should consider at least using find_package($PKG QUIET) to avoid the unnecessary verbosity, although in the case of OCaml it didn't have any effect, due to the custom FindOCaml.cmake which does not implement the QUIET option.

Dec 19 2017, 2:35 AM

Dec 18 2017

amadio created D41356: Don't look for OCaml if LLVM_ENABLE_OCAMLDOC=OFF.
Dec 18 2017, 8:37 AM

Dec 6 2017

amadio added a comment to D33467: Fix LLVM build errors if necent build of GCC 7 is used.

The problems fixed here also happen when compiling with Clang-5.0 and C++17 enabled. What happens is that the assignment to ProfileFileName needs a conversion of PGOTestProfileFile from the opt type to std::string, but the compiler is trying to use a deleted constructor of opt instead:

Dec 6 2017, 4:12 AM

Nov 27 2017

amadio added a comment to D39716: Explicitly set CMake policy CMP0068 to NEW to avoid warnings.

Actually, I do not see the warning anymore in our builds, so maybe this patch is no longer necessary. Please feel free to discard it.

Nov 27 2017, 11:40 AM

Nov 23 2017

amadio added inline comments to D21478: [build] Link main executable with libpthread.
Nov 23 2017, 9:10 AM

Nov 7 2017

amadio created D39716: Explicitly set CMake policy CMP0068 to NEW to avoid warnings.
Nov 7 2017, 12:19 AM