- User Since
- Nov 6 2017, 8:17 AM (89 w, 4 h)
Nov 28 2018
Abandoning, equivalent change added by commit below:
This patch can be dropped as it no longer applies and there is now the option to disable OCaml bindings via LLVM_ENABLE_BINDINGS.
Dec 19 2017
I patched ROOT in Gentoo to avoid the error messages, but how could OCaml bindings be turned off in LLVM if OCaml is installed at configure time? (and avoiding the package lookup if it's not needed?)
Another comment is that include(FindOCaml) and find_package(OCaml) serve more or less the same purpose, so the error message appears twice. One of the lines could be removed.
Because the "Could NOT find ..." messages interfere with automated checks of issues: https://bugs.gentoo.org/641536.
Maybe LLVM should consider at least using find_package($PKG QUIET) to avoid the unnecessary verbosity, although in the case of OCaml it didn't have any effect, due to the custom FindOCaml.cmake which does not implement the QUIET option.
Dec 18 2017
Dec 6 2017
The problems fixed here also happen when compiling with Clang-5.0 and C++17 enabled. What happens is that the assignment to ProfileFileName needs a conversion of PGOTestProfileFile from the opt type to std::string, but the compiler is trying to use a deleted constructor of opt instead:
Nov 27 2017
Actually, I do not see the warning anymore in our builds, so maybe this patch is no longer necessary. Please feel free to discard it.