Page MenuHomePhabricator

alxu (Alex Xu (Hello71))
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 22 2018, 12:19 PM (204 w, 5 d)

Recent Activity

Apr 10 2022

alxu abandoned D123223: [lld] Ignore --no-add-needed.

https://github.com/llvm/llvm-project/commit/c29c19cb5327624dd31fcb776f8fbe66ca1011bb discussed with @MaskRay on IRC

Apr 10 2022, 8:11 AM · Restricted Project, Restricted Project

Apr 6 2022

alxu requested review of D123223: [lld] Ignore --no-add-needed.
Apr 6 2022, 8:26 AM · Restricted Project, Restricted Project

Feb 22 2022

alxu removed a reviewer for D120375: Trim unnecessary component/library dependencies.: Restricted Project.
Feb 22 2022, 6:12 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
alxu planned changes to D120375: Trim unnecessary component/library dependencies..
Feb 22 2022, 5:39 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
alxu requested review of D120375: Trim unnecessary component/library dependencies..
Feb 22 2022, 5:34 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project

Feb 4 2022

alxu added a comment to D116753: [Driver] Default to -fno-math-errno for musl too.

@alxu Just realized you don't have commit access. Do you want one of us to merge this?

Feb 4 2022, 6:47 PM · Restricted Project

Jan 26 2022

alxu updated subscribers of D116753: [Driver] Default to -fno-math-errno for musl too.

Hi, can someone take a look at this? @MaskRay, @pirama, @srhines? Thanks!

Jan 26 2022, 5:01 AM · Restricted Project

Jan 7 2022

alxu added a comment to D116755: Revert "[CodeGen] Mark fma as const for Android".

I don't have commit access; can someone commit this for me? Please use author "Alex Xu (Hello71) <alex_y_xu@yahoo.ca>". Thanks!

Jan 7 2022, 7:03 AM · Restricted Project
alxu added a comment to D116337: [clang] set __NO_MATH_ERRNO__ if -fno-math-errno.

I don't have commit access; can someone commit this for me? Please use author "Alex Xu (Hello71) <alex_y_xu@yahoo.ca>". Thanks!

Jan 7 2022, 7:03 AM · Restricted Project

Jan 6 2022

alxu updated the summary of D116753: [Driver] Default to -fno-math-errno for musl too.
Jan 6 2022, 11:53 AM · Restricted Project
alxu updated the diff for D116337: [clang] set __NO_MATH_ERRNO__ if -fno-math-errno.

Re-add context lines.

Jan 6 2022, 10:40 AM · Restricted Project
alxu updated the diff for D116337: [clang] set __NO_MATH_ERRNO__ if -fno-math-errno.

Update init.c, init-aarch64.c tests.

Jan 6 2022, 10:39 AM · Restricted Project
alxu updated the diff for D116337: [clang] set __NO_MATH_ERRNO__ if -fno-math-errno.

Correct logic, increase context.

Jan 6 2022, 9:50 AM · Restricted Project
alxu added a reverting change for rGfbfba29d7474: [CodeGen] Mark fma as const for Android: D116755: Revert "[CodeGen] Mark fma as const for Android".
Jan 6 2022, 9:21 AM
alxu added a reverting change for D44852: [CodeGen] Mark fma as const for Android: D116755: Revert "[CodeGen] Mark fma as const for Android".
Jan 6 2022, 9:21 AM
alxu updated the summary of D116755: Revert "[CodeGen] Mark fma as const for Android".
Jan 6 2022, 9:21 AM · Restricted Project
alxu requested review of D116755: Revert "[CodeGen] Mark fma as const for Android".
Jan 6 2022, 9:14 AM · Restricted Project
alxu requested review of D116753: [Driver] Default to -fno-math-errno for musl too.
Jan 6 2022, 8:54 AM · Restricted Project

Jan 5 2022

alxu updated the diff for D116337: [clang] set __NO_MATH_ERRNO__ if -fno-math-errno.

Sort test defines orthographically, not chronologically.

Jan 5 2022, 8:01 PM · Restricted Project
alxu updated the diff for D116337: [clang] set __NO_MATH_ERRNO__ if -fno-math-errno.

Try -p1 compatible diff.

Jan 5 2022, 2:13 PM · Restricted Project
alxu added inline comments to D116337: [clang] set __NO_MATH_ERRNO__ if -fno-math-errno.
Jan 5 2022, 2:04 PM · Restricted Project
alxu updated the diff for D116337: [clang] set __NO_MATH_ERRNO__ if -fno-math-errno.

Thanks for this! I'm adding some more reviewers to the list to help get this reviewed.

The patch doesn't seem to apply cleanly, so precommit CI isn't running on it. Can you rectify that?

Jan 5 2022, 2:02 PM · Restricted Project

Dec 28 2021

alxu requested review of D116337: [clang] set __NO_MATH_ERRNO__ if -fno-math-errno.
Dec 28 2021, 11:22 AM · Restricted Project

Sep 7 2020

alxu abandoned D49652: Apply -fdebug-prefix-map in reverse of command line order.
Sep 7 2020, 10:04 AM

Jan 10 2019

alxu added a comment to D49466: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map.

FYI, according to my comment on D49652, assuming I checked it correctly, gcc applies the maps in reverse order of command line specification, not sorted order. It seems unlikely that anyone is actually depending on the order though.

Jan 10 2019, 2:41 PM · Restricted Project, Restricted Project, Restricted Project

Jul 23 2018

alxu added a comment to D49652: Apply -fdebug-prefix-map in reverse of command line order.

my general theory is that it's better to have tests that test everything at once if possible, but I guess it's unlikely enough that the debug info path will be correct in the IR and then not correct in the generated file and that that won't be caught by LLVM tests.

Jul 23 2018, 3:05 PM
alxu added a comment to D49466: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map.

FYI, gcc uses the stupid and bad string prefix matching approach. if clang supports the same option, it should have the same behavior. you could decide that it's a bad idea, but then the option should be called something else, otherwise people will have to go back to testing compiler name and versions again which is :(.

Jul 23 2018, 2:09 PM · Restricted Project, Restricted Project, Restricted Project
alxu added a comment to D49652: Apply -fdebug-prefix-map in reverse of command line order.

I was just going to run llvm-dwarfdump.

Jul 23 2018, 1:54 PM
alxu added a comment to D49652: Apply -fdebug-prefix-map in reverse of command line order.

Also, is it right to use SmallVector in one place and vector in the other? I just assumed based on the surrounding declarations, but I really have no idea.

Jul 23 2018, 8:23 AM
alxu planned changes to D49652: Apply -fdebug-prefix-map in reverse of command line order.

The test syntax looked complicated, and I assumed that the documentation was terrible, like wine's, but it's actually pretty good, so I'll give it a go. I think the order is not really surprising though. It is run from right to left, but basically it means that right options override left options, which is how most of them work, e.g. -W and -Wno work based on the rightmost toggle, same with -f and -fno, etc.

Jul 23 2018, 8:21 AM

Jul 22 2018

alxu added a comment to D49652: Apply -fdebug-prefix-map in reverse of command line order.

Oh, I forgot to mention, this is the way that gcc does it. Therefore, I expect that almost everybody either doesn't care about the order, or assumes the gcc behavior.

Jul 22 2018, 1:49 PM
alxu created D49652: Apply -fdebug-prefix-map in reverse of command line order.
Jul 22 2018, 1:45 PM