Page MenuHomePhabricator

alexshap (Alexander Shaposhnikov)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 22 2016, 3:32 PM (169 w, 3 d)

Recent Activity

Thu, Oct 17

alexshap committed rG68db51d5c677: [Object] Fix the return type of getOffset/getSize (authored by alexshap).
[Object] Fix the return type of getOffset/getSize
Thu, Oct 17, 11:49 AM
alexshap committed rL375154: [Object] Fix the return type of getOffset/getSize.
[Object] Fix the return type of getOffset/getSize
Thu, Oct 17, 11:49 AM
alexshap closed D69126: [Object] Fix the return type of getOffset/getSize.
Thu, Oct 17, 11:49 AM · Restricted Project
alexshap updated the summary of D69126: [Object] Fix the return type of getOffset/getSize.
Thu, Oct 17, 11:31 AM · Restricted Project
alexshap created D69126: [Object] Fix the return type of getOffset/getSize.
Thu, Oct 17, 11:30 AM · Restricted Project

Wed, Oct 16

alexshap added a comment to D65541: [llvm-objcopy][MachO] Implement --only-section.

@seiya - thanks for all your work, I'm wondering - can you commit this change / is there anything blocking this diff ?

Wed, Oct 16, 3:26 PM · Restricted Project
alexshap accepted D65541: [llvm-objcopy][MachO] Implement --only-section.
Wed, Oct 16, 6:18 AM · Restricted Project

Tue, Oct 15

alexshap committed rG4f2f9c00b978: [llvm-lipo] Add missing cast (authored by alexshap).
[llvm-lipo] Add missing cast
Tue, Oct 15, 1:10 PM
alexshap committed rL374945: [llvm-lipo] Add missing cast.
[llvm-lipo] Add missing cast
Tue, Oct 15, 1:10 PM
alexshap closed D68966: [llvm-lipo] Add missing cast.

(committed (r374945))

Tue, Oct 15, 1:10 PM · Restricted Project

Mon, Oct 14

alexshap created D68966: [llvm-lipo] Add missing cast.
Mon, Oct 14, 6:14 PM · Restricted Project

Fri, Oct 11

alexshap committed rGb42e679a4bde: [llvm-lipo] Pass ArrayRef by value. (authored by alexshap).
[llvm-lipo] Pass ArrayRef by value.
Fri, Oct 11, 11:13 PM
alexshap committed rL374637: [llvm-lipo] Pass ArrayRef by value..
[llvm-lipo] Pass ArrayRef by value.
Fri, Oct 11, 11:13 PM

Mon, Oct 7

alexshap committed rGf5d700ac05cb: [llvm-lipo] Relax the check of the specified input file architecture (authored by alexshap).
[llvm-lipo] Relax the check of the specified input file architecture
Mon, Oct 7, 10:20 PM
alexshap committed rL373966: [llvm-lipo] Relax the check of the specified input file architecture.
[llvm-lipo] Relax the check of the specified input file architecture
Mon, Oct 7, 10:20 PM
alexshap closed D68319: [llvm-lipo] Relax the check of the specified input file architecture.
Mon, Oct 7, 7:51 PM · Restricted Project
alexshap accepted D68594: [llvm-lipo] Add TextAPI to LINK_COMPONENTS.

ok, thanks

Mon, Oct 7, 7:17 PM · Restricted Project

Wed, Oct 2

alexshap accepted D66449: [llvm-objcopy] Accept MachO formats in commad-line parsing.
Wed, Oct 2, 4:16 AM · Restricted Project
alexshap updated the diff for D68319: [llvm-lipo] Relax the check of the specified input file architecture.

fix formatting

Wed, Oct 2, 2:16 AM · Restricted Project

Tue, Oct 1

alexshap created D68319: [llvm-lipo] Relax the check of the specified input file architecture.
Tue, Oct 1, 10:20 PM · Restricted Project
alexshap added inline comments to D66280: [llvm-objcopy][MachO] Support indirect symbol table.
Tue, Oct 1, 2:18 PM · Restricted Project
alexshap accepted D66280: [llvm-objcopy][MachO] Support indirect symbol table.
Tue, Oct 1, 2:04 PM · Restricted Project

Fri, Sep 27

alexshap committed rGfa6584c54216: [llvm-lipo] Add support for -arch (authored by alexshap).
[llvm-lipo] Add support for -arch
Fri, Sep 27, 3:40 PM
alexshap committed rL373132: [llvm-lipo] Add support for -arch .
[llvm-lipo] Add support for -arch
Fri, Sep 27, 3:32 PM
alexshap closed D68116: [llvm-lipo] Add support for -arch.
Fri, Sep 27, 3:31 PM · Restricted Project
alexshap added a comment to D68146: [FileCheck] Implement --ignore-case option..

Oh, this is painful.
I'm curious - what do you think about some other options, e.g. about extending FileCheck to add support for case insensitiveness,
but maybe smb else might have a better idea

Fri, Sep 27, 2:28 PM · Restricted Project

Thu, Sep 26

alexshap created D68116: [llvm-lipo] Add support for -arch.
Thu, Sep 26, 8:31 PM · Restricted Project
alexshap committed rL373030: Request commit access for alexshap.
Request commit access for alexshap
Thu, Sep 26, 4:17 PM

Mon, Sep 23

alexshap committed rG2eef85e24727: [llvm-lipo] Add support for archives (authored by alexshap).
[llvm-lipo] Add support for archives
Mon, Sep 23, 3:28 PM
alexshap committed rL372666: [llvm-lipo] Add support for archives .
[llvm-lipo] Add support for archives
Mon, Sep 23, 3:25 PM
alexshap closed D67758: [llvm-lipo] Add support for archives.
Mon, Sep 23, 3:24 PM · Restricted Project
alexshap added inline comments to D67758: [llvm-lipo] Add support for archives.
Mon, Sep 23, 2:12 PM · Restricted Project

Sep 20 2019

alexshap updated the diff for D67758: [llvm-lipo] Add support for archives.

fix minor issues

Sep 20 2019, 5:44 PM · Restricted Project
alexshap updated the diff for D67758: [llvm-lipo] Add support for archives.

Address review comments

Sep 20 2019, 1:53 PM · Restricted Project
alexshap added inline comments to D67758: [llvm-lipo] Add support for archives.
Sep 20 2019, 12:32 PM · Restricted Project

Sep 19 2019

alexshap created D67758: [llvm-lipo] Add support for archives.
Sep 19 2019, 5:12 AM · Restricted Project

Sep 18 2019

alexshap committed rG4fd11c1e456e: [Object] Extend MachOUniversalBinary::getObjectForArch (authored by alexshap).
[Object] Extend MachOUniversalBinary::getObjectForArch
Sep 18 2019, 5:05 PM
alexshap committed rL372278: [Object] Extend MachOUniversalBinary::getObjectForArch.
[Object] Extend MachOUniversalBinary::getObjectForArch
Sep 18 2019, 5:05 PM
alexshap closed D67700: [Object] Extend MachOUniversalBinary::getObjectForArch.
Sep 18 2019, 5:05 PM · Restricted Project
alexshap accepted D67139: [llvm-objcopy] Refactor ELF-specific config out to ELFCopyConfig. NFC..
Sep 18 2019, 4:10 PM · Restricted Project
alexshap added inline comments to D67700: [Object] Extend MachOUniversalBinary::getObjectForArch.
Sep 18 2019, 1:08 PM · Restricted Project
alexshap updated the diff for D67700: [Object] Extend MachOUniversalBinary::getObjectForArch.
Sep 18 2019, 2:49 AM · Restricted Project
alexshap created D67700: [Object] Extend MachOUniversalBinary::getObjectForArch.
Sep 18 2019, 2:40 AM · Restricted Project

Sep 16 2019

alexshap accepted D67618: [docs] Make --version text more correct.
Sep 16 2019, 3:16 PM · Restricted Project
alexshap added a comment to D67139: [llvm-objcopy] Refactor ELF-specific config out to ELFCopyConfig. NFC..

for what it's worth - i was thinking about it for some time,
it seems to me that using inheritance here would look more complicated + would require a bit more code.
Somehow it feels better to me when there is only one instance of CopyConfig (and it's not moved around).
(yeah, some fields would be populated only when the format of the input is known, but overall this looks kinda simpler to me)
(but i don't want to insist)

Sep 16 2019, 1:59 PM · Restricted Project

Sep 13 2019

alexshap added inline comments to D67139: [llvm-objcopy] Refactor ELF-specific config out to ELFCopyConfig. NFC..
Sep 13 2019, 10:51 AM · Restricted Project
alexshap added inline comments to D67139: [llvm-objcopy] Refactor ELF-specific config out to ELFCopyConfig. NFC..
Sep 13 2019, 3:05 AM · Restricted Project

Sep 5 2019

alexshap added a comment to D66613: [support][llvm-objcopy] Add support for shell wildcards.

khm, I don't insist, but personally I would split out the changes in lib/Support and the corresponding unit tests into a separate patch

Sep 5 2019, 11:14 AM · Restricted Project

Sep 4 2019

alexshap added a comment to D67139: [llvm-objcopy] Refactor ELF-specific config out to ELFCopyConfig. NFC..

P.S. i'm ok with @jhenderson's suggestion.

Sep 4 2019, 9:52 AM · Restricted Project
alexshap added a comment to D67139: [llvm-objcopy] Refactor ELF-specific config out to ELFCopyConfig. NFC..

just want to mention a slightly different approach:

Sep 4 2019, 12:05 AM · Restricted Project

Sep 3 2019

alexshap added a comment to D66281: [llvm-objcopy][MachO] Implement --strip-all.

@seyia, sorry about the delays with code review, does this particular diff have any unreviewed dependencies ?

Sep 3 2019, 3:20 PM · Restricted Project
alexshap accepted D66281: [llvm-objcopy][MachO] Implement --strip-all.

LG

Sep 3 2019, 3:20 PM · Restricted Project

Aug 20 2019

alexshap added a comment to D66407: [llvm-objcopy][MachO] Implement -Ibinary.

I'll take a closer look at this diff this week, sorry about the delay

Aug 20 2019, 3:07 PM · Restricted Project

Aug 19 2019

alexshap accepted D66408: [llvm-objcopy][MachO] Implement --dump-section.

LG!

Aug 19 2019, 3:37 PM · Restricted Project

Aug 16 2019

alexshap added a comment to D65540: [llvm-objcopy][MachO] Fix method names. NFC..

@seiya i think this diff is safe to commit (if it has not been committed yet)

Aug 16 2019, 12:09 AM · Restricted Project

Aug 15 2019

alexshap added a comment to D65539: [llvm-objcopy][MachO] Implement a layout algorithm for executables.

LGTM

Aug 15 2019, 9:56 AM · Restricted Project
alexshap accepted D65539: [llvm-objcopy][MachO] Implement a layout algorithm for executables.
Aug 15 2019, 9:52 AM · Restricted Project

Aug 14 2019

alexshap added a comment to D65539: [llvm-objcopy][MachO] Implement a layout algorithm for executables.

in general i like the approach, i have added a few minor comments and one question (maybe I'm missing smth).

Aug 14 2019, 12:57 PM · Restricted Project
alexshap accepted D66075: [llvm-readobj][MachO] Fix section type printing.

LG, thanks!

Aug 14 2019, 5:33 AM · Restricted Project

Aug 11 2019

alexshap added inline comments to D65832: [llvm-readelf] Implement note parsing for NT_FILE and unknown descriptors.
Aug 11 2019, 7:39 AM · Restricted Project

Aug 9 2019

alexshap accepted D65799: [yaml2obj/obj2yaml][MachO] Allow setting custom section data.
Aug 9 2019, 1:27 PM · Restricted Project
alexshap added a comment to D65799: [yaml2obj/obj2yaml][MachO] Allow setting custom section data.

LG, thanks for working on this!

Aug 9 2019, 1:27 PM · Restricted Project

Aug 7 2019

alexshap added inline comments to D65799: [yaml2obj/obj2yaml][MachO] Allow setting custom section data.
Aug 7 2019, 10:41 PM · Restricted Project

Aug 6 2019

alexshap accepted D65676: [llvm-lipo] Update llvm-lipo docs for -info -thin -create -replace -segalign flags.
Aug 6 2019, 9:10 PM · Restricted Project

Aug 5 2019

alexshap added inline comments to D65774: Removing redundant-move warnings generated by gcc9x..
Aug 5 2019, 9:29 PM · Restricted Project

Aug 1 2019

alexshap added inline comments to D65541: [llvm-objcopy][MachO] Implement --only-section.
Aug 1 2019, 1:42 AM · Restricted Project
alexshap added inline comments to D65541: [llvm-objcopy][MachO] Implement --only-section.
Aug 1 2019, 1:32 AM · Restricted Project

Jul 31 2019

alexshap accepted D65540: [llvm-objcopy][MachO] Fix method names. NFC..
Jul 31 2019, 4:43 PM · Restricted Project

Jul 30 2019

alexshap accepted D65420: [llvm-lipo] Implement -segalign.
Jul 30 2019, 2:40 PM · Restricted Project
alexshap accepted D65477: [build] add the ability to create a symlink for lipo.
Jul 30 2019, 2:33 PM · Restricted Project

Jul 29 2019

alexshap added inline comments to D65420: [llvm-lipo] Implement -segalign.
Jul 29 2019, 3:46 PM · Restricted Project

Jul 24 2019

alexshap accepted D65247: [llvm-lipo] Implement -replace.

LG

Jul 24 2019, 3:25 PM · Restricted Project
alexshap added inline comments to D65247: [llvm-lipo] Implement -replace.
Jul 24 2019, 3:23 PM · Restricted Project
alexshap added inline comments to D64871: [llvm-lipo] Implement alignment function in -create.
Jul 24 2019, 2:27 PM · Restricted Project
alexshap added a comment to D65191: [llvm-objdump] Implement highlighting.

i think the title of the diff should be adjusted a bit: 's/llvm-objcopy/llvm-objdump/g'

Jul 24 2019, 12:31 AM · Restricted Project
alexshap accepted D63395: [llvm-objcopy][MachO] Support load commands used in executables/shared libraries.
Jul 24 2019, 12:10 AM · Restricted Project

Jul 23 2019

alexshap accepted D65117: [llvm-Object] Added public MaxSectionAlignment to MachOUniversal.
Jul 23 2019, 5:03 PM · Restricted Project
alexshap added a comment to D63395: [llvm-objcopy][MachO] Support load commands used in executables/shared libraries.

the code looks good to me, but we need tests. I'd add simple tests which take YAML (similarly to how the existing tests work), generate MachO (using yaml2obj), copy it using llvm-objcopy,
dump the results (using llvm-readobj and obj2yamal) and verify that the output is what we expect. Plus those tools will parse the binary generated by llvm-objcopy thus they will verify (to some extent) that we have built a valid MachO object file.

Jul 23 2019, 3:36 PM · Restricted Project

Jul 20 2019

alexshap added inline comments to D64871: [llvm-lipo] Implement alignment function in -create.
Jul 20 2019, 2:00 PM · Restricted Project

Jul 17 2019

alexshap added inline comments to D63395: [llvm-objcopy][MachO] Support load commands used in executables/shared libraries.
Jul 17 2019, 10:41 AM · Restricted Project
alexshap added inline comments to D63395: [llvm-objcopy][MachO] Support load commands used in executables/shared libraries.
Jul 17 2019, 10:36 AM · Restricted Project
alexshap added a reviewer for D63395: [llvm-objcopy][MachO] Support load commands used in executables/shared libraries: compnerd.
Jul 17 2019, 10:33 AM · Restricted Project
alexshap added a comment to D63395: [llvm-objcopy][MachO] Support load commands used in executables/shared libraries.

it's simply a very very busy season

Jul 17 2019, 7:42 AM · Restricted Project
alexshap added a comment to D63395: [llvm-objcopy][MachO] Support load commands used in executables/shared libraries.

sorry about the delay, will get to these reviews today

Jul 17 2019, 7:40 AM · Restricted Project

Jul 15 2019

alexshap added inline comments to D64668: [llvm-lipo] Implement -info.
Jul 15 2019, 2:21 PM · Restricted Project
alexshap accepted D64668: [llvm-lipo] Implement -info.

LG

Jul 15 2019, 2:18 PM · Restricted Project
alexshap added inline comments to D64668: [llvm-lipo] Implement -info.
Jul 15 2019, 12:23 PM · Restricted Project
alexshap accepted D64668: [llvm-lipo] Implement -info.
Jul 15 2019, 12:12 PM · Restricted Project
alexshap added inline comments to D64668: [llvm-lipo] Implement -info.
Jul 15 2019, 12:10 PM · Restricted Project
alexshap added inline comments to D64668: [llvm-lipo] Implement -info.
Jul 15 2019, 12:08 PM · Restricted Project
alexshap added inline comments to D64668: [llvm-lipo] Implement -info.
Jul 15 2019, 10:34 AM · Restricted Project
alexshap added inline comments to D64668: [llvm-lipo] Implement -info.
Jul 15 2019, 7:52 AM · Restricted Project
alexshap added inline comments to D64668: [llvm-lipo] Implement -info.
Jul 15 2019, 4:35 AM · Restricted Project

Jul 14 2019

alexshap added inline comments to D64668: [llvm-lipo] Implement -info.
Jul 14 2019, 6:50 PM · Restricted Project

Jul 3 2019

alexshap added inline comments to D64102: [llvm-lipo] Implement -create part 1.
Jul 3 2019, 3:48 PM · Restricted Project
alexshap added inline comments to D64102: [llvm-lipo] Implement -create part 1.
Jul 3 2019, 3:44 PM · Restricted Project
alexshap accepted D64102: [llvm-lipo] Implement -create part 1.

I've added a couple of minor comments, but other than that - looks good to me) I'd wait for @mtrent 's approval as well

Jul 3 2019, 3:42 PM · Restricted Project

Jul 2 2019

alexshap added inline comments to D64102: [llvm-lipo] Implement -create part 1.
Jul 2 2019, 3:43 PM · Restricted Project

Jun 24 2019

alexshap accepted D63735: [MachOObjectFile]Added Valid Architecture Function.

LG

Jun 24 2019, 4:01 PM · Restricted Project
alexshap added inline comments to D63735: [MachOObjectFile]Added Valid Architecture Function.
Jun 24 2019, 2:38 PM · Restricted Project