Page MenuHomePhabricator

alexshap (Alexander Shaposhnikov)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 22 2016, 3:32 PM (135 w, 16 h)

Recent Activity

Mon, Feb 4

alexshap added inline comments to D57618: [ADT] Add a fallible_iterator wrapper..
Mon, Feb 4, 2:51 PM · Restricted Project
alexshap added inline comments to D57618: [ADT] Add a fallible_iterator wrapper..
Mon, Feb 4, 2:42 PM · Restricted Project
alexshap added inline comments to D57517: [llvm-objcopy] Allow using regex in name comparison.
Mon, Feb 4, 12:02 AM · Restricted Project

Sun, Feb 3

alexshap added inline comments to D57517: [llvm-objcopy] Allow using regex in name comparison.
Sun, Feb 3, 9:58 PM · Restricted Project
alexshap added inline comments to D57517: [llvm-objcopy] Allow using regex in name comparison.
Sun, Feb 3, 9:42 PM · Restricted Project

Fri, Feb 1

alexshap committed rL352950: [llvm-objcopy] Temporarily limit one test to darwin.
[llvm-objcopy] Temporarily limit one test to darwin
Fri, Feb 1, 9:00 PM
alexshap committed rL352947: [llvm-objcopy] Fix triples in macho tests..
[llvm-objcopy] Fix triples in macho tests.
Fri, Feb 1, 6:04 PM
alexshap committed rL352944: [llvm-objcopy] Add ability to copy MachO object files.
[llvm-objcopy] Add ability to copy MachO object files
Fri, Feb 1, 4:38 PM
alexshap closed D54674: [llvm-objcopy] First bits for MachO .
Fri, Feb 1, 4:38 PM · Restricted Project

Tue, Jan 29

alexshap accepted D57423: [llvm-objcopy][NFC] More error propagation.
Tue, Jan 29, 5:29 PM

Fri, Jan 25

alexshap accepted D57217: llvm-objcopy: Add support for -g as an alias for --strip-debug.
Fri, Jan 25, 12:49 AM
alexshap added a comment to D57217: llvm-objcopy: Add support for -g as an alias for --strip-debug.

I agree with Jordan regarding tests, otherwise this change looks good to me.

Fri, Jan 25, 12:17 AM

Thu, Jan 24

alexshap added inline comments to D57217: llvm-objcopy: Add support for -g as an alias for --strip-debug.
Thu, Jan 24, 9:01 PM
alexshap added inline comments to D57217: llvm-objcopy: Add support for -g as an alias for --strip-debug.
Thu, Jan 24, 8:47 PM
alexshap accepted D56806: [llvm-objcopy] Fix crash when writing empty binary output.

thanks!

Thu, Jan 24, 10:35 AM

Jan 18 2019

alexshap accepted D56683: [llvm-objcopy] [COFF] Add support for removing sections.
Jan 18 2019, 2:56 PM
alexshap accepted D56930: [llvm-objcopy] Return Error from Buffer::allocate(), [ELF]Writer::finalize(), and [ELF]Writer::commit().

i have one inline comment, but otherwise this looks good to me

Jan 18 2019, 2:49 PM
alexshap added inline comments to D56683: [llvm-objcopy] [COFF] Add support for removing sections.
Jan 18 2019, 2:43 PM

Jan 17 2019

alexshap added inline comments to D56806: [llvm-objcopy] Fix crash when writing empty binary output.
Jan 17 2019, 7:58 PM
alexshap added inline comments to D56683: [llvm-objcopy] [COFF] Add support for removing sections.
Jan 17 2019, 5:07 PM
alexshap added inline comments to D56806: [llvm-objcopy] Fix crash when writing empty binary output.
Jan 17 2019, 4:52 PM

Jan 10 2019

alexshap added a comment to D56570: [llvm-objcopy] Use SHT_NOTE for added note sections..

I'd probably modify the test (to make it work on Windows (if it doesn't)) (or add a comment why it works if it does), other than that (and one minor inline comment) this diff looks like the right fix to me.

Jan 10 2019, 10:56 PM

Jan 9 2019

alexshap added a comment to D56513: [llvm-objcopy][NFC] Consistenly use two dashes for flags in tests..

on the other hand, i don't really have strong objections against using two dashes if you really want that consistency, not a big deal imo.

Jan 9 2019, 3:33 PM
alexshap added a comment to D56513: [llvm-objcopy][NFC] Consistenly use two dashes for flags in tests..

tbh i'm not sure about all the cases here (+ not sure if it's really worth doing),
one dash / two dashes - these things are described in tablegen opts files,
i remember there was a bug when 'one dash' was working while 'two dashes' wasn't (i don't already remember the details unfortunately),
so having at least some tests for both is not useless imo.

Jan 9 2019, 3:27 PM

Jan 7 2019

alexshap accepted D55881: [llvm-objcopy] [COFF] Add support for removing symbols.
Jan 7 2019, 3:15 PM
alexshap added inline comments to D55881: [llvm-objcopy] [COFF] Add support for removing symbols.
Jan 7 2019, 2:33 PM
alexshap added inline comments to D55881: [llvm-objcopy] [COFF] Add support for removing symbols.
Jan 7 2019, 2:29 PM

Jan 4 2019

alexshap accepted D56294: [ObjectYAML] [COFF] Support multiple symbols with the same name.

LGTM with one minor nit

Jan 4 2019, 3:41 PM
alexshap added inline comments to D56294: [ObjectYAML] [COFF] Support multiple symbols with the same name.
Jan 4 2019, 2:47 PM

Jan 2 2019

alexshap accepted D56140: [llvm-readobj] [COFF] Print the symbol index for relocations.
Jan 2 2019, 3:20 PM
alexshap added a comment to D54674: [llvm-objcopy] First bits for MachO .

@echristo, oh, i see, thanks.

Jan 2 2019, 11:08 AM · Restricted Project
alexshap added a comment to D54674: [llvm-objcopy] First bits for MachO .

@lhames , can we proceed here ?

Jan 2 2019, 11:00 AM · Restricted Project

Dec 31 2018

alexshap added inline comments to D56140: [llvm-readobj] [COFF] Print the symbol index for relocations.
Dec 31 2018, 10:25 PM

Dec 29 2018

alexshap added a reviewer for D56140: [llvm-readobj] [COFF] Print the symbol index for relocations: alexshap.
Dec 29 2018, 12:48 AM

Dec 20 2018

alexshap added inline comments to D55881: [llvm-objcopy] [COFF] Add support for removing symbols.
Dec 20 2018, 7:10 PM
alexshap accepted D55922: [llvm-objcopy] [COFF] Use Error/Expected returns instead of calling reportError. NFC..

I think this is a step in the right direction, although now we have some inconsistency with the existing code, but okay, I hope we will change the old code in the future as well. Plus I will change the not yet committed code for MachO myself.

Dec 20 2018, 4:37 PM
alexshap added inline comments to D54674: [llvm-objcopy] First bits for MachO .
Dec 20 2018, 4:24 PM · Restricted Project

Dec 19 2018

alexshap added a comment to D54674: [llvm-objcopy] First bits for MachO .

Thanks, definitely I'll wait for @lhames

Dec 19 2018, 1:20 PM · Restricted Project
alexshap updated the diff for D54674: [llvm-objcopy] First bits for MachO .

Address comments + rename some files for consistency with coff. @lhames , @jakehehrlich - if you find a minute to have a look at this new version - that will be wonderful, many thanks in advance

Dec 19 2018, 2:05 AM · Restricted Project
alexshap added inline comments to D54674: [llvm-objcopy] First bits for MachO .
Dec 19 2018, 1:56 AM · Restricted Project

Dec 18 2018

alexshap added a comment to D54939: [llvm-objcopy] Initial COFF support.

on my side i think this is fine, I don't want to block this diff.
I would wait for Jake since he is the code owner for llvm-objcopy, but to me this looks good enough (to start the ball rolling).

Dec 18 2018, 10:43 AM

Dec 14 2018

alexshap added inline comments to D54939: [llvm-objcopy] Initial COFF support.
Dec 14 2018, 12:55 PM
alexshap added a comment to D54939: [llvm-objcopy] Initial COFF support.

@jakehehrlich , @jhenderson - are there any concerns with moving this forward ?

Dec 14 2018, 11:35 AM
alexshap accepted D54939: [llvm-objcopy] Initial COFF support.
Dec 14 2018, 11:35 AM
alexshap added a comment to D54939: [llvm-objcopy] Initial COFF support.

I've looked at the code, there are few minor nits, but to me this code looks like a pretty good start, many thanks for working on this ))

Dec 14 2018, 11:35 AM

Dec 13 2018

alexshap added a comment to D54939: [llvm-objcopy] Initial COFF support.

that's fine, my point was to "unload" some code from Object.cpp, in particular, the serialization/deserialization into separate files. (probably it won't change that much in the future, but the code for modifying Object will evolve as more features will be added).

Dec 13 2018, 3:28 PM
alexshap added a comment to D54939: [llvm-objcopy] Initial COFF support.

sorry about the delay, I've also pinged some other people who know coff better than I do (at the moment).
What do think about keeping the implementation of Reader and Writer in their own files, and (in the future) put into Object.cpp only the logic for
modifying the "intermediate representation" (mutations of COFF) ?

Dec 13 2018, 2:16 PM

Dec 11 2018

alexshap accepted D55564: [lit]Add llvm-readelf to tool substitutions.

oh, i see.

Dec 11 2018, 9:37 AM

Dec 7 2018

alexshap planned changes to D54674: [llvm-objcopy] First bits for MachO .

will address the comments and update this diff, huge thanks for the review

Dec 7 2018, 11:17 AM · Restricted Project

Dec 6 2018

alexshap added a comment to D54674: [llvm-objcopy] First bits for MachO .

Hey! I've recently pinged multiple people via e-mail (sorry about the disturbance, I apologize for all the inconveniences and I do understand that people are probably very busy given that it's the end of the half),
@mtrent, @beanz , @ributzka @lhames, @echristo, @compnerd - just give me an idea if any of you will eventually have a look at it (imo it'd be good to have people from Apple involved in the code review since this code is for MachO, who knows - maybe you will find it useful at some point - i.e. as a potential replacement/replacements for cctools in the future). If it's not super-interesting - then it's okay...., let's just make some decision if there is a way to move forward here (which you would be comfortable with) or not. (The main reason why I'm bothering you & asking this question - this diff has been around for 3+ weeks without much visible progress)

Dec 6 2018, 3:52 PM · Restricted Project
alexshap added inline comments to D54674: [llvm-objcopy] First bits for MachO .
Dec 6 2018, 3:43 PM · Restricted Project

Dec 3 2018

alexshap added a comment to D54674: [llvm-objcopy] First bits for MachO .

@beanz Chris, would you have a minute to have a look at this diff ? (though this is just the beginning, so things will change)

Dec 3 2018, 10:33 AM · Restricted Project
alexshap added a reviewer for D54674: [llvm-objcopy] First bits for MachO : beanz.
Dec 3 2018, 10:28 AM · Restricted Project
alexshap added inline comments to D54939: [llvm-objcopy] Initial COFF support.
Dec 3 2018, 10:20 AM

Nov 29 2018

alexshap committed rL347958: [llvm-objcopy] Move elf-specific tests into subfolder.
[llvm-objcopy] Move elf-specific tests into subfolder
Nov 29 2018, 9:48 PM
alexshap added a comment to D54939: [llvm-objcopy] Initial COFF support.

i will get to this diff early next week, sorry about the delay. A small side note - probably the simple changes to include/llvm/Object/COFF.h can be factored out from this diff and reviewed separately (and probably much faster).

Nov 29 2018, 9:23 PM
alexshap updated subscribers of D54939: [llvm-objcopy] Initial COFF support.
Nov 29 2018, 9:20 PM
alexshap added inline comments to D54674: [llvm-objcopy] First bits for MachO .
Nov 29 2018, 8:30 PM · Restricted Project
alexshap added inline comments to D54674: [llvm-objcopy] First bits for MachO .
Nov 29 2018, 7:58 PM · Restricted Project
alexshap added inline comments to D54674: [llvm-objcopy] First bits for MachO .
Nov 29 2018, 7:53 PM · Restricted Project

Nov 28 2018

alexshap accepted D55040: [llvm-objcopy] Delete redundant !Config.xx.empty() when followed by positive is_contained() check.

Thanks for cleaning this up.

Nov 28 2018, 9:28 PM

Nov 26 2018

alexshap added a comment to D54674: [llvm-objcopy] First bits for MachO .

Ping @echristo Eric, could you please help review this patch / or add smb else ?

Nov 26 2018, 2:10 PM · Restricted Project

Nov 19 2018

alexshap added a reviewer for D54674: [llvm-objcopy] First bits for MachO : echristo.
Nov 19 2018, 8:06 PM · Restricted Project
alexshap added a comment to D54674: [llvm-objcopy] First bits for MachO .

ok, no worries, if smb has a look at it next week - that will be wonderful. Many thanks.

Nov 19 2018, 2:28 PM · Restricted Project
alexshap added a comment to D54674: [llvm-objcopy] First bits for MachO .

@mstorsjo, no, I'm not working on COFF, i have a fe

Nov 19 2018, 1:45 PM · Restricted Project
alexshap added a comment to D54674: [llvm-objcopy] First bits for MachO .

also, @jakehehrlich, @jhenderson, @rupprecht - what would you say to moving the existing tests (llvm/test/tools/llvm-objcopy) into the subfolder ELF (llvm/test/tools/llvm-objcopy/ELF) ? if it's ok - i can do that on a separate diff.

Nov 19 2018, 11:58 AM · Restricted Project
alexshap updated the diff for D54674: [llvm-objcopy] First bits for MachO .

one more typo fixed

Nov 19 2018, 11:54 AM · Restricted Project
alexshap updated subscribers of D54674: [llvm-objcopy] First bits for MachO .
Nov 19 2018, 11:45 AM · Restricted Project
alexshap added a comment to D54674: [llvm-objcopy] First bits for MachO .

@jhenderson, yeah, this is the minimal amount of code i was able to come up with for coping over MachO object files without modifications, so essentially the only useful (hopefully) things here are serialization/deserialization. The "intermediate" model is a stub and will change in the future. However, even with this minimal capabilities we can do smth useful (in the nearest future), in particular, in a follow-up patch i was planning to add support for "fat" (universal) binaries, and as soon as it is done (together with this patch) we will be able to build an llvm-based drop-in replacement for the tool "lipo".

Nov 19 2018, 11:45 AM · Restricted Project
alexshap updated the diff for D54674: [llvm-objcopy] First bits for MachO .

Address comments, improve the tests, fix some typos.

Nov 19 2018, 11:37 AM · Restricted Project

Nov 17 2018

alexshap updated the diff for D54674: [llvm-objcopy] First bits for MachO .

typo fixed

Nov 17 2018, 7:08 PM · Restricted Project
alexshap changed the visibility for D54674: [llvm-objcopy] First bits for MachO .
Nov 17 2018, 6:59 PM · Restricted Project
alexshap created D54674: [llvm-objcopy] First bits for MachO .
Nov 17 2018, 6:53 PM · Restricted Project

Nov 14 2018

alexshap accepted D54384: [llvm-objcopy] Add --build-id-link-dir flag.

I would probably use more detailed help messages for the new options (i.e. what exactly the last two options mean (name's suffix) and how exactly the path is constructed from the build-id),
so that users can understand what's going on without looking at the actual implementation.
other than that - LGTM

Nov 14 2018, 8:53 PM

Nov 13 2018

alexshap added inline comments to D54384: [llvm-objcopy] Add --build-id-link-dir flag.
Nov 13 2018, 11:28 PM

Nov 10 2018

alexshap added inline comments to D54384: [llvm-objcopy] Add --build-id-link-dir flag.
Nov 10 2018, 6:05 PM
alexshap added inline comments to D54384: [llvm-objcopy] Add --build-id-link-dir flag.
Nov 10 2018, 5:48 PM

Oct 31 2018

alexshap accepted D53954: [llvm-strip] Support --keep and --strip-all-gnu from llvm-objcopy.
Oct 31 2018, 6:38 PM

Oct 29 2018

alexshap committed rL345558: [analyzer] Allow padding checker to traverse simple class hierarchies.
[analyzer] Allow padding checker to traverse simple class hierarchies
Oct 29 2018, 6:23 PM
alexshap committed rC345558: [analyzer] Allow padding checker to traverse simple class hierarchies.
[analyzer] Allow padding checker to traverse simple class hierarchies
Oct 29 2018, 6:23 PM
alexshap closed D53206: Allow padding checker to traverse simple class hierarchies.
Oct 29 2018, 6:23 PM · Restricted Project
alexshap committed rL345544: [llvm-objcopy] Move elf-specific code into subfolder.
[llvm-objcopy] Move elf-specific code into subfolder
Oct 29 2018, 2:25 PM

Oct 26 2018

alexshap accepted D53782: [llvm-objcopy] Don't apply --localize flags to common symbols.
Oct 26 2018, 6:10 PM
alexshap added a reviewer for D53051: [llvm-tapi] initial commit, supports ELF text stubs: alexshap.
Oct 26 2018, 9:44 AM

Oct 25 2018

alexshap added inline comments to D53667: [llvm-objcopy] Handle -O <format> flag..
Oct 25 2018, 11:34 AM

Oct 24 2018

alexshap committed rL345217: [llvm-objcopy] Introduce dispatch mechanism based on the input.
[llvm-objcopy] Introduce dispatch mechanism based on the input
Oct 24 2018, 3:51 PM
alexshap added a comment to D53667: [llvm-objcopy] Handle -O <format> flag..

@rupprecht Jordan, if you don't mind I will commit my patch https://reviews.llvm.org/D53311 (this probably will cause some minor rebase for you), and then I will cherry-pick your changes (locally) and send my future patch (to move elf-specific things into a separate file and subfolder) on top of yours

Oct 24 2018, 3:12 PM

Oct 18 2018

alexshap added a comment to D52296: [Clang] - Add '-gsplit-dwarf[=split,=single]' version for '-gsplit-dwarf' option..

Ping

Oct 18 2018, 6:28 PM
alexshap added a comment to D52296: [Clang] - Add '-gsplit-dwarf[=split,=single]' version for '-gsplit-dwarf' option..

I talked to David @dblaikie offline about this diff yesterday, if I understood correctly this change is reasonable in general, @echristo Eric, would you mind having a look at this diff ?

Oct 18 2018, 6:28 PM

Oct 15 2018

alexshap committed rL344585: [llvm-objcopy] Factor out Buffer.
[llvm-objcopy] Factor out Buffer
Oct 15 2018, 10:42 PM
alexshap added a comment to D52296: [Clang] - Add '-gsplit-dwarf[=split,=single]' version for '-gsplit-dwarf' option..

I see, many thanks. I've cherry-picked this patch locally and played with GDB - it appears to work fine with it.
I'm also interested and support this change since this would simplify the adoption of Fission by some build systems.
@dblaikie, @echristo - are there any particular concerns with moving this forward ?

Oct 15 2018, 7:38 PM

Oct 11 2018

alexshap accepted D53029: [llvm-objcopy] Add -F|--target compatibility.

thanks, sorry for causing you to rebase

Oct 11 2018, 4:40 PM
alexshap committed rL344307: [llvm-objcopy] Factor out CopyConfig.
[llvm-objcopy] Factor out CopyConfig
Oct 11 2018, 3:36 PM

Oct 9 2018

alexshap added a comment to D52296: [Clang] - Add '-gsplit-dwarf[=split,=single]' version for '-gsplit-dwarf' option..

@grimar, this is an interesting observation which I've had on my mind for quite some time as well; a couple of things which I have not double-checked yet - just in case - do both gold and lld completely ignore dwo-related sections ? (did you check that ?), and another small question - just wondering if the debuggers (GDB and LLDB) are okay with it / or smth needs to be adjusted or fixed on their side. I guess everything should be fine, but asking just in case.

Oct 9 2018, 3:40 AM
alexshap updated subscribers of D52296: [Clang] - Add '-gsplit-dwarf[=split,=single]' version for '-gsplit-dwarf' option..
Oct 9 2018, 3:27 AM

Sep 21 2018

alexshap accepted D51841: [llvm-objcopy] Dwarf decompression support. .

but, pls, also wait for Jake or James

Sep 21 2018, 3:35 PM

Sep 20 2018

alexshap accepted D52328: [llvm-objcopy/llvm-strip]: handle --version.

I've just had a look at LLD - it does smth similar, so to me this looks good. Pls, wait for Jake as well.

Sep 20 2018, 3:43 PM
alexshap added a comment to D52182: [llvm-objcopy] Make -S an alias for --strip-all.

@jakehehrlich Jake, would you mind committing this ?

Sep 20 2018, 1:09 PM

Sep 17 2018

alexshap accepted D52180: [llvm-objcopy] Change --only-keep to --only-sections.
Sep 17 2018, 12:42 PM
alexshap accepted D52182: [llvm-objcopy] Make -S an alias for --strip-all.
Sep 17 2018, 12:41 PM