Page MenuHomePhabricator

alexshap (Alexander Shaposhnikov)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 22 2016, 3:32 PM (151 w, 2 d)

Recent Activity

Yesterday

alexshap added inline comments to D63341: [llvm-lipo] Implement -thin.
Sun, Jun 16, 3:57 PM · Restricted Project
alexshap added a comment to D62991: [yaml2obj][MachO] Don't fill dummy data for virtual sections.

i think we can commit this

Sun, Jun 16, 12:09 AM · Restricted Project

Tue, Jun 11

alexshap added inline comments to D62991: [yaml2obj][MachO] Don't fill dummy data for virtual sections.
Tue, Jun 11, 3:51 AM · Restricted Project

Mon, Jun 10

alexshap accepted D63100: [llvm-lipo] Update llvm-lipo docs for -archs flag.

I've added one inline comment, other than that - LGTM, I'd wait for @mtrent as well )

Mon, Jun 10, 3:38 PM · Restricted Project
alexshap accepted D62991: [yaml2obj][MachO] Don't fill dummy data for virtual sections.

ok, this makes sense to me now, thanks for the explanation. LGTM with a couple of inline comments

Mon, Jun 10, 2:50 PM · Restricted Project

Fri, Jun 7

alexshap committed rG85ea2de4b54b: [llvm-lipo] Add docs for llvm-lipo (authored by alexshap).
[llvm-lipo] Add docs for llvm-lipo
Fri, Jun 7, 3:03 PM
alexshap committed rL362848: [llvm-lipo] Add docs for llvm-lipo.
[llvm-lipo] Add docs for llvm-lipo
Fri, Jun 7, 3:03 PM
alexshap closed D62706: [llvm-lipo] Add docs for llvm-lipo.
Fri, Jun 7, 3:02 PM · Restricted Project

Thu, Jun 6

alexshap added a comment to D62991: [yaml2obj][MachO] Don't fill dummy data for virtual sections.

khm, could you please explain the rationale for this change ? If yaml2obj completely ignores virtual sections we won't be able to create a MachO binary containing them, moreover, even in some simple cases the round trip conversion yaml -> obj -> yaml will create a completely different binary. Having ability to create binaries with virtual sections overall seems to be useful for testing various tools etc.

Thu, Jun 6, 6:53 PM · Restricted Project
alexshap added a reviewer for D62991: [yaml2obj][MachO] Don't fill dummy data for virtual sections: alexshap.
Thu, Jun 6, 6:45 PM · Restricted Project
alexshap added a comment to D62706: [llvm-lipo] Add docs for llvm-lipo.

Thu, Jun 6, 4:29 PM · Restricted Project
alexshap added inline comments to D62706: [llvm-lipo] Add docs for llvm-lipo.
Thu, Jun 6, 4:29 PM · Restricted Project
alexshap added a comment to D62706: [llvm-lipo] Add docs for llvm-lipo.

the static html file (attached to my previous comments) contains some relative paths to various .css style sheets, so it needs to be placed into <your_build_dir>/docs/html/CommandGuide/ to be rendered correctly

Thu, Jun 6, 4:23 PM · Restricted Project
alexshap updated the diff for D62706: [llvm-lipo] Add docs for llvm-lipo.

Address @mtrent comments,

Thu, Jun 6, 4:20 PM · Restricted Project
alexshap added inline comments to D62753: [llvm-lipo] Implement -archs.
Thu, Jun 6, 3:18 PM · Restricted Project
alexshap accepted D62753: [llvm-lipo] Implement -archs.

I think this looks okay / relatively small change anyway, i don't want to block it anymore, if there are any extra comments I think we can always either revert the diff or address them post-commit.

Thu, Jun 6, 2:15 PM · Restricted Project

Wed, Jun 5

alexshap added a comment to D62652: [llvm-objcopy][MachO] Recompute and update offset/size fields in the writer.

@seiya, ok, i think if nobody comments on this diff in the coming days it's safe to proceed and commit it, I kinda don't want to block it and I'm looking forward to more tests in the follow-up patches .

Wed, Jun 5, 6:57 PM · Restricted Project
alexshap added a reviewer for D62706: [llvm-lipo] Add docs for llvm-lipo: lhames.
Wed, Jun 5, 2:53 PM · Restricted Project
alexshap added a comment to D62706: [llvm-lipo] Add docs for llvm-lipo.

Ping) @mtrent @lhames

Wed, Jun 5, 2:53 PM · Restricted Project

Tue, Jun 4

alexshap accepted D62652: [llvm-objcopy][MachO] Recompute and update offset/size fields in the writer.

so in general this looks very promising to me,
however test coverage needs improvements imo, though given that at the moment we don't expose any non-trivial options here, we can add more tests incrementally. Btw - for DYSYMTAB, SYMTAB - is it possible to add YAML-based tests ? or yaml2obj's support is not sufficient for this ?

Tue, Jun 4, 7:01 PM · Restricted Project
alexshap accepted D62817: [test][llvm-objcopy] Test llvm-objcopy with standard streams.
Tue, Jun 4, 1:11 AM · Restricted Project

Mon, Jun 3

alexshap added inline comments to D62817: [test][llvm-objcopy] Test llvm-objcopy with standard streams.
Mon, Jun 3, 3:28 PM · Restricted Project
alexshap added inline comments to D62652: [llvm-objcopy][MachO] Recompute and update offset/size fields in the writer.
Mon, Jun 3, 3:07 PM · Restricted Project
alexshap added inline comments to D60974: Clang IFSO driver action..
Mon, Jun 3, 2:27 PM · Restricted Project, Restricted Project

Fri, May 31

alexshap added inline comments to D62753: [llvm-lipo] Implement -archs.
Fri, May 31, 6:11 PM · Restricted Project
alexshap added inline comments to D62753: [llvm-lipo] Implement -archs.
Fri, May 31, 6:07 PM · Restricted Project
alexshap added inline comments to D62753: [llvm-lipo] Implement -archs.
Fri, May 31, 5:56 PM · Restricted Project
alexshap added inline comments to D62753: [llvm-lipo] Implement -archs.
Fri, May 31, 5:49 PM · Restricted Project
alexshap added inline comments to D62753: [llvm-lipo] Implement -archs.
Fri, May 31, 3:56 PM · Restricted Project
alexshap added inline comments to D62753: [llvm-lipo] Implement -archs.
Fri, May 31, 3:53 PM · Restricted Project
alexshap added inline comments to D62753: [llvm-lipo] Implement -archs.
Fri, May 31, 3:46 PM · Restricted Project
alexshap added inline comments to D62753: [llvm-lipo] Implement -archs.
Fri, May 31, 3:38 PM · Restricted Project
alexshap added inline comments to D62753: [llvm-lipo] Implement -archs.
Fri, May 31, 3:35 PM · Restricted Project
alexshap added inline comments to D62753: [llvm-lipo] Implement -archs.
Fri, May 31, 3:32 PM · Restricted Project

Thu, May 30

alexshap updated the diff for D62706: [llvm-lipo] Add docs for llvm-lipo.

Change wrapping

Thu, May 30, 3:28 PM · Restricted Project
alexshap updated the diff for D62706: [llvm-lipo] Add docs for llvm-lipo.

Minor update

Thu, May 30, 3:26 PM · Restricted Project
alexshap created D62706: [llvm-lipo] Add docs for llvm-lipo.
Thu, May 30, 3:19 PM · Restricted Project
alexshap added inline comments to D62652: [llvm-objcopy][MachO] Recompute and update offset/size fields in the writer.
Thu, May 30, 1:31 PM · Restricted Project
alexshap added a comment to D62652: [llvm-objcopy][MachO] Recompute and update offset/size fields in the writer.

great start! I will take a closer look at the diff tomorrow + over the weekend

Thu, May 30, 1:09 PM · Restricted Project

Wed, May 29

alexshap added inline comments to D62578: [llvm-objcopy][MachO] Print an error message on use of unsupported options.
Wed, May 29, 3:56 AM · Restricted Project
alexshap accepted D62578: [llvm-objcopy][MachO] Print an error message on use of unsupported options.

LGTM

Wed, May 29, 3:56 AM · Restricted Project

Tue, May 28

alexshap committed rG88aed8da61f1: [tools] Introduce llvm-lipo (authored by alexshap).
[tools] Introduce llvm-lipo
Tue, May 28, 4:20 PM
alexshap committed rL361896: [tools] Introduce llvm-lipo.
[tools] Introduce llvm-lipo
Tue, May 28, 4:19 PM
alexshap closed D61927: [tools]Introduce llvm-lipo.
Tue, May 28, 4:19 PM · Restricted Project

Thu, May 23

alexshap added a reviewer for D62277: [llvm-objdump] Emit error if start address equal to stop address: alexshap.
Thu, May 23, 3:46 AM · Restricted Project

May 17 2019

alexshap changed the visibility for D61927: [tools]Introduce llvm-lipo.
May 17 2019, 4:00 PM · Restricted Project

May 16 2019

alexshap updated the diff for D61927: [tools]Introduce llvm-lipo.

Use a bigger hammer to parse command line options

May 16 2019, 12:34 AM · Restricted Project

May 15 2019

alexshap planned changes to D61927: [tools]Introduce llvm-lipo.
May 15 2019, 10:04 PM · Restricted Project
alexshap added a comment to D61927: [tools]Introduce llvm-lipo.

@mtrent, good call, will have a look and update this diff

May 15 2019, 9:48 PM · Restricted Project
alexshap added a comment to D61927: [tools]Introduce llvm-lipo.

regarding -verify_arch X Y Z - yeah, I can try to make it work with LLVM's command line options parser, not sure if this interface is ideal / better than -verify_arch X -verify_arch Y -verify_arch Z, but yeah, on the other hand, this would be an incompatibility / would require customers of the old tool to update their scripts/code. The downside of the old interface - the positional argument should go before -verify_arch. To be honest at the moment I don't see how to express the old behavior of -verify_arch using libCommandLine, any suggestions would be helpful, alternatively we can try to live with this incompatibility.

May 15 2019, 6:04 PM · Restricted Project
alexshap updated the diff for D61927: [tools]Introduce llvm-lipo.

Address comments, have not added docs in this commit yet, can do as a follow-up or will update this diff a bit later.

May 15 2019, 4:51 PM · Restricted Project

May 14 2019

alexshap planned changes to D61927: [tools]Introduce llvm-lipo.

will update this diff tomorrow

May 14 2019, 11:47 PM · Restricted Project
alexshap updated the summary of D61927: [tools]Introduce llvm-lipo.
May 14 2019, 10:59 PM · Restricted Project
alexshap added a reviewer for D61927: [tools]Introduce llvm-lipo: mtrent.
May 14 2019, 6:55 PM · Restricted Project
alexshap created D61927: [tools]Introduce llvm-lipo.
May 14 2019, 6:29 PM · Restricted Project

May 13 2019

alexshap added a reviewer for D61082: llvm-nm and llvm-objcopy belong to toolchain: compnerd.
May 13 2019, 5:14 PM · Restricted Project
alexshap added a comment to D61082: llvm-nm and llvm-objcopy belong to toolchain.
  1. patches which are meant to be sent for code review should include "full context" https://llvm.org/docs/Phabricator.html
  2. I think it'd be useful to flash out the description of this change (why you are changing this / what does this fix, even if the change is small)

my understanding is that you are trying to change LLVM_TOOLCHAIN_TOOLS - is it correct ?

  1. I will add one more reviewer to have a look at this diff (just in case).
May 13 2019, 5:09 PM · Restricted Project

Apr 25 2019

alexshap accepted D61082: llvm-nm and llvm-objcopy belong to toolchain.
Apr 25 2019, 11:59 PM · Restricted Project
alexshap accepted D61137: Fix llvm-objcopy/ELF/preserve-segment-contents test on UTF-8 locale.

to me looks good.

Apr 25 2019, 8:15 PM · Restricted Project

Mar 25 2019

alexshap added inline comments to D59763: [llvm-objcopy] - Strip sections before symbols..
Mar 25 2019, 12:00 PM · Restricted Project

Feb 4 2019

alexshap added inline comments to D57618: [ADT] Add a fallible_iterator wrapper..
Feb 4 2019, 2:51 PM · Restricted Project
alexshap added inline comments to D57618: [ADT] Add a fallible_iterator wrapper..
Feb 4 2019, 2:42 PM · Restricted Project
alexshap added inline comments to D57517: [llvm-objcopy] Allow using regex in name comparison.
Feb 4 2019, 12:02 AM · Restricted Project

Feb 3 2019

alexshap added inline comments to D57517: [llvm-objcopy] Allow using regex in name comparison.
Feb 3 2019, 9:58 PM · Restricted Project
alexshap added inline comments to D57517: [llvm-objcopy] Allow using regex in name comparison.
Feb 3 2019, 9:42 PM · Restricted Project

Feb 1 2019

alexshap committed rL352950: [llvm-objcopy] Temporarily limit one test to darwin.
[llvm-objcopy] Temporarily limit one test to darwin
Feb 1 2019, 9:00 PM
alexshap committed rL352947: [llvm-objcopy] Fix triples in macho tests..
[llvm-objcopy] Fix triples in macho tests.
Feb 1 2019, 6:04 PM
alexshap committed rL352944: [llvm-objcopy] Add ability to copy MachO object files.
[llvm-objcopy] Add ability to copy MachO object files
Feb 1 2019, 4:38 PM
alexshap closed D54674: [llvm-objcopy] First bits for MachO .
Feb 1 2019, 4:38 PM · Restricted Project

Jan 29 2019

alexshap accepted D57423: [llvm-objcopy][NFC] More error propagation.
Jan 29 2019, 5:29 PM

Jan 25 2019

alexshap accepted D57217: llvm-objcopy: Add support for -g as an alias for --strip-debug.
Jan 25 2019, 12:49 AM
alexshap added a comment to D57217: llvm-objcopy: Add support for -g as an alias for --strip-debug.

I agree with Jordan regarding tests, otherwise this change looks good to me.

Jan 25 2019, 12:17 AM

Jan 24 2019

alexshap added inline comments to D57217: llvm-objcopy: Add support for -g as an alias for --strip-debug.
Jan 24 2019, 9:01 PM
alexshap added inline comments to D57217: llvm-objcopy: Add support for -g as an alias for --strip-debug.
Jan 24 2019, 8:47 PM
alexshap accepted D56806: [llvm-objcopy] Fix crash when writing empty binary output.

thanks!

Jan 24 2019, 10:35 AM

Jan 18 2019

alexshap accepted D56683: [llvm-objcopy] [COFF] Add support for removing sections.
Jan 18 2019, 2:56 PM
alexshap accepted D56930: [llvm-objcopy] Return Error from Buffer::allocate(), [ELF]Writer::finalize(), and [ELF]Writer::commit().

i have one inline comment, but otherwise this looks good to me

Jan 18 2019, 2:49 PM
alexshap added inline comments to D56683: [llvm-objcopy] [COFF] Add support for removing sections.
Jan 18 2019, 2:43 PM

Jan 17 2019

alexshap added inline comments to D56806: [llvm-objcopy] Fix crash when writing empty binary output.
Jan 17 2019, 7:58 PM
alexshap added inline comments to D56683: [llvm-objcopy] [COFF] Add support for removing sections.
Jan 17 2019, 5:07 PM
alexshap added inline comments to D56806: [llvm-objcopy] Fix crash when writing empty binary output.
Jan 17 2019, 4:52 PM

Jan 10 2019

alexshap added a comment to D56570: [llvm-objcopy] Use SHT_NOTE for added note sections..

I'd probably modify the test (to make it work on Windows (if it doesn't)) (or add a comment why it works if it does), other than that (and one minor inline comment) this diff looks like the right fix to me.

Jan 10 2019, 10:56 PM

Jan 9 2019

alexshap added a comment to D56513: [llvm-objcopy][NFC] Consistenly use two dashes for flags in tests..

on the other hand, i don't really have strong objections against using two dashes if you really want that consistency, not a big deal imo.

Jan 9 2019, 3:33 PM
alexshap added a comment to D56513: [llvm-objcopy][NFC] Consistenly use two dashes for flags in tests..

tbh i'm not sure about all the cases here (+ not sure if it's really worth doing),
one dash / two dashes - these things are described in tablegen opts files,
i remember there was a bug when 'one dash' was working while 'two dashes' wasn't (i don't already remember the details unfortunately),
so having at least some tests for both is not useless imo.

Jan 9 2019, 3:27 PM

Jan 7 2019

alexshap accepted D55881: [llvm-objcopy] [COFF] Add support for removing symbols.
Jan 7 2019, 3:15 PM
alexshap added inline comments to D55881: [llvm-objcopy] [COFF] Add support for removing symbols.
Jan 7 2019, 2:33 PM
alexshap added inline comments to D55881: [llvm-objcopy] [COFF] Add support for removing symbols.
Jan 7 2019, 2:29 PM

Jan 4 2019

alexshap accepted D56294: [ObjectYAML] [COFF] Support multiple symbols with the same name.

LGTM with one minor nit

Jan 4 2019, 3:41 PM
alexshap added inline comments to D56294: [ObjectYAML] [COFF] Support multiple symbols with the same name.
Jan 4 2019, 2:47 PM

Jan 2 2019

alexshap accepted D56140: [llvm-readobj] [COFF] Print the symbol index for relocations.
Jan 2 2019, 3:20 PM
alexshap added a comment to D54674: [llvm-objcopy] First bits for MachO .

@echristo, oh, i see, thanks.

Jan 2 2019, 11:08 AM · Restricted Project
alexshap added a comment to D54674: [llvm-objcopy] First bits for MachO .

@lhames , can we proceed here ?

Jan 2 2019, 11:00 AM · Restricted Project

Dec 31 2018

alexshap added inline comments to D56140: [llvm-readobj] [COFF] Print the symbol index for relocations.
Dec 31 2018, 10:25 PM

Dec 29 2018

alexshap added a reviewer for D56140: [llvm-readobj] [COFF] Print the symbol index for relocations: alexshap.
Dec 29 2018, 12:48 AM

Dec 20 2018

alexshap added inline comments to D55881: [llvm-objcopy] [COFF] Add support for removing symbols.
Dec 20 2018, 7:10 PM
alexshap accepted D55922: [llvm-objcopy] [COFF] Use Error/Expected returns instead of calling reportError. NFC..

I think this is a step in the right direction, although now we have some inconsistency with the existing code, but okay, I hope we will change the old code in the future as well. Plus I will change the not yet committed code for MachO myself.

Dec 20 2018, 4:37 PM
alexshap added inline comments to D54674: [llvm-objcopy] First bits for MachO .
Dec 20 2018, 4:24 PM · Restricted Project

Dec 19 2018

alexshap added a comment to D54674: [llvm-objcopy] First bits for MachO .

Thanks, definitely I'll wait for @lhames

Dec 19 2018, 1:20 PM · Restricted Project
alexshap updated the diff for D54674: [llvm-objcopy] First bits for MachO .

Address comments + rename some files for consistency with coff. @lhames , @jakehehrlich - if you find a minute to have a look at this new version - that will be wonderful, many thanks in advance

Dec 19 2018, 2:05 AM · Restricted Project
alexshap added inline comments to D54674: [llvm-objcopy] First bits for MachO .
Dec 19 2018, 1:56 AM · Restricted Project