Page MenuHomePhabricator

alexshap (Alexander Shaposhnikov)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 22 2016, 3:32 PM (160 w, 4 d)

Recent Activity

Today

alexshap added a comment to D66407: [llvm-objcopy][MachO] Implement -Ibinary.

I'll take a closer look at this diff this week, sorry about the delay

Tue, Aug 20, 3:07 PM · Restricted Project

Yesterday

alexshap accepted D66408: [llvm-objcopy][MachO] Implement --dump-section.

LG!

Mon, Aug 19, 3:37 PM · Restricted Project

Fri, Aug 16

alexshap added a comment to D65540: [llvm-objcopy][MachO] Fix method names. NFC..

@seiya i think this diff is safe to commit (if it has not been committed yet)

Fri, Aug 16, 12:09 AM · Restricted Project

Thu, Aug 15

alexshap added a comment to D65539: [llvm-objcopy][MachO] Implement a layout algorithm for executables.

LGTM

Thu, Aug 15, 9:56 AM · Restricted Project
alexshap accepted D65539: [llvm-objcopy][MachO] Implement a layout algorithm for executables.
Thu, Aug 15, 9:52 AM · Restricted Project

Wed, Aug 14

alexshap added a comment to D65539: [llvm-objcopy][MachO] Implement a layout algorithm for executables.

in general i like the approach, i have added a few minor comments and one question (maybe I'm missing smth).

Wed, Aug 14, 12:57 PM · Restricted Project
alexshap accepted D66075: [llvm-readobj][MachO] Fix section type printing.

LG, thanks!

Wed, Aug 14, 5:33 AM · Restricted Project

Sun, Aug 11

alexshap added inline comments to D65832: [llvm-readelf] Implement note parsing for NT_FILE and unknown descriptors.
Sun, Aug 11, 7:39 AM · Restricted Project

Fri, Aug 9

alexshap accepted D65799: [yaml2obj/obj2yaml][MachO] Allow setting custom section data.
Fri, Aug 9, 1:27 PM · Restricted Project
alexshap added a comment to D65799: [yaml2obj/obj2yaml][MachO] Allow setting custom section data.

LG, thanks for working on this!

Fri, Aug 9, 1:27 PM · Restricted Project

Wed, Aug 7

alexshap added inline comments to D65799: [yaml2obj/obj2yaml][MachO] Allow setting custom section data.
Wed, Aug 7, 10:41 PM · Restricted Project

Tue, Aug 6

alexshap accepted D65676: [llvm-lipo] Update llvm-lipo docs for -info -thin -create -replace -segalign flags.
Tue, Aug 6, 9:10 PM · Restricted Project

Mon, Aug 5

alexshap added inline comments to D65774: Removing redundant-move warnings generated by gcc9x..
Mon, Aug 5, 9:29 PM · Restricted Project

Thu, Aug 1

alexshap added inline comments to D65541: [llvm-objcopy][MachO] Implement --only-section.
Thu, Aug 1, 1:42 AM · Restricted Project
alexshap added inline comments to D65541: [llvm-objcopy][MachO] Implement --only-section.
Thu, Aug 1, 1:32 AM · Restricted Project

Wed, Jul 31

alexshap accepted D65540: [llvm-objcopy][MachO] Fix method names. NFC..
Wed, Jul 31, 4:43 PM · Restricted Project

Tue, Jul 30

alexshap accepted D65420: [llvm-lipo] Implement -segalign.
Tue, Jul 30, 2:40 PM · Restricted Project
alexshap accepted D65477: [build] add the ability to create a symlink for lipo.
Tue, Jul 30, 2:33 PM · Restricted Project

Mon, Jul 29

alexshap added inline comments to D65420: [llvm-lipo] Implement -segalign.
Mon, Jul 29, 3:46 PM · Restricted Project

Wed, Jul 24

alexshap accepted D65247: [llvm-lipo] Implement -replace.

LG

Wed, Jul 24, 3:25 PM · Restricted Project
alexshap added inline comments to D65247: [llvm-lipo] Implement -replace.
Wed, Jul 24, 3:23 PM · Restricted Project
alexshap added inline comments to D64871: [llvm-lipo] Implement alignment function in -create.
Wed, Jul 24, 2:27 PM · Restricted Project
alexshap added a comment to D65191: [llvm-objdump] Implement highlighting.

i think the title of the diff should be adjusted a bit: 's/llvm-objcopy/llvm-objdump/g'

Wed, Jul 24, 12:31 AM · Restricted Project
alexshap accepted D63395: [llvm-objcopy][MachO] Support load commands used in executables/shared libraries.
Wed, Jul 24, 12:10 AM · Restricted Project

Tue, Jul 23

alexshap accepted D65117: [llvm-Object] Added public MaxSectionAlignment to MachOUniversal.
Tue, Jul 23, 5:03 PM · Restricted Project
alexshap added a comment to D63395: [llvm-objcopy][MachO] Support load commands used in executables/shared libraries.

the code looks good to me, but we need tests. I'd add simple tests which take YAML (similarly to how the existing tests work), generate MachO (using yaml2obj), copy it using llvm-objcopy,
dump the results (using llvm-readobj and obj2yamal) and verify that the output is what we expect. Plus those tools will parse the binary generated by llvm-objcopy thus they will verify (to some extent) that we have built a valid MachO object file.

Tue, Jul 23, 3:36 PM · Restricted Project

Jul 20 2019

alexshap added inline comments to D64871: [llvm-lipo] Implement alignment function in -create.
Jul 20 2019, 2:00 PM · Restricted Project

Jul 17 2019

alexshap added inline comments to D63395: [llvm-objcopy][MachO] Support load commands used in executables/shared libraries.
Jul 17 2019, 10:41 AM · Restricted Project
alexshap added inline comments to D63395: [llvm-objcopy][MachO] Support load commands used in executables/shared libraries.
Jul 17 2019, 10:36 AM · Restricted Project
alexshap added a reviewer for D63395: [llvm-objcopy][MachO] Support load commands used in executables/shared libraries: compnerd.
Jul 17 2019, 10:33 AM · Restricted Project
alexshap added a comment to D63395: [llvm-objcopy][MachO] Support load commands used in executables/shared libraries.

it's simply a very very busy season

Jul 17 2019, 7:42 AM · Restricted Project
alexshap added a comment to D63395: [llvm-objcopy][MachO] Support load commands used in executables/shared libraries.

sorry about the delay, will get to these reviews today

Jul 17 2019, 7:40 AM · Restricted Project

Jul 15 2019

alexshap added inline comments to D64668: [llvm-lipo] Implement -info.
Jul 15 2019, 2:21 PM · Restricted Project
alexshap accepted D64668: [llvm-lipo] Implement -info.

LG

Jul 15 2019, 2:18 PM · Restricted Project
alexshap added inline comments to D64668: [llvm-lipo] Implement -info.
Jul 15 2019, 12:23 PM · Restricted Project
alexshap accepted D64668: [llvm-lipo] Implement -info.
Jul 15 2019, 12:12 PM · Restricted Project
alexshap added inline comments to D64668: [llvm-lipo] Implement -info.
Jul 15 2019, 12:10 PM · Restricted Project
alexshap added inline comments to D64668: [llvm-lipo] Implement -info.
Jul 15 2019, 12:08 PM · Restricted Project
alexshap added inline comments to D64668: [llvm-lipo] Implement -info.
Jul 15 2019, 10:34 AM · Restricted Project
alexshap added inline comments to D64668: [llvm-lipo] Implement -info.
Jul 15 2019, 7:52 AM · Restricted Project
alexshap added inline comments to D64668: [llvm-lipo] Implement -info.
Jul 15 2019, 4:35 AM · Restricted Project

Jul 14 2019

alexshap added inline comments to D64668: [llvm-lipo] Implement -info.
Jul 14 2019, 6:50 PM · Restricted Project

Jul 3 2019

alexshap added inline comments to D64102: [llvm-lipo] Implement -create part 1.
Jul 3 2019, 3:48 PM · Restricted Project
alexshap added inline comments to D64102: [llvm-lipo] Implement -create part 1.
Jul 3 2019, 3:44 PM · Restricted Project
alexshap accepted D64102: [llvm-lipo] Implement -create part 1.

I've added a couple of minor comments, but other than that - looks good to me) I'd wait for @mtrent 's approval as well

Jul 3 2019, 3:42 PM · Restricted Project

Jul 2 2019

alexshap added inline comments to D64102: [llvm-lipo] Implement -create part 1.
Jul 2 2019, 3:43 PM · Restricted Project

Jun 24 2019

alexshap accepted D63735: [MachOObjectFile]Added Valid Architecture Function.

LG

Jun 24 2019, 4:01 PM · Restricted Project
alexshap added inline comments to D63735: [MachOObjectFile]Added Valid Architecture Function.
Jun 24 2019, 2:38 PM · Restricted Project
alexshap added a comment to D63309: [llvm-objcopy][MachO] Rebuild the symbol/string table in the writer.

@anushabasana , this is addressed in https://reviews.llvm.org/D63699 (jfyi)

Jun 24 2019, 12:24 PM · Restricted Project
alexshap accepted D63699: [llvm-objcopy][MachO] Fix strict-aliasing warning. NFCI.

LG

Jun 24 2019, 1:11 AM · Restricted Project

Jun 21 2019

alexshap accepted D63647: [llvm-readobj/llvm-readelf] - Eliminate the elf-groups.x86_64 precompiled binary from the inputs..

LG, thanks!

Jun 21 2019, 3:42 PM · Restricted Project
alexshap accepted D63341: [llvm-lipo] Implement -thin.
Jun 21 2019, 12:06 PM · Restricted Project

Jun 20 2019

alexshap accepted D63606: [docs][llvm-objdump] Improve llvm-objdump documentation.
Jun 20 2019, 8:25 PM · Restricted Project

Jun 19 2019

alexshap accepted D63309: [llvm-objcopy][MachO] Rebuild the symbol/string table in the writer.

Just to double check - do the existing tests pass with this patch ? If so - LGTM

Jun 19 2019, 7:50 PM · Restricted Project
alexshap added inline comments to D63309: [llvm-objcopy][MachO] Rebuild the symbol/string table in the writer.
Jun 19 2019, 7:15 PM · Restricted Project
alexshap added inline comments to D63341: [llvm-lipo] Implement -thin.
Jun 19 2019, 4:52 PM · Restricted Project

Jun 18 2019

alexshap added inline comments to D63309: [llvm-objcopy][MachO] Rebuild the symbol/string table in the writer.
Jun 18 2019, 8:29 PM · Restricted Project
alexshap added inline comments to D63395: [llvm-objcopy][MachO] Support load commands used in executables/shared libraries.
Jun 18 2019, 8:09 PM · Restricted Project
alexshap added inline comments to D63395: [llvm-objcopy][MachO] Support load commands used in executables/shared libraries.
Jun 18 2019, 7:44 PM · Restricted Project
alexshap added a comment to D63395: [llvm-objcopy][MachO] Support load commands used in executables/shared libraries.

Regarding tests - even without computing the new layout - could we add a test which simply copies a .so and verifies that the output is the same ?

Jun 18 2019, 7:02 PM · Restricted Project
alexshap added a comment to D63395: [llvm-objcopy][MachO] Support load commands used in executables/shared libraries.

sorry about the delay with the review, I've been (and probably will be over the next few weeks) quite busy recently, but I'll take a closer look at the diff tomorrow.

Jun 18 2019, 6:48 PM · Restricted Project

Jun 17 2019

alexshap added a comment to D63341: [llvm-lipo] Implement -thin.

i think that we should not "replicate cctools lipo error messages exactly", ours could be better / more convenient or informative where it makes sense.
But in this particular case (see the comments above) I agree, including the names into the error message would be good!
Regarding exit codes - yes, it's important (for many reasons) to make sure that our exit codes are correct.

Jun 17 2019, 5:02 PM · Restricted Project

Jun 16 2019

alexshap added inline comments to D63341: [llvm-lipo] Implement -thin.
Jun 16 2019, 3:57 PM · Restricted Project
alexshap added a comment to D62991: [yaml2obj][MachO] Don't fill dummy data for virtual sections.

i think we can commit this

Jun 16 2019, 12:09 AM · Restricted Project

Jun 11 2019

alexshap added inline comments to D62991: [yaml2obj][MachO] Don't fill dummy data for virtual sections.
Jun 11 2019, 3:51 AM · Restricted Project

Jun 10 2019

alexshap accepted D63100: [llvm-lipo] Update llvm-lipo docs for -archs flag.

I've added one inline comment, other than that - LGTM, I'd wait for @mtrent as well )

Jun 10 2019, 3:38 PM · Restricted Project
alexshap accepted D62991: [yaml2obj][MachO] Don't fill dummy data for virtual sections.

ok, this makes sense to me now, thanks for the explanation. LGTM with a couple of inline comments

Jun 10 2019, 2:50 PM · Restricted Project

Jun 7 2019

alexshap committed rG85ea2de4b54b: [llvm-lipo] Add docs for llvm-lipo (authored by alexshap).
[llvm-lipo] Add docs for llvm-lipo
Jun 7 2019, 3:03 PM
alexshap committed rL362848: [llvm-lipo] Add docs for llvm-lipo.
[llvm-lipo] Add docs for llvm-lipo
Jun 7 2019, 3:03 PM
alexshap closed D62706: [llvm-lipo] Add docs for llvm-lipo.
Jun 7 2019, 3:02 PM · Restricted Project

Jun 6 2019

alexshap added a comment to D62991: [yaml2obj][MachO] Don't fill dummy data for virtual sections.

khm, could you please explain the rationale for this change ? If yaml2obj completely ignores virtual sections we won't be able to create a MachO binary containing them, moreover, even in some simple cases the round trip conversion yaml -> obj -> yaml will create a completely different binary. Having ability to create binaries with virtual sections overall seems to be useful for testing various tools etc.

Jun 6 2019, 6:53 PM · Restricted Project
alexshap added a reviewer for D62991: [yaml2obj][MachO] Don't fill dummy data for virtual sections: alexshap.
Jun 6 2019, 6:45 PM · Restricted Project
alexshap added a comment to D62706: [llvm-lipo] Add docs for llvm-lipo.

Jun 6 2019, 4:29 PM · Restricted Project
alexshap added inline comments to D62706: [llvm-lipo] Add docs for llvm-lipo.
Jun 6 2019, 4:29 PM · Restricted Project
alexshap added a comment to D62706: [llvm-lipo] Add docs for llvm-lipo.

the static html file (attached to my previous comments) contains some relative paths to various .css style sheets, so it needs to be placed into <your_build_dir>/docs/html/CommandGuide/ to be rendered correctly

Jun 6 2019, 4:23 PM · Restricted Project
alexshap updated the diff for D62706: [llvm-lipo] Add docs for llvm-lipo.

Address @mtrent comments,

Jun 6 2019, 4:20 PM · Restricted Project
alexshap added inline comments to D62753: [llvm-lipo] Implement -archs.
Jun 6 2019, 3:18 PM · Restricted Project
alexshap accepted D62753: [llvm-lipo] Implement -archs.

I think this looks okay / relatively small change anyway, i don't want to block it anymore, if there are any extra comments I think we can always either revert the diff or address them post-commit.

Jun 6 2019, 2:15 PM · Restricted Project

Jun 5 2019

alexshap added a comment to D62652: [llvm-objcopy][MachO] Recompute and update offset/size fields in the writer.

@seiya, ok, i think if nobody comments on this diff in the coming days it's safe to proceed and commit it, I kinda don't want to block it and I'm looking forward to more tests in the follow-up patches .

Jun 5 2019, 6:57 PM · Restricted Project
alexshap added a reviewer for D62706: [llvm-lipo] Add docs for llvm-lipo: lhames.
Jun 5 2019, 2:53 PM · Restricted Project
alexshap added a comment to D62706: [llvm-lipo] Add docs for llvm-lipo.

Ping) @mtrent @lhames

Jun 5 2019, 2:53 PM · Restricted Project

Jun 4 2019

alexshap accepted D62652: [llvm-objcopy][MachO] Recompute and update offset/size fields in the writer.

so in general this looks very promising to me,
however test coverage needs improvements imo, though given that at the moment we don't expose any non-trivial options here, we can add more tests incrementally. Btw - for DYSYMTAB, SYMTAB - is it possible to add YAML-based tests ? or yaml2obj's support is not sufficient for this ?

Jun 4 2019, 7:01 PM · Restricted Project
alexshap accepted D62817: [test][llvm-objcopy] Test llvm-objcopy with standard streams.
Jun 4 2019, 1:11 AM · Restricted Project

Jun 3 2019

alexshap added inline comments to D62817: [test][llvm-objcopy] Test llvm-objcopy with standard streams.
Jun 3 2019, 3:28 PM · Restricted Project
alexshap added inline comments to D62652: [llvm-objcopy][MachO] Recompute and update offset/size fields in the writer.
Jun 3 2019, 3:07 PM · Restricted Project
alexshap added inline comments to D60974: Clang IFSO driver action..
Jun 3 2019, 2:27 PM · Restricted Project, Restricted Project

May 31 2019

alexshap added inline comments to D62753: [llvm-lipo] Implement -archs.
May 31 2019, 6:11 PM · Restricted Project
alexshap added inline comments to D62753: [llvm-lipo] Implement -archs.
May 31 2019, 6:07 PM · Restricted Project
alexshap added inline comments to D62753: [llvm-lipo] Implement -archs.
May 31 2019, 5:56 PM · Restricted Project
alexshap added inline comments to D62753: [llvm-lipo] Implement -archs.
May 31 2019, 5:49 PM · Restricted Project
alexshap added inline comments to D62753: [llvm-lipo] Implement -archs.
May 31 2019, 3:56 PM · Restricted Project
alexshap added inline comments to D62753: [llvm-lipo] Implement -archs.
May 31 2019, 3:53 PM · Restricted Project
alexshap added inline comments to D62753: [llvm-lipo] Implement -archs.
May 31 2019, 3:46 PM · Restricted Project
alexshap added inline comments to D62753: [llvm-lipo] Implement -archs.
May 31 2019, 3:38 PM · Restricted Project
alexshap added inline comments to D62753: [llvm-lipo] Implement -archs.
May 31 2019, 3:35 PM · Restricted Project
alexshap added inline comments to D62753: [llvm-lipo] Implement -archs.
May 31 2019, 3:32 PM · Restricted Project

May 30 2019

alexshap updated the diff for D62706: [llvm-lipo] Add docs for llvm-lipo.

Change wrapping

May 30 2019, 3:28 PM · Restricted Project
alexshap updated the diff for D62706: [llvm-lipo] Add docs for llvm-lipo.

Minor update

May 30 2019, 3:26 PM · Restricted Project
alexshap created D62706: [llvm-lipo] Add docs for llvm-lipo.
May 30 2019, 3:19 PM · Restricted Project
alexshap added inline comments to D62652: [llvm-objcopy][MachO] Recompute and update offset/size fields in the writer.
May 30 2019, 1:31 PM · Restricted Project