Page MenuHomePhabricator

alexreinking (Alex Reinking)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 25 2021, 12:29 PM (10 w, 1 d)

Recent Activity

Wed, May 5

alexreinking added a comment to D99680: Allow /STACK in #pragma comment(linker, ...).

No, thank you, @rnk, for adding the test! I've been busy with my grad school obligations lately and this wound up pretty far down my to-do list. I'm happy this could get merged 🙂

Wed, May 5, 5:28 PM · Restricted Project, lld

Mar 31 2021

alexreinking updated the diff for D99680: Allow /STACK in #pragma comment(linker, ...).

Fix formatting.

Mar 31 2021, 2:29 PM · Restricted Project, lld
alexreinking added a reviewer for D99680: Allow /STACK in #pragma comment(linker, ...): ruiu.
Mar 31 2021, 1:07 PM · Restricted Project, lld
alexreinking requested review of D99680: Allow /STACK in #pragma comment(linker, ...).
Mar 31 2021, 1:03 PM · Restricted Project, lld

Mar 29 2021

alexreinking added a comment to D99451: Use write_basic_package_version_file for LLVM.

In trying to reproduce this, I have done the following.

Mar 29 2021, 3:49 AM · Restricted Project

Mar 28 2021

alexreinking added a comment to D99451: Use write_basic_package_version_file for LLVM.

This broke the runtimes build with the following error:

CMake Warning at CMakeLists.txt:28 (find_package):
  Could not find a configuration file for package "LLVM" that is compatible
  with requested version "".

  The following configuration files were considered but not accepted:

    /b/s/w/ir/x/w/staging/llvm_build/lib/cmake/llvm/LLVMConfig.cmake, version: 13.0.0git (64bit)

Would it be possible to revert this change?

Mar 28 2021, 11:53 PM · Restricted Project

Mar 27 2021

alexreinking updated the diff for D97513: [CMake] Add <Project>ConfigVersion.cmake files.

As requested, move instances of include(CMakePackageConfigHelpers) to AddLLVM.cmake.

Mar 27 2021, 3:05 PM · Restricted Project, Restricted Project, Restricted Project
alexreinking updated the diff for D97513: [CMake] Add <Project>ConfigVersion.cmake files.

Update & wrap commit message

Mar 27 2021, 2:14 PM · Restricted Project, Restricted Project, Restricted Project
alexreinking updated the diff for D97513: [CMake] Add <Project>ConfigVersion.cmake files.

Remove unused version variables (that were used in a previous revision)

Mar 27 2021, 2:10 PM · Restricted Project, Restricted Project, Restricted Project
alexreinking added a comment to D99451: Use write_basic_package_version_file for LLVM.

The former file is generated with different content for the purpose of installing. [Putting it in the CMakeFiles directory is strange as that directory is arguably internal to the CMake implementation and third parties shouldn't put things there, but that's beside the point for this MR anyway.]

Mar 27 2021, 12:40 PM · Restricted Project
alexreinking updated the diff for D97513: [CMake] Add <Project>ConfigVersion.cmake files.

Drop *ConfigVersion.cmake files from CMakeFiles tree

Mar 27 2021, 12:40 PM · Restricted Project, Restricted Project, Restricted Project
alexreinking updated the diff for D99451: Use write_basic_package_version_file for LLVM.

Remove LLVMConfigVersion from CMakeFiles tree

Mar 27 2021, 12:35 PM · Restricted Project
alexreinking updated the diff for D97513: [CMake] Add <Project>ConfigVersion.cmake files.

Use PACKAGE_VERSION instead

Mar 27 2021, 10:28 AM · Restricted Project, Restricted Project, Restricted Project
alexreinking updated the diff for D99451: Use write_basic_package_version_file for LLVM.

Use PACKAGE_VERSION instead

Mar 27 2021, 10:26 AM · Restricted Project
alexreinking added a comment to D99451: Use write_basic_package_version_file for LLVM.

Also adds the file to the build tree, which the comments suggested would happen, but wasn't.

I don't think this is true. Even before your patch, the generated LLVMConfigVersion.cmake is in ${CMAKE_BINARY_DIR}/lib/cmake/llvm which is where it should be? That location is what enables using find_package with the CMAKE_PREFIX_PATH pointing at the build dir.

Mar 27 2021, 10:19 AM · Restricted Project

Mar 26 2021

alexreinking requested review of D99451: Use write_basic_package_version_file for LLVM.
Mar 26 2021, 10:28 PM · Restricted Project
alexreinking added a reviewer for D97513: [CMake] Add <Project>ConfigVersion.cmake files: steveire.
Mar 26 2021, 10:27 PM · Restricted Project, Restricted Project, Restricted Project
alexreinking updated the diff for D97513: [CMake] Add <Project>ConfigVersion.cmake files.

Uses write_basic_package_version_file

Mar 26 2021, 10:24 PM · Restricted Project, Restricted Project, Restricted Project

Feb 26 2021

alexreinking added a comment to D97513: [CMake] Add <Project>ConfigVersion.cmake files.

So with this patch, I tried to imitate the existing code as much as possible. However, I think it would be quite a bit better to use the write_basic_package_version_file command from CMakePackageConfigHelpers. It gained support for major + minor version compatibility matching in CMake 3.11. Since LLVM is on 3.13 now, I don't see a reason not to use this. Instead of the existing configure_file and *ConfigVersion.cmake.in combo, we would delete the template (.in) and just write:

Feb 26 2021, 12:17 PM · Restricted Project, Restricted Project, Restricted Project

Feb 25 2021

alexreinking requested review of D97513: [CMake] Add <Project>ConfigVersion.cmake files.
Feb 25 2021, 4:31 PM · Restricted Project, Restricted Project, Restricted Project