- User Since
- Feb 5 2014, 8:11 AM (451 w, 5 d)
Jul 31 2014
Woo :D nice work!
Jul 29 2014
Thanks again for smashing on this, Manuel. This rabbit hole just keeps on getting deeper.
Jul 28 2014
Is there a test case that covers this bug?
May 27 2014
I'm also confused by the use of LastBindTemporary, and why we only need to save the last one. A clearer name might help make this more understandable.
May 23 2014
Looking really good, thanks Manuel! I'll leave the final acceptance for Jordan or someone else with more clang cred than I.
May 6 2014
This is awesome, thanks Manuel! I can't wait to see this working :)
May 2 2014
Submitted as r207867
If you call Stmt::dump(), it creates an ASTDumper without a SourceManager: ASTDumper.cpp:2163 http://clang.llvm.org/doxygen/ASTDumper_8cpp_source.html#l02162
May 1 2014
Apr 30 2014
Richard approved via email.
- Respond to review comments: copy options instead of maintaining a reference, and add more test cases.
Apr 29 2014
- Fix typo.
This is my first time sending a review with arc & phabricator: please let me know if I've set anything up incorrectly!
Awesome, thanks for this fix, Manuel!