Page MenuHomePhabricator

alexeyr (Alexey Romanov)
User

Projects

User does not belong to any projects.

User Details

User Since
Tue, Jan 28, 5:06 AM (3 w, 3 d)

Recent Activity

Mon, Feb 17

alexeyr added a comment to D74705: [mlir][quantizer] Support quantizing sparse tensors.

I've added ShapedType::withElementType here because I noticed there is equivalent code in other places as well, but changes to them would be a separate patch. Alternatively, this method could be just defined locally.

Mon, Feb 17, 5:48 AM · Restricted Project
alexeyr created D74705: [mlir][quantizer] Support quantizing sparse tensors.
Mon, Feb 17, 5:30 AM · Restricted Project

Fri, Feb 14

alexeyr added a comment to D73775: [clang-tidy] Cover cases like (b && c && b) in the redundant expression check.

@aaron.ballman I just noticed this in https://mlir.llvm.org/getting_started/Contributing/

Fri, Feb 14, 2:48 AM · Restricted Project, Restricted Project

Thu, Feb 13

alexeyr added a comment to D73775: [clang-tidy] Cover cases like (b && c && b) in the redundant expression check.

Yes, I do. Thank you (and @Eugene.Zelenko) for your help making this better!

Thu, Feb 13, 10:24 AM · Restricted Project, Restricted Project
alexeyr updated the diff for D73775: [clang-tidy] Cover cases like (b && c && b) in the redundant expression check.

Actually updated.

Thu, Feb 13, 2:39 AM · Restricted Project, Restricted Project
alexeyr updated the diff for D73775: [clang-tidy] Cover cases like (b && c && b) in the redundant expression check.

@aaron.ballman Updated.

Thu, Feb 13, 2:32 AM · Restricted Project, Restricted Project

Wed, Feb 12

alexeyr added a comment to D73775: [clang-tidy] Cover cases like (b && c && b) in the redundant expression check.

Ping. Are any other changes needed?

Wed, Feb 12, 12:34 AM · Restricted Project, Restricted Project

Wed, Feb 5

alexeyr added a comment to D73775: [clang-tidy] Cover cases like (b && c && b) in the redundant expression check.

Huh, this does seem like it may be a bug in clang-tidy. I would have expected ClangTidyDiagnosticConsumer::forwardDiagnostic() to do this work.

Wed, Feb 5, 5:59 AM · Restricted Project, Restricted Project
alexeyr updated the diff for D73775: [clang-tidy] Cover cases like (b && c && b) in the redundant expression check.

Lower-case warning messages

Wed, Feb 5, 5:34 AM · Restricted Project, Restricted Project
alexeyr added a comment to D73775: [clang-tidy] Cover cases like (b && c && b) in the redundant expression check.

Also I am not sure why, but the ranges added to the diagnostic in lines 1222-1226 don't show up in the message.

Do you mean that there are no squiggly underlines under the range, or something else? Passing in a range to the diagnostics engine gives it something to put an underline under, as in what's under the -12 in: https://godbolt.org/z/GeQzYg

Yes, exactly. I expect to see the underlines, but don't; only the ^ in the location provided to diag call.

The only time I've seen that happen is when the range is invalid. I'm guessing you'll have to step through the diagnostics code to see what's going on.

Wed, Feb 5, 5:23 AM · Restricted Project, Restricted Project

Tue, Feb 4

alexeyr added a comment to D73775: [clang-tidy] Cover cases like (b && c && b) in the redundant expression check.

Also I am not sure why, but the ranges added to the diagnostic in lines 1222-1226 don't show up in the message.

Do you mean that there are no squiggly underlines under the range, or something else? Passing in a range to the diagnostics engine gives it something to put an underline under, as in what's under the -12 in: https://godbolt.org/z/GeQzYg

Tue, Feb 4, 5:56 AM · Restricted Project, Restricted Project

Mon, Feb 3

alexeyr added inline comments to D73775: [clang-tidy] Cover cases like (b && c && b) in the redundant expression check.
Mon, Feb 3, 11:56 PM · Restricted Project, Restricted Project
alexeyr added inline comments to D73775: [clang-tidy] Cover cases like (b && c && b) in the redundant expression check.
Mon, Feb 3, 11:56 PM · Restricted Project, Restricted Project
alexeyr updated the diff for D73775: [clang-tidy] Cover cases like (b && c && b) in the redundant expression check.

Added tests for overloaded operators and fixed parent check logic.

Mon, Feb 3, 11:47 PM · Restricted Project, Restricted Project
alexeyr added inline comments to D73775: [clang-tidy] Cover cases like (b && c && b) in the redundant expression check.
Mon, Feb 3, 7:24 AM · Restricted Project, Restricted Project
alexeyr added inline comments to D73775: [clang-tidy] Cover cases like (b && c && b) in the redundant expression check.
Mon, Feb 3, 2:36 AM · Restricted Project, Restricted Project
alexeyr updated the diff for D73775: [clang-tidy] Cover cases like (b && c && b) in the redundant expression check.

Followed Eugene Zelenko's comments and fixed a false positive.

Mon, Feb 3, 2:27 AM · Restricted Project, Restricted Project

Sun, Feb 2

alexeyr added inline comments to D73775: [clang-tidy] Cover cases like (b && c && b) in the redundant expression check.
Sun, Feb 2, 11:41 PM · Restricted Project, Restricted Project

Fri, Jan 31

alexeyr added a comment to D73775: [clang-tidy] Cover cases like (b && c && b) in the redundant expression check.

Also I am not sure why, but the ranges added to the diagnostic in lines 1222-1226 don't show up in the message.

Fri, Jan 31, 5:00 AM · Restricted Project, Restricted Project
alexeyr updated the diff for D73775: [clang-tidy] Cover cases like (b && c && b) in the redundant expression check.

Fixed test broken by git clang-format

Fri, Jan 31, 4:53 AM · Restricted Project, Restricted Project
alexeyr added a comment to D73775: [clang-tidy] Cover cases like (b && c && b) in the redundant expression check.

Note: during testing I found that ++X && ++X is a false positive, my current implementation also introduces X && ++X && X which I'll try to fix.

Fri, Jan 31, 4:53 AM · Restricted Project, Restricted Project
alexeyr created D73775: [clang-tidy] Cover cases like (b && c && b) in the redundant expression check.
Fri, Jan 31, 4:44 AM · Restricted Project, Restricted Project