Page MenuHomePhabricator

alexandru.guduleasa (Alexandru Guduleasa)
Engineering

Projects

User does not belong to any projects.

User Details

User Since
Dec 23 2015, 3:07 AM (352 w, 5 d)

Recent Activity

Aug 6 2017

alexandru.guduleasa updated the diff for D35998: [TableGen] AsmMatcher: fix OpIdx computation when HasOptionalOperands is true.

I agree with the sift by one proposal and I apologize that we didn't catch this error on our end.
Apparently, there are some immediate operands that have the same value (e.g. 0).
For these, the OpIdx is not used, but it was computed anyway (and caused the out of bounds error).

Aug 6 2017, 7:38 AM · Restricted Project

Aug 3 2017

alexandru.guduleasa updated the diff for D35998: [TableGen] AsmMatcher: fix OpIdx computation when HasOptionalOperands is true.

We managed to reproduce this using Visual Studio; thank you for your patience.
The issue was that for Tied operand, the OpIdx is an index in Inst, not in the Operands vector.
Since we subtracted 1 for the mnemonic, we had an underflow access in the array.
For Tied Operands, we don't need the array at all since the index is in the Inst, not the Operands.

Aug 3 2017, 2:50 AM · Restricted Project

Aug 2 2017

alexandru.guduleasa added a comment to D35998: [TableGen] AsmMatcher: fix OpIdx computation when HasOptionalOperands is true.

Thank you for your reply.

Aug 2 2017, 12:07 AM · Restricted Project

Jul 31 2017

alexandru.guduleasa added a comment to D35998: [TableGen] AsmMatcher: fix OpIdx computation when HasOptionalOperands is true.

Can you please tell which tests? And how did you ran them?

Jul 31 2017, 11:58 PM · Restricted Project

Jul 30 2017

alexandru.guduleasa added a comment to D35998: [TableGen] AsmMatcher: fix OpIdx computation when HasOptionalOperands is true.

Yes, thank you.

Jul 30 2017, 10:31 PM · Restricted Project

Jul 28 2017

alexandru.guduleasa updated the diff for D35998: [TableGen] AsmMatcher: fix OpIdx computation when HasOptionalOperands is true.

Added requested comment.

Jul 28 2017, 1:58 PM · Restricted Project
alexandru.guduleasa added inline comments to D35998: [TableGen] AsmMatcher: fix OpIdx computation when HasOptionalOperands is true.
Jul 28 2017, 8:31 AM · Restricted Project
alexandru.guduleasa added a comment to D35998: [TableGen] AsmMatcher: fix OpIdx computation when HasOptionalOperands is true.

Unfortunately, the only in-tree target that uses IsOptional attribute is AMDGPU.

Jul 28 2017, 7:42 AM · Restricted Project
alexandru.guduleasa created D35998: [TableGen] AsmMatcher: fix OpIdx computation when HasOptionalOperands is true.
Jul 28 2017, 7:11 AM · Restricted Project

Jun 9 2017

alexandru.guduleasa added a comment to D33993: Fix compiler crash in AsmParser::Lex.

Thank you for the review.
I do not have commit access; I would appreciate it if someone can commit this.

Jun 9 2017, 6:44 AM

Jun 7 2017

alexandru.guduleasa updated the diff for D33993: Fix compiler crash in AsmParser::Lex.

Updated as per comments.

Jun 7 2017, 8:51 AM
alexandru.guduleasa added a reviewer for D33993: Fix compiler crash in AsmParser::Lex: llvm-commits.
Jun 7 2017, 7:13 AM
alexandru.guduleasa created D33993: Fix compiler crash in AsmParser::Lex.
Jun 7 2017, 7:08 AM

Jan 31 2016

alexandru.guduleasa added a comment to D15742: Fix infinite recursion in MCAsmStreamer::EmitValueImpl.

Thank you for the review!
Can someone help me commit this?

Jan 31 2016, 5:57 AM

Dec 30 2015

alexandru.guduleasa updated the diff for D15742: Fix infinite recursion in MCAsmStreamer::EmitValueImpl.

I've updated the comment just above the changes.
Also, I've computed the EmissionSize based on the min of (Size - 1) and Remaining.
This is closer to the original implementation.
If Size is a number that is not a power of 2 (e.g. 7), this should result in a 4+2+1 split in normal cases.
If the target does not support 4, instead of looping we will split as 2+2+2+1; the 2 values may be split as 1+1 if required.

Dec 30 2015, 5:45 AM

Dec 23 2015

alexandru.guduleasa retitled D15742: Fix infinite recursion in MCAsmStreamer::EmitValueImpl from to Fix infinite recursion in MCAsmStreamer::EmitValueImpl.
Dec 23 2015, 4:09 AM