Page MenuHomePhabricator

alban.bridonneau (Alban Bridonneau)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 10 2019, 2:40 AM (112 w, 1 h)

Recent Activity

Oct 5 2021

alban.bridonneau abandoned D110706: Protect calls to KMP_DLSYM in kmp_alloc.cpp.
Oct 5 2021, 3:17 AM · Restricted Project
alban.bridonneau added a comment to D110706: Protect calls to KMP_DLSYM in kmp_alloc.cpp.

Hi!
Sorry for the delay, i had a couple of concurrent tasks.

Oct 5 2021, 3:17 AM · Restricted Project

Sep 29 2021

alban.bridonneau added a comment to D110706: Protect calls to KMP_DLSYM in kmp_alloc.cpp.

The issue was detected on Linux, AArch64.

Sep 29 2021, 7:06 AM · Restricted Project
alban.bridonneau added reviewers for D110706: Protect calls to KMP_DLSYM in kmp_alloc.cpp: hbae, AndreyChurbanov, huntergr.
Sep 29 2021, 6:15 AM · Restricted Project
alban.bridonneau requested review of D110706: Protect calls to KMP_DLSYM in kmp_alloc.cpp.
Sep 29 2021, 5:57 AM · Restricted Project

Sep 8 2021

alban.bridonneau added a comment to D108371: [LAA] Add Memory dependence and unknown bounds remarks..

Thanks Malhar. The patch looks good to me

Sep 8 2021, 9:54 AM · Restricted Project
alban.bridonneau added a comment to D108371: [LAA] Add Memory dependence and unknown bounds remarks..

Just one small comment. Otherwise the patch looks good to me

Sep 8 2021, 7:26 AM · Restricted Project

Sep 7 2021

alban.bridonneau added inline comments to D108371: [LAA] Add Memory dependence and unknown bounds remarks..
Sep 7 2021, 1:54 AM · Restricted Project

Sep 6 2021

alban.bridonneau added a comment to D108371: [LAA] Add Memory dependence and unknown bounds remarks..

I quite like the way it looks with the code moved from the vectorizer to loop access analysis. I'll do a more in-depth review after the unit tests are fixed, but i left a couple of simple comments for now.

Sep 6 2021, 3:49 AM · Restricted Project

Aug 24 2021

alban.bridonneau added a comment to D108371: [LAA] Add Memory dependence and unknown bounds remarks..

Thanks Malhar. Code looks good to me. I'll need to take another look at the unit tests.
I'm going away for a week, so either someone else picks up the review in the meantime, or we can resume working on this when I come back.

Aug 24 2021, 8:40 AM · Restricted Project

Aug 23 2021

alban.bridonneau added a comment to D108371: [LAA] Add Memory dependence and unknown bounds remarks..

Thanks for the cleanup on the unit tests. It's clearer, it helps to start digging into the details of what they do.

Aug 23 2021, 7:02 AM · Restricted Project
alban.bridonneau abandoned D108281: [GVN] Improve alias analysis for parallel accesses.
Aug 23 2021, 1:08 AM · Restricted Project

Aug 20 2021

alban.bridonneau added inline comments to D108371: [LAA] Add Memory dependence and unknown bounds remarks..
Aug 20 2021, 8:31 AM · Restricted Project
alban.bridonneau added a comment to D108281: [GVN] Improve alias analysis for parallel accesses.

Thank you for the clarifications!
I see now that the llvm.loop.parallel_accesses metadata can't be used in the way that we wanted. We have also come back to the original IR and found that there was a more appropriate way to tackle our issue. So I'll close this review. I'll also add a bit more information about our case below, in case you're interested.

Aug 20 2021, 1:15 AM · Restricted Project

Aug 18 2021

alban.bridonneau added a comment to D108281: [GVN] Improve alias analysis for parallel accesses.

Could I have some more information with regards to the proposed changes?

Aug 18 2021, 10:05 AM · Restricted Project
alban.bridonneau added a comment to D108281: [GVN] Improve alias analysis for parallel accesses.

Thanks for the review. I started looking at the metadata definition and previous messages from the mailing list. It seems you're right, and the metadata doesn't give the information i thought it did.
I'd love to get some confirmation, if someone knows for sure that this is an abuse of this particular metadata.
I'll come back to the IR of the original test case, and see if there some other information i should have used.

Aug 18 2021, 8:49 AM · Restricted Project
alban.bridonneau added a comment to D108281: [GVN] Improve alias analysis for parallel accesses.

The build error seems unrelated to the this patch. There is another build next to mine, for a different patch, with the same unit test failing.

Aug 18 2021, 4:01 AM · Restricted Project
alban.bridonneau added reviewers for D108281: [GVN] Improve alias analysis for parallel accesses: david-arm, hfinkel, dfukalov, nikic.
Aug 18 2021, 3:06 AM · Restricted Project
alban.bridonneau requested review of D108281: [GVN] Improve alias analysis for parallel accesses.
Aug 18 2021, 2:15 AM · Restricted Project