Page MenuHomePhabricator

alban.bridonneau (Alban Bridonneau)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 10 2019, 2:40 AM (172 w, 3 d)

Recent Activity

May 11 2022

alban.bridonneau committed rGe6635377e56e: [NFC] Change comment number in aarch64 isel (authored by alban.bridonneau).
[NFC] Change comment number in aarch64 isel
May 11 2022, 8:47 AM · Restricted Project, Restricted Project

May 9 2022

alban.bridonneau closed D124908: [SVE] Optimize new cases for lowerConvertToSVBool.

The patch has been submitted. Somehow this revision wasn't closed automatically

May 9 2022, 7:40 AM · Restricted Project, Restricted Project

May 6 2022

alban.bridonneau updated the diff for D124908: [SVE] Optimize new cases for lowerConvertToSVBool.

I've refactored the switch statement as proposed.

May 6 2022, 8:38 AM · Restricted Project, Restricted Project

May 5 2022

alban.bridonneau updated the diff for D124908: [SVE] Optimize new cases for lowerConvertToSVBool.

I've changed the name for the unit test

May 5 2022, 5:58 AM · Restricted Project, Restricted Project

May 4 2022

alban.bridonneau updated the diff for D124908: [SVE] Optimize new cases for lowerConvertToSVBool.

I've changed the code to only explicitely check for splats of 1, rather
than all forms of all active predicates.
I also added the requested negative unit test. Note that this doesn't
actually guard the code that we just changed, because the to.bool is
lowered before the from.bool, so the from.bool has not yet been lowered
to reinterpret cast at this point. I kept the unit test anyway,
because this is a valid case to be tested.

May 4 2022, 9:39 AM · Restricted Project, Restricted Project
alban.bridonneau retitled D124908: [SVE] Optimize new cases for lowerConvertToSVBool from Optimize new cases for lowerConvertToSVBool to [SVE] Optimize new cases for lowerConvertToSVBool.
May 4 2022, 1:37 AM · Restricted Project, Restricted Project
alban.bridonneau updated the diff for D124908: [SVE] Optimize new cases for lowerConvertToSVBool.

Just adding [SVE] to the commit message

May 4 2022, 1:34 AM · Restricted Project, Restricted Project
alban.bridonneau added reviewers for D124908: [SVE] Optimize new cases for lowerConvertToSVBool: paulwalker-arm, peterwaller-arm, efriedma.
May 4 2022, 1:27 AM · Restricted Project, Restricted Project
alban.bridonneau requested review of D124908: [SVE] Optimize new cases for lowerConvertToSVBool.
May 4 2022, 1:23 AM · Restricted Project, Restricted Project

Apr 14 2022

alban.bridonneau updated the diff for D123516: Fix SLP score for out of order contiguous loads.

The CHECK lines are now autogenerated.

Apr 14 2022, 6:36 AM · Restricted Project, Restricted Project
alban.bridonneau added a comment to D123516: Fix SLP score for out of order contiguous loads.

@ABataev , I had a look at the various patches you pointed. That looks like a proper piece of work! Given how much change is going to happen, i don't think it is worth pushing the fix i am proposing today.

Apr 14 2022, 1:45 AM · Restricted Project, Restricted Project
alban.bridonneau updated the diff for D123516: Fix SLP score for out of order contiguous loads.

Further reduction of the unit test

Apr 14 2022, 1:35 AM · Restricted Project, Restricted Project

Apr 12 2022

alban.bridonneau added a comment to D123516: Fix SLP score for out of order contiguous loads.

@vporpo I was just starting to look at removing the loop-related code. That's a good point, i keep thinking about SLP in the context of loops, but it shouldn't be just about loops. The various costs seem completely different, it might require some extra work to reproduce the exact case without the loop control code.

Apr 12 2022, 8:47 AM · Restricted Project, Restricted Project
alban.bridonneau updated the diff for D123516: Fix SLP score for out of order contiguous loads.

I have simplified the unit tests.
As far as this patch goes, both tests were checking the same
behaviour, so I have only kept one. The complex data structures
and unnecesary attributes have been removed, and the IR has been reordered
to make the patterns clearer. Let me know if further reduction
is needed.

Apr 12 2022, 4:18 AM · Restricted Project, Restricted Project

Apr 11 2022

alban.bridonneau added reviewers for D123516: Fix SLP score for out of order contiguous loads: david-arm, ABataev, vporpo.
Apr 11 2022, 8:04 AM · Restricted Project, Restricted Project
alban.bridonneau requested review of D123516: Fix SLP score for out of order contiguous loads.
Apr 11 2022, 8:02 AM · Restricted Project, Restricted Project

Jan 25 2022

alban.bridonneau added inline comments to D118019: Implement correct cost for SVE bitcasts.
Jan 25 2022, 5:36 AM · Restricted Project
alban.bridonneau updated the diff for D118019: Implement correct cost for SVE bitcasts.

Adding test cases for float to integer bitcasts

Jan 25 2022, 5:35 AM · Restricted Project

Jan 24 2022

alban.bridonneau added a reviewer for D118019: Implement correct cost for SVE bitcasts: sdesmalen.
Jan 24 2022, 2:00 AM · Restricted Project
alban.bridonneau added reviewers for D118019: Implement correct cost for SVE bitcasts: david-arm, t.p.northover.
Jan 24 2022, 1:58 AM · Restricted Project
alban.bridonneau requested review of D118019: Implement correct cost for SVE bitcasts.
Jan 24 2022, 1:55 AM · Restricted Project

Oct 5 2021

alban.bridonneau abandoned D110706: Protect calls to KMP_DLSYM in kmp_alloc.cpp.
Oct 5 2021, 3:17 AM · Restricted Project
alban.bridonneau added a comment to D110706: Protect calls to KMP_DLSYM in kmp_alloc.cpp.

Hi!
Sorry for the delay, i had a couple of concurrent tasks.

Oct 5 2021, 3:17 AM · Restricted Project

Sep 29 2021

alban.bridonneau added a comment to D110706: Protect calls to KMP_DLSYM in kmp_alloc.cpp.

The issue was detected on Linux, AArch64.

Sep 29 2021, 7:06 AM · Restricted Project
alban.bridonneau added reviewers for D110706: Protect calls to KMP_DLSYM in kmp_alloc.cpp: hbae, AndreyChurbanov, huntergr.
Sep 29 2021, 6:15 AM · Restricted Project
alban.bridonneau requested review of D110706: Protect calls to KMP_DLSYM in kmp_alloc.cpp.
Sep 29 2021, 5:57 AM · Restricted Project

Sep 8 2021

alban.bridonneau added a comment to D108371: [LAA] Add Memory dependence remarks..

Thanks Malhar. The patch looks good to me

Sep 8 2021, 9:54 AM · Restricted Project
alban.bridonneau added a comment to D108371: [LAA] Add Memory dependence remarks..

Just one small comment. Otherwise the patch looks good to me

Sep 8 2021, 7:26 AM · Restricted Project

Sep 7 2021

alban.bridonneau added inline comments to D108371: [LAA] Add Memory dependence remarks..
Sep 7 2021, 1:54 AM · Restricted Project

Sep 6 2021

alban.bridonneau added a comment to D108371: [LAA] Add Memory dependence remarks..

I quite like the way it looks with the code moved from the vectorizer to loop access analysis. I'll do a more in-depth review after the unit tests are fixed, but i left a couple of simple comments for now.

Sep 6 2021, 3:49 AM · Restricted Project

Aug 24 2021

alban.bridonneau added a comment to D108371: [LAA] Add Memory dependence remarks..

Thanks Malhar. Code looks good to me. I'll need to take another look at the unit tests.
I'm going away for a week, so either someone else picks up the review in the meantime, or we can resume working on this when I come back.

Aug 24 2021, 8:40 AM · Restricted Project

Aug 23 2021

alban.bridonneau added a comment to D108371: [LAA] Add Memory dependence remarks..

Thanks for the cleanup on the unit tests. It's clearer, it helps to start digging into the details of what they do.

Aug 23 2021, 7:02 AM · Restricted Project
alban.bridonneau abandoned D108281: [GVN] Improve alias analysis for parallel accesses.
Aug 23 2021, 1:08 AM · Restricted Project

Aug 20 2021

alban.bridonneau added inline comments to D108371: [LAA] Add Memory dependence remarks..
Aug 20 2021, 8:31 AM · Restricted Project
alban.bridonneau added a comment to D108281: [GVN] Improve alias analysis for parallel accesses.

Thank you for the clarifications!
I see now that the llvm.loop.parallel_accesses metadata can't be used in the way that we wanted. We have also come back to the original IR and found that there was a more appropriate way to tackle our issue. So I'll close this review. I'll also add a bit more information about our case below, in case you're interested.

Aug 20 2021, 1:15 AM · Restricted Project

Aug 18 2021

alban.bridonneau added a comment to D108281: [GVN] Improve alias analysis for parallel accesses.

Could I have some more information with regards to the proposed changes?

Aug 18 2021, 10:05 AM · Restricted Project
alban.bridonneau added a comment to D108281: [GVN] Improve alias analysis for parallel accesses.

Thanks for the review. I started looking at the metadata definition and previous messages from the mailing list. It seems you're right, and the metadata doesn't give the information i thought it did.
I'd love to get some confirmation, if someone knows for sure that this is an abuse of this particular metadata.
I'll come back to the IR of the original test case, and see if there some other information i should have used.

Aug 18 2021, 8:49 AM · Restricted Project
alban.bridonneau added a comment to D108281: [GVN] Improve alias analysis for parallel accesses.

The build error seems unrelated to the this patch. There is another build next to mine, for a different patch, with the same unit test failing.

Aug 18 2021, 4:01 AM · Restricted Project
alban.bridonneau added reviewers for D108281: [GVN] Improve alias analysis for parallel accesses: david-arm, hfinkel, dfukalov, nikic.
Aug 18 2021, 3:06 AM · Restricted Project
alban.bridonneau requested review of D108281: [GVN] Improve alias analysis for parallel accesses.
Aug 18 2021, 2:15 AM · Restricted Project