Page MenuHomePhabricator

akshaybaviskar (Akshay Baviskar)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 16 2022, 4:41 AM (17 w, 5 d)

Recent Activity

Feb 16 2022

akshaybaviskar requested review of D119919: NFC. Replace `verifier` with `hasVerifer` for gpu.alloc op.
Feb 16 2022, 12:39 AM · Restricted Project

Feb 13 2022

akshaybaviskar updated the diff for D117427: Add verifier for gpu.alloc op.

Add verifier for gpu.alloc op

Feb 13 2022, 11:14 PM · Restricted Project
akshaybaviskar updated the diff for D117427: Add verifier for gpu.alloc op.

Add verifier for gpu.alloc op

Feb 13 2022, 11:09 PM · Restricted Project

Jan 19 2022

akshaybaviskar added a comment to D117427: Add verifier for gpu.alloc op.

Thanks for adding this. Could this rather reuse the logic from verifyAllocLike from the memref operations? It is the same logic but it would need to be exposed to other dialect.

Thanks for the suggestion. Is it allowed to expose this function to other dialect?

Jan 19 2022, 7:29 AM · Restricted Project

Jan 17 2022

akshaybaviskar added a comment to D117427: Add verifier for gpu.alloc op.

Thanks for adding this. Could this rather reuse the logic from verifyAllocLike from the memref operations? It is the same logic but it would need to be exposed to other dialect.

Jan 17 2022, 7:45 PM · Restricted Project

Jan 16 2022

akshaybaviskar updated the diff for D117427: Add verifier for gpu.alloc op.

Add verifier for gpu.alloc op to verify if the dimension operand counts and symbol operand counts are same as their memref counterparts.

Jan 16 2022, 11:03 PM · Restricted Project
akshaybaviskar added a comment to D117427: Add verifier for gpu.alloc op.

I’ve never seen a title duplicated in a git commit message, do you have any reference recommending this?

Jan 16 2022, 8:22 PM · Restricted Project
akshaybaviskar updated the summary of D117427: Add verifier for gpu.alloc op.
Jan 16 2022, 8:21 PM · Restricted Project
akshaybaviskar updated the summary of D117427: Add verifier for gpu.alloc op.
Jan 16 2022, 8:13 PM · Restricted Project
akshaybaviskar requested review of D117427: Add verifier for gpu.alloc op.
Jan 16 2022, 5:00 AM · Restricted Project