User Details
User Details
- User Since
- Mar 16 2017, 8:21 PM (349 w, 4 d)
Apr 3 2017
Apr 3 2017
ahmedasadi updated the diff for D31235: Enhance -Wshadow to warn when shadowing typedefs or type aliases.
Updated diff to address Eric's comment - it's best not to issue a warning if the shadowing declaration is part of a class (this is what GCC currently does).
Mar 30 2017
Mar 30 2017
ahmedasadi added a comment to D31235: Enhance -Wshadow to warn when shadowing typedefs or type aliases.
Thanks for reviewing. Would you be able to commit this patch for me, as I do not have commit access?
ahmedasadi updated the diff for D31235: Enhance -Wshadow to warn when shadowing typedefs or type aliases.
Re-ordered the checks in shouldWarnIfShadowedDecl as suggested by rnk.
Mar 28 2017
Mar 28 2017
ahmedasadi updated the diff for D31235: Enhance -Wshadow to warn when shadowing typedefs or type aliases.
ahmedasadi added inline comments to D31235: Enhance -Wshadow to warn when shadowing typedefs or type aliases.
Mar 22 2017
Mar 22 2017
ahmedasadi added inline comments to D31235: Enhance -Wshadow to warn when shadowing typedefs or type aliases.
ahmedasadi updated the diff for D31235: Enhance -Wshadow to warn when shadowing typedefs or type aliases.
Updated diff to include context.
ahmedasadi added reviewers for D31235: Enhance -Wshadow to warn when shadowing typedefs or type aliases: rsmith, rnk.
Mar 17 2017
Mar 17 2017
ahmedasadi added a comment to D31069: Don't warn about an unreachable fallthrough annotation in a template function.
Thanks for reviewing. Yes, I need someone to commit for me.
Mar 16 2017
Mar 16 2017
ahmedasadi updated the diff for D31069: Don't warn about an unreachable fallthrough annotation in a template function.
Added a test case.