Page MenuHomePhabricator

aharries-upmem (Adam Brouwers-Harries)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 23 2021, 8:13 AM (17 w, 43 m)

Recent Activity

Jun 30 2021

aharries-upmem added a comment to D93479: [lldb] Simplify the is_finalized logic in process and make it thread safe..

! In D93479#2850445, @jingham wrote:
Don't hesitate to reach out for questions, explanations, "what the heck"-s once you get back to this.

Jun 30 2021, 10:28 AM · Restricted Project
aharries-upmem added a comment to D93479: [lldb] Simplify the is_finalized logic in process and make it thread safe..

Huh... I fear you are going to have to debug this further on your end. I can't see anything else suspect in this patch.

Jun 30 2021, 7:37 AM · Restricted Project

Jun 25 2021

aharries-upmem added a comment to D93479: [lldb] Simplify the is_finalized logic in process and make it thread safe..

I'm also a little suspicious of (in Process::Finalize):

if (m_finalizing.exchange(true))
  return;

rather than

m_finalize_called = true;
Jun 25 2021, 4:33 AM · Restricted Project
aharries-upmem added a comment to D93479: [lldb] Simplify the is_finalized logic in process and make it thread safe..

I wonder if instead of doing:

// Use our target to get a shared pointer to ourselves...
if (m_finalize_called && !PrivateStateThreadIsValid())
  BroadcastEvent(event_sp);
else
  m_private_state_broadcaster.BroadcastEvent(event_sp);

->

m_private_state_broadcaster.BroadcastEvent(event_sp);

we should have just replaced m_finalize_called with m_finalizing? If you tried to sent the exited event to the private event broadcaster after it was shut down, that event would never get to the public process event queue.

Jun 25 2021, 4:30 AM · Restricted Project

Jun 24 2021

aharries-upmem added a comment to D93479: [lldb] Simplify the is_finalized logic in process and make it thread safe..

Hi all,

Jun 24 2021, 6:36 AM · Restricted Project