Page MenuHomePhabricator
People agrieve

agrieve (Andrew Grieve)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 22 2019, 10:12 AM (189 w, 3 d)

Recent Activity
View All

Jul 8 2022

agrieve added a comment to D113413: Add introsort to avoid O(n^2) behavior and a benchmark for adversarial quick sort input..
In D113413#3548857, @hiraditya wrote:
In D113413#3528143, @agrieve wrote:

re: binary size - std::sort-related symbols make up more than 1% of Chrome's binary size (for arm32 Android at least). Any work to reduce the size overhead of std::sort() would be very welcome. From what I can tell, the main contributing factor is the templated nature of the function. It gets stamped out a *lot* of times, and in a way that identical-code-folding is often not applicable.

Will it help to explicitly specialize some of the commonly used templates in Chrome?

Jul 8 2022, 8:08 AM · Restricted Project, Restricted Project

May 20 2022

agrieve added a comment to D113413: Add introsort to avoid O(n^2) behavior and a benchmark for adversarial quick sort input..

re: binary size - std::sort-related symbols make up more than 1% of Chrome's binary size (for arm32 Android at least). Any work to reduce the size overhead of std::sort() would be very welcome. From what I can tell, the main contributing factor is the templated nature of the function. It gets stamped out a *lot* of times, and in a way that identical-code-folding is often not applicable.

May 20 2022, 11:17 AM · Restricted Project, Restricted Project

Jul 21 2020

agrieve added a comment to D84237: asan_device_setup's wrapper scripts not handling args with spaces correctly.

Thanks! Are you able to land this for me?

Jul 21 2020, 6:38 PM · Restricted Project
Herald added a project to D84237: asan_device_setup's wrapper scripts not handling args with spaces correctly: Restricted Project.
Jul 21 2020, 6:49 AM · Restricted Project