Page MenuHomePhabricator

aeden (Anthony Eden)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 18 2019, 3:38 PM (78 w, 6 d)

Recent Activity

Sat, Jan 9

aeden added a comment to D84788: [ELF] for symver directives, preserve the given symbol's size.

Ping. Would love to see this in an upcoming release.

Sat, Jan 9, 8:19 PM · Restricted Project

Jul 31 2020

aeden updated the diff for D84788: [ELF] for symver directives, preserve the given symbol's size.

Updated to use existing global1 in llvm/test/MC/ELF/symver.s

Jul 31 2020, 10:54 AM · Restricted Project

Jul 28 2020

aeden updated the diff for D84788: [ELF] for symver directives, preserve the given symbol's size.

Updated to include llvm/test/MC/ELF/symver.s modifications

Jul 28 2020, 6:14 PM · Restricted Project
aeden requested review of D84788: [ELF] for symver directives, preserve the given symbol's size.
Jul 28 2020, 12:26 PM · Restricted Project

Mar 10 2020

aeden added a comment to D64962: appendToGlobalCtors: allow for llvm.global_ctors functions of varying type.

Relaxing it to Constant and asserting that it has the right type (pointer to void function) seems reasonable. I would prefer that the caller be the one to insert the cast from the void(int, char**, char**) prototype to the void prototype, since only the caller can know that it is safe.

Okay, sure.

Mar 10 2020, 9:46 AM · Restricted Project

Oct 9 2019

aeden added a comment to D64962: appendToGlobalCtors: allow for llvm.global_ctors functions of varying type.

In the meantime I've "worked around this" by casting my ConstantExpr * into a Function * and passing it off as one when calling appendToGlobalCtors. This happens to work only because the pointer is only ever used as a Constant * (possible Q: Why should appendToGlobalCtors take a Function * in the first place?)

Oct 9 2019, 6:32 PM · Restricted Project

Sep 13 2019

aeden added reviewers for D64962: appendToGlobalCtors: allow for llvm.global_ctors functions of varying type: rnk, dexonsmith, MaskRay.
Sep 13 2019, 6:49 PM · Restricted Project

Jul 18 2019

aeden created D64962: appendToGlobalCtors: allow for llvm.global_ctors functions of varying type.
Jul 18 2019, 4:51 PM · Restricted Project