Page MenuHomePhabricator

Wmbat (Wmbat)
User

Projects

User does not belong to any projects.

User Details

User Since
May 22 2021, 11:34 AM (9 w, 5 d)

Recent Activity

Jun 28 2021

Wmbat updated the diff for D102992: [libcxx][type_traits] remove `std::is_literal_type` and `std::result_of` for C++20.

Fixed incorrect header to atomic_helpers.h in atomic_wait.pass.cpp

Jun 28 2021, 6:53 PM · Restricted Project
Wmbat updated the diff for D102992: [libcxx][type_traits] remove `std::is_literal_type` and `std::result_of` for C++20.

Modifications based on @ldionne's recommendations

Jun 28 2021, 6:28 PM · Restricted Project

Jun 27 2021

Wmbat updated the diff for D102992: [libcxx][type_traits] remove `std::is_literal_type` and `std::result_of` for C++20.

Rebased on main

Jun 27 2021, 8:44 AM · Restricted Project

Jun 24 2021

Wmbat updated the diff for D102992: [libcxx][type_traits] remove `std::is_literal_type` and `std::result_of` for C++20.

Changes based on recommendations.

Jun 24 2021, 11:59 AM · Restricted Project

Jun 5 2021

Wmbat accepted D103753: [libc++] [P0619] Add _LIBCPP_ABI_NO_BINDER_BASES and remove binder typedefs in C++20..

LGTM!

Jun 5 2021, 3:03 PM · Restricted Project

Jun 4 2021

Wmbat added a comment to D103478: [libc++][compare] Implement three_way_comparable[_with] concepts.

I was looking at how to implement compare_three_way and found out that it needs to be present in both <compare> and <functional> according to the standard draft ( <function> synopsis, <compare> synopsis).

Sounds like someone should file an LWG issue. I'm not aware of any other library facilities that are listed multiple times in different places in the Standard. This might be a cut-and-paste error.

This is the new way to say "this thing is provided if you include either header": https://github.com/cplusplus/draft/issues/3683

It's very much intentional that compare_three_way is available if you include either <functional> or <compare>.

Jun 4 2021, 12:27 PM · Restricted Project

Jun 2 2021

Wmbat added a comment to D103478: [libc++][compare] Implement three_way_comparable[_with] concepts.

I would like to bring forward a potential change.

Jun 2 2021, 3:20 PM · Restricted Project

Jun 1 2021

Wmbat added inline comments to D102992: [libcxx][type_traits] remove `std::is_literal_type` and `std::result_of` for C++20.
Jun 1 2021, 1:48 PM · Restricted Project
Wmbat updated the diff for D102992: [libcxx][type_traits] remove `std::is_literal_type` and `std::result_of` for C++20.

Rebase on main + minor changes

Jun 1 2021, 12:52 PM · Restricted Project

May 31 2021

Wmbat updated the diff for D102992: [libcxx][type_traits] remove `std::is_literal_type` and `std::result_of` for C++20.

Implementing suggestions from @Quuxplusone

May 31 2021, 2:28 PM · Restricted Project

May 29 2021

Wmbat retitled D102992: [libcxx][type_traits] remove `std::is_literal_type` and `std::result_of` for C++20 from [libcxx][type_traits] deprecates `std::is_literal_type` and remove it for C++20 to [libcxx][type_traits] remove `std::is_literal_type` and `std::result_of` for C++20.
May 29 2021, 5:01 PM · Restricted Project
Wmbat updated the diff for D102992: [libcxx][type_traits] remove `std::is_literal_type` and `std::result_of` for C++20.

Now also deprecates and remove std::result_of

May 29 2021, 4:59 PM · Restricted Project

May 26 2021

Wmbat added inline comments to D102992: [libcxx][type_traits] remove `std::is_literal_type` and `std::result_of` for C++20.
May 26 2021, 12:22 PM · Restricted Project

May 25 2021

Wmbat added inline comments to D102992: [libcxx][type_traits] remove `std::is_literal_type` and `std::result_of` for C++20.
May 25 2021, 4:58 PM · Restricted Project
Wmbat updated the diff for D102992: [libcxx][type_traits] remove `std::is_literal_type` and `std::result_of` for C++20.

Added _LIBCPP_ENABLE_CXX20_REMOVED_IS_LITERAL_TYPE macro and fixed inconsistencies in some unit tests.

May 25 2021, 4:14 PM · Restricted Project

May 24 2021

Wmbat updated the diff for D102992: [libcxx][type_traits] remove `std::is_literal_type` and `std::result_of` for C++20.

Fix broken is_literal_type.deprecated.fail.cpp unit test

May 24 2021, 11:36 AM · Restricted Project
Wmbat updated the diff for D102992: [libcxx][type_traits] remove `std::is_literal_type` and `std::result_of` for C++20.

Fixes double commit problem

May 24 2021, 10:12 AM · Restricted Project
Wmbat updated the diff for D102992: [libcxx][type_traits] remove `std::is_literal_type` and `std::result_of` for C++20.
  • Added an extra test for checking deprecation message
  • Removed extra lines and other minor problems
  • Replaced all instances of
#pragma clang diagnostic ignored "-Wdeprecated-declarations"
#pragma GCC diagnostic ignored "-Wdeprecated-declarations"

with

// ADDITIONAL_COMPILE_FLAGS: -D_LIBCPP_DISABLE_DEPRECATION_WARNINGS
May 24 2021, 9:44 AM · Restricted Project
Wmbat added inline comments to D102992: [libcxx][type_traits] remove `std::is_literal_type` and `std::result_of` for C++20.
May 24 2021, 9:19 AM · Restricted Project
Wmbat added inline comments to D102992: [libcxx][type_traits] remove `std::is_literal_type` and `std::result_of` for C++20.
May 24 2021, 9:01 AM · Restricted Project

May 23 2021

Wmbat updated the summary of D102992: [libcxx][type_traits] remove `std::is_literal_type` and `std::result_of` for C++20.
May 23 2021, 2:17 PM · Restricted Project
Wmbat requested review of D102992: [libcxx][type_traits] remove `std::is_literal_type` and `std::result_of` for C++20.
May 23 2021, 2:14 PM · Restricted Project