Page MenuHomePhabricator

Weiwei-2021 (Weiwei)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 26 2021, 6:57 PM (69 w, 2 d)

Recent Activity

Nov 1 2021

Weiwei-2021 committed rG3483fc5a3117: [mlir][SPIRVToLLVM] Add shufflevector conversion (authored by Weiwei-2021).
[mlir][SPIRVToLLVM] Add shufflevector conversion
Nov 1 2021, 8:06 AM
Weiwei-2021 closed D112161: [mlir][SPIRVToLLVM] Add shufflevector conversion for static index.
Nov 1 2021, 8:06 AM · Restricted Project
Weiwei-2021 added a comment to D112161: [mlir][SPIRVToLLVM] Add shufflevector conversion for static index.

Thank you for your comment. Fixed and will land soon!

Nov 1 2021, 7:43 AM · Restricted Project

Oct 29 2021

Weiwei-2021 added inline comments to D112161: [mlir][SPIRVToLLVM] Add shufflevector conversion for static index.
Oct 29 2021, 12:01 PM · Restricted Project
Weiwei-2021 updated the diff for D112161: [mlir][SPIRVToLLVM] Add shufflevector conversion for static index.
Oct 29 2021, 12:01 PM · Restricted Project

Oct 20 2021

Weiwei-2021 requested review of D112161: [mlir][SPIRVToLLVM] Add shufflevector conversion for static index.
Oct 20 2021, 10:46 AM · Restricted Project

Oct 12 2021

Weiwei-2021 committed rGc0a6381e4984: [mlir][SPIRVToLLVM] Solve ExecutionModeOp redefinition and add… (authored by Weiwei-2021).
[mlir][SPIRVToLLVM] Solve ExecutionModeOp redefinition and add…
Oct 12 2021, 7:04 PM
Weiwei-2021 closed D111193: [mlir][SPIRVToLLVM] Solve ExecutionModeOp redefinition and add OpTypeSampledImage into SPV_Type.
Oct 12 2021, 7:04 PM · Restricted Project

Oct 5 2021

Weiwei-2021 requested review of D111193: [mlir][SPIRVToLLVM] Solve ExecutionModeOp redefinition and add OpTypeSampledImage into SPV_Type.
Oct 5 2021, 4:34 PM · Restricted Project

Oct 4 2021

Weiwei-2021 committed rG1e4cfe5e4f21: [mlir][SPIRVToLLVM] Propagate location attribute from spv.GlobalVariable to… (authored by Weiwei-2021).
[mlir][SPIRVToLLVM] Propagate location attribute from spv.GlobalVariable to…
Oct 4 2021, 9:15 AM
Weiwei-2021 closed D110207: [mlir][SPIRVToLLVM] Propagate location attribute from spv.GlobalVariable to llvm.mlir.global.
Oct 4 2021, 9:15 AM · Restricted Project

Sep 29 2021

Weiwei-2021 added inline comments to D110207: [mlir][SPIRVToLLVM] Propagate location attribute from spv.GlobalVariable to llvm.mlir.global.
Sep 29 2021, 10:23 PM · Restricted Project
Weiwei-2021 added a comment to D110207: [mlir][SPIRVToLLVM] Propagate location attribute from spv.GlobalVariable to llvm.mlir.global.

Thank you for comments.

Sep 29 2021, 10:22 PM · Restricted Project
Weiwei-2021 updated the diff for D110207: [mlir][SPIRVToLLVM] Propagate location attribute from spv.GlobalVariable to llvm.mlir.global.
Sep 29 2021, 10:21 PM · Restricted Project

Sep 21 2021

Weiwei-2021 requested review of D110207: [mlir][SPIRVToLLVM] Propagate location attribute from spv.GlobalVariable to llvm.mlir.global.
Sep 21 2021, 4:50 PM · Restricted Project

Sep 1 2021

Weiwei-2021 committed rGa79d7c2c8536: [mlir][SPIRV] Add Image Operands for Image Instructions (authored by Weiwei-2021).
[mlir][SPIRV] Add Image Operands for Image Instructions
Sep 1 2021, 1:14 PM
Weiwei-2021 closed D108501: [SPIRV][ImageOperand] Add Image Operands for Image Instructions (NFC).
Sep 1 2021, 1:14 PM · Restricted Project

Aug 30 2021

Weiwei-2021 added inline comments to D108501: [SPIRV][ImageOperand] Add Image Operands for Image Instructions (NFC).
Aug 30 2021, 8:00 AM · Restricted Project

Aug 24 2021

Weiwei-2021 added inline comments to D108501: [SPIRV][ImageOperand] Add Image Operands for Image Instructions (NFC).
Aug 24 2021, 7:54 PM · Restricted Project
Weiwei-2021 updated the diff for D108501: [SPIRV][ImageOperand] Add Image Operands for Image Instructions (NFC).

fix some problems.

Aug 24 2021, 7:52 PM · Restricted Project
Weiwei-2021 added inline comments to D108501: [SPIRV][ImageOperand] Add Image Operands for Image Instructions (NFC).
Aug 24 2021, 7:44 PM · Restricted Project
Weiwei-2021 updated the diff for D108501: [SPIRV][ImageOperand] Add Image Operands for Image Instructions (NFC).

Updated the verify part.

Aug 24 2021, 7:44 PM · Restricted Project

Aug 20 2021

Weiwei-2021 requested review of D108501: [SPIRV][ImageOperand] Add Image Operands for Image Instructions (NFC).
Aug 20 2021, 5:41 PM · Restricted Project

Jul 15 2021

Weiwei-2021 committed rG108a320a58b1: [mlir][spirv] Add support for GLSL FMix (authored by Weiwei-2021).
[mlir][spirv] Add support for GLSL FMix
Jul 15 2021, 5:30 PM
Weiwei-2021 closed D104153: [mlir][spirv] Add support for GLSL FMix.
Jul 15 2021, 5:30 PM · Restricted Project

Jul 14 2021

Weiwei-2021 added a comment to D104153: [mlir][spirv] Add support for GLSL FMix.

Ping people to help on reviewing this patch.

Jul 14 2021, 11:18 AM · Restricted Project
Weiwei-2021 added reviewers for D104153: [mlir][spirv] Add support for GLSL FMix: mravishankar, ergawy.
Jul 14 2021, 11:17 AM · Restricted Project

Jun 11 2021

Weiwei-2021 requested review of D104153: [mlir][spirv] Add support for GLSL FMix.
Jun 11 2021, 1:44 PM · Restricted Project

May 13 2021

Weiwei-2021 committed rGcd0eeb52ad37: [mlir][spirv] Define spv.ImageQuerySize operation (authored by Weiwei-2021).
[mlir][spirv] Define spv.ImageQuerySize operation
May 13 2021, 10:21 AM
Weiwei-2021 closed D102029: [mlir][spirv] Define spv.ImageQuerySize operation.
May 13 2021, 10:21 AM · Restricted Project
Weiwei-2021 updated the diff for D102029: [mlir][spirv] Define spv.ImageQuerySize operation.

Upload the latest version and land.

May 13 2021, 10:15 AM · Restricted Project
Weiwei-2021 added a comment to D102029: [mlir][spirv] Define spv.ImageQuerySize operation.

Thank you @antiagainst for reviewing! I will change based on your comments and then land.

May 13 2021, 7:18 AM · Restricted Project

May 6 2021

Weiwei-2021 requested review of D102029: [mlir][spirv] Define spv.ImageQuerySize operation.
May 6 2021, 3:56 PM · Restricted Project

Apr 8 2021

Weiwei-2021 committed rG12ffc260678d: [mlir][spirv] Define spv.ImageDrefGather operation (authored by Weiwei-2021).
[mlir][spirv] Define spv.ImageDrefGather operation
Apr 8 2021, 5:21 PM
Weiwei-2021 closed D100128: [mlir][spirv] Define spv.ImageDrefGather operation.
Apr 8 2021, 5:20 PM · Restricted Project
Weiwei-2021 added a comment to D100128: [mlir][spirv] Define spv.ImageDrefGather operation.

Cool, just two minor issue.

BTW, do you still need me to land the patches from now on? I assume you have commit access now given https://github.com/llvm/llvm-project/commit/63e676ffff6fd57e731412f7d905ef9044d716bf?

Apr 8 2021, 1:01 PM · Restricted Project
Weiwei-2021 requested review of D100128: [mlir][spirv] Define spv.ImageDrefGather operation.
Apr 8 2021, 10:31 AM · Restricted Project

Mar 11 2021

Weiwei-2021 committed rG63e676ffff6f: Test commit (authored by Weiwei-2021).
Test commit
Mar 11 2021, 12:07 PM

Mar 10 2021

Weiwei-2021 added inline comments to D98270: [mlir][spirv] Define spv.Image Operation.
Mar 10 2021, 10:06 AM · Restricted Project
Weiwei-2021 updated the diff for D98270: [mlir][spirv] Define spv.Image Operation.
Mar 10 2021, 10:03 AM · Restricted Project

Mar 9 2021

Weiwei-2021 added a comment to D98270: [mlir][spirv] Define spv.Image Operation.

One thing I noticed that if we define the operation's type format as "type($sampledimage) -> type($result)", the operation seems a little bit log due to the image type. Please let me know whether it is a problem.

Mar 9 2021, 9:50 AM · Restricted Project
Weiwei-2021 requested review of D98270: [mlir][spirv] Define spv.Image Operation.
Mar 9 2021, 9:48 AM · Restricted Project

Feb 24 2021

Weiwei-2021 added inline comments to D97228: [mlir][spirv] Add support for Ldexp operation in glsl extended instruction set.
Feb 24 2021, 9:40 AM · Restricted Project
Weiwei-2021 updated the diff for D97228: [mlir][spirv] Add support for Ldexp operation in glsl extended instruction set.
Feb 24 2021, 9:39 AM · Restricted Project

Feb 22 2021

Weiwei-2021 updated the diff for D97228: [mlir][spirv] Add support for Ldexp operation in glsl extended instruction set.
Feb 22 2021, 2:56 PM · Restricted Project
Weiwei-2021 added a comment to D97228: [mlir][spirv] Add support for Ldexp operation in glsl extended instruction set.

Forget to mention it in the commit msg (too quick to click the button:)). I am not 100% sure how to refer an operand in the error msg (e.g., x, exp in this case). Therefore, I keep the words the same as the SPIR-V Extended Instruction Set Spec.

Feb 22 2021, 2:35 PM · Restricted Project
Weiwei-2021 requested review of D97228: [mlir][spirv] Add support for Ldexp operation in glsl extended instruction set.
Feb 22 2021, 2:30 PM · Restricted Project

Feb 16 2021

Weiwei-2021 added a comment to D96527: [mlir][spirv] Add support for FrexpStruct in GLSL extended instruction set.

I tried to use define_inst.sh to create autogen GLSL

Feb 16 2021, 5:06 PM · Restricted Project
Weiwei-2021 updated the diff for D96527: [mlir][spirv] Add support for FrexpStruct in GLSL extended instruction set.
Feb 16 2021, 5:05 PM · Restricted Project

Feb 11 2021

Weiwei-2021 updated the diff for D96527: [mlir][spirv] Add support for FrexpStruct in GLSL extended instruction set.
Feb 11 2021, 10:43 AM · Restricted Project
Weiwei-2021 requested review of D96527: [mlir][spirv] Add support for FrexpStruct in GLSL extended instruction set.
Feb 11 2021, 10:40 AM · Restricted Project

Feb 9 2021

Weiwei-2021 added a comment to D96169: [mlir][spirv] Add support for OpTypeSampledImage.

Thanks for contributing and also thanks for the patience to tolerate multiple runs of my nitpicking. :) The first few patches typically see more of that as a way to establish coding conventions. I expect it to happen less in the future.

Feb 9 2021, 1:03 PM · Restricted Project
Weiwei-2021 added inline comments to D96169: [mlir][spirv] Add support for OpTypeSampledImage.
Feb 9 2021, 10:37 AM · Restricted Project
Weiwei-2021 updated the diff for D96169: [mlir][spirv] Add support for OpTypeSampledImage.
Feb 9 2021, 10:37 AM · Restricted Project

Feb 8 2021

Weiwei-2021 added inline comments to D96169: [mlir][spirv] Add support for OpTypeSampledImage.
Feb 8 2021, 5:47 PM · Restricted Project
Weiwei-2021 updated the diff for D96169: [mlir][spirv] Add support for OpTypeSampledImage.

I am not familiar with adding test for mlir, please let me know whether the way I add API it right or wrong. Thanks!

Feb 8 2021, 5:44 PM · Restricted Project

Feb 5 2021

Weiwei-2021 requested review of D96169: [mlir][spirv] Add support for OpTypeSampledImage.
Feb 5 2021, 11:49 AM · Restricted Project

Feb 1 2021

Weiwei-2021 added a comment to D95580: [mlir][spirv] Add support for OpImageType.

@antiagainst Thank you for start mering this commit! The author filed is "Weiwei Li <weiwei.li1@huawei.com>".

Awesome, thanks! Fixed and relanded as https://github.com/llvm/llvm-project/commit/35f746c17fd0315b235050c0a350fc521f944f20.

Feb 1 2021, 2:35 PM · Restricted Project
Weiwei-2021 added a comment to D95580: [mlir][spirv] Add support for OpImageType.

@antiagainst Thank you for start mering this commit! The author filed is "Weiwei Li <weiwei.li1@huawei.com>".

Feb 1 2021, 12:12 PM · Restricted Project
Weiwei-2021 added inline comments to D95580: [mlir][spirv] Add support for OpImageType.
Feb 1 2021, 8:04 AM · Restricted Project
Weiwei-2021 updated the diff for D95580: [mlir][spirv] Add support for OpImageType.

Correct one work for error handling

Feb 1 2021, 8:02 AM · Restricted Project

Jan 29 2021

Weiwei-2021 added inline comments to D95580: [mlir][spirv] Add support for OpImageType.
Jan 29 2021, 10:02 AM · Restricted Project
Weiwei-2021 updated the diff for D95580: [mlir][spirv] Add support for OpImageType.

Fix a numbering issue in test.

Jan 29 2021, 10:01 AM · Restricted Project
Weiwei-2021 added inline comments to D95580: [mlir][spirv] Add support for OpImageType.
Jan 29 2021, 9:56 AM · Restricted Project
Weiwei-2021 updated the diff for D95580: [mlir][spirv] Add support for OpImageType.

Apply some changes based on comments.

Jan 29 2021, 9:44 AM · Restricted Project

Jan 28 2021

Weiwei-2021 added inline comments to D95580: [mlir][spirv] Add support for OpImageType.
Jan 28 2021, 10:10 AM · Restricted Project
Weiwei-2021 updated the diff for D95580: [mlir][spirv] Add support for OpImageType.

Remove a redundant assertion.

Jan 28 2021, 10:09 AM · Restricted Project
Weiwei-2021 added inline comments to D95580: [mlir][spirv] Add support for OpImageType.
Jan 28 2021, 8:09 AM · Restricted Project

Jan 27 2021

Weiwei-2021 requested review of D95580: [mlir][spirv] Add support for OpImageType.
Jan 27 2021, 6:32 PM · Restricted Project