Thank you for your comment. Fixed and will land soon!

Thank you for comments.

fix some problems.

Updated the verify part.

Ping people to help on reviewing this patch.

Upload the latest version and land.

Thank you @antiagainst for reviewing! I will change based on your comments and then land.

In D100128#2677375, @antiagainst wrote:

Cool, just two minor issue.

BTW, do you still need me to land the patches from now on? I assume you have commit access now given https://github.com/llvm/llvm-project/commit/63e676ffff6fd57e731412f7d905ef9044d716bf?

One thing I noticed that if we define the operation's type format as "type($sampledimage) -> type($result)", the operation seems a little bit log due to the image type. Please let me know whether it is a problem.

Forget to mention it in the commit msg (too quick to click the button:)). I am not 100% sure how to refer an operand in the error msg (e.g., x, exp in this case). Therefore, I keep the words the same as the SPIR-V Extended Instruction Set Spec.

I tried to use define_inst.sh to create autogen GLSL

In D96169#2551917, @antiagainst wrote:

Thanks for contributing and also thanks for the patience to tolerate multiple runs of my nitpicking. :) The first few patches typically see more of that as a way to establish coding conventions. I expect it to happen less in the future.

I am not familiar with adding test for mlir, please let me know whether the way I add API it right or wrong. Thanks!

In D95580#2534844, @antiagainst wrote:

In D95580#2534580, @Weiwei-2021 wrote:

@antiagainst Thank you for start mering this commit! The author filed is "Weiwei Li <weiwei.li1@huawei.com>".

Awesome, thanks! Fixed and relanded as https://github.com/llvm/llvm-project/commit/35f746c17fd0315b235050c0a350fc521f944f20.

@antiagainst Thank you for start mering this commit! The author filed is "Weiwei Li <weiwei.li1@huawei.com>".

Correct one work for error handling

Fix a numbering issue in test.

Apply some changes based on comments.

Remove a redundant assertion.