- User Since
- Mar 18 2018, 10:12 AM (163 w, 3 d)
Mar 21 2021
Thank you for the fix!
May 4 2020
Thanks for the patch !
Apr 28 2020
Thanks for the fix!
Apr 27 2020
Thank for the changes !
Feb 26 2020
Feb 13 2020
Feb 11 2020
Thank you @MyDeveloperDay for the validation! I'm happy that my contribution (and my work to do it well) is accepted.
Feb 10 2020
Is the last change ok? That is the next step to be able to validate this patch?
Feb 1 2020
I launch docs/tools/dump_style.py on ClangFormatStyleOptions.rst (it seems to generate the same result as the previous diff) and add an entry in the Release Note. Tell me if there other documentation to update.
Jan 20 2020
@klimek will you have time to review this patch? The current patch integrate the last remarks and also modification due to inline lambda.
Jan 12 2020
Here a new version of the patch with the last version of the source.
It fixes problem with inline lambda. I add more more UnitTest to test.
I also make few small changes to follow remarks.
Nov 14 2019
Aug 20 2019
I update the patch for the last version of clang format, especially since option "AllowShortLambdasOnASingleLine" has been added (which require more change for this patch).
Indeed, for AllowShortLambdasOnASingleLine patch (https://reviews.llvm.org/D57687), the isAllmanBrace() function has been changed (adding TT_LambdaLBrace) which require more test to handle break for lambda body.
Sep 4 2018
Sep 1 2018
Aug 25 2018
do you have time to take a look again to this patch?
Is my last patch ok for you?
Jul 12 2018
Here a new patch, which is very similar to Diff 3. I just remove the extra line parsing which was no necessary since a new tag TT_LambdaLSquare was added.
I'm agree with klimek, path Diff 4 was quite weird and after some test contain an error in the code and unittest (inside the first test I added...)
Jul 3 2018
Jul 2 2018
Here the third version to manage break with lambda in Allman.
I implement the modification propose by klimek.
If a lambda is detected, the BlockParameterCount and ParameterCount are increment one more time in order to avoid extra line parsing after. It's lead to less code and less computation time, so I prefer this modification too.
Thank to klimek for this great remark :).
Jun 26 2018
after my last modification (require by previous comment), I do not see any feedback or validation for this patch.
Is their something special to do in order to go forward on this patch?
Apr 28 2018
I upload a new patch with the modifications you proposed.
The option is now enable by default in Allman style. So I move the option to the BraceWrappingFlags struct, which make more sense.
Apr 27 2018
many thank for your comments. I will made the modifications you propose and then update this patch.
Apr 23 2018
Here a project where there is lambda and allman style for them :
Apr 6 2018
I'm not working on a public project with a public style guide, so not sure it will fit all the requirement inside. But perhaps the request of Rian for bareflank (https://bugs.llvm.org//show_bug.cgi?id=32151#c4) could help to fit the needs.
Apr 5 2018
Mar 28 2018
I do not know which reviewer to add for this review. Is it possible to give the name of the person that will be able to review this code ?
Mar 18 2018
I upload the full context for these files.