Page MenuHomePhabricator

Wawha (Francois JEAN)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 18 2018, 10:12 AM (163 w, 3 d)

Recent Activity

Mar 21 2021

Wawha accepted D99031: [clang-format] Fix CompactNamespaces corner case when AllowShortLambdasOnASingleLine/BraceWrapping.BeforeLambdaBody are set.

Thank you for the fix!

Mar 21 2021, 9:08 AM · Restricted Project, Restricted Project

May 4 2020

Wawha accepted D79320: [clang-format [PR45791] BeforeLambdaBody is confused by comment inside lambda.

Thanks for the patch !

May 4 2020, 10:44 AM · Restricted Project, Restricted Project

Apr 28 2020

Wawha accepted D79022: [clang-format] Fix a bug causing BeforeLambdaBody to affect brace initialiser formatting.

Thanks for the fix!

Apr 28 2020, 10:44 AM · Restricted Project, Restricted Project

Apr 27 2020

Wawha accepted D78909: [clang-format] NFC clang-format the clang-format sources.

Thank for the changes !

Apr 27 2020, 12:25 PM · Restricted Project, Restricted Project

Feb 26 2020

Wawha added a comment to D44609: [clang-format] New option BeforeLambdaBody to manage lambda line break inside function parameter call (in Allman style).

Nice to finally see this patch integrated!

But, it looks like you didn't include all the test case I posted 1.5y ago in this post, that are still problematic and not formatting correctly with your patch:
For example, this simple case do not format correctly:

paramBeforeAndAfterLambda(8,[](int x){call();},5);

The output is:

paramBeforeAndAfterLambda(
        8,
        [](int x)
        {
                call();
        },
        5);

although I would expect to see

paramBeforeAndAfterLambda(8,
        [](int x)
        {
                call();
        },
        5);

See my proposed fix in the discussion, but note that I don't think it's clean enough to be accepted :)

Feb 26 2020, 1:06 PM · Restricted Project, Restricted Project

Feb 13 2020

Wawha committed rGf7e2227832a6: [clang] Fix bad line ending (DOS instead of Unix) inside the release notes. (authored by Wawha).
[clang] Fix bad line ending (DOS instead of Unix) inside the release notes.
Feb 13 2020, 1:56 PM
Wawha added a comment to rGfa0118e6e588: [clang-format] Add new option BeforeLambdaBody in Allman style..

maybe a unix2dos thing going on on the release notes

Feb 13 2020, 1:56 PM
Wawha added a comment to D44609: [clang-format] New option BeforeLambdaBody to manage lambda line break inside function parameter call (in Allman style).

Correct follow that description on how to request commit access

Feb 13 2020, 1:29 PM · Restricted Project, Restricted Project
Wawha committed rGfa0118e6e588: [clang-format] Add new option BeforeLambdaBody in Allman style. (authored by Wawha).
[clang-format] Add new option BeforeLambdaBody in Allman style.
Feb 13 2020, 1:20 PM
Wawha closed D44609: [clang-format] New option BeforeLambdaBody to manage lambda line break inside function parameter call (in Allman style).
Feb 13 2020, 1:20 PM · Restricted Project, Restricted Project
Wawha committed rGaf6353efe74b: Test commit to validate invitation (authored by Wawha).
Test commit to validate invitation
Feb 13 2020, 12:06 PM

Feb 11 2020

Wawha added a comment to D44609: [clang-format] New option BeforeLambdaBody to manage lambda line break inside function parameter call (in Allman style).

Thank you @MyDeveloperDay for the validation! I'm happy that my contribution (and my work to do it well) is accepted.

Feb 11 2020, 4:20 PM · Restricted Project, Restricted Project

Feb 10 2020

Wawha added a comment to D44609: [clang-format] New option BeforeLambdaBody to manage lambda line break inside function parameter call (in Allman style).

Hi @MyDeveloperDay
Is the last change ok? That is the next step to be able to validate this patch?

Feb 10 2020, 2:33 PM · Restricted Project, Restricted Project

Feb 1 2020

Wawha updated the diff for D44609: [clang-format] New option BeforeLambdaBody to manage lambda line break inside function parameter call (in Allman style).
Feb 1 2020, 4:48 AM · Restricted Project, Restricted Project
Wawha updated the diff for D44609: [clang-format] New option BeforeLambdaBody to manage lambda line break inside function parameter call (in Allman style).

@MyDeveloperDay
I launch docs/tools/dump_style.py on ClangFormatStyleOptions.rst (it seems to generate the same result as the previous diff) and add an entry in the Release Note. Tell me if there other documentation to update.

Feb 1 2020, 4:39 AM · Restricted Project, Restricted Project

Jan 20 2020

Wawha added a comment to D44609: [clang-format] New option BeforeLambdaBody to manage lambda line break inside function parameter call (in Allman style).

Hello,
@klimek will you have time to review this patch? The current patch integrate the last remarks and also modification due to inline lambda.

Jan 20 2020, 9:21 AM · Restricted Project, Restricted Project

Jan 12 2020

Wawha updated the diff for D44609: [clang-format] New option BeforeLambdaBody to manage lambda line break inside function parameter call (in Allman style).

Here a new version of the patch with the last version of the source.
It fixes problem with inline lambda. I add more more UnitTest to test.
I also make few small changes to follow remarks.

Jan 12 2020, 3:12 PM · Restricted Project, Restricted Project

Nov 14 2019

danra awarded D44609: [clang-format] New option BeforeLambdaBody to manage lambda line break inside function parameter call (in Allman style) a Like token.
Nov 14 2019, 12:05 PM · Restricted Project, Restricted Project

Aug 20 2019

Wawha updated the diff for D44609: [clang-format] New option BeforeLambdaBody to manage lambda line break inside function parameter call (in Allman style).

I update the patch for the last version of clang format, especially since option "AllowShortLambdasOnASingleLine" has been added (which require more change for this patch).
Indeed, for AllowShortLambdasOnASingleLine patch (https://reviews.llvm.org/D57687), the isAllmanBrace() function has been changed (adding TT_LambdaLBrace) which require more test to handle break for lambda body.

Aug 20 2019, 12:54 AM · Restricted Project, Restricted Project

Sep 4 2018

Wawha added inline comments to D44609: [clang-format] New option BeforeLambdaBody to manage lambda line break inside function parameter call (in Allman style).
Sep 4 2018, 3:02 PM · Restricted Project, Restricted Project

Sep 1 2018

Wawha added inline comments to D44609: [clang-format] New option BeforeLambdaBody to manage lambda line break inside function parameter call (in Allman style).
Sep 1 2018, 6:23 AM · Restricted Project, Restricted Project

Aug 25 2018

Wawha added a comment to D44609: [clang-format] New option BeforeLambdaBody to manage lambda line break inside function parameter call (in Allman style).
Hi klimek,

do you have time to take a look again to this patch?
Is my last patch ok for you?

Aug 25 2018, 11:09 AM · Restricted Project, Restricted Project

Jul 12 2018

Wawha updated the diff for D44609: [clang-format] New option BeforeLambdaBody to manage lambda line break inside function parameter call (in Allman style).

Here a new patch, which is very similar to Diff 3. I just remove the extra line parsing which was no necessary since a new tag TT_LambdaLSquare was added.
I'm agree with klimek, path Diff 4 was quite weird and after some test contain an error in the code and unittest (inside the first test I added...)

Jul 12 2018, 1:06 PM · Restricted Project, Restricted Project

Jul 3 2018

Wawha added inline comments to D44609: [clang-format] New option BeforeLambdaBody to manage lambda line break inside function parameter call (in Allman style).
Jul 3 2018, 1:46 AM · Restricted Project, Restricted Project

Jul 2 2018

Wawha updated the diff for D44609: [clang-format] New option BeforeLambdaBody to manage lambda line break inside function parameter call (in Allman style).

Here the third version to manage break with lambda in Allman.
I implement the modification propose by klimek.
If a lambda is detected, the BlockParameterCount and ParameterCount are increment one more time in order to avoid extra line parsing after. It's lead to less code and less computation time, so I prefer this modification too.
Thank to klimek for this great remark :).

Jul 2 2018, 3:35 PM · Restricted Project, Restricted Project

Jun 26 2018

Wawha added a comment to D44609: [clang-format] New option BeforeLambdaBody to manage lambda line break inside function parameter call (in Allman style).
Hello,

after my last modification (require by previous comment), I do not see any feedback or validation for this patch.
Is their something special to do in order to go forward on this patch?

Jun 26 2018, 12:07 PM · Restricted Project, Restricted Project

Apr 28 2018

Wawha updated the diff for D44609: [clang-format] New option BeforeLambdaBody to manage lambda line break inside function parameter call (in Allman style).

Hi klimek,
I upload a new patch with the modifications you proposed.
The option is now enable by default in Allman style. So I move the option to the BraceWrappingFlags struct, which make more sense.

Apr 28 2018, 12:32 PM · Restricted Project, Restricted Project

Apr 27 2018

Wawha added a comment to D44609: [clang-format] New option BeforeLambdaBody to manage lambda line break inside function parameter call (in Allman style).
Hi klimek,

many thank for your comments. I will made the modifications you propose and then update this patch.

Apr 27 2018, 2:21 AM · Restricted Project, Restricted Project

Apr 23 2018

Wawha added a comment to D44609: [clang-format] New option BeforeLambdaBody to manage lambda line break inside function parameter call (in Allman style).

Hi djasper,
Here a project where there is lambda and allman style for them :
https://github.com/boostorg/hof/blob/develop/example/in.cpp
https://github.com/boostorg/hof/blob/develop/example/sequence.cpp

Apr 23 2018, 3:23 PM · Restricted Project, Restricted Project

Apr 6 2018

Wawha added a comment to D44609: [clang-format] New option BeforeLambdaBody to manage lambda line break inside function parameter call (in Allman style).

I'm not working on a public project with a public style guide, so not sure it will fit all the requirement inside. But perhaps the request of Rian for bareflank (https://bugs.llvm.org//show_bug.cgi?id=32151#c4) could help to fit the needs.

Apr 6 2018, 6:51 AM · Restricted Project, Restricted Project

Apr 5 2018

Wawha added a reviewer for D44609: [clang-format] New option BeforeLambdaBody to manage lambda line break inside function parameter call (in Allman style): djasper.
Apr 5 2018, 2:46 PM · Restricted Project, Restricted Project

Mar 28 2018

Wawha added a comment to D44609: [clang-format] New option BeforeLambdaBody to manage lambda line break inside function parameter call (in Allman style).

I do not know which reviewer to add for this review. Is it possible to give the name of the person that will be able to review this code ?

Mar 28 2018, 2:15 AM · Restricted Project, Restricted Project

Mar 18 2018

Wawha added a comment to D44609: [clang-format] New option BeforeLambdaBody to manage lambda line break inside function parameter call (in Allman style).

Also, tests?

Mar 18 2018, 10:56 AM · Restricted Project, Restricted Project
Wawha updated the diff for D44609: [clang-format] New option BeforeLambdaBody to manage lambda line break inside function parameter call (in Allman style).

I upload the full context for these files.

Mar 18 2018, 10:53 AM · Restricted Project, Restricted Project
Wawha created D44609: [clang-format] New option BeforeLambdaBody to manage lambda line break inside function parameter call (in Allman style).
Mar 18 2018, 10:42 AM · Restricted Project, Restricted Project