Page MenuHomePhabricator

Wawha (Francois JEAN)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 18 2018, 10:12 AM (74 w, 6 d)

Recent Activity

Tue, Aug 20

Wawha updated the diff for D44609: [Clang-Format] New option BeforeLambdaBody to manage lambda line break inside function parameter call (in Allman style).

I update the patch for the last version of clang format, especially since option "AllowShortLambdasOnASingleLine" has been added (which require more change for this patch).
Indeed, for AllowShortLambdasOnASingleLine patch (https://reviews.llvm.org/D57687), the isAllmanBrace() function has been changed (adding TT_LambdaLBrace) which require more test to handle break for lambda body.

Tue, Aug 20, 12:54 AM · Restricted Project

Sep 4 2018

Wawha added inline comments to D44609: [Clang-Format] New option BeforeLambdaBody to manage lambda line break inside function parameter call (in Allman style).
Sep 4 2018, 3:02 PM · Restricted Project

Sep 1 2018

Wawha added inline comments to D44609: [Clang-Format] New option BeforeLambdaBody to manage lambda line break inside function parameter call (in Allman style).
Sep 1 2018, 6:23 AM · Restricted Project

Aug 25 2018

Wawha added a comment to D44609: [Clang-Format] New option BeforeLambdaBody to manage lambda line break inside function parameter call (in Allman style).
Hi klimek,

do you have time to take a look again to this patch?
Is my last patch ok for you?

Aug 25 2018, 11:09 AM · Restricted Project

Jul 12 2018

Wawha updated the diff for D44609: [Clang-Format] New option BeforeLambdaBody to manage lambda line break inside function parameter call (in Allman style).

Here a new patch, which is very similar to Diff 3. I just remove the extra line parsing which was no necessary since a new tag TT_LambdaLSquare was added.
I'm agree with klimek, path Diff 4 was quite weird and after some test contain an error in the code and unittest (inside the first test I added...)

Jul 12 2018, 1:06 PM · Restricted Project

Jul 3 2018

Wawha added inline comments to D44609: [Clang-Format] New option BeforeLambdaBody to manage lambda line break inside function parameter call (in Allman style).
Jul 3 2018, 1:46 AM · Restricted Project

Jul 2 2018

Wawha updated the diff for D44609: [Clang-Format] New option BeforeLambdaBody to manage lambda line break inside function parameter call (in Allman style).

Here the third version to manage break with lambda in Allman.
I implement the modification propose by klimek.
If a lambda is detected, the BlockParameterCount and ParameterCount are increment one more time in order to avoid extra line parsing after. It's lead to less code and less computation time, so I prefer this modification too.
Thank to klimek for this great remark :).

Jul 2 2018, 3:35 PM · Restricted Project

Jun 26 2018

Wawha added a comment to D44609: [Clang-Format] New option BeforeLambdaBody to manage lambda line break inside function parameter call (in Allman style).
Hello,

after my last modification (require by previous comment), I do not see any feedback or validation for this patch.
Is their something special to do in order to go forward on this patch?

Jun 26 2018, 12:07 PM · Restricted Project

Apr 28 2018

Wawha updated the diff for D44609: [Clang-Format] New option BeforeLambdaBody to manage lambda line break inside function parameter call (in Allman style).

Hi klimek,
I upload a new patch with the modifications you proposed.
The option is now enable by default in Allman style. So I move the option to the BraceWrappingFlags struct, which make more sense.

Apr 28 2018, 12:32 PM · Restricted Project

Apr 27 2018

Wawha added a comment to D44609: [Clang-Format] New option BeforeLambdaBody to manage lambda line break inside function parameter call (in Allman style).
Hi klimek,

many thank for your comments. I will made the modifications you propose and then update this patch.

Apr 27 2018, 2:21 AM · Restricted Project

Apr 23 2018

Wawha added a comment to D44609: [Clang-Format] New option BeforeLambdaBody to manage lambda line break inside function parameter call (in Allman style).

Hi djasper,
Here a project where there is lambda and allman style for them :
https://github.com/boostorg/hof/blob/develop/example/in.cpp
https://github.com/boostorg/hof/blob/develop/example/sequence.cpp

Apr 23 2018, 3:23 PM · Restricted Project

Apr 6 2018

Wawha added a comment to D44609: [Clang-Format] New option BeforeLambdaBody to manage lambda line break inside function parameter call (in Allman style).

I'm not working on a public project with a public style guide, so not sure it will fit all the requirement inside. But perhaps the request of Rian for bareflank (https://bugs.llvm.org//show_bug.cgi?id=32151#c4) could help to fit the needs.

Apr 6 2018, 6:51 AM · Restricted Project

Apr 5 2018

Wawha added a reviewer for D44609: [Clang-Format] New option BeforeLambdaBody to manage lambda line break inside function parameter call (in Allman style): djasper.
Apr 5 2018, 2:46 PM · Restricted Project

Mar 28 2018

Wawha added a comment to D44609: [Clang-Format] New option BeforeLambdaBody to manage lambda line break inside function parameter call (in Allman style).

I do not know which reviewer to add for this review. Is it possible to give the name of the person that will be able to review this code ?

Mar 28 2018, 2:15 AM · Restricted Project

Mar 18 2018

Wawha added a comment to D44609: [Clang-Format] New option BeforeLambdaBody to manage lambda line break inside function parameter call (in Allman style).

Also, tests?

Mar 18 2018, 10:56 AM · Restricted Project
Wawha updated the diff for D44609: [Clang-Format] New option BeforeLambdaBody to manage lambda line break inside function parameter call (in Allman style).

I upload the full context for these files.

Mar 18 2018, 10:53 AM · Restricted Project
Wawha created D44609: [Clang-Format] New option BeforeLambdaBody to manage lambda line break inside function parameter call (in Allman style).
Mar 18 2018, 10:42 AM · Restricted Project