Page MenuHomePhabricator

VelocityRa (Nick Renieris)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 27 2019, 7:33 AM (21 w, 1 d)

Recent Activity

May 1 2019

dgardner awarded D28462: clang-format: Add new style option AlignConsecutiveMacros a Like token.
May 1 2019, 1:24 PM · Restricted Project

Apr 26 2019

fgross awarded D28462: clang-format: Add new style option AlignConsecutiveMacros a Like token.
Apr 26 2019, 5:01 AM · Restricted Project

Apr 17 2019

shua27 awarded D28462: clang-format: Add new style option AlignConsecutiveMacros a Like token.
Apr 17 2019, 5:46 AM · Restricted Project

Mar 31 2019

Jololol awarded D28462: clang-format: Add new style option AlignConsecutiveMacros a Love token.
Mar 31 2019, 7:35 PM · Restricted Project

Mar 28 2019

VelocityRa updated the diff for D28462: clang-format: Add new style option AlignConsecutiveMacros.
Mar 28 2019, 12:08 PM · Restricted Project
VelocityRa added inline comments to D28462: clang-format: Add new style option AlignConsecutiveMacros.
Mar 28 2019, 12:08 PM · Restricted Project

Mar 22 2019

VelocityRa updated the diff for D28462: clang-format: Add new style option AlignConsecutiveMacros.

Right, how's that?

Mar 22 2019, 8:48 AM · Restricted Project

Mar 20 2019

VelocityRa updated the diff for D28462: clang-format: Add new style option AlignConsecutiveMacros.

Diff updated.
Some comments about the inline changes, since the rest were trivial:

  • AlignMacroSequence was inlined
  • AlignMacros was after that
  • AlignMacrosMatches can't be inlined because it's used both by alignConsecutiveMacros's (pre-AlignMacros) AlignCurrentSequence lambda and alignConsecutiveMacros itself.
  • AlignCurrentSequence can't be inlined because it's used three times in alignConsecutiveMacros.
Mar 20 2019, 7:45 AM · Restricted Project
VelocityRa added inline comments to D28462: clang-format: Add new style option AlignConsecutiveMacros.
Mar 20 2019, 7:45 AM · Restricted Project

Mar 14 2019

VelocityRa added a comment to D28462: clang-format: Add new style option AlignConsecutiveMacros.

Waiting for further feedback before pushing an update.

Mar 14 2019, 9:20 AM · Restricted Project

Feb 5 2019

VelocityRa added a comment to D28462: clang-format: Add new style option AlignConsecutiveMacros.

Ping.

Feb 5 2019, 10:53 AM · Restricted Project

Feb 3 2019

raziel awarded D28462: clang-format: Add new style option AlignConsecutiveMacros a Like token.
Feb 3 2019, 12:13 PM · Restricted Project

Jan 30 2019

VelocityRa added a comment to D28462: clang-format: Add new style option AlignConsecutiveMacros.

Looks fine to me, although I confess I did not build and run it because I don't have the time to set up the environment again, took a few hours last time I built from scratch (side note, if there's an easy way to speed up llvm/clang compilation up I'd love to hear it :) ).

Jan 30 2019, 7:58 AM · Restricted Project

Jan 29 2019

MyDeveloperDay awarded D28462: clang-format: Add new style option AlignConsecutiveMacros a Like token.
Jan 29 2019, 1:52 AM · Restricted Project

Jan 28 2019

VelocityRa updated the diff for D28462: clang-format: Add new style option AlignConsecutiveMacros.

I extracted the logic of AlignTokens and AlignTokenSequence that aligning macros uses to the best of my ability.

Jan 28 2019, 8:09 PM · Restricted Project
VelocityRa commandeered D28462: clang-format: Add new style option AlignConsecutiveMacros.
Jan 28 2019, 8:02 PM · Restricted Project