Typz (Francois Ferrand)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 25 2017, 12:43 AM (21 w, 4 d)

Recent Activity

Wed, Sep 20

Typz added a comment to D33589: clang-format: consider not splitting tokens in optimization.

This cannot be implemented where we currently call breakProtrudingToken(), since this function starts by 'creating' the BreakableToken and dealing with meany corner cases: so this should be done before in any case.
But the code at the end of breakProtrudingToken() is actually very similar to what you propose.

Wed, Sep 20, 1:03 AM

Tue, Sep 19

Typz updated the diff for D33589: clang-format: consider not splitting tokens in optimization.

Remove Reflow from LineState, and perform the decision again during reconstruction phase.

Tue, Sep 19, 6:06 AM
Typz added a comment to D33589: clang-format: consider not splitting tokens in optimization.

I am still trying to get to the bottom of this assertion, any hint where to look for?

Tue, Sep 19, 5:50 AM
Typz added a comment to D33589: clang-format: consider not splitting tokens in optimization.

I think doing the computation twice is fine. Or at least, I'd need a test case where it actually shows substantial overhead before doing what you are doing here. Understand that creating more States and making the State object itself larger also has cost and that cost occurs in the combinatorial exploration of the solution space. Doing an additional computation at the end should be comparatively cheap. Look at it this way: During the exploration of the solution space, we might enter breakProtrudingToken many times for the same comment. One more time during reconstruction of the solution is not that harmful.

Tue, Sep 19, 5:37 AM
Typz added a comment to D33589: clang-format: consider not splitting tokens in optimization.

For one thing, we need to update the state to store the "decision" of the reflowing mode, which is performed only in DryRun=true mode, to avoid doing the computation multiple times.

Tue, Sep 19, 4:57 AM
Typz updated the diff for D37813: clang-format: better handle namespace macros.

rebase

Tue, Sep 19, 1:09 AM
Typz added inline comments to D33440: clang-format: better handle statement macros.
Tue, Sep 19, 1:04 AM
Typz updated the diff for D33440: clang-format: better handle statement macros.

Add tests.
Replace sorted list with hashtable.

Tue, Sep 19, 1:03 AM

Wed, Sep 13

Typz added a reviewer for D37813: clang-format: better handle namespace macros: klimek.
Wed, Sep 13, 9:30 AM
Typz retitled D33440: clang-format: better handle statement macros from clang-format: better handle statement and namespace macros to clang-format: better handle statement macros.
Wed, Sep 13, 9:29 AM
Typz created D37813: clang-format: better handle namespace macros.
Wed, Sep 13, 9:28 AM
Typz updated the diff for D33440: clang-format: better handle statement macros.

Split diff: handle only statements in here, namespace macros will be moved to another one.

Wed, Sep 13, 9:23 AM
Typz updated the diff for D33440: clang-format: better handle statement macros.

Fix review comments, before splitting the commit.

Wed, Sep 13, 8:58 AM
Typz added inline comments to D33440: clang-format: better handle statement macros.
Wed, Sep 13, 8:49 AM
Typz updated the diff for D33589: clang-format: consider not splitting tokens in optimization.

Reorder the functions to minimize diff.

Wed, Sep 13, 8:28 AM
Typz added inline comments to D33589: clang-format: consider not splitting tokens in optimization.
Wed, Sep 13, 7:50 AM
Typz accepted D37795: SplitEmptyFunction should be true in the Mozilla coding style.
Wed, Sep 13, 7:33 AM

Tue, Sep 12

Typz updated the diff for D33440: clang-format: better handle statement macros.

Rebase to master to fix merge issue

Tue, Sep 12, 2:05 AM

Mon, Sep 11

Typz added a comment to D32478: [clang-format] Fix AlignOperands when BreakBeforeBinaryOperators is set.

ping?

Mon, Sep 11, 8:35 AM
Typz added a comment to D33440: clang-format: better handle statement macros.

ping?

Mon, Sep 11, 8:35 AM
Typz added a comment to D33589: clang-format: consider not splitting tokens in optimization.

ping?

Mon, Sep 11, 8:35 AM

Jul 28 2017

Typz updated the diff for D33589: clang-format: consider not splitting tokens in optimization.

Rebase

Jul 28 2017, 7:16 AM
Typz committed rL309370: clang-format: merge short case labels with trailing comments.
clang-format: merge short case labels with trailing comments
Jul 28 2017, 12:57 AM
Typz closed D35557: clang-format: merge short case labels with trailing comments by committing rL309370: clang-format: merge short case labels with trailing comments.
Jul 28 2017, 12:57 AM
Typz committed rL309369: clang-format: fix block OpeningLineIndex around preprocessor.
clang-format: fix block OpeningLineIndex around preprocessor
Jul 28 2017, 12:57 AM
Typz closed D35483: clang-format: fix block OpeningLineIndex around preprocessor by committing rL309369: clang-format: fix block OpeningLineIndex around preprocessor.
Jul 28 2017, 12:56 AM

Jul 24 2017

Typz added inline comments to D35483: clang-format: fix block OpeningLineIndex around preprocessor.
Jul 24 2017, 5:42 AM

Jul 23 2017

Typz updated the diff for D35483: clang-format: fix block OpeningLineIndex around preprocessor.

Address review commentsx

Jul 23 2017, 2:33 PM
Typz added inline comments to D35557: clang-format: merge short case labels with trailing comments.
Jul 23 2017, 2:31 PM
Typz updated the diff for D35557: clang-format: merge short case labels with trailing comments.

Address review comments

Jul 23 2017, 2:31 PM

Jul 18 2017

Typz added a comment to D33440: clang-format: better handle statement macros.

t>>! In D33440#812645, @djasper wrote:

So, there are two things in this patch: Statement macros and namespace macros. Lets break this out and handle them individually. They really aren't related that much.

Jul 18 2017, 6:18 AM
Typz created D35557: clang-format: merge short case labels with trailing comments.
Jul 18 2017, 5:53 AM
Typz updated the diff for D35483: clang-format: fix block OpeningLineIndex around preprocessor.

Add more tests

Jul 18 2017, 1:40 AM

Jul 17 2017

Typz created D35483: clang-format: fix block OpeningLineIndex around preprocessor.
Jul 17 2017, 6:36 AM

Jul 13 2017

Typz updated the diff for D33589: clang-format: consider not splitting tokens in optimization.

Move code out of optimizer, directly into ContinuationIndenter::breakProtrudingToken(), to minimize impact on performance.
Comment reflowing of breakable items which break the limit will be slightly slower, since we now consider the two options; however this change has no impact on the performance of processing non-breakable items, and may actually increase the operformance of processing breakable items which do not need to be reflowed.

Jul 13 2017, 9:30 AM
Typz added inline comments to D33589: clang-format: consider not splitting tokens in optimization.
Jul 13 2017, 6:30 AM
Typz added inline comments to D33589: clang-format: consider not splitting tokens in optimization.
Jul 13 2017, 5:17 AM
Typz added a comment to D33440: clang-format: better handle statement macros.

ping?

Jul 13 2017, 2:25 AM

Jul 12 2017

Typz added a comment to D32478: [clang-format] Fix AlignOperands when BreakBeforeBinaryOperators is set.

I renamed the option to AlignAfterOperator, is it acceptable now?
(I also thought of UnindentOperator, but I think it is better to keep the notion of alignment)

Jul 12 2017, 9:33 AM
Typz updated the diff for D32478: [clang-format] Fix AlignOperands when BreakBeforeBinaryOperators is set.

Rename option to AlignAfterOperator

Jul 12 2017, 8:17 AM

Jul 4 2017

Typz added a comment to D33589: clang-format: consider not splitting tokens in optimization.

ping?

Jul 4 2017, 1:33 AM
Typz added a comment to D33440: clang-format: better handle statement macros.

ping?

Jul 4 2017, 1:24 AM

Jun 30 2017

Typz committed rL306874: clang-format: add options to merge empty record body.
clang-format: add options to merge empty record body
Jun 30 2017, 1:26 PM
Typz closed D34395: clang-format: add options to merge empty record body by committing rL306874: clang-format: add options to merge empty record body.
Jun 30 2017, 1:26 PM
Typz committed rL306868: clang-format: Do not binpack initialization lists.
clang-format: Do not binpack initialization lists
Jun 30 2017, 1:00 PM
Typz closed D34238: clang-format: Do not binpack initialization lists by committing rL306868: clang-format: Do not binpack initialization lists.
Jun 30 2017, 1:00 PM

Jun 29 2017

Typz added inline comments to D32478: [clang-format] Fix AlignOperands when BreakBeforeBinaryOperators is set.
Jun 29 2017, 6:07 AM

Jun 28 2017

Typz added a comment to D33440: clang-format: better handle statement macros.

ping?

Jun 28 2017, 3:09 AM

Jun 26 2017

Typz updated the diff for D34395: clang-format: add options to merge empty record body.

Merge SplitEmptyClass/Struct/Union options into a single SplitEmptyRecord option.

Jun 26 2017, 6:33 AM
Typz updated the diff for D33440: clang-format: better handle statement macros.

Fix typo

Jun 26 2017, 6:18 AM
Typz updated the summary of D33440: clang-format: better handle statement macros.
Jun 26 2017, 6:18 AM
Typz retitled D33440: clang-format: better handle statement macros from clang-format: properly handle Q_UNUSED and QT_REQUIRE_VERSION to clang-format: better handle statement and namespace macros.
Jun 26 2017, 6:18 AM
Typz updated the diff for D33440: clang-format: better handle statement macros.

Complete refactor to make the processing much more generic

Jun 26 2017, 6:15 AM
Typz added a comment to D34395: clang-format: add options to merge empty record body.

I don't know if some style would want different styles, and I agree with you on principle; but since the brace wrapping is already configured for each kind of record, I choose to keep things consistent and have flags for each kind of record.
But I can merge the options, and keep only SplitEmptyRecord and SplitEmptyNamespace, if you really think it is better.

Jun 26 2017, 1:28 AM

Jun 23 2017

Typz added a comment to D33589: clang-format: consider not splitting tokens in optimization.

why do we want to make an exception for comments and not for regular code?

Jun 23 2017, 8:49 AM
Typz added a comment to D34395: clang-format: add options to merge empty record body.

ping?

Jun 23 2017, 5:59 AM
Typz added a comment to D32478: [clang-format] Fix AlignOperands when BreakBeforeBinaryOperators is set.

ping?

Jun 23 2017, 5:58 AM
Typz added a comment to D34238: clang-format: Do not binpack initialization lists.

ping?

Jun 23 2017, 5:58 AM

Jun 21 2017

Typz committed rL305912: clang-format: introduce InlineOnly short function style.
clang-format: introduce InlineOnly short function style
Jun 21 2017, 6:56 AM
Typz closed D34399: clang-format: introduce InlineOnly short function style by committing rL305912: clang-format: introduce InlineOnly short function style.
Jun 21 2017, 6:56 AM
Typz updated the diff for D34399: clang-format: introduce InlineOnly short function style.

Fix according to review comments

Jun 21 2017, 5:02 AM
Typz added inline comments to D34399: clang-format: introduce InlineOnly short function style.
Jun 21 2017, 4:52 AM

Jun 20 2017

Typz updated the diff for D34395: clang-format: add options to merge empty record body.

Enable merging records for Mozilla style

Jun 20 2017, 6:43 AM
Typz updated the diff for D32478: [clang-format] Fix AlignOperands when BreakBeforeBinaryOperators is set.

Rebase & fix indentation when newline is inserted after return or equal.

Jun 20 2017, 6:11 AM
Typz added a comment to D32478: [clang-format] Fix AlignOperands when BreakBeforeBinaryOperators is set.

This style is used in the Skia project.

Jun 20 2017, 6:10 AM
Typz created D34399: clang-format: introduce InlineOnly short function style.
Jun 20 2017, 5:52 AM
Typz created D34395: clang-format: add options to merge empty record body.
Jun 20 2017, 4:45 AM

Jun 19 2017

Typz updated the diff for D34238: clang-format: Do not binpack initialization lists.

Fix indentation

Jun 19 2017, 9:04 AM
Typz updated the diff for D34238: clang-format: Do not binpack initialization lists.

Fix case where the content fits on a line, by wrapping after each comma, like this:

Jun 19 2017, 8:51 AM
Typz committed rL305696: clang-format: Fix C99 designated initializers corner cases.
clang-format: Fix C99 designated initializers corner cases
Jun 19 2017, 7:42 AM
Typz closed D33491: clang-format: Fix C99 designated initializers corner cases by committing rL305696: clang-format: Fix C99 designated initializers corner cases.
Jun 19 2017, 7:42 AM
Typz added inline comments to D33491: clang-format: Fix C99 designated initializers corner cases.
Jun 19 2017, 5:03 AM
Typz updated the diff for D33491: clang-format: Fix C99 designated initializers corner cases.

Fix review comments

Jun 19 2017, 5:03 AM
Typz added a comment to D33491: clang-format: Fix C99 designated initializers corner cases.

ping

Jun 19 2017, 1:38 AM
Typz added a comment to D33589: clang-format: consider not splitting tokens in optimization.

@krasimir, @alexfh : can I get some feedback?

Jun 19 2017, 1:34 AM

Jun 16 2017

Typz added inline comments to D33823: [clang-format] Support sorting using declarations.
Jun 16 2017, 5:44 AM
Typz updated the diff for D34238: clang-format: Do not binpack initialization lists.

fix indent

Jun 16 2017, 5:28 AM
Typz updated the diff for D34238: clang-format: Do not binpack initialization lists.

remove special case after assignment

Jun 16 2017, 5:26 AM
Typz updated the summary of D33491: clang-format: Fix C99 designated initializers corner cases.
Jun 16 2017, 4:47 AM
Typz updated the diff for D33491: clang-format: Fix C99 designated initializers corner cases.

Fix incorrect labelling as ObjCMethodExpr
Do not binpack designated array initializers, just like designated member initializers

Jun 16 2017, 4:47 AM

Jun 15 2017

Typz updated the diff for D34238: clang-format: Do not binpack initialization lists.

fix unit tests

Jun 15 2017, 8:13 AM
Typz added a comment to D34238: clang-format: Do not binpack initialization lists.

Some people write

auto x = std::map<int, std::string>{
     { 0, "foo fjakfjaklf kljj" },
     { 1, "bar fjakfjaklf kljj" },
     { 2, "stuff fjakfjaklf kljj" },
 };
Jun 15 2017, 7:44 AM
Typz updated the summary of D34238: clang-format: Do not binpack initialization lists.
Jun 15 2017, 7:31 AM
Typz added a comment to D34238: clang-format: Do not binpack initialization lists.

This patch is probably not complete, though it works fine in all situations I could think of: nested initializers, "short" statement (properly merged), column layout is still performed when needed...

Jun 15 2017, 7:30 AM
Typz created D34238: clang-format: Do not binpack initialization lists.
Jun 15 2017, 7:15 AM

Jun 14 2017

Typz added reviewers for D33491: clang-format: Fix C99 designated initializers corner cases: krasimir, djasper.
Jun 14 2017, 9:08 AM
Typz added a comment to D33491: clang-format: Fix C99 designated initializers corner cases.

Seems there is a special exception to BinPacking in case of designated member initializers.
Should BinPacking be disabled also in case of designated array initializers?

Jun 14 2017, 9:07 AM
Typz updated the diff for D33491: clang-format: Fix C99 designated initializers corner cases.

Implement fix

Jun 14 2017, 9:07 AM
Typz retitled D33491: clang-format: Fix C99 designated initializers corner cases from clang-format: Fix C99 designated initializers when Cpp11BracedListStyle=false to clang-format: Fix C99 designated initializers corner cases.
Jun 14 2017, 9:05 AM
Typz added a comment to D33589: clang-format: consider not splitting tokens in optimization.

@krasimir : ping

Jun 14 2017, 5:57 AM
Typz committed rL305384: clang-format: Add CompactNamespaces option.
clang-format: Add CompactNamespaces option
Jun 14 2017, 5:30 AM
Typz closed D32480: clang-format: Add CompactNamespaces option by committing rL305384: clang-format: Add CompactNamespaces option.
Jun 14 2017, 5:30 AM · Restricted Project
Typz updated the diff for D32480: clang-format: Add CompactNamespaces option.

Move tests that add or fix namespace end comments to NamespaceEndCommentsFixerTest.cpp

Jun 14 2017, 5:16 AM · Restricted Project
Typz updated the diff for D32480: clang-format: Add CompactNamespaces option.

Make tests more readable

Jun 14 2017, 4:31 AM · Restricted Project

Jun 13 2017

Typz updated the diff for D32480: clang-format: Add CompactNamespaces option.
  • make "compacted" namespaces always add at most one level of indentation
  • compact only namespaces which both start and end on consecutive lines
Jun 13 2017, 9:04 AM · Restricted Project
Typz committed rL305272: clang-format: add option to merge empty function body.
clang-format: add option to merge empty function body
Jun 13 2017, 12:03 AM
Typz closed D33447: clang-format: add option to merge empty function body by committing rL305272: clang-format: add option to merge empty function body.
Jun 13 2017, 12:03 AM

Jun 12 2017

Typz added a comment to D32480: clang-format: Add CompactNamespaces option.

ping?

Jun 12 2017, 6:44 AM · Restricted Project
Typz added a comment to D33447: clang-format: add option to merge empty function body.

ping?

Jun 12 2017, 6:44 AM
Typz added a comment to D33589: clang-format: consider not splitting tokens in optimization.

ping?

Jun 12 2017, 6:37 AM