Page MenuHomePhabricator
People Topotuna

Topotuna (Justas Janickas)
Software Engineer at Arm - Part Time Undergraduate

Projects

User does not belong to any projects.

User Details

User Since
Jul 8 2021, 5:45 AM (89 w, 2 d)

Recent Activity
View All

May 9 2022

Topotuna requested review of D125208: [OpenCL] Fix __remove_address_space documentation code example.
May 9 2022, 12:28 AM · Restricted Project, Restricted Project

Jan 3 2022

Topotuna accepted D116271: [Docs] Document C++ for OpenCL 2021 support in clang.

LGTM!

Jan 3 2022, 1:17 AM · Restricted Project

Dec 27 2021

Topotuna added a comment to D116271: [Docs] Document C++ for OpenCL 2021 support in clang.

Overall, I think that adjustments are accurate. Suggested a couple of small edits

Dec 27 2021, 1:33 AM · Restricted Project
Topotuna closed D110155: [OpenCL] Allow optional __generic in __remove_address_space utility.

Closed by commit: rGb5fef6dbfd6b4c84d61155fd2221064bcc1ecdcf

Dec 27 2021, 1:20 AM · Restricted Project
Topotuna added a comment to rGb5fef6dbfd6b: [OpenCL] Allow optional __generic in __remove_address_space utility.

Differential Revision: https://reviews.llvm.org/D110155

Dec 27 2021, 1:14 AM
Topotuna committed rGb5fef6dbfd6b: [OpenCL] Allow optional __generic in __remove_address_space utility (authored by Topotuna).
[OpenCL] Allow optional __generic in __remove_address_space utility
Dec 27 2021, 1:11 AM

Nov 30 2021

Topotuna updated the diff for D110185: [OpenCL] Reuse C++ for OpenCL 1.0 address space tests for version 2021.

Test coverage expanded

Nov 30 2021, 1:45 AM · Restricted Project
Topotuna requested review of D114781: [OpenCL] C++ for OpenCL address space test refactoring of RUN lines.
Nov 30 2021, 1:43 AM
Topotuna updated the diff for D110155: [OpenCL] Allow optional __generic in __remove_address_space utility.

Run line argument reordering

Nov 30 2021, 1:32 AM · Restricted Project

Nov 12 2021

Topotuna committed rG388e8110db6f: [OpenCL] Constructor address space test adjusted for C++ for OpenCL 2021 (authored by Topotuna).
[OpenCL] Constructor address space test adjusted for C++ for OpenCL 2021
Nov 12 2021, 6:33 AM
Topotuna closed D110184: [OpenCL] Constructor address space test adjusted for C++ for OpenCL 2021.
Nov 12 2021, 6:32 AM · Restricted Project
Topotuna requested review of D110155: [OpenCL] Allow optional __generic in __remove_address_space utility.
Nov 12 2021, 2:54 AM · Restricted Project
Topotuna reopened D110155: [OpenCL] Allow optional __generic in __remove_address_space utility.
Nov 12 2021, 2:53 AM · Restricted Project
Topotuna updated the diff for D110155: [OpenCL] Allow optional __generic in __remove_address_space utility.

Run line -triple is now set explicitly. Test moved from CodeGenOpenCLCXX directory to SemaOpenCLCXX

Nov 12 2021, 2:53 AM · Restricted Project

Nov 9 2021

Topotuna added a reverting change for rG81081daef029: [OpenCL] Allow optional __generic in __remove_address_space utility: rGd85d57e98789: Revert "[OpenCL] Allow optional __generic in __remove_address_space utility".
Nov 9 2021, 1:43 AM
Topotuna added a reverting change for D110155: [OpenCL] Allow optional __generic in __remove_address_space utility: rGd85d57e98789: Revert "[OpenCL] Allow optional __generic in __remove_address_space utility".
Nov 9 2021, 1:43 AM · Restricted Project
Topotuna committed rGd85d57e98789: Revert "[OpenCL] Allow optional __generic in __remove_address_space utility" (authored by Topotuna).
Revert "[OpenCL] Allow optional __generic in __remove_address_space utility"
Nov 9 2021, 1:43 AM
Topotuna added a comment to D110155: [OpenCL] Allow optional __generic in __remove_address_space utility.
In D110155#3117786, @carlosgalvezp wrote:

Hi! I believe this commit broke a number of CI jobs, would you be able to look into it?

https://lab.llvm.org/buildbot/#/builders/52/builds/12263

Nov 9 2021, 1:41 AM · Restricted Project
Topotuna committed rG81081daef029: [OpenCL] Allow optional __generic in __remove_address_space utility (authored by Topotuna).
[OpenCL] Allow optional __generic in __remove_address_space utility
Nov 9 2021, 12:14 AM
Topotuna closed D110155: [OpenCL] Allow optional __generic in __remove_address_space utility.
Nov 9 2021, 12:14 AM · Restricted Project

Nov 8 2021

Topotuna added a comment to D110184: [OpenCL] Constructor address space test adjusted for C++ for OpenCL 2021.
In D110184#3115361, @Anastasia wrote:

Ping, @Topotuna do you still plan to commit this?

Nov 8 2021, 6:19 AM · Restricted Project

Sep 21 2021

Topotuna requested review of D110185: [OpenCL] Reuse C++ for OpenCL 1.0 address space tests for version 2021.
Sep 21 2021, 10:01 AM · Restricted Project
Topotuna requested review of D110184: [OpenCL] Constructor address space test adjusted for C++ for OpenCL 2021.
Sep 21 2021, 9:55 AM · Restricted Project
Topotuna added inline comments to D109002: [OpenCL] Supports optional image types in C++ for OpenCL 2021.
Sep 21 2021, 7:44 AM · Restricted Project
Topotuna added a comment to D108379: [OpenCL] Fix version reporting of C++ for OpenCL 2021.

Changes rG054e331d9dbd and rG37cdc7ebd9a3 contain test cases that display C++ for OpenCL version 2021 in diagnostics.

Sep 21 2021, 7:35 AM · Restricted Project
Topotuna committed rG32b994bca666: [OpenCL] Defines helper function for OpenCL default address space (authored by Topotuna).
[OpenCL] Defines helper function for OpenCL default address space
Sep 21 2021, 7:13 AM
Topotuna closed D109874: [OpenCL] Defines helper function for OpenCL default address space.
Sep 21 2021, 7:13 AM · Restricted Project
Topotuna requested review of D110155: [OpenCL] Allow optional __generic in __remove_address_space utility.
Sep 21 2021, 4:51 AM · Restricted Project
Topotuna added a comment to D109874: [OpenCL] Defines helper function for OpenCL default address space.

Both comments addressed. Personally, I would shuffle words around to rename helper function as getDefaultOpenCLPointeeAddrSpace or getOpenCLDefaultPointeeAddrSpace. Although I am not sure if there are some assumed naming conventions in Clang. Originally, I was following the name of getDefaultCXXMethodAddrSpace.

Sep 21 2021, 3:20 AM · Restricted Project
Topotuna updated the diff for D109874: [OpenCL] Defines helper function for OpenCL default address space.

Helper function renamed for clarity. Additional check added to if statement to ensure it is only carried out in OpenCL.

Sep 21 2021, 3:14 AM · Restricted Project
Topotuna committed rG57b8b5c114b6: [OpenCL] Test case for C++ for OpenCL 2021 in OpenCL C header test (authored by Topotuna).
[OpenCL] Test case for C++ for OpenCL 2021 in OpenCL C header test
Sep 21 2021, 2:28 AM
Topotuna closed D109492: [OpenCL] Test case for C++ for OpenCL 2021 in OpenCL C header test.
Sep 21 2021, 2:28 AM · Restricted Project

Sep 20 2021

Topotuna committed rG228dd20c3f1e: [OpenCL] Supports atomics in C++ for OpenCL 2021 (authored by Topotuna).
[OpenCL] Supports atomics in C++ for OpenCL 2021
Sep 20 2021, 8:25 AM
Topotuna closed D109424: [OpenCL] Supports atomics in C++ for OpenCL 2021.
Sep 20 2021, 8:24 AM · Restricted Project
Topotuna committed rGca3bebd8440f: [OpenCL] Supports optional writing to 3d images in C++ for OpenCL 2021 (authored by Topotuna).
[OpenCL] Supports optional writing to 3d images in C++ for OpenCL 2021
Sep 20 2021, 2:08 AM
Topotuna closed D109328: [OpenCL] Supports optional writing to 3d images in C++ for OpenCL 2021.
Sep 20 2021, 2:08 AM · Restricted Project

Sep 17 2021

Topotuna committed rGb7e9d203c679: [OpenCL] Supports optional same image reads and writes in C++ for OpenCL 2021 (authored by Topotuna).
[OpenCL] Supports optional same image reads and writes in C++ for OpenCL 2021
Sep 17 2021, 6:16 AM
Topotuna closed D109307: [OpenCL] Supports optional same image reads and writes in C++ for OpenCL 2021.
Sep 17 2021, 6:15 AM · Restricted Project
Topotuna committed rG37cdc7ebd9a3: [OpenCL] Supports optional pipe types in C++ for OpenCL 2021 (authored by Topotuna).
[OpenCL] Supports optional pipe types in C++ for OpenCL 2021
Sep 17 2021, 1:57 AM
Topotuna closed D109306: [OpenCL] Supports optional pipe types in C++ for OpenCL 2021.
Sep 17 2021, 1:56 AM · Restricted Project

Sep 16 2021

Topotuna updated the diff for D109874: [OpenCL] Defines helper function for OpenCL default address space.

Code refactored inside clang/lib/AST/Expr.cpp. Commit message added.

Sep 16 2021, 8:00 AM · Restricted Project
Topotuna committed rG054e331d9dbd: [OpenCL] Supports optional program scope global variables in C++ for OpenCL 2021 (authored by Topotuna).
[OpenCL] Supports optional program scope global variables in C++ for OpenCL 2021
Sep 16 2021, 4:48 AM
Topotuna closed D109305: [OpenCL] Supports optional program scope global variables in C++ for OpenCL 2021.
Sep 16 2021, 4:48 AM · Restricted Project
Topotuna planned changes to D109874: [OpenCL] Defines helper function for OpenCL default address space.

Current change is an initial draft. More code refactoring will be performed and change summary provided in near future.

Sep 16 2021, 3:38 AM · Restricted Project
Topotuna requested review of D109874: [OpenCL] Defines helper function for OpenCL default address space.
Sep 16 2021, 3:35 AM · Restricted Project

Sep 15 2021

Topotuna committed rG3b9470a6c46d: [OpenCL] Supports optional image types in C++ for OpenCL 2021 (authored by Topotuna).
[OpenCL] Supports optional image types in C++ for OpenCL 2021
Sep 15 2021, 2:04 AM
Topotuna closed D109002: [OpenCL] Supports optional image types in C++ for OpenCL 2021.
Sep 15 2021, 2:04 AM · Restricted Project

Sep 14 2021

Topotuna committed rG09dc454b00b8: [OpenCL] Enables .rgba vector extension in C++ for OpenCL 2021 (authored by Topotuna).
[OpenCL] Enables .rgba vector extension in C++ for OpenCL 2021
Sep 14 2021, 5:06 AM
Topotuna closed D109370: [OpenCL] Enables .rgba vector extension in C++ for OpenCL 2021.
Sep 14 2021, 5:06 AM · Restricted Project
Topotuna committed rGad88632b6503: [OpenCL] Tests C++ for OpenCL version macros (authored by Topotuna).
[OpenCL] Tests C++ for OpenCL version macros
Sep 14 2021, 1:50 AM
Topotuna closed D109366: [OpenCL] Tests C++ for OpenCL version macros.
Sep 14 2021, 1:49 AM · Restricted Project

Sep 10 2021

Topotuna updated the diff for D109366: [OpenCL] Tests C++ for OpenCL version macros.

Reuses --check-prefix=CHECK-CLCPP10 for default C++ for OpenCL command line version

Sep 10 2021, 2:04 AM · Restricted Project
Topotuna accepted D109327: [OpenCL][Docs] Release 13 notes.

LGTM! Thanks

Sep 10 2021, 1:48 AM

Sep 9 2021

Topotuna updated the diff for D109366: [OpenCL] Tests C++ for OpenCL version macros.

Test case added for command line flag -cl-std=clc++

Sep 9 2021, 3:56 AM · Restricted Project
Topotuna requested review of D109492: [OpenCL] Test case for C++ for OpenCL 2021 in OpenCL C header test.
Sep 9 2021, 1:43 AM · Restricted Project

Sep 8 2021

Topotuna requested review of D109424: [OpenCL] Supports atomics in C++ for OpenCL 2021.
Sep 8 2021, 1:48 AM · Restricted Project

Sep 7 2021

Topotuna requested review of D109370: [OpenCL] Enables .rgba vector extension in C++ for OpenCL 2021.
Sep 7 2021, 8:56 AM · Restricted Project
Topotuna requested review of D109366: [OpenCL] Tests C++ for OpenCL version macros.
Sep 7 2021, 8:19 AM · Restricted Project
Topotuna added a comment to D109327: [OpenCL][Docs] Release 13 notes.

Overall, I think the release notes accurately describe tasks I have been working on. A couple of suggestions and minor grammatical changes provided.

Sep 7 2021, 3:07 AM
Topotuna committed rGc33e296be1da: [OpenCL] Disallows static kernel functions in C++ for OpenCL (authored by Topotuna).
[OpenCL] Disallows static kernel functions in C++ for OpenCL
Sep 7 2021, 2:24 AM
Topotuna closed D109150: [OpenCL] Disallows static kernel functions in C++ for OpenCL.
Sep 7 2021, 2:24 AM · Restricted Project

Sep 6 2021

Topotuna requested review of D109328: [OpenCL] Supports optional writing to 3d images in C++ for OpenCL 2021.
Sep 6 2021, 8:25 AM · Restricted Project
Topotuna committed rG52f7cd23b4af: [OpenCL] Fix condition macro name in test (authored by Topotuna).
[OpenCL] Fix condition macro name in test
Sep 6 2021, 5:15 AM
Topotuna updated the diff for D109150: [OpenCL] Disallows static kernel functions in C++ for OpenCL.

Condition on OpenCL C / C++ for OpenCL version removed because it was redundant.

Sep 6 2021, 5:06 AM · Restricted Project
Topotuna added inline comments to D109150: [OpenCL] Disallows static kernel functions in C++ for OpenCL.
Sep 6 2021, 5:04 AM · Restricted Project
Topotuna committed rGcc9260a0fb7c: [OpenCL] Supports optional generic address space semantics in C++ for OpenCL… (authored by Topotuna).
[OpenCL] Supports optional generic address space semantics in C++ for OpenCL…
Sep 6 2021, 2:21 AM
Topotuna closed D108461: [OpenCL] Supports optional generic address space sematics in C++ for OpenCL 2021.
Sep 6 2021, 2:21 AM · Restricted Project
Topotuna added inline comments to D108461: [OpenCL] Supports optional generic address space sematics in C++ for OpenCL 2021.
Sep 6 2021, 1:29 AM · Restricted Project
Topotuna requested review of D109307: [OpenCL] Supports optional same image reads and writes in C++ for OpenCL 2021.
Sep 6 2021, 1:23 AM · Restricted Project
Topotuna requested review of D109306: [OpenCL] Supports optional pipe types in C++ for OpenCL 2021.
Sep 6 2021, 1:20 AM · Restricted Project
Topotuna requested review of D109305: [OpenCL] Supports optional program scope global variables in C++ for OpenCL 2021.
Sep 6 2021, 1:18 AM · Restricted Project

Sep 3 2021

Topotuna committed rGbd74f4b10834: [OpenCL] Supports optional 64-bit floating point types in C++ for OpenCL 2021 (authored by Topotuna).
[OpenCL] Supports optional 64-bit floating point types in C++ for OpenCL 2021
Sep 3 2021, 2:59 AM
Topotuna closed D108989: [OpenCL] Supports optional 64-bit floating point types in C++ for OpenCL 2021.
Sep 3 2021, 2:58 AM · Restricted Project

Sep 2 2021

Topotuna requested review of D109150: [OpenCL] Disallows static kernel functions in C++ for OpenCL.
Sep 2 2021, 5:38 AM · Restricted Project
Topotuna added inline comments to D109002: [OpenCL] Supports optional image types in C++ for OpenCL 2021.
Sep 2 2021, 5:29 AM · Restricted Project
Topotuna updated the diff for D109002: [OpenCL] Supports optional image types in C++ for OpenCL 2021.

Boolean variable renamed to IsOpenCLC30Compatible. FIXME comment added.

Sep 2 2021, 5:26 AM · Restricted Project

Sep 1 2021

Topotuna updated the diff for D108461: [OpenCL] Supports optional generic address space sematics in C++ for OpenCL 2021.

The previously suggested change was split into intermediate steps:
reviews.llvm.org/rGf9bc1b3bee55 - introduced a mapping function for C++ for OpenCL version compatibility with OpenCL and modified condition for setting OpenCLGenericAddressSpace language option.
reviews.llvm.org/rGfb321c2ea274 - enabled all OpenCL 3.0 optional core feature macros without implementing their support in C++ for OpenCL 2021.

Sep 1 2021, 6:21 AM · Restricted Project
Topotuna added inline comments to D109002: [OpenCL] Supports optional image types in C++ for OpenCL 2021.
Sep 1 2021, 2:45 AM · Restricted Project
Topotuna committed rGfb321c2ea274: [OpenCL] Define OpenCL 3.0 optional core features in C++ for OpenCL 2021 (authored by Topotuna).
[OpenCL] Define OpenCL 3.0 optional core features in C++ for OpenCL 2021
Sep 1 2021, 2:17 AM
Topotuna closed D108704: [OpenCL] Define OpenCL 3.0 optional core features in C++ for OpenCL 2021.
Sep 1 2021, 2:16 AM · Restricted Project

Aug 31 2021

Topotuna requested review of D109002: [OpenCL] Supports optional image types in C++ for OpenCL 2021.
Aug 31 2021, 8:55 AM · Restricted Project
Topotuna requested review of D108989: [OpenCL] Supports optional 64-bit floating point types in C++ for OpenCL 2021.
Aug 31 2021, 5:29 AM · Restricted Project
Topotuna committed rGf9bc1b3bee55: [OpenCL] Defines helper function for kernel language compatible OpenCL version (authored by Topotuna).
[OpenCL] Defines helper function for kernel language compatible OpenCL version
Aug 31 2021, 2:09 AM
Topotuna closed D108693: [OpenCL] Defines helper function for kernel language compatible OpenCL version.
Aug 31 2021, 2:09 AM · Restricted Project

Aug 25 2021

Topotuna committed rG9dc92bba6c74: [OpenCL][NFC] Fix code example in __remove_address_space documentation. (authored by Topotuna).
[OpenCL][NFC] Fix code example in __remove_address_space documentation.
Aug 25 2021, 1:26 PM
Topotuna requested review of D108704: [OpenCL] Define OpenCL 3.0 optional core features in C++ for OpenCL 2021.
Aug 25 2021, 8:06 AM · Restricted Project
Topotuna requested review of D108693: [OpenCL] Defines helper function for kernel language compatible OpenCL version.
Aug 25 2021, 3:30 AM · Restricted Project

Aug 23 2021

Topotuna planned changes to D108461: [OpenCL] Supports optional generic address space sematics in C++ for OpenCL 2021.

__opencl_c_generic_address_space should not have been chosen as the first feature to be addressed out of all OpenCL 3.0 optional core features. This is because __opencl_c_device_enqueue has a dependency on this feature. I will review the order in which OpenCL 3.0 optional features should be introduced to C++ for OpenCL 2021 and return to this revision when all dependencies are resolved.

Aug 23 2021, 7:12 AM · Restricted Project

Aug 20 2021

Topotuna requested review of D108461: [OpenCL] Supports optional generic address space sematics in C++ for OpenCL 2021.
Aug 20 2021, 5:55 AM · Restricted Project
Topotuna committed rG9ae9262857a1: [OpenCL] Fix version reporting of C++ for OpenCL 2021 (authored by Topotuna).
[OpenCL] Fix version reporting of C++ for OpenCL 2021
Aug 20 2021, 12:59 AM
Topotuna closed D108379: [OpenCL] Fix version reporting of C++ for OpenCL 2021.
Aug 20 2021, 12:58 AM · Restricted Project

Aug 19 2021

Topotuna added a comment to D108379: [OpenCL] Fix version reporting of C++ for OpenCL 2021.
In D108379#2954826, @Anastasia wrote:

LGTM! Thanks!

I imagine you will be adding some tests that will check the correctness of diagnostic wording in the subsequent commits?

Aug 19 2021, 8:46 AM · Restricted Project
Topotuna requested review of D108379: [OpenCL] Fix version reporting of C++ for OpenCL 2021.
Aug 19 2021, 8:19 AM · Restricted Project

Aug 18 2021

Topotuna committed rG0d0628b2d213: [OpenCL] C++ for OpenCL version 2021 introduced to command line. (authored by Topotuna).
[OpenCL] C++ for OpenCL version 2021 introduced to command line.
Aug 18 2021, 2:15 AM
Topotuna closed D108038: [C++4OpenCL] C++ for OpenCL version 2021 introduced to command line.
Aug 18 2021, 2:15 AM · Restricted Project

Aug 16 2021

Topotuna requested review of D108113: [C++4OpenCL] Enable -cl-std flag clc++21 as a shorthand for clc++2021.
Aug 16 2021, 3:08 AM · Restricted Project

Aug 13 2021

Topotuna requested review of D108038: [C++4OpenCL] C++ for OpenCL version 2021 introduced to command line.
Aug 13 2021, 7:47 AM · Restricted Project
Topotuna committed rGcfdfb75c1ff3: [OpenCL] Clang diagnostics allow reporting C++ for OpenCL version. (authored by Topotuna).
[OpenCL] Clang diagnostics allow reporting C++ for OpenCL version.
Aug 13 2021, 5:57 AM
Topotuna closed D107648: [OpenCL] Clang diagnostics allow reporting C++ for OpenCL version..
Aug 13 2021, 5:57 AM · Restricted Project

Aug 9 2021

Topotuna updated the diff for D107648: [OpenCL] Clang diagnostics allow reporting C++ for OpenCL version..

Diagnostic err_opencl_unknown_type_specifier addressed. Deprecation conditions changed in nosvm attribute test.

Aug 9 2021, 7:34 AM · Restricted Project