- User Since
- Jul 8 2021, 5:45 AM (89 w, 2 d)
May 9 2022
Jan 3 2022
Dec 27 2021
Overall, I think that adjustments are accurate. Suggested a couple of small edits
Closed by commit: rGb5fef6dbfd6b4c84d61155fd2221064bcc1ecdcf
Differential Revision: https://reviews.llvm.org/D110155
Nov 30 2021
Test coverage expanded
Run line argument reordering
Nov 12 2021
Run line -triple is now set explicitly. Test moved from CodeGenOpenCLCXX directory to SemaOpenCLCXX
Nov 9 2021
Nov 8 2021
Sep 21 2021
Changes rG054e331d9dbd and rG37cdc7ebd9a3 contain test cases that display C++ for OpenCL version 2021 in diagnostics.
Both comments addressed. Personally, I would shuffle words around to rename helper function as getDefaultOpenCLPointeeAddrSpace or getOpenCLDefaultPointeeAddrSpace. Although I am not sure if there are some assumed naming conventions in Clang. Originally, I was following the name of getDefaultCXXMethodAddrSpace.
Helper function renamed for clarity. Additional check added to if statement to ensure it is only carried out in OpenCL.
Sep 20 2021
Sep 17 2021
Sep 16 2021
Code refactored inside clang/lib/AST/Expr.cpp. Commit message added.
Current change is an initial draft. More code refactoring will be performed and change summary provided in near future.
Sep 15 2021
Sep 14 2021
Sep 10 2021
Reuses --check-prefix=CHECK-CLCPP10 for default C++ for OpenCL command line version
Sep 9 2021
Test case added for command line flag -cl-std=clc++
Sep 8 2021
Sep 7 2021
Overall, I think the release notes accurately describe tasks I have been working on. A couple of suggestions and minor grammatical changes provided.
Sep 6 2021
Condition on OpenCL C / C++ for OpenCL version removed because it was redundant.
Sep 3 2021
Sep 2 2021
Boolean variable renamed to IsOpenCLC30Compatible. FIXME comment added.
Sep 1 2021
The previously suggested change was split into intermediate steps:
reviews.llvm.org/rGf9bc1b3bee55 - introduced a mapping function for C++ for OpenCL version compatibility with OpenCL and modified condition for setting OpenCLGenericAddressSpace language option.
reviews.llvm.org/rGfb321c2ea274 - enabled all OpenCL 3.0 optional core feature macros without implementing their support in C++ for OpenCL 2021.
Aug 31 2021
Aug 25 2021
Aug 23 2021
__opencl_c_generic_address_space should not have been chosen as the first feature to be addressed out of all OpenCL 3.0 optional core features. This is because __opencl_c_device_enqueue has a dependency on this feature. I will review the order in which OpenCL 3.0 optional features should be introduced to C++ for OpenCL 2021 and return to this revision when all dependencies are resolved.
Aug 20 2021
Aug 19 2021
Aug 18 2021
Aug 16 2021
Aug 13 2021
Aug 9 2021
Diagnostic err_opencl_unknown_type_specifier addressed. Deprecation conditions changed in nosvm attribute test.