Page MenuHomePhabricator

Topotuna (Justas Janickas)
Software Engineer at Arm - Part Time Undergraduate

Projects

User does not belong to any projects.

User Details

User Since
Jul 8 2021, 5:45 AM (10 w, 4 d)

Recent Activity

Today

Topotuna committed rG228dd20c3f1e: [OpenCL] Supports atomics in C++ for OpenCL 2021 (authored by Topotuna).
[OpenCL] Supports atomics in C++ for OpenCL 2021
Mon, Sep 20, 8:25 AM
Topotuna closed D109424: [OpenCL] Supports atomics in C++ for OpenCL 2021.
Mon, Sep 20, 8:24 AM · Restricted Project
Topotuna committed rGca3bebd8440f: [OpenCL] Supports optional writing to 3d images in C++ for OpenCL 2021 (authored by Topotuna).
[OpenCL] Supports optional writing to 3d images in C++ for OpenCL 2021
Mon, Sep 20, 2:08 AM
Topotuna closed D109328: [OpenCL] Supports optional writing to 3d images in C++ for OpenCL 2021.
Mon, Sep 20, 2:08 AM · Restricted Project

Fri, Sep 17

Topotuna committed rGb7e9d203c679: [OpenCL] Supports optional same image reads and writes in C++ for OpenCL 2021 (authored by Topotuna).
[OpenCL] Supports optional same image reads and writes in C++ for OpenCL 2021
Fri, Sep 17, 6:16 AM
Topotuna closed D109307: [OpenCL] Supports optional same image reads and writes in C++ for OpenCL 2021.
Fri, Sep 17, 6:15 AM · Restricted Project
Topotuna committed rG37cdc7ebd9a3: [OpenCL] Supports optional pipe types in C++ for OpenCL 2021 (authored by Topotuna).
[OpenCL] Supports optional pipe types in C++ for OpenCL 2021
Fri, Sep 17, 1:57 AM
Topotuna closed D109306: [OpenCL] Supports optional pipe types in C++ for OpenCL 2021.
Fri, Sep 17, 1:56 AM · Restricted Project

Thu, Sep 16

Topotuna updated the diff for D109874: [OpenCL] Defines helper function for OpenCL default address space.

Code refactored inside clang/lib/AST/Expr.cpp. Commit message added.

Thu, Sep 16, 8:00 AM · Restricted Project
Topotuna committed rG054e331d9dbd: [OpenCL] Supports optional program scope global variables in C++ for OpenCL 2021 (authored by Topotuna).
[OpenCL] Supports optional program scope global variables in C++ for OpenCL 2021
Thu, Sep 16, 4:48 AM
Topotuna closed D109305: [OpenCL] Supports optional program scope global variables in C++ for OpenCL 2021.
Thu, Sep 16, 4:48 AM · Restricted Project
Topotuna planned changes to D109874: [OpenCL] Defines helper function for OpenCL default address space.

Current change is an initial draft. More code refactoring will be performed and change summary provided in near future.

Thu, Sep 16, 3:38 AM · Restricted Project
Topotuna requested review of D109874: [OpenCL] Defines helper function for OpenCL default address space.
Thu, Sep 16, 3:35 AM · Restricted Project

Wed, Sep 15

Topotuna committed rG3b9470a6c46d: [OpenCL] Supports optional image types in C++ for OpenCL 2021 (authored by Topotuna).
[OpenCL] Supports optional image types in C++ for OpenCL 2021
Wed, Sep 15, 2:04 AM
Topotuna closed D109002: [OpenCL] Supports optional image types in C++ for OpenCL 2021.
Wed, Sep 15, 2:04 AM · Restricted Project

Tue, Sep 14

Topotuna committed rG09dc454b00b8: [OpenCL] Enables .rgba vector extension in C++ for OpenCL 2021 (authored by Topotuna).
[OpenCL] Enables .rgba vector extension in C++ for OpenCL 2021
Tue, Sep 14, 5:06 AM
Topotuna closed D109370: [OpenCL] Enables .rgba vector extension in C++ for OpenCL 2021.
Tue, Sep 14, 5:06 AM · Restricted Project
Topotuna committed rGad88632b6503: [OpenCL] Tests C++ for OpenCL version macros (authored by Topotuna).
[OpenCL] Tests C++ for OpenCL version macros
Tue, Sep 14, 1:50 AM
Topotuna closed D109366: [OpenCL] Tests C++ for OpenCL version macros.
Tue, Sep 14, 1:49 AM · Restricted Project

Fri, Sep 10

Topotuna updated the diff for D109366: [OpenCL] Tests C++ for OpenCL version macros.

Reuses --check-prefix=CHECK-CLCPP10 for default C++ for OpenCL command line version

Fri, Sep 10, 2:04 AM · Restricted Project
Topotuna accepted D109327: [OpenCL][Docs] Release 13 notes.

LGTM! Thanks

Fri, Sep 10, 1:48 AM

Thu, Sep 9

Topotuna updated the diff for D109366: [OpenCL] Tests C++ for OpenCL version macros.

Test case added for command line flag -cl-std=clc++

Thu, Sep 9, 3:56 AM · Restricted Project
Topotuna requested review of D109492: [OpenCL] Test case for C++ for OpenCL 2021 in OpenCL C header test.
Thu, Sep 9, 1:43 AM · Restricted Project

Wed, Sep 8

Topotuna requested review of D109424: [OpenCL] Supports atomics in C++ for OpenCL 2021.
Wed, Sep 8, 1:48 AM · Restricted Project

Tue, Sep 7

Topotuna requested review of D109370: [OpenCL] Enables .rgba vector extension in C++ for OpenCL 2021.
Tue, Sep 7, 8:56 AM · Restricted Project
Topotuna requested review of D109366: [OpenCL] Tests C++ for OpenCL version macros.
Tue, Sep 7, 8:19 AM · Restricted Project
Topotuna added a comment to D109327: [OpenCL][Docs] Release 13 notes.

Overall, I think the release notes accurately describe tasks I have been working on. A couple of suggestions and minor grammatical changes provided.

Tue, Sep 7, 3:07 AM
Topotuna committed rGc33e296be1da: [OpenCL] Disallows static kernel functions in C++ for OpenCL (authored by Topotuna).
[OpenCL] Disallows static kernel functions in C++ for OpenCL
Tue, Sep 7, 2:24 AM
Topotuna closed D109150: [OpenCL] Disallows static kernel functions in C++ for OpenCL.
Tue, Sep 7, 2:24 AM · Restricted Project

Mon, Sep 6

Topotuna requested review of D109328: [OpenCL] Supports optional writing to 3d images in C++ for OpenCL 2021.
Mon, Sep 6, 8:25 AM · Restricted Project
Topotuna committed rG52f7cd23b4af: [OpenCL] Fix condition macro name in test (authored by Topotuna).
[OpenCL] Fix condition macro name in test
Mon, Sep 6, 5:15 AM
Topotuna updated the diff for D109150: [OpenCL] Disallows static kernel functions in C++ for OpenCL.

Condition on OpenCL C / C++ for OpenCL version removed because it was redundant.

Mon, Sep 6, 5:06 AM · Restricted Project
Topotuna added inline comments to D109150: [OpenCL] Disallows static kernel functions in C++ for OpenCL.
Mon, Sep 6, 5:04 AM · Restricted Project
Topotuna committed rGcc9260a0fb7c: [OpenCL] Supports optional generic address space semantics in C++ for OpenCL… (authored by Topotuna).
[OpenCL] Supports optional generic address space semantics in C++ for OpenCL…
Mon, Sep 6, 2:21 AM
Topotuna closed D108461: [OpenCL] Supports optional generic address space sematics in C++ for OpenCL 2021.
Mon, Sep 6, 2:21 AM · Restricted Project
Topotuna added inline comments to D108461: [OpenCL] Supports optional generic address space sematics in C++ for OpenCL 2021.
Mon, Sep 6, 1:29 AM · Restricted Project
Topotuna requested review of D109307: [OpenCL] Supports optional same image reads and writes in C++ for OpenCL 2021.
Mon, Sep 6, 1:23 AM · Restricted Project
Topotuna requested review of D109306: [OpenCL] Supports optional pipe types in C++ for OpenCL 2021.
Mon, Sep 6, 1:20 AM · Restricted Project
Topotuna requested review of D109305: [OpenCL] Supports optional program scope global variables in C++ for OpenCL 2021.
Mon, Sep 6, 1:18 AM · Restricted Project

Fri, Sep 3

Topotuna committed rGbd74f4b10834: [OpenCL] Supports optional 64-bit floating point types in C++ for OpenCL 2021 (authored by Topotuna).
[OpenCL] Supports optional 64-bit floating point types in C++ for OpenCL 2021
Fri, Sep 3, 2:59 AM
Topotuna closed D108989: [OpenCL] Supports optional 64-bit floating point types in C++ for OpenCL 2021.
Fri, Sep 3, 2:58 AM · Restricted Project

Thu, Sep 2

Topotuna requested review of D109150: [OpenCL] Disallows static kernel functions in C++ for OpenCL.
Thu, Sep 2, 5:38 AM · Restricted Project
Topotuna added inline comments to D109002: [OpenCL] Supports optional image types in C++ for OpenCL 2021.
Thu, Sep 2, 5:29 AM · Restricted Project
Topotuna updated the diff for D109002: [OpenCL] Supports optional image types in C++ for OpenCL 2021.

Boolean variable renamed to IsOpenCLC30Compatible. FIXME comment added.

Thu, Sep 2, 5:26 AM · Restricted Project

Wed, Sep 1

Topotuna updated the diff for D108461: [OpenCL] Supports optional generic address space sematics in C++ for OpenCL 2021.

The previously suggested change was split into intermediate steps:
reviews.llvm.org/rGf9bc1b3bee55 - introduced a mapping function for C++ for OpenCL version compatibility with OpenCL and modified condition for setting OpenCLGenericAddressSpace language option.
reviews.llvm.org/rGfb321c2ea274 - enabled all OpenCL 3.0 optional core feature macros without implementing their support in C++ for OpenCL 2021.

Wed, Sep 1, 6:21 AM · Restricted Project
Topotuna added inline comments to D109002: [OpenCL] Supports optional image types in C++ for OpenCL 2021.
Wed, Sep 1, 2:45 AM · Restricted Project
Topotuna committed rGfb321c2ea274: [OpenCL] Define OpenCL 3.0 optional core features in C++ for OpenCL 2021 (authored by Topotuna).
[OpenCL] Define OpenCL 3.0 optional core features in C++ for OpenCL 2021
Wed, Sep 1, 2:17 AM
Topotuna closed D108704: [OpenCL] Define OpenCL 3.0 optional core features in C++ for OpenCL 2021.
Wed, Sep 1, 2:16 AM · Restricted Project

Tue, Aug 31

Topotuna requested review of D109002: [OpenCL] Supports optional image types in C++ for OpenCL 2021.
Tue, Aug 31, 8:55 AM · Restricted Project
Topotuna requested review of D108989: [OpenCL] Supports optional 64-bit floating point types in C++ for OpenCL 2021.
Tue, Aug 31, 5:29 AM · Restricted Project
Topotuna committed rGf9bc1b3bee55: [OpenCL] Defines helper function for kernel language compatible OpenCL version (authored by Topotuna).
[OpenCL] Defines helper function for kernel language compatible OpenCL version
Tue, Aug 31, 2:09 AM
Topotuna closed D108693: [OpenCL] Defines helper function for kernel language compatible OpenCL version.
Tue, Aug 31, 2:09 AM · Restricted Project

Wed, Aug 25

Topotuna committed rG9dc92bba6c74: [OpenCL][NFC] Fix code example in __remove_address_space documentation. (authored by Topotuna).
[OpenCL][NFC] Fix code example in __remove_address_space documentation.
Wed, Aug 25, 1:26 PM
Topotuna requested review of D108704: [OpenCL] Define OpenCL 3.0 optional core features in C++ for OpenCL 2021.
Wed, Aug 25, 8:06 AM · Restricted Project
Topotuna requested review of D108693: [OpenCL] Defines helper function for kernel language compatible OpenCL version.
Wed, Aug 25, 3:30 AM · Restricted Project

Mon, Aug 23

Topotuna planned changes to D108461: [OpenCL] Supports optional generic address space sematics in C++ for OpenCL 2021.

__opencl_c_generic_address_space should not have been chosen as the first feature to be addressed out of all OpenCL 3.0 optional core features. This is because __opencl_c_device_enqueue has a dependency on this feature. I will review the order in which OpenCL 3.0 optional features should be introduced to C++ for OpenCL 2021 and return to this revision when all dependencies are resolved.

Mon, Aug 23, 7:12 AM · Restricted Project

Aug 20 2021

Topotuna requested review of D108461: [OpenCL] Supports optional generic address space sematics in C++ for OpenCL 2021.
Aug 20 2021, 5:55 AM · Restricted Project
Topotuna committed rG9ae9262857a1: [OpenCL] Fix version reporting of C++ for OpenCL 2021 (authored by Topotuna).
[OpenCL] Fix version reporting of C++ for OpenCL 2021
Aug 20 2021, 12:59 AM
Topotuna closed D108379: [OpenCL] Fix version reporting of C++ for OpenCL 2021.
Aug 20 2021, 12:58 AM · Restricted Project

Aug 19 2021

Topotuna added a comment to D108379: [OpenCL] Fix version reporting of C++ for OpenCL 2021.

LGTM! Thanks!

I imagine you will be adding some tests that will check the correctness of diagnostic wording in the subsequent commits?

Aug 19 2021, 8:46 AM · Restricted Project
Topotuna requested review of D108379: [OpenCL] Fix version reporting of C++ for OpenCL 2021.
Aug 19 2021, 8:19 AM · Restricted Project

Aug 18 2021

Topotuna committed rG0d0628b2d213: [OpenCL] C++ for OpenCL version 2021 introduced to command line. (authored by Topotuna).
[OpenCL] C++ for OpenCL version 2021 introduced to command line.
Aug 18 2021, 2:15 AM
Topotuna closed D108038: [C++4OpenCL] C++ for OpenCL version 2021 introduced to command line.
Aug 18 2021, 2:15 AM · Restricted Project

Aug 16 2021

Topotuna requested review of D108113: [C++4OpenCL] Enable -cl-std flag clc++21 as a shorthand for clc++2021.
Aug 16 2021, 3:08 AM · Restricted Project

Aug 13 2021

Topotuna requested review of D108038: [C++4OpenCL] C++ for OpenCL version 2021 introduced to command line.
Aug 13 2021, 7:47 AM · Restricted Project
Topotuna committed rGcfdfb75c1ff3: [OpenCL] Clang diagnostics allow reporting C++ for OpenCL version. (authored by Topotuna).
[OpenCL] Clang diagnostics allow reporting C++ for OpenCL version.
Aug 13 2021, 5:57 AM
Topotuna closed D107648: [OpenCL] Clang diagnostics allow reporting C++ for OpenCL version..
Aug 13 2021, 5:57 AM · Restricted Project

Aug 9 2021

Topotuna updated the diff for D107648: [OpenCL] Clang diagnostics allow reporting C++ for OpenCL version..

Diagnostic err_opencl_unknown_type_specifier addressed. Deprecation conditions changed in nosvm attribute test.

Aug 9 2021, 7:34 AM · Restricted Project
Topotuna updated the diff for D107648: [OpenCL] Clang diagnostics allow reporting C++ for OpenCL version..

Diagnostics reworded. Helper function getOpenCLVersionString() added. Tests updated

Aug 9 2021, 4:54 AM · Restricted Project

Aug 6 2021

Topotuna updated the diff for D107648: [OpenCL] Clang diagnostics allow reporting C++ for OpenCL version..

Diagnostic argument index updated (from %1 to %2)

Aug 6 2021, 7:57 AM · Restricted Project
Topotuna requested review of D107648: [OpenCL] Clang diagnostics allow reporting C++ for OpenCL version..
Aug 6 2021, 7:48 AM · Restricted Project
Topotuna committed rGa5a2f05dcc80: [C++4OpenCL] Introduces __remove_address_space utility (authored by Topotuna).
[C++4OpenCL] Introduces __remove_address_space utility
Aug 6 2021, 2:41 AM
Topotuna closed D106785: [C++4OpenCL] Introduces __remove_address_space utility.
Aug 6 2021, 2:41 AM · Restricted Project

Aug 5 2021

Topotuna updated the diff for D106785: [C++4OpenCL] Introduces __remove_address_space utility.

Documentation section title reworded

Aug 5 2021, 4:46 AM · Restricted Project

Aug 2 2021

Topotuna committed rGb13fc7311eab: [OpenCL] __cpp_threadsafe_static_init is by default undefined in OpenCL mode. (authored by Topotuna).
[OpenCL] __cpp_threadsafe_static_init is by default undefined in OpenCL mode.
Aug 2 2021, 6:11 AM
Topotuna closed D107163: [OpenCL] __cpp_threadsafe_static_init is by default undefined in OpenCL mode.
Aug 2 2021, 6:11 AM · Restricted Project
Topotuna committed rG9988ab3989a2: [clang][NFC] Typo fixes. Test commit. (authored by Topotuna).
[clang][NFC] Typo fixes. Test commit.
Aug 2 2021, 5:25 AM

Jul 30 2021

Topotuna added inline comments to D107163: [OpenCL] __cpp_threadsafe_static_init is by default undefined in OpenCL mode.
Jul 30 2021, 7:49 AM · Restricted Project
Topotuna updated the summary of D107163: [OpenCL] __cpp_threadsafe_static_init is by default undefined in OpenCL mode.
Jul 30 2021, 7:17 AM · Restricted Project
Topotuna requested review of D107163: [OpenCL] __cpp_threadsafe_static_init is by default undefined in OpenCL mode.
Jul 30 2021, 7:16 AM · Restricted Project
Topotuna updated Topotuna.
Jul 30 2021, 2:53 AM

Jul 27 2021

Topotuna updated the diff for D106785: [C++4OpenCL] Introduces __remove_address_space utility.

Test case added that checks if __remove_address_space modifies types without address space

Jul 27 2021, 7:28 AM · Restricted Project
Topotuna added inline comments to D106785: [C++4OpenCL] Introduces __remove_address_space utility.
Jul 27 2021, 4:39 AM · Restricted Project
Topotuna updated the diff for D106785: [C++4OpenCL] Introduces __remove_address_space utility.

Documentation rewording

Jul 27 2021, 4:38 AM · Restricted Project
Topotuna updated the diff for D106785: [C++4OpenCL] Introduces __remove_address_space utility.

Additional tests added for is_same

Jul 27 2021, 2:44 AM · Restricted Project
Topotuna updated the diff for D106785: [C++4OpenCL] Introduces __remove_address_space utility.

Reference to C++ for OpenCL 1.0 specification removed. More elaborate code example added.

Jul 27 2021, 1:24 AM · Restricted Project

Jul 26 2021

Topotuna added a comment to D106785: [C++4OpenCL] Introduces __remove_address_space utility.

Change to LanguageExtensions.rst assumes there is a section about the utility on official C++ for OpenCL documentation. However, it is not yet documented

Jul 26 2021, 4:17 AM · Restricted Project
Topotuna requested review of D106785: [C++4OpenCL] Introduces __remove_address_space utility.
Jul 26 2021, 4:14 AM · Restricted Project

Jul 22 2021

Topotuna added a comment to D106266: [C++4OpenCL] Add run line standard aliases clc++1.0 and CLC++1.0.

That is good to know. Thank you for sorting it out

Jul 22 2021, 4:35 AM · Restricted Project, Restricted Project

Jul 20 2021

Topotuna added inline comments to D106266: [C++4OpenCL] Add run line standard aliases clc++1.0 and CLC++1.0.
Jul 20 2021, 2:28 AM · Restricted Project, Restricted Project
Topotuna updated the diff for D106266: [C++4OpenCL] Add run line standard aliases clc++1.0 and CLC++1.0.

clc++ made no longer deprecated

Jul 20 2021, 2:28 AM · Restricted Project, Restricted Project

Jul 19 2021

Topotuna requested review of D106266: [C++4OpenCL] Add run line standard aliases clc++1.0 and CLC++1.0.
Jul 19 2021, 5:05 AM · Restricted Project, Restricted Project
Topotuna added inline comments to D105987: [C++4OpenCL] NULL redefined as nullptr.
Jul 19 2021, 2:23 AM · Restricted Project
Topotuna updated the diff for D105987: [C++4OpenCL] NULL redefined as nullptr.

Separate NFC performed in D106254

Jul 19 2021, 2:21 AM · Restricted Project
Topotuna requested review of D106254: [OpenCL][NFC] Refactors conditional versioning.
Jul 19 2021, 2:13 AM · Restricted Project

Jul 16 2021

Topotuna added inline comments to D105987: [C++4OpenCL] NULL redefined as nullptr.
Jul 16 2021, 2:24 AM · Restricted Project
Topotuna updated the diff for D105987: [C++4OpenCL] NULL redefined as nullptr.

Patch made compatible with changes to D105988

Jul 16 2021, 2:23 AM · Restricted Project

Jul 15 2021

Topotuna added inline comments to D105988: [OpenCL] NULL introduced prior to v2.0.
Jul 15 2021, 3:53 AM · Restricted Project
Topotuna updated the diff for D105988: [OpenCL] NULL introduced prior to v2.0.

Full diff now added. Redundant condition #if removed

Jul 15 2021, 3:51 AM · Restricted Project

Jul 14 2021

Topotuna updated the diff for D105988: [OpenCL] NULL introduced prior to v2.0.

Wrong diff file added previously

Jul 14 2021, 9:02 AM · Restricted Project