Page MenuHomePhabricator

TimNN (Tim Neumann)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 17 2017, 4:29 PM (131 w, 2 d)

Recent Activity

Nov 21 2018

TimNN added a comment to D53485: [ScheduleDAGRRList] Do not preschedule the node has ADJCALLSTACKDOWN parent.

Sorry for taking so long to reply. The original example I shared (https://gist.github.com/TimNN/501819422631149c3ab2b8cc0b15c98d) reproduces the issue for the AVR target. I'm not sure about the terminology here, but I would consider AVR "in-tree", even though it is still experimental. I don't know if / how the issue can be reproduced on other targets.

Nov 21 2018, 9:31 PM

Nov 1 2018

TimNN added a comment to D53485: [ScheduleDAGRRList] Do not preschedule the node has ADJCALLSTACKDOWN parent.

Friendly Ping! Is there anything I can do to help this patch along? It looks like no reviewers have been assigned yet, do you know of anyone who would be appropriate, @shiva0217?

Nov 1 2018, 11:36 PM
TimNN removed a reviewer for D53106: [SelectionDAG] Fix behavior topological ordering with regards to glued nodes.: TimNN.

I don't think I can help here any more. The changes to hasPredecessorHelper look good to me an definitely fix the original problem. However I don't know enough about the surrounding code to comment on the changes in AssignTopologicalOrder.

Nov 1 2018, 11:36 PM · Restricted Project

Oct 22 2018

TimNN added inline comments to D53485: [ScheduleDAGRRList] Do not preschedule the node has ADJCALLSTACKDOWN parent.
Oct 22 2018, 7:40 AM

Oct 10 2018

TimNN added a comment to D53106: [SelectionDAG] Fix behavior topological ordering with regards to glued nodes..

The approach in general looks good to me, however I don't think this interacts correctly with the TopologicalPrune optimization.

Oct 10 2018, 10:52 PM · Restricted Project

May 3 2017

TimNN abandoned D32822: Win64: set HasWinCFI for naked functions.

Another fix has been commited.

May 3 2017, 9:43 PM
TimNN created D32822: Win64: set HasWinCFI for naked functions.
May 3 2017, 12:05 PM

Apr 10 2017

TimNN added a comment to D31790: [PowerPC] Assume 128bit multiply uses CTR.

I cannot commit this myself, could someone please do it for me?

Apr 10 2017, 1:52 PM
TimNN added a comment to D31790: [PowerPC] Assume 128bit multiply uses CTR.

@hfinkel: Thanks for the feedback!

Apr 10 2017, 9:36 AM

Apr 7 2017

TimNN updated the diff for D31790: [PowerPC] Assume 128bit multiply uses CTR.

Updated to a more targeted fix and added a test as suggested.

Apr 7 2017, 9:39 AM

Apr 6 2017

TimNN created D31790: [PowerPC] Assume 128bit multiply uses CTR.
Apr 6 2017, 3:18 PM

Mar 18 2017

TimNN added a comment to D31116: [ARM] handle promotion of zero sized constants..

I cannot commit this myself, could someone please do it for me?

Mar 18 2017, 5:12 AM
TimNN updated the diff for D31116: [ARM] handle promotion of zero sized constants..

I have updated the patch as suggested.

Mar 18 2017, 4:35 AM
TimNN created D31116: [ARM] handle promotion of zero sized constants..
Mar 18 2017, 2:26 AM