- User Since
- Jul 3 2019, 6:25 PM (204 w, 2 d)
Sep 4 2021
Hi, my name is JeanHeyd Meneide. I'm the Project Editor for C, but more importantly I'm the author of this paper: http://www.open-std.org/jtc1/sc22/wg14/www/docs/n2728.htm
Apr 20 2021
Just a tiny comment: could you please make sure the name of the resolved encoding is also propagated to InitPreprocessor.cpp that sets the __clang_literal_encoding__ macro? (https://github.com/llvm/llvm-project/blob/main/clang/lib/Frontend/InitPreprocessor.cpp#L784)
I actually think it's fine to just do == 8. I was just adding my comments for the benefit of the future, really! Doing a full -fwide-exec-charset= patch is definitely overkill for a simple case like this. I also just know there are a LOT of 8-bit character sets, so assuming UTF-8 might be a bit bad. But, again, you should definitely go ahead with >= 16 as the 2nd check and then leave the 8-bit case as last in the if-else chain:
Apr 13 2021
Oops, almost forgot the doc fixes for the *wide__* macro!
Update the text for the documentation to be more explicit.
Apr 12 2021
The tests check for macros in strict byte-value "alphabetical" order. We also need documentation, as was suggested!!
Fixes formatting derps in the pre-linter check.
Oct 24 2020
Minor addition for this change; if this does go through, llvm-specific macros in C-like languages should expose the chosen name. I submitted a patch and a feature request to MSVC and GCC for their own implementation-specific macros as well: